[FIX] CM led notifications [MERGED] - Droid Incredible Android Development

These changes have been merged into the latest nightly. Expect to see it in the new dinc build on 11/30/2010.
-------------
Hey fellow dinc users. We've been complaining for too long and now we can complain no more (or some more)
I've made a patch that fixes the led notifications so that green and amber blinks now. You can flash this over any version of cm 6.
The led blinks like stock, but the blink rate is not configurable.
-Flash in succession works for different notification colors.
Flash like any zip. Be sure to back up.
Bug: There seems to be an issue with the led light colors not being properly set by CM settings.. Here is a possible solution:
tdiman said:
Next: Bingo:
Set a custom color (somewhere in the pink-red range). Got a red LED immediately.
Now flash color, blink rate work as advertised.
Hopefully that helps narrow down the issue me and CUViper are seeing.
Click to expand...
Click to collapse
Devs: I've started a Gerritt issue for the fix. I'm not sure if I broke things for other phones.. so hopefully there'll be more contribution from other devs to get this into cm6.1..... update- they didn't like my generic liblights fix, so I've made a device specific one for our inc. It works right now, but I will clean up the file when I get a chance.
http://review.cyanogenmod.com/527
NEW: http://review.cyanogenmod.com/#change,681

Do you think this will work with RUBY?

shoman24v said:
Do you think this will work with RUBY?
Click to expand...
Click to collapse
I think it should. But please let us know if it doesn't!

Let me do a backup and I'll try it out.

nice.. much appreciated! what's left in terms of issues? just the cam force close or are there others? once the cam's fixed.. i'd like to use cm as my daily

The camera really only fcs for 720p recording with autofocus. I might look into it over Thanksgiving.
The led issue was just really bugging me and I was getting impatient lol..

No, go. When I get a text it doesn't blink, or even stay on like it did.

shoman24v said:
No, go. When I get a text it doesn't blink, or even stay on like it did.
Click to expand...
Click to collapse
Sorry man, there must be other changes in Ruby that I don't know about. Have you tried changing the colors of your notifications? The driver only responds if it's green or red.

seanzer said:
Sorry man, there must be other changes in Ruby that I don't know about. Have you tried changing the colors of your notifications? The driver only responds if it's green or red.
Click to expand...
Click to collapse
I don't believe Ruby allows you to change the color of your LED. We only have two anyway

shoman24v said:
I don't believe Ruby allows you to change the color of your LED. We only have two anyway
Click to expand...
Click to collapse
You should try an led tester or handcent. An app that lets you change test the color of the led. I could recode the patch to default to green for all other colors, I believe that would make it work for MIUI. Pm me if you're willing to try it..

I think many users may want it blink for Ruby. Though, it does work just fine as it is being only solid. Reason I sorta perfer that is I'm not being tricked into thinking I have a notification. When it blinks I have to always take a second look at it
I tried LED Tester, only colors we have are green and red.

For the apps that have built in LED configuration, like handcent and kik. THey wouldn't even have the orange LED blinking right, which leads me to have it set to no blind in CMsettings and the app settings.
Will this fix work with those aswell?

mikeymop said:
For the apps that have built in LED configuration, like handcent and kik. THey wouldn't even have the orange LED blinking right, which leads me to have it set to no blind in CMsettings and the app settings.
Will this fix work with those aswell?
Click to expand...
Click to collapse
I'm not sure what you mean, but I can use handcent's settings to set the led color. Only green and red work though. For the apps that don't have a way to set the color, I can control it using cyanogen's settings under the led notifications menu.

I added some review comments in Gerrit for you. When I tried it myself, I wasn't able to get it working until I uncommented your BLINK_FILE writes.

This b0rks the green LED when charging above 90% Now both orange and green are lit.
Also rather then plain green flashing I get nothing :/

CUViper said:
I added some review comments in Gerrit for you. When I tried it myself, I wasn't able to get it working until I uncommented your BLINK_FILE writes.
Click to expand...
Click to collapse
When remove the comments, don't the blinks go sporadically?
I intended for the leds to be able to have both red and green, but it looks rediculous so I'm going to fix it.

seanzer said:
When remove the comments, don't the blinks go sporadically?
Click to expand...
Click to collapse
I'm not sure what you mean by sporadic. It's a quick blink about every two seconds, longer off than on. But with your comments in place, I don't get anything blinking lights at all. The solid charge light works, but blinking notification doesn't.

CUViper said:
I'm not sure what you mean by sporadic. It's a quick blink about every two seconds, longer off than on. But with your comments in place, I don't get anything blinking lights at all. The solid charge light works, but blinking notification doesn't.
Click to expand...
Click to collapse
Interesting, try setting different blink rates, it definitely works!
I'm posting a new version fixing the issue with both lights showing up.

Ok, this is weird. I built your second patch from Gerrit, pushed it out, rebooted, and then suddenly I was getting the opposite of before, now a long blink on with a short off. So I went into Advanced and chose "Reset all colors and apps", and now I can't get anything to blink at all. I'm about to give up and let you and others figure it out...
Can you tell what all the settings are for you? I have only the default "Miscellaneous" category, and I've tried "Always pulse" on and off. The other Advanced settings don't look like they should matter, but I have the rest all off. Then I go into the applications list and choose Gmail, set it to green or red, choose any blink rate, and then "Flash test" does nothing.

You should get a long blink with short off..
I just repeated what you did..
Reset all notifications,
Goto led settings for gmail,
Test flash does nothing,
pick green..even though it was already selected...
Test flash and it worked..
Not exactly sure why it doesn't work for you. lets see what the others say.

Related

LED Notifications: Changing Blink Speed?

One thing I really miss from my 8125 was the fact that when I had a missed call/email/VM/text, the amber LED would blink twice as fast as the regular green phone status light.
I know there are programs that will change the LED color for notifications on the Kaiser, but I would like to keep the current color configuration.
Does anyone know of a way in increase the blink speed of the amber LED when I have a missed call/email/etc.?
Thanks for any help.
i want to know this too , any1?
thnx
Yes, if you want to break your LED's you can do it
grizzley said:
Yes, if you want to break your LED's you can do it
Click to expand...
Click to collapse
as long as it's faster honey
definitely sounds good to me. missed calls having the delay between flashes decreased, or have it do double flashes. maybe the occasional beep or vibrate depending on setting for missed calls / texts
ziddey said:
as long as it's faster honey
definitely sounds good to me. missed calls having the delay between flashes decreased, or have it do double flashes. maybe the occasional beep or vibrate depending on setting for missed calls / texts
Click to expand...
Click to collapse
Well, it will break your LED's so in the end you have NO flashing LED's or sometimes LED's or wrong LED's. So, search, there are a few threads about it. They will be faster, but only IF they work. I haven't seen anyone that has gotten it to work correctly, especially on the Kaiser.
I sure wish there was a good solution to this...on my HTC Apache/6700 whenever I had a notification the LED would be orange and would flash twice as fast. Considering that in certain light conditions it's difficult to tell whether the light is orange or green, having it flash twice as fast is the perfect solution.
true , now we need a solution for this
On my mio a701 i had this feature , it was usefull
Hockey37 said:
I know there are programs that will change the LED color for notifications on the Kaiser, but I would like to keep the current color configuration.
Click to expand...
Click to collapse
Do you or anyone else have a link to instructions on how to change the color? If I could change notifications to red it might be easier to see than orange. Afaik red is only for low battery anyways and my battery is never low. It's not possible to search for a 3-letter string like "LED."
Thanks
kaiser notifications
kaiser notifications
for color leads changing
thats only for colors , not for speeds
Hockey37 said:
One thing I really miss from my 8125 was the fact that when I had a missed call/email/VM/text, the amber LED would blink twice as fast as the regular green phone status light.
I know there are programs that will change the LED color for notifications on the Kaiser, but I would like to keep the current color configuration.
Does anyone know of a way in increase the blink speed of the amber LED when I have a missed call/email/etc.?
Thanks for any help.
Click to expand...
Click to collapse
led port is different in devices.
can it use at htc touch to change color ?

LED configuration

I am looking for a way to configure the LED on my Kaiser, so that p.ex. on a missed call, a new sms/mms or email, the LED flashes differently, in a different color or stays light.
Have tried nueLED which should do that and much more, but without results.
Any thoughts on how to achieve the LED config?
Thanks and rgds
Sansibar
sansibar said:
I am looking for a way to configure the LED on my Kaiser, so that p.ex. on a missed call, a new sms/mms or email, the LED flashes differently, in a different color or stays light.
Have tried nueLED which should do that and much more, but without results.
Any thoughts on how to achieve the LED config?
Thanks and rgds
Sansibar
Click to expand...
Click to collapse
Good luck removing nueLED, it's been stuck on my device since I installed it long ago... Blergh..
KaiserNotification is another one which modifies the LED behavior, but it doesn't change the inherent behavior of the lights, only allows you to modify which lights show..
Such as I don't want the stupid "signal" or "GPS", or "Bluetooth" lights so I disable those. I set missed calls to Red, Missed SMS/MMS to blue, unread emails to Green.
One caveat is that you no longer see charging/charged lights.. I dunno if there's some way around this, but it's not a huge deal for me.

[Q] Control notification LED?

Has anyone found an app that gives us better control over the hardware LED?
I'd like to have the notification light periodically blink when there's an SMS message or missed call, (and maybe some of the other important notifications), and the default settings offer so little control as to be useless. <rant> Seriously, why would I want a LED to tell me if the phone is charging, I can see damned well that it's charging, there's a cord attached! </rant>
There's the LEDBlinker app, which has all the options i'd want, but when I put it into test mode, it doesn't blink the leds.
Has anyone else tried to do this? Has anyone had any success? It's a cool hardware feature, that I think i'd really use - but it's hobbled by the crap configuration options Samsung gave us.
Thanks
DrAzzy said:
There's the LEDBlinker app, which has all the options i'd want, but when I put it into test mode, it doesn't blink the leds.
Click to expand...
Click to collapse
Samsung prevents the LED notifications from working unless the screen is turned off. I'm using Light Manager (the dev participates on this forum), and so far it works fine in "alternate" mode. When you test the LED settings, a pop-up tells you to turn off the screen, and only then will the test work (and it does).
barnabydog said:
Samsung prevents the LED notifications from working unless the screen is turned off. I'm using Light Manager (the dev participates on this forum), and so far it works fine in "alternate" mode. When you test the LED settings, a pop-up tells you to turn off the screen, and only then will the test work (and it does).
Click to expand...
Click to collapse
Thanks - turns out I'd turned the LED off in settings (along with the options to use the LED to show charging status). /facepalm

Light flow... Does it work?

Anybody tried light flow yet?
Works like a sharm! No root necessary. The new notification light is much better then the speaker built in thing from the z1c.
Tested "Light Manager" and that works, too.
Can't seem to change the charging led though
Yup, I have the paid for version of Light Flow setup and working perfectly!
sim87 said:
Yup, I have the paid for version of Light Flow setup and working perfectly!
Click to expand...
Click to collapse
How about the charging led?
cyphomatic said:
How about the charging led?
Click to expand...
Click to collapse
I just tested and i can't get light flow to change the charging LED. It doesn't even turn off if you disable the notification light in Androids DIsplay settings.
sim87 said:
I just tested and i can't get light flow to change the charging LED. It doesn't even turn off if you disable the notification light in Androids DIsplay settings.
Click to expand...
Click to collapse
To bad. It's keeping me awake at night and really holding me from buying a dock.
sim87 said:
I just tested and i can't get light flow to change the charging LED. It doesn't even turn off if you disable the notification light in Androids DIsplay settings.
Click to expand...
Click to collapse
I've been able to sort of fix this using Light Manager. I select a really dark color (almost black) for both charging and fully charged set it to be always on (no blinking).
It's kinda finicky, though, and sometimes it takes a few moments until it LM takes over from the built in notification light. For me, Light Manager works better than Light Flow. YMMV, it's possible to do this with both of them.
cyphomatic said:
To bad. It's keeping me awake at night and really holding me from buying a dock.
Click to expand...
Click to collapse
Flip it over.
NRG1975 said:
Flip it over.
Click to expand...
Click to collapse
:cyclops: still no solution for when I would dock it.
Fruktsallad said:
I've been able to sort of fix this using Light Manager. I select a really dark color (almost black) for both charging and fully charged set it to be always on (no blinking).
It's kinda finicky, though, and sometimes it takes a few moments until it LM takes over from the built in notification light. For me, Light Manager works better than Light Flow. YMMV, it's possible to do this with both of them.
Click to expand...
Click to collapse
Just wanted to say that I have done this with Light Flow and it works great. It still shows the default charging colours when the screen is on, but when it's off it uses the ones in light flow. The trick is to use anything but totally black. I set it with the HEX code to FF000001 and it works.
That is on a full-size Z3 but I can't imagine the hardware is different regarding LEDs.
I use light manager and it does work with a dark colour to set the charging/charged led colour. (dark blue)
BUT
When I use sleep mode (so I get to notification lights) the charging/charged trick doesn't work ....
So I have to dissable sleep mode
anyone has a solution for this?
Lightflow doesn't seem to work for me neither.
Is there any other option without rooting the device (no option, as it's for the device of my girlfriend)
Works perfectly for me. Keep trying. Make sure it's enabled in settings security notification access.
Sent from my D5803
phositadc said:
Works perfectly for me. Keep trying. Make sure it's enabled in settings security notification access.
Sent from my D5803
Click to expand...
Click to collapse
Hmmmm very good point. Thx for the advice. I think I activated this after the installation of Light Flow. I remember some red info message bugging me But to be honest I can't find this setting anymore. Where can I reconfigure/ review this?
tertom said:
Hmmmm very good point. Thx for the advice. I think I activated this after the installation of Light Flow. I remember some red info message bugging me But to be honest I can't find this setting anymore. Where can I reconfigure/ review this?
Click to expand...
Click to collapse
Settings -> Security -> Notification Access
Sent from my D5803 using XDA Free mobile app
Light Manager works for me, colorwise - but I get constant false SMS blink - any solutions?
sxtester said:
Settings -> Security -> Notification Access
Sent from my D5803 using XDA Free mobile app
Click to expand...
Click to collapse
Ahh Thx But this doesn't seem to be the problem. Checkbox for Lightflow is checked there.
Will keep trying to get it working.
Thanks a lot for the help so far.
Light flow works like a charm for me and love how I set colour per notification type it's the only app that works 100%

Notification light?

I could've swore I seen info about the v40 having a notification led. Does it have one or no?
I'm asking because a recent video I saw, stated it didn't have one.
Hehh, it doesn't. And I just noticed this after having the phone for 2 weeks.
It does have edge lighting when its locked/off tho. And that is really neat.
chelseytx said:
Hehh, it doesn't. And I just noticed this after having the phone for 2 weeks.
It does have edge lighting when its locked/off tho. And that is really neat.
Click to expand...
Click to collapse
That sucks. I hated that about the v30.
I'll have to look up the edge lighting.
Edit: Just seen edge lighting and it's nowhere near as good as an led. Man, I may have to reconsider this phone now.
Its really neat to watch. It moves around the screen and glows alternatingly. I want to say it changes color too.
chelseytx said:
Its really neat to watch. It moves around the screen and glows alternatingly. I want to say it changes color too.
Click to expand...
Click to collapse
But it doesn't go on continually.
True, but who now-a-days doesn't automatically check their phone when they pick it up. Light or no light? Its instinct - at least for me - to pick up the phone and hit the screen to open it and look at my notifications.
chelseytx said:
True, but who now-a-days doesn't automatically check their phone when they pick it up. Light or no light? Its instinct - at least for me - to pick up the phone and hit the screen to open it and look at my notifications.
Click to expand...
Click to collapse
At work I don't just pick up my phone. If I come back to my desk and see a certain color led, I know I need to pick it up.
20degrees said:
At work I don't just pick up my phone. If I come back to my desk and see a certain color led, I know I need to pick it up.
Click to expand...
Click to collapse
ah. Okay. True.
Yeah funny how I thought we have it but nope. Not a big deal especially wit always on display.
AoD is far better. Notification lights doesn't mean anything. Just a color flashing
twoxa said:
Yeah funny how I thought we have it but nope. Not a big deal especially wit always on display.
Click to expand...
Click to collapse
guytano86 said:
AoD is far better. Notification lights doesn't mean anything. Just a color flashing
Click to expand...
Click to collapse
Yep! And you can turn off AoD between certain times with 8.1!!
Sounds about right..
All a matter of opinion. It has literally turned me off from buying this phone.
LG is confused on their direction. Led, no led, led is back, nope no led.
20degrees said:
All a matter of opinion. It has literally turned me off from buying this phone.
LG is confused on their direction. Led, no led, led is back, nope no led.
Click to expand...
Click to collapse
led light doesn't reveal any info and that's in the past. AOD is far more useful.
guytano86 said:
led light doesn't reveal any info and that's in the past. AOD is far more useful.
Click to expand...
Click to collapse
Again, matter of opinion. I don't want the screen on showing the time. I'd prefer a small led that flashes a select color for certain things.
It's fine if you don't care for one, but I do. A small colored light flashing a certain color reveals exactly the info I need.
20degrees said:
Again, matter of opinion. I don't want the screen on showing the time. I'd prefer a small led that flashes a select color for certain things.
It's fine if you don't care for one, but I do. A small colored light flashing a certain color reveals exactly the info I need.
Click to expand...
Click to collapse
Ok bro whatever that works for you. Lg 40 is not for you. Good luck
I've got a 1 year old now, and try to keep my phone usage to a minimum with her around, not to mention protecting my new LG from her grip.
My phone sits on the counter, and unless I see the notification light, I keep it out of the way. I've missed tons of messages, some concerning time related issues, since I'm not one of those "pick up the phone every 3 seconds millennial" types.
I never thought they'd take the LED away, so I didn't even check before I bought it.
Too late for me.
From my understanding none of the v-series had led notification light.. My last lg phone with notification light was the lg g2
Except with apps like Light Flow, the light means very particular things. Certain contacts, certain apps, etc. can all be seen from across the room or in the dark, where the AoD requires focusing and being nearby.
20degrees said:
Again, matter of opinion. I don't want the screen on showing the time. I'd prefer a small led that flashes a select color for certain things.
It's fine if you don't care for one, but I do. A small colored light flashing a certain color reveals exactly the info I need.
Click to expand...
Click to collapse
I was a bit put off with the V40 not having a notification light also. I've tried several alternative apps ...
(Always On Edge Display, LED Blinker and NoLED).
The only one that works, for me is the NoLED app. https://forum.xda-developers.com/showthread.php?t=730692

Categories

Resources