Database Develop

[DEV] [COMPILE] [ERROR] Jelly Bean for Galaxy Note [N7000] [UBUNTU]

Source Developers or people experienced please help with this error...I'm stuck.
.....
.....
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp: In function 'OMX_ERRORTYPE SEC_OSAL_LockANBHandle(OMX_U32, OMX_U32, OMX_U32, OMX_COLOR_FORMATTYPE, void**)':
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp:161:78: error: 'GRALLOC_USAGE_YUV_ADDR' was not declared in this scope
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp:160:5: warning: case value '256' not in enumerated type 'OMX_COLOR_FORMATTYPE' [-Wswitch]
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp: In function 'OMX_ERRORTYPE SEC_OSAL_GetPhysANBHandle(OMX_U32, void**)':
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp:218:16: error: 'class android::GraphicBufferMapper' has no member named 'getphys'
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp: In function 'OMX_ERRORTYPE SEC_OSAL_GetANBParameter(OMX_HANDLETYPE, OMX_INDEXTYPE, OMX_PTR)':
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp:323:5: warning: case value '2130706450' not in enumerated type 'OMX_INDEXTYPE' [-Wswitch]
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp: In function 'OMX_ERRORTYPE SEC_OSAL_SetANBParameter(OMX_HANDLETYPE, OMX_INDEXTYPE, OMX_PTR)':
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp:405:5: warning: case value '2130706449' not in enumerated type 'OMX_INDEXTYPE' [-Wswitch]
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp:434:5: warning: case value '2130706451' not in enumerated type 'OMX_INDEXTYPE' [-Wswitch]
hardware/samsung/exynos/multimedia/openmax/osal/SEC_OSAL_Android.cpp:486:5: warning: case value '2130706452' not in enumerated type 'OMX_INDEXTYPE' [-Wswitch]
make: *** [out/target/product/n7000/obj/STATIC_LIBRARIES/libsecosal_intermediates/SEC_OSAL_Android.o] Error 1
make: *** Waiting for unfinished jobs...

I'm trying to port aosp jellybean to i9100, and i met the same error you posted here. It seems we need to apply some patches from cyanogenmod in android_framworks_base. Refer to http://forum.xda-developers.com/showthread.php?t=1760242&page=4

[Q] [Assistance needed] Acodec.cpp

I know most of you don't expect me starting a thread in the Q&A but I am out of ideas. I googled, searched, duh, but found nothing that could be useful to me.
The problem is that the file attached is giving me an error.
Code:
target thumb C++: libstagefright <= frameworks/base/media/libstagefright/ACodec.cpp
In file included from frameworks/base/media/libstagefright/ACodec.cpp:42:
./vendor/qcom/opensource/omx/mm-core/omxcore/inc/OMX_QCOMExtns.h:846: warning: 'typedef' was ignored in this declaration
frameworks/base/media/libstagefright/ACodec.cpp:176: error: expected primary-expression before 'struct'
frameworks/base/media/libstagefright/ACodec.cpp:176: error: expected ',' or ';' before 'struct'
frameworks/base/media/libstagefright/ACodec.cpp:3041: error: expected '}' at end of input
make: *** [out/target/product/golfu/obj/SHARED_LIBRARIES/libstagefright_intermediates/ACodec.o] Error 1
I tried editing it in several ways for about 2 hours but it doesn't work.
I would really appreciate if someone would either link me to a working one/tell me where the error is/fix it and point out the error.
Im curious as to what causes the error.
Thanks :3

which rom are you building?
best if you do a repo sync

cybojenix said:
which rom are you building?
best if you do a repo sync
Click to expand...
Click to collapse
I am building Cyanogenmod 9.
I tried deleting the frameworks folder, where the error is and then re-repo sync, but to no avail. :T
And yeah, to my surprise I did try repo syncing. o.o

You are missing an } sine the compiler passes by the typedef thing. Also you are misssing an ; but most of the errors are from }. I'll look over the code and I'll chech for the misssing/wrong }.
Sent from my HTC Desire C using xda premium

That's what it says but I reviewed the file and did not find any errors. So any help would be appreciated :3

Bump
I hate reviving a dead thread, but I'm going through the same problem right now, building CM9, and I got the same Acodec.cpp errors. I also checked the file and it was written correctly. I'm not sure how to fix this, and could use some help from the community.

SignOfTheShadow said:
I hate reviving a dead thread, but I'm going through the same problem right now, building CM9, and I got the same Acodec.cpp errors. I also checked the file and it was written correctly. I'm not sure how to fix this, and could use some help from the community.
Click to expand...
Click to collapse
Looks like there was something missing in the struct typedef thing.
Try removing //QCOM_HARDWARE from line #172

bugkillr said:
Can you share the local code snippet on pastebin? Looks like there was something missing in the struct typedef thing.
Click to expand...
Click to collapse
I can't access PasteBin from work (they consider the text there to be "Personal Storage & Backup"), so the file in it's entirety is attached after pasting into a .txt file.
This is Line 176, mentioned in the error code, with 5 lines before and after:
Code:
#endif
#endif //QCOM_HARDWARE
////////////////////////////////////////////////////////////////////////////////
struct ACodec::BaseState : public AState {
BaseState(ACodec *codec, const sp<AState> &parentState = NULL);
protected:
enum PortMode {
KEEP_BUFFERS,
and this is line 3041, with 5 before (3041 is the last line):
Code:
LOGV("FlushingOutputState Change state to port settings changed");
mCodec->changeState(mCodec->mOutputPortSettingsChangedState);
}
}
#endif
} // namespace android
I'm totally lost as far as this file goes. I'm no good with C++... Thank you for taking an interest, I really do appreciate it. I messaged Nick Bacon (OP) and he gave me some suggestions, but nothing really panned out.

I removed "//QCOM_HARDWARE" from line 172 and am brunching as we speak. I'll edit with the results in a few.
EDIT: No good. Same error.
2nd EDIT: I added a ";" and two carriage returns before "struct" on line 176, and that seemed to just give me more errors:
Code:
target thumb C++: libstagefright <= frameworks/base/media/libstagefright/ACodec.cpp
In file included from frameworks/base/media/libstagefright/ACodec.cpp:42:
./vendor/qcom/opensource/omx/mm-core/omxcore/inc/OMX_QCOMExtns.h:846: warning: 'typedef' was ignored in this declaration
frameworks/base/media/libstagefright/ACodec.cpp:176: error: expected primary-expression before ';' token
frameworks/base/media/libstagefright/ACodec.cpp: In member function 'android::status_t android::ACodec::allocateOutputBuffersFromNativeWindow()':
frameworks/base/media/libstagefright/ACodec.cpp:537: warning: enumeral mismatch in conditional expression: '<anonymous enum>' vs 'OMX_COLOR_FORMATTYPE'
frameworks/base/media/libstagefright/ACodec.cpp: In member function 'void android::ACodec::sendFormatChange()':
frameworks/base/media/libstagefright/ACodec.cpp:1386: warning: enumeral mismatch in conditional expression: '<anonymous enum>' vs 'OMX_COLOR_FORMATTYPE'
make: *** [out/target/product/l35g/obj/SHARED_LIBRARIES/libstagefright_intermediates/ACodec.o] Error 1

SignOfTheShadow said:
I removed "//QCOM_HARDWARE" from line 172 and am brunching as we speak. I'll edit with the results in a few.
EDIT: No good. Same error.
2nd EDIT: I added a ";" and two carriage returns before "struct" on line 176, and that seemed to just give me more errors:
Code:
target thumb C++: libstagefright <= frameworks/base/media/libstagefright/ACodec.cpp
In file included from frameworks/base/media/libstagefright/ACodec.cpp:42:
./vendor/qcom/opensource/omx/mm-core/omxcore/inc/OMX_QCOMExtns.h:846: warning: 'typedef' was ignored in this declaration
frameworks/base/media/libstagefright/ACodec.cpp:176: error: expected primary-expression before ';' token
frameworks/base/media/libstagefright/ACodec.cpp: In member function 'android::status_t android::ACodec::allocateOutputBuffersFromNativeWindow()':
frameworks/base/media/libstagefright/ACodec.cpp:537: warning: enumeral mismatch in conditional expression: '<anonymous enum>' vs 'OMX_COLOR_FORMATTYPE'
frameworks/base/media/libstagefright/ACodec.cpp: In member function 'void android::ACodec::sendFormatChange()':
frameworks/base/media/libstagefright/ACodec.cpp:1386: warning: enumeral mismatch in conditional expression: '<anonymous enum>' vs 'OMX_COLOR_FORMATTYPE'
make: *** [out/target/product/l35g/obj/SHARED_LIBRARIES/libstagefright_intermediates/ACodec.o] Error 1
Click to expand...
Click to collapse
Well, I don't even have the libraries used in this code and its a large piece of code. So what I can suggest you is setting breakpoints and debugging in Eclipse or a good IDE. OR alternatively you can use gdb or valgrind to see extended flaws in the code. Because just rectifying the bugs in the code would definitely solve the issue.

bugkillr said:
Well, I don't even have the libraries used in this code and its a large piece of code. So what I can suggest you is setting breakpoints and debugging in Eclipse or a good IDE. OR alternatively you can use gdb or valgrind to see extended flaws in the code. Because just rectifying the bugs in the code would definitely solve the issue.
Click to expand...
Click to collapse
I ended up adding:
Code:
{};
to line 175 of the original file. It worked. Thanks for helping.

Are u saying u successfully built cm9??
Sent from my HTC Desire C using xda app-developers app

SignOfTheShadow said:
I ended up adding:
Code:
{};
to line 175 of the original file. It worked. Thanks for helping.
Click to expand...
Click to collapse
Never knew that would fix it! Congratulations btw.

This is very useful. Thanks for the solve. Gonna spam some thanks and request this thread to be closed.

[Q] build failing with custom kernel

So recently i have been trying my hands on building rom from source.
i tried with cm12, which builds well with the stock cm kernel source..
then i took a step further to try to add a custom kernel to my rom source
i am using ElementalX kernel's source..
but i am getting build failure with the following error:
Code:
../../../../../../kernel/lge/ElementalX/kernel/auditsc.c: In function 'audit_filter_inodes':
../../../../../../kernel/lge/ElementalX/kernel/auditsc.c:927:23: warning: 'state' may be used uninitialized in this function [-Wmaybe-uninitialized]
error, forbidden warning: auditsc.c:927
make[3]: *** [kernel/auditsc.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [kernel] Error 2
make[1]: *** [sub-make] Error 2
make[1]: Leaving directory `/home/pratyush/android/kernel/lge/ElementalX'
make: *** [TARGET_KERNEL_BINARIES] Error 2
i have added this in manifest as the repo link:
Code:
<project name="flar2/ElementalX-N5" path="kernel/lge/ElementalX" remote="github" revision="ElementalX-2.00" />
and modified the boardconfig.mk as this:
Code:
# Define kernel config for inline building
TARGET_KERNEL_CONFIG := hammerhead_defconfig
TARGET_KERNEL_SOURCE := kernel/lge/ElementalX
any help is appreciated.. thanks. :fingers-crossed:

wrick17 said:
and modified the boardconfig.mk as this:
Code:
# Define kernel config for inline building
TARGET_KERNEL_CONFIG := hammerhead_defconfig
TARGET_KERNEL_SOURCE := kernel/lge/ElementalX
Click to expand...
Click to collapse
Use elementalx_defconfig instead.

Lethargy said:
Use elementalx_defconfig instead.
Click to expand...
Click to collapse
that worked pretty well though.. but now it got stuck at this...
Code:
target thumb C++: gralloc.msm8974 <= hardware/qcom/display/msm8974/libgralloc/mapper.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/msm8974/libgralloc/ionalloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/msm8974/libgralloc/alloc_controller.cpp
target thumb C++: libqdutils <= hardware/qcom/display/msm8974/libqdutils/profiler.cpp
target thumb C++: libqdutils <= hardware/qcom/display/msm8974/libqdutils/mdp_version.cpp
target thumb C++: libqdutils <= hardware/qcom/display/msm8974/libqdutils/idle_invalidator.cpp
target thumb C++: libqdutils <= hardware/qcom/display/msm8974/libqdutils/comptype.cpp
target thumb C++: hwcomposer.msm8974 <= hardware/qcom/display/msm8974/libhwcomposer/hwc.cpp
target thumb C++: hwcomposer.msm8974 <= hardware/qcom/display/msm8974/libhwcomposer/hwc_utils.cpp
hardware/qcom/display/msm8974/libgralloc/ionalloc.cpp: In member function 'virtual int gralloc::IonAlloc::alloc_buffer(gralloc::alloc_data&)':
hardware/qcom/display/msm8974/libgralloc/ionalloc.cpp:76:18: error: 'struct ion_allocation_data' has no member named 'heap_id_mask'
ionAllocData.heap_id_mask = data.flags & ~ION_SECURE;
^
make: *** [/home/pratyush/android/out/target/product/hammerhead/obj/SHARED_LIBRARIES/libmemalloc_intermediates/ionalloc.o] Error 1
make: *** Waiting for unfinished jobs....
tried to search for but got no clue nowhere..

wrick17 said:
that worked pretty well though.. but now it got stuck at this...
Code:
target thumb C++: gralloc.msm8974 <= hardware/qcom/display/msm8974/libgralloc/mapper.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/msm8974/libgralloc/ionalloc.cpp
target thumb C++: libmemalloc <= hardware/qcom/display/msm8974/libgralloc/alloc_controller.cpp
target thumb C++: libqdutils <= hardware/qcom/display/msm8974/libqdutils/profiler.cpp
target thumb C++: libqdutils <= hardware/qcom/display/msm8974/libqdutils/mdp_version.cpp
target thumb C++: libqdutils <= hardware/qcom/display/msm8974/libqdutils/idle_invalidator.cpp
target thumb C++: libqdutils <= hardware/qcom/display/msm8974/libqdutils/comptype.cpp
target thumb C++: hwcomposer.msm8974 <= hardware/qcom/display/msm8974/libhwcomposer/hwc.cpp
target thumb C++: hwcomposer.msm8974 <= hardware/qcom/display/msm8974/libhwcomposer/hwc_utils.cpp
hardware/qcom/display/msm8974/libgralloc/ionalloc.cpp: In member function 'virtual int gralloc::IonAlloc::alloc_buffer(gralloc::alloc_data&)':
hardware/qcom/display/msm8974/libgralloc/ionalloc.cpp:76:18: error: 'struct ion_allocation_data' has no member named 'heap_id_mask'
ionAllocData.heap_id_mask = data.flags & ~ION_SECURE;
^
make: *** [/home/pratyush/android/out/target/product/hammerhead/obj/SHARED_LIBRARIES/libmemalloc_intermediates/ionalloc.o] Error 1
make: *** Waiting for unfinished jobs....
tried to search for but got no clue nowhere..
Click to expand...
Click to collapse
Have you tried cleaning build directory and/or running a repo sync?

Lethargy said:
Have you tried cleaning build directory and/or running a repo sync?
Click to expand...
Click to collapse
Yep, both.. But i get this whenever i use elementalx source..

wrick17 said:
Yep, both.. But i get this whenever i use elementalx source..
Click to expand...
Click to collapse
Some sort of conflict then, not sure.

U need to make sure u are using the correct kernel branch, elementalX has multiple branches, some caf, some not, if ur building cm, u need a caf kernel or build will fail, make sure ur on the right branch, or give me a copy of the error and I can help

soupysoup said:
U need to make sure u are using the correct kernel branch, elementalX has multiple branches, some caf, some not, if ur building cm, u need a caf kernel or build will fail, make sure ur on the right branch, or give me a copy of the error and I can help
Click to expand...
Click to collapse
Yeah sure, I'll try to build again. When it fails again, I'll post u the logs. Still can u give a quick headsup on which which branch should i use?

same issue here...
Code:
hardware/qcom/display/msm8974/libgralloc/ionalloc.cpp: In member function 'virtual int gralloc::IonAlloc::alloc_buffer(gralloc::alloc_data&)':
hardware/qcom/display/msm8974/libgralloc/ionalloc.cpp:76:18: error: 'struct ion_allocation_data' has no member named 'heap_id_mask'
ionAllocData.heap_id_mask = data.flags & ~ION_SECURE;
^
any hint? trying to build lp5.1 from https://github.com/SlimRoms repo
thank you

What cross compiler are you using? I seem to recall an error like this using the AOSP cross compiler (used to build the rest of AOSP). I pulled a toolchain from google and it worked fine:
Code:
git clone https://android.googlesource.com/platform/prebuilts/gcc/linux-x86/arm/arm-eabi-4.6

Gene Poole said:
What cross compiler are you using? I seem to recall an error like this using the AOSP cross compiler (used to build the rest of AOSP). I pulled a toolchain from google and it worked fine:
Code:
git clone https://android.googlesource.com/platform/prebuilts/gcc/linux-x86/arm/arm-eabi-4.6
Click to expand...
Click to collapse
where do i place it? The repo?

You can place it anywhere. I put it in /usr/src/ where all my other source code resides. Most guides I've seen place them somewhere off the users' home directory but this never made sense to me unless you were on a machine you didn't administer.
Where ever you put it, just export it as a path variable for your kernel compile (I'm assuming the toolchain is in /usr/src/arm-eabi-4.6/ and the kernel is /usr/src/aosp5.1/msm/ and you are root in this case):
Code:
cd /usr/src/aosp5.1/msm/
export ARCH="arm"
export SUBARCH="arm"
export CROSS_COMPILE=arm-eabi-
export PATH=$PATH:/usr/src/arm-eabi-4.6/bin
make -j10

Elementalx uses an optimized toolchain. Google's toolchains don't work to compile this kernel. Use this toolchain instead. Never had any problems with it:
http://forum.xda-developers.com/showthread.php?t=2098133

wrick17 said:
where do i place it? The repo?
Click to expand...
Click to collapse
Are u trying to build CAF or AOSP version?

JoaoPaulo said:
Are u trying to build CAF or AOSP version?
Click to expand...
Click to collapse
CAF. CM12.

wrick17 said:
CAF. CM12.
Click to expand...
Click to collapse
Try to get some different kernel source elementalx is not CAF.
But you can try rename that line of code from:
Code:
ionAllocData.heap_id_mask = data.flags & ~ION_SECURE;
to
Code:
ionAllocData.heap_mask = data.flags & ~ION_SECURE;
Say something then

JoaoPaulo said:
Try to get some different kernel source elementalx is not CAF.
But you can try rename that line of code from:
Code:
ionAllocData.heap_id_mask = data.flags & ~ION_SECURE;
to
Code:
ionAllocData.heap_mask = data.flags & ~ION_SECURE;
Say something then
Click to expand...
Click to collapse
Oki. Cool. Will try and let u know. Currently i m a bit busy with other things. Will do it and let u guys know.

JoaoPaulo said:
Try to get some different kernel source elementalx is not CAF.
But you can try rename that line of code from:
Code:
ionAllocData.heap_id_mask = data.flags & ~ION_SECURE;
to
Code:
ionAllocData.heap_mask = data.flags & ~ION_SECURE;
Say something then
Click to expand...
Click to collapse
ElementalX does have a CM compatible source, just switch branches and make sure u change roomservice.py to allow building with a custom kernel, if u wanna pm me I can help

@wrick17 I am having the same issue. Did you find a solution?
This is for CM non-CAF version.

zymphad said:
@wrick17 I am having the same issue. Did you find a solution?
This is for CM non-CAF version.
Click to expand...
Click to collapse
Sorry mate, I haven't actually got it working after that. And now I am actually short of space on my disk that i can't even try to build it. Maybe somewhere down in future i'll try again. Till then i'm yet to try. Please update us if you find any solution..

[Q] Building Kernel Issue -- toolchain

Hi,
I'm attempting to build the Nexus 6 kernel from the msm source code ([android.googlesource.com/kernel/msm.git). I switch into the correct branch (msm-shamu-3.10-lollipop-release), create the shamu_defconfig, and then execute make with the make ARCH=arm SUBARCH=arm CROSS_COMPILE=arm-eabi- command. I keep getting a variety of errors, some of which I've been able to fix. I believe these errors could be due to the fact I'm using the wrong toolchain. I've tried to build with the following toolchains: arm-eabi-4.6, arm-eabi-4.8, arm-linux-androideabi-4.8, and arm-linux-androideabi-4.9. Those last two were from the android source tree. What toolchain do you all use to build the kernel source?
Details:
Phone: Nexus 6, Android 5.0.1, Kernel 3.10.40-g72dfced, Build LRX22C
Development Env.: Ubuntu 14.04 x64 (on a VmWare VM)
Below is the error I'm currently stuck at. I feel like the real problem is just that I'm using the wrong toolchain rather than me keep modifying the source code that I imagine should be up to date and working):
drivers/net/wireless/bcmdhd/wl_cfg80211.h:818:20: error: 'struct cfg80211_scan_request' has no member named 'dev'
(cfg->scan_request->dev == cfg->p2p_net)) ? true : false)
^
drivers/net/wireless/bcmdhd/wl_cfg80211.c:10184:9: note: in expansion of macro 'scan_req_match'
if (!scan_req_match(cfg)) {
^
drivers/net/wireless/bcmdhd/wl_cfg80211.c: In function 'wl_cfg80211_scan_stop':
drivers/net/wireless/bcmdhd/wl_cfg80211.c:12651:44: error: 'struct cfg80211_scan_request' has no member named 'dev'
if (cfg->scan_request && cfg->scan_request->dev == cfgdev) {
^
make[4]: *** [drivers/net/wireless/bcmdhd/wl_cfg80211.o] Error 1
make[3]: *** [drivers/net/wireless/bcmdhd] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

T280 Custom ROM Progress Thread

Just got a T280 - would like to get Nougat on it. I saw @jedld did awesome work on T285 and @_mone did with TWRP, however, I was hoping to create a thread to consolidate any ongoing efforts for T280 in one place, and see where I could help.

This is what I know of the state of the T280 development.
TWRP and root has been available for the T280 for some time, almost at the same time the T285 version has. There is no non-stock based rom available yet.
Custom T280 kernel here courtesy of @_mone, there are reports that it works with an updated T280 stock firmware.
Before flashing a generated boot.img note that it requires special headers for the T280 here: https://forum.xda-developers.com/showpost.php?p=68843058&postcount=81. There is at least one developer in this forum that is looking to make this process easier.
Assumming this works with the T280 stock firmware, the steps that I see are the following:
1. Patch the N and M related linux kernel patches to the T280 kernel http://jeffvanderstoep.blogspot.com/2016/05/selinux-kernel-patches-for-android-n.html. Update the arm defconfig to the latest recommended by android.
2. Create a lineage device tree, you can use my gtexslte manifest as a starting point https://github.com/jedld/android.git. Probably just need to take out the RIL related modules.

awesome - i'll give this a go.. right now I'm just testing building samsung's stock opensource kernel.

It's people like you that make me love xda. Thanks!

Downloading source code.....
@jedld I downloading lineage14.1 src and gtexslte kernel/device trees
How to create gtexswifi device tree based gtexslte?

tdukazudon said:
@jedld I downloading lineage14.1 src and gtexslte kernel/device trees
How to create gtexswifi device tree based gtexslte?
Click to expand...
Click to collapse
You can start by renaming gtexslte to gtexswifi, I believe flash partitions sizes and mountpoints are about the same for both SM-T285 and SM-T280 so you don't need to change much. You probably need to remove phone related configs. You also need to use the SM-T280 kernel also. I don't know if there are other hardware differences from the T280 and T285 (gps?) If this is your first time doing any sort of porting, this can be a daunting task, so I suggest you try to learn how to extract the stock boot and system images, modify some files and then flash it back as an exercise. There might already be a gtexswifi device tree in progress somewhere, I suggest that you contact those devs or probably set up an irc channel to coordinate your efforts.

@jedld - I'm confused - for the M/N Patches to the kernel, it seems like 2 sets of patches undo each other, namely:
Revert "SELinux: per-command whitelisting of ioctls" - https://android-review.googlesource.com/162275
selinux: extended permissions for ioctls - https://android-review.googlesource.com/162279
and
Revert "security: lsm_audit: add ioctl specific auditing" - https://android-review.googlesource.com/162276
security: add ioctl specific auditing to lsm_audit - https://android-review.googlesource.com/162278
What'd you do for those?

chiefwigms said:
@jedld - I'm confused - for the M/N Patches to the kernel, it seems like 2 sets of patches undo each other, namely:
Revert "SELinux: per-command whitelisting of ioctls" - https://android-review.googlesource.com/162275
selinux: extended permissions for ioctls - https://android-review.googlesource.com/162279
and
Revert "security: lsm_audit: add ioctl specific auditing" - https://android-review.googlesource.com/162276
security: add ioctl specific auditing to lsm_audit - https://android-review.googlesource.com/162278
What'd you do for those?
Click to expand...
Click to collapse
I ignored the reverts at first. I can't remember if it worked after that. Though I ended up just doing a straight diff with the selinux modules based on the aosp 3.10.y kernel sources and just merging them.

jedld said:
I ignored the reverts at first. I can't remember if it worked after that. Though I ended up just doing a straight diff with the selinux modules based on the aosp 3.10.y kernel sources and just merging them.
Click to expand...
Click to collapse
Sound good - i'll just diff w/ your repo Thx!

@jedld
This build error happened.Do you have solution?
hardware/sprd/libmemion/MemoryHeapIon.cpp:614:30: error: variable has incomplete type 'struct ion_kmap_data'
struct ion_kmap_data kmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:614:16: note: forward declaration of 'ion_kmap_data'
struct ion_kmap_data kmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:618:27: error: use of undeclared identifier 'ION_SPRD_CUSTOM_MAP_KERNEL'; did you mean 'ION_SPRD_CUSTOM_MAP'?
custom_data.cmd = ION_SPRD_CUSTOM_MAP_KERNEL;
^~~~~~~~~~~~~~~~~~~~~~~~~~
ION_SPRD_CUSTOM_MAP
/home/aletheia/smt280/out/target/product/gtexswifi/obj/KERNEL_OBJ/usr/include/video/ion_sprd.h:54:2: note: 'ION_SPRD_CUSTOM_MAP' declared here
ION_SPRD_CUSTOM_MAP,
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:638:32: error: variable has incomplete type 'struct ion_kunmap_data'
struct ion_kunmap_data kunmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:638:16: note: forward declaration of 'ion_kunmap_data'
struct ion_kunmap_data kunmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:642:27: error: use of undeclared identifier 'ION_SPRD_CUSTOM_UNMAP_KERNEL'; did you mean 'ION_SPRD_CUSTOM_UNMAP'?
custom_data.cmd = ION_SPRD_CUSTOM_UNMAP_KERNEL;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
ION_SPRD_CUSTOM_UNMAP
/home/aletheia/smt280/out/target/product/gtexswifi/obj/KERNEL_OBJ/usr/include/video/ion_sprd.h:55:2: note: 'ION_SPRD_CUSTOM_UNMAP' declared here
ION_SPRD_CUSTOM_UNMAP,
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:663:30: error: variable has incomplete type 'struct ion_kmap_data'
struct ion_kmap_data kmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:663:16: note: forward declaration of 'ion_kmap_data'
struct ion_kmap_data kmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:667:27: error: use of undeclared identifier 'ION_SPRD_CUSTOM_MAP_KERNEL'; did you mean 'ION_SPRD_CUSTOM_MAP'?
custom_data.cmd = ION_SPRD_CUSTOM_MAP_KERNEL;
^~~~~~~~~~~~~~~~~~~~~~~~~~
ION_SPRD_CUSTOM_MAP
/home/aletheia/smt280/out/target/product/gtexswifi/obj/KERNEL_OBJ/usr/include/video/ion_sprd.h:54:2: note: 'ION_SPRD_CUSTOM_MAP' declared here
ION_SPRD_CUSTOM_MAP,
^
Import includes file: /home/aletheia/smt280/out/target/product/gtexswifi/obj/SHARED_LIBRARIES/libRSCpuRef_intermediates/import_includes
hardware/sprd/libmemion/MemoryHeapIon.cpp:690:32: error: variable has incomplete type 'struct ion_kunmap_data'
struct ion_kunmap_data kunmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:690:16: note: forward declaration of 'ion_kunmap_data'
struct ion_kunmap_data kunmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:694:27: error: use of undeclared identifier 'ION_SPRD_CUSTOM_UNMAP_KERNEL'; did you mean 'ION_SPRD_CUSTOM_UNMAP'?
custom_data.cmd = ION_SPRD_CUSTOM_UNMAP_KERNEL;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
ION_SPRD_CUSTOM_UNMAP
/home/aletheia/smt280/out/target/product/gtexswifi/obj/KERNEL_OBJ/usr/include/video/ion_sprd.h:55:2: note: 'ION_SPRD_CUSTOM_UNMAP' declared here
ION_SPRD_CUSTOM_UNMAP,
^
8 errors generated.

tdukazudon said:
@jedld
This build error happened.Do you have solution?
hardware/sprd/libmemion/MemoryHeapIon.cpp:614:30: error: variable has incomplete type 'struct ion_kmap_data'
struct ion_kmap_data kmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:614:16: note: forward declaration of 'ion_kmap_data'
struct ion_kmap_data kmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:618:27: error: use of undeclared identifier 'ION_SPRD_CUSTOM_MAP_KERNEL'; did you mean 'ION_SPRD_CUSTOM_MAP'?
custom_data.cmd = ION_SPRD_CUSTOM_MAP_KERNEL;
^~~~~~~~~~~~~~~~~~~~~~~~~~
ION_SPRD_CUSTOM_MAP
/home/aletheia/smt280/out/target/product/gtexswifi/obj/KERNEL_OBJ/usr/include/video/ion_sprd.h:54:2: note: 'ION_SPRD_CUSTOM_MAP' declared here
ION_SPRD_CUSTOM_MAP,
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:638:32: error: variable has incomplete type 'struct ion_kunmap_data'
struct ion_kunmap_data kunmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:638:16: note: forward declaration of 'ion_kunmap_data'
struct ion_kunmap_data kunmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:642:27: error: use of undeclared identifier 'ION_SPRD_CUSTOM_UNMAP_KERNEL'; did you mean 'ION_SPRD_CUSTOM_UNMAP'?
custom_data.cmd = ION_SPRD_CUSTOM_UNMAP_KERNEL;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
ION_SPRD_CUSTOM_UNMAP
/home/aletheia/smt280/out/target/product/gtexswifi/obj/KERNEL_OBJ/usr/include/video/ion_sprd.h:55:2: note: 'ION_SPRD_CUSTOM_UNMAP' declared here
ION_SPRD_CUSTOM_UNMAP,
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:663:30: error: variable has incomplete type 'struct ion_kmap_data'
struct ion_kmap_data kmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:663:16: note: forward declaration of 'ion_kmap_data'
struct ion_kmap_data kmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:667:27: error: use of undeclared identifier 'ION_SPRD_CUSTOM_MAP_KERNEL'; did you mean 'ION_SPRD_CUSTOM_MAP'?
custom_data.cmd = ION_SPRD_CUSTOM_MAP_KERNEL;
^~~~~~~~~~~~~~~~~~~~~~~~~~
ION_SPRD_CUSTOM_MAP
/home/aletheia/smt280/out/target/product/gtexswifi/obj/KERNEL_OBJ/usr/include/video/ion_sprd.h:54:2: note: 'ION_SPRD_CUSTOM_MAP' declared here
ION_SPRD_CUSTOM_MAP,
^
Import includes file: /home/aletheia/smt280/out/target/product/gtexswifi/obj/SHARED_LIBRARIES/libRSCpuRef_intermediates/import_includes
hardware/sprd/libmemion/MemoryHeapIon.cpp:690:32: error: variable has incomplete type 'struct ion_kunmap_data'
struct ion_kunmap_data kunmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:690:16: note: forward declaration of 'ion_kunmap_data'
struct ion_kunmap_data kunmap_data;
^
hardware/sprd/libmemion/MemoryHeapIon.cpp:694:27: error: use of undeclared identifier 'ION_SPRD_CUSTOM_UNMAP_KERNEL'; did you mean 'ION_SPRD_CUSTOM_UNMAP'?
custom_data.cmd = ION_SPRD_CUSTOM_UNMAP_KERNEL;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
ION_SPRD_CUSTOM_UNMAP
/home/aletheia/smt280/out/target/product/gtexswifi/obj/KERNEL_OBJ/usr/include/video/ion_sprd.h:55:2: note: 'ION_SPRD_CUSTOM_UNMAP' declared here
ION_SPRD_CUSTOM_UNMAP,
^
8 errors generated.
Click to expand...
Click to collapse
You need so sync up the kernel ion drivers and include files with the one used by the gtexslte

Pardon my stupidity, but from your post here with the custom t280 header, how would I go about modifying the degas-mkbootimg command with the permissive kernel that I have?

chiefwigms said:
Pardon my stupidity, but from your post here with the custom t280 header, how would I go about modifying the degas-mkbootimg command with the permissive kernel that I have?
Click to expand...
Click to collapse
best approach I believe would be to leave mkbootimg as is and just create another commandline utility that takes an exisitng boot.img and prepend the T280 header to it. I'll try to create a C program that does it if I have time.

jedld said:
best approach I believe would be to leave mkbootimg as is and just create another commandline utility that takes an exisitng boot.img and prepend the T280 header to it. I'll try to create a C program that does it if I have time.
Click to expand...
Click to collapse
I'll clone your repo & add something to repack the t280 boot.img. Sorry - had to read through that post a few times - didn't realize the seandroid header was at the end of the file..
Kernel question : the zImage I compile is ~ 5 megs (Image is ~12) - when i unpack the stock boot.img (or the ones that @_mone made), they're around ~10 megs. Any ideas?

chiefwigms said:
I'll clone your repo & add something to repack the t280 boot.img. Sorry - had to read through that post a few times - didn't realize the seandroid header was at the end of the file..
Kernel question : the zImage I compile is ~ 5 megs (Image is ~12) - when i unpack the stock boot.img (or the ones that @_mone made), they're around ~10 megs. Any ideas?
Click to expand...
Click to collapse
boot.img also contains the ramdisk aside from the compressed kernel image.

jedld said:
best approach I believe would be to leave mkbootimg as is and just create another commandline utility that takes an exisitng boot.img and prepend the T280 header to it. I'll try to create a C program that does it if I have time.
Click to expand...
Click to collapse
jedld said:
boot.img also contains the ramdisk aside from the compressed kernel image.
Click to expand...
Click to collapse
Right, but I'm talking about zImage.. doesn't that remain untouched?

chiefwigms said:
Right, but I'm talking about zImage.. doesn't that remain untouched?
Click to expand...
Click to collapse
If you are comparing to stock size, samsung might have less flags enabled when they built their kernel as compared to the sources available to us so it could be smaller

jedld said:
If you are comparing to stock size, samsung might have less flags enabled when they built their kernel as compared to the sources available to us so it could be smaller
Click to expand...
Click to collapse
I don't know - I merged most of your def config to mine, and rebuilt stock, _mone, the modified one ive been working on, and your performance_2 branch for the t285 - all the zImages are around 5 MB :
[email protected]:/gtaba# ls -la kernel_samsung_gtexslte/arch/arm/boot/*Image*
-rwxr-xr-x 1 root root 12788984 Aug 26 23:06 kernel_samsung_gtexslte/arch/arm/boot/Image
-rwxr-xr-x 1 root root 5622664 Aug 26 23:06 kernel_samsung_gtexslte/arch/arm/boot/zImage
[email protected]:/gtaba# ls -la android_kernel_samsung_gtexswifi/arch/arm/boot/*Image*
-rwxr-xr-x 1 root root 12516984 Aug 25 21:05 android_kernel_samsung_gtexswifi/arch/arm/boot/Image
-rwxr-xr-x 1 root root 5488912 Aug 25 21:05 android_kernel_samsung_gtexswifi/arch/arm/boot/zImage

chiefwigms said:
I don't know - I merged most of your def config to mine, and rebuilt stock, _mone, the modified one ive been working on, and your performance_2 branch for the t285 - all the zImages are around 5 MB :
[email protected]:/gtaba# ls -la kernel_samsung_gtexslte/arch/arm/boot/*Image*
-rwxr-xr-x 1 root root 12788984 Aug 26 23:06 kernel_samsung_gtexslte/arch/arm/boot/Image
-rwxr-xr-x 1 root root 5622664 Aug 26 23:06 kernel_samsung_gtexslte/arch/arm/boot/zImage
[email protected]:/gtaba# ls -la android_kernel_samsung_gtexswifi/arch/arm/boot/*Image*
-rwxr-xr-x 1 root root 12516984 Aug 25 21:05 android_kernel_samsung_gtexswifi/arch/arm/boot/Image
-rwxr-xr-x 1 root root 5488912 Aug 25 21:05 android_kernel_samsung_gtexswifi/arch/arm/boot/zImage
Click to expand...
Click to collapse
For the gtexslte the size is about similar as well:
[email protected]:~/android-work/kernel/samsung/gtexslte/arch$ ls -la arm/boot/*Image*
-rwxrwxr-x 1 jedld jedld 12672968 Aug 28 07:00 arm/boot/Image
-rwxrwxr-x 1 jedld jedld 5566008 Aug 28 07:00 arm/boot/zImage

jedld said:
For the gtexslte the size is about similar as well:
[email protected]:~/android-work/kernel/samsung/gtexslte/arch$ ls -la arm/boot/*Image*
-rwxrwxr-x 1 jedld jedld 12672968 Aug 28 07:00 arm/boot/Image
-rwxrwxr-x 1 jedld jedld 5566008 Aug 28 07:00 arm/boot/zImage
Click to expand...
Click to collapse
Alright.. I'll try that.. and just to make sure, you repack zImage not image right? Just curious why when I unpack _mone it's 2x the size