Related
Hello,
Now, as we finally can use a feature complete ROM on our Tattoo devices, I was wondering what steps need to be done to port sense onto cm7?
Could it be done on file level or would it be necessary to merge it on source Level?
NikiB said:
Hello,
Now, as we finally can use a feature complete ROM on our Tattoo devices, I was wondering what steps need to be done to port sense onto cm7?
Could it be done on file level or would it be necessary to merge it on source Level?
Click to expand...
Click to collapse
Do you have the htc source?
Of course not thats why I am asking if a file merge could possibly sufficient.
NikiB said:
Of course not thats why I am asking if a file merge could possibly sufficient.
Click to expand...
Click to collapse
I'm just jokin'.. Is possible to make a theme, but it's not the same thing..
I know what people would like from a rom: http://forum.xda-developers.com/showthread.php?t=989143
But for our little Click is better stay clean
Hi Guys,
I actually tried to port CyanogenMod 13 from my Samsung Galaxy Tab 2.
Here is some info about this device - http://www.gsmarena.com/samsung_galaxy_tab_2_7_0_p3100-4543.php
Why I choose Galaxy Tab 2? Cause that is the only device i have that has CyanogenMod 13. If there is something wrong please let me know.
Now here is the problem. I modified the System folder. but now i cant switch it into system.new.dat . I tried every single program but no use.
So if anyone can help me converting it into system.new.dat. if anyone can i will upload the files in Drive so let me know.
@tasnim_tamim I'm not breaking your heart but it'll not work.
Completely different processors nd kernel versions.
Try porting from a device which has same processor, Snapdragon 410.
Examples: Lenovo A6000, Samsung J5, Moto g(3rd gen), HTC Desire 510, Samsung A3, Samsung A5 & Many more.
Happy porting! I told you all the devices I knew about by my researches so far.
Has.007 said:
@tasnim_tamim I'm not breaking your heart but it'll not work.
Completely different processors nd kernel versions.
Try porting from a device which has same processor, Snapdragon 410.
Examples: Lenovo A6000, Samsung J5, Moto g(3rd gen), HTC Desire 510, Samsung A3, Samsung A5 & Many more.
Happy porting! I told you all the devices I knew about by my researches so far.
Click to expand...
Click to collapse
No problem. I'll try that. Its my first time I am porting a ROM. So I am a noob at these stuff. But anyway thanks for letting me know about that.
Has.007 said:
@tasnim_tamim I'm not breaking your heart but it'll not work.
Completely different processors nd kernel versions.
Try porting from a device which has same processor, Snapdragon 410.
Examples: Lenovo A6000, Samsung J5, Moto g(3rd gen), HTC Desire 510, Samsung A3, Samsung A5 & Many more.
Happy porting! I told you all the devices I knew about by my researches so far.
Click to expand...
Click to collapse
But the thing I'll like to know from you is how you repack system_ or system.img to system. new.DAT??
@tasnim_tamim You're welcome. You'll need Linux for that.
Has.007 said:
@tasnim_tamim You're welcome. You'll need Linux for that.
Click to expand...
Click to collapse
I have Ubuntu 14.04 dualbooted on my system.
And BTW I have selected a ROM from Moto g 3rd gen 2015 which is CM13. ... I am extremely interested in porting ROM.
tasnim_tamim said:
I have Ubuntu 14.04 dualbooted on my system.
And BTW I have selected a ROM from Moto g 3rd gen 2015 which is CM13. ... I am extremely interested in porting ROM.
Click to expand...
Click to collapse
Here you go open the thread nd you can find what you need to know.
http://forum.xda-developers.com/che...arshmallow-t3283452/post64587718#post64587718
Actually I'm not sure if the Cm13 ROMs will work yet, until @zim555 or any other developer builds a Cm13 kernel.
You can try porting but if you're not successful you should go for 5.0 or 5.1.1 ROMs.
Has.007 said:
Here you go open the thread nd you can find what you need to know.
http://forum.xda-developers.com/che...arshmallow-t3283452/post64587718#post64587718
Actually I'm not sure if the Cm13 ROMs will work yet, until @zim555 or any other developer builds a Cm13 kernel.
You can try porting but if you're not successful you should go for 5.0 or 5.1.1 ROMs.
Click to expand...
Click to collapse
Thanks dude for the link.
I am sure I will stuck in a boot loop because I don't have a kernel. So my expectations are wait for @zim555. If cm13 fails I'll try 5.1.1 dirty unicorn
tasnim_tamim said:
Thanks dude for the link.
I am sure I will stuck in a boot loop because I don't have a kernel. So my expectations are wait for @zim555. If cm13 fails I'll try 5.1.1 dirty unicorn
Click to expand...
Click to collapse
Press the thanks instead.
Yup that's the problem, Zim is actually trying to patch the Cm13 kernel to make it work so I'm sure soon he'll start that project maybe in some days.
Best of luck go for Dirty Unicorns.
Has.007 said:
Press the thanks instead.
Yup that's the problem, Zim is actually trying to patch the Cm13 kernel to make it work so I'm sure soon he'll start that project maybe in some days.
Best of luck go for Dirty Unicorns.
Click to expand...
Click to collapse
Okay, I tried porting 5.1.1 OmniRom using the link you gave me. now i followed everything. everything was fine. but when i tried making system.img it dosent works. any suggestion??
tasnim_tamim said:
Okay, I tried porting 5.1.1 OmniRom using the link you gave me. now i followed everything. everything was fine. but when i tried making system.img it dosent works. any suggestion??
Click to expand...
Click to collapse
Check the name of the file you've in that folder. Change the command accordingly.
Has.007 said:
Check the name of the file you've in that folder. Change the command accordingly.
Click to expand...
Click to collapse
First of all the I already messed the conversion to system.img which after that I had to goto windows and extract the whole damn thing. So now I can't change it to system.new.dat. on my windows there is also a software for that. But that asks for something like Select system.img size. Which is what extremely confuses me. And I said earlier that I completely messed up everything on Ubuntu side that now. Now the thing on thread what it said doesn't even works. I did ported everything. But I can't compress it. If you want I can give you screenshot on windows about the program. So if you can help me with that
BTW I am porting OmniRom 5.1.1 from Moto G 2013
Hi,
I have been looking for any information but i couldn´t find anything (or i didn´t search proprely) but I want to know if this device can act like a mini pc itself. I mean, in other pcs you can install, reinstall and change OS.
Is there any possibility of installing Phoenix OS, Android x86 (or android os) or any other OS instead of the Remix?? I have been wondering to give it a chance if I can change OS to have a portable PC (I am thinking to have it for school, I am teacher) and connect it to proyectors...
If anyone has any idea is more than welcome, and if I find any solution or I can install any other OS i will edit the post!!
All together, more power :highfive: :highfive: :victory:
Cheers!!
Unfortunately I think this was discussed a long time ago on this forum, there was never enough development support to make it happen.
Sent from my PH-1 using Tapatalk
So I'm trying to get halium working for tab 2 (we can get ubuntu touch and maybe even plasma mobile with help of it) and I get this error
Code:
arch/arm/boot/compressed/atags_to_fdt.o: In function `merge_fdt_bootargs':
atags_to_fdt.c:(.text+0x20c): undefined reference to `__stack_chk_fail'
atags_to_fdt.c:(.text+0x210): undefined reference to `__stack_chk_guard'
It seems to be a toolchain error any help?
"It would appear that the -mstack-protector-guard option is only for backwards compatibility with how the stack protector worked in the past. In the past the canary was in a global variable. Later it was switched to TLS. It would appear that the operating system / libc you use either removed or never had support for the global variable canary, so only TLS works.
Don't touch the -mstack-protector-guard option and everything should work. The default should be fine when you use -fstack-protector-all."
"Provide __stack_chk_guard with a random value in c file, avoid using regular values like all zero's or FF's because the stack can easily get these values during any memory operation. Wiki on providing magic number implementation. This __stack_chk_guard will be placed at the top and bottom of the stack, which will be checked during every stack access. Any change in the value implies a corrupted stack and returns with error providing the stack protection.
unsigned long __stack_chk_guard;
void __stack_chk_guard_setup(void)
{
__stack_chk_guard = 0xBAAAAAAD;//provide some magic numbers
}
void __stack_chk_fail(void)
{
/* Error message */
}// will be called when guard variable is corrupted "
"There are two ways to remove this error: 1. From the compiler option disable(comment out) the "stack guard".
Define __stack_chk_guard in you c file.
When you define __stack_chk_guard make sure you provide random value to it. For providing random value you need to pass as an argument to the random function.
For any further detail you can refer to the compiler manual."
"For those that get this error in bare metal software development with a custom linker script, make sure to pass the option -nostdlib option:
gcc -nostdlib
since Ubuntu 16.04 for example enables the stack protection by default on the compiler. man gcc says:
NOTE: In Ubuntu 14.10 and later versions, -fstack-protector-strong is enabled by default for C, C++, ObjC, ObjC++, if none of -fno-stack-protector, -nostdlib, nor -ffreestanding are found.
-fno-stack-protector also solved it for me, but you should likely tell your poor compiler that you are doing baremetal stuff to prevent other such problems.
I'm guessing this is because the feature relies on symbols which are normally defined if a linker script is not given? But TODO I found no mention of those symbols by dumping the default linker script with:
aarch64-linux-gnu-gcc -Wl,-verbose main.c
so I'm not sure.
I grepped GCC 6.4.0 source code and it suggests that the symbol comes from libgcc2.c at gcc/doc/tm.texi:
The default version of this hook creates a variable called @samp{__stack_chk_guard}, which is normally defined in @file{libgcc2.c}."
Click to expand...
Click to collapse
source: https://stackoverflow.com/questions/27290086/gcc-canaries-undefined-reference-to-stack-chk-guard
i cant wait to use this and your other project (sailfishos)!
wizzer48 said:
i cant wait to use this and your other project (sailfishos)!
Click to expand...
Click to collapse
Yes even I can't wait for both as there is no latest development for our tab !!!
Arc android said:
Yes even I can't wait for both as there is no latest development for our tab !!!
Click to expand...
Click to collapse
Halium doesnt seem to work i tried but to no avail
Mithil17 said:
Halium doesnt seem to work i tried but to no avail
Click to expand...
Click to collapse
Its OK at least you tried to build it !!
Hey I have a great idea Mithil17, can you try to build MIUI 7 for galaxy tab 2? There was an attempt to build it earlier but it wasn't successful.
Arc android said:
Hey I have a great idea Mithil17, can you try to build MIUI 7 for galaxy tab 2? There was an attempt to build it earlier but it wasn't successful.
Click to expand...
Click to collapse
MIUI ??? Why do you wanna china bloadware sooo badly?? what's wrong with LOS or any other bloadware free ROMs?
Plus it's gonna be laggy as h3ll... done and forgotten.
drnightshadow said:
MIUI ??? Why do you wanna china bloadware sooo badly?? what's wrong with LOS or any other bloadware free ROMs?
Plus it's gonna be laggy as h3ll... done and forgotten.
Click to expand...
Click to collapse
Yeah I know it's Chinese but it looks beautiful. You'll know it if you have tried mini 5 for tab 2.
Arc android said:
Yeah I know it's Chinese but it looks beautiful. You'll know it if you have tried mini 5 for tab 2.haha
Click to expand...
Click to collapse
Haha, no thank you! I'm happy with LOS and RR ROMS. I own redmi note 5 pro but never used MIUI [email protected], I unlocked bootloader and installed LOS asap. I like to have privacy in my hand and I hate when OS wanna rape my privacy. My privacy isn't on sale.
drnightshadow said:
Haha, no thank you! I'm happy with LOS and RR ROMS. I own redmi note 5 pro but never used MIUI [email protected], I unlocked bootloader and installed LOS asap. I like to have privacy in my hand and I hate when OS wanna rape my privacy. My privacy isn't on sale.
Click to expand...
Click to collapse
If you actually want this much privacy, here's something for you : https://androidfilehost.com/?fid=17248734326145705104
An unofficial /e/os build for your device. Just trying to help you in case you didn't know this. That's all !
Arc android said:
If you actually want this much privacy, here's something for you : https://androidfilehost.com/?fid=17248734326145705104
An unofficial /e/os build for your device. Just trying to help you in case you didn't know this. That's all !
Click to expand...
Click to collapse
whyred = Redmi Note 5. Not SGT2
Are you sure? It can brick device
levider said:
whyred = Redmi Note 5. Not SGT2Are you sure? It can brick device
Click to expand...
Click to collapse
Note 5/pro = whyred that's what Google says.
Also in the above link, it is made for redmi note 5 pro
Official /e/ forum link : https://www.google.com/url?sa=t&sou...FjACegQIBBAC&usg=AOvVaw1iyAyl2Ur__Xid-tw1cRCz
I hope I am not doing anything wrong
Arc android said:
Note 5/pro = whyred that's what Google says.
Also in the above link, it is made for redmi note 5 pro
Click to expand...
Click to collapse
Dude, this is not Redmi Note 5 thread.
Update: It boots now, Sources are in https://github.com/Halium/projectmanagement/issues/238 no ui still
Mithil17 said:
Update: It boots now, Sources are in https://github.com/Halium/projectmanagement/issues/238 no ui still
Click to expand...
Click to collapse
So we can install it now ???? !!!!!
Arc android said:
So we can install it now ???? !!!!!
Click to expand...
Click to collapse
Well you can just install it, it just boots, no ui/display
Mithil17 said:
Well you can just install it, it just boots, no ui/display
Click to expand...
Click to collapse
So it means even if I install it, it can't be operated. Why some things are way too difficult for tab 2 ?? I mean miui7, sfos, treble, Oreo and now haloum are ported to other devices too that are mostly similar to ours but running them on tab 2 is a bit more difficult.
Hey there interweb!
This thread is meant as a general area to organise the mess of files scattered across the internet for the original Wi-Fi version of the Samsung Galaxy Tab S 8.4.
This Google Drive folder contains the following:
Stock Odin TAR/MD5 firmware files
ROMs, and their accompanying files + install instructions that have been confirmed to boot,
Kernels that have been confirmed to boot,
Useful mods which are confirmed to work and add genuine capability to your device;
and anything else which I think is useful to those wishing to mod their Tab S.
Link:
androiddev - Google Drive
drive.google.com
If you know of any files which you think should be included, and are not already here, please feel free to either reply to this thread or DM me. If you want any assistance at all, please feel free to do the same, and I will try to assist you to the best of my ability.
All the best,
Cessna
I must reiterate, as always, that although I have tested each of these mods, I am not responsible for bricks, loss of data, or permanent damage to your device. You yourself are choosing to make these modifications, and although they have my quality assurance, I can not guarantee their 100% safety. Just because they worked on my device, does not necessarily mean they will work on yours.
CessnaBroon said:
Hey there interweb!
This thread is meant as a general area to organise the mess of files scattered across the internet for the original Wi-Fi version of the Samsung Galaxy Tab S 8.4.
This Google Drive folder contains the following:
Stock Odin TAR/MD5 firmware files
ROMs, and their accompanying files + install instructions that have been confirmed to boot,
Kernels that have been confirmed to boot,
Useful mods which are confirmed to work and add genuine capability to your device;
and anything else which I think is useful to those wishing to mod their Tab S.
Link:
klimtwifi - Google Drive
drive.google.com
If you know of any files which you think should be included, and are not already here, please feel free to either reply to this thread or DM me. If you want any assistance at all, please feel free to do the same, and I will try to assist you to the best of my ability.
All the best,
Cessna
I must reiterate, as always, that although I have tested each of these mods, I am not responsible for bricks, loss of data, or permanent damage to your device. You yourself are choosing to make these modifications, and although they have my quality assurance, I can not guarantee their 100% safety. Just because they worked on my device, does not necessarily mean they will work on yours.
Click to expand...
Click to collapse
Good idea to gather everything on one place and make the mess a bit easier to handle..
I helped myself with the TWRP and the LOS17, much obliged. Don't really need help otherwise.
That is, unless you know why my t705 (i have one of those too) keeps messing with me and losing charge even when switched off...
prkfsz said:
Good idea to gather everything on one place and make the mess a bit easier to handle..
I helped myself with the TWRP and the LOS17, much obliged. Don't really need help otherwise.
That is, unless you know why my t705 (i have one of those too) keeps messing with me and losing charge even when switched off...
Click to expand...
Click to collapse
I'll be honest, my Tab s battery has decreased to about 2100 mAh from 4900 so it's probably just age I'm afraid. If you use it more, you could do a battery transplant, but I don't have ROMs for klimtlte. Thanks for using my mirror
CessnaBroon said:
I'll be honest, my Tab s battery has decreased to about 2100 mAh from 4900 so it's probably just age I'm afraid. If you use it more, you could do a battery transplant, but I don't have ROMs for klimtlte. Thanks for using my mirror
Click to expand...
Click to collapse
Not battery. Changed it. And the same battery works fine on T700 and does not lose charge when off. Tried flashing other ROM as well, but i can't find solution.
prkfsz said:
Not battery. Changed it. And the same battery works fine on T700 and does not lose charge when off. Tried flashing other ROM as well, but i can't find solution.
Click to expand...
Click to collapse
That's odd. Have you tried flashing a custom kernel in TWRP? If not, I'll upload one to the Google Drive in the /androiddev/klimtlte folder. Will create it soon, along with instructions.
CessnaBroon said:
That's odd. Have you tried flashing a custom kernel in TWRP? If not, I'll upload one to the Google Drive in the /androiddev/klimtlte folder. Will create it soon, along with instructions.
Click to expand...
Click to collapse
Odd indeed. And really frustrating. :-/
Have not tried with custom kernel but can of course do that, if it's simple. But, like i said - it's a T705, you mean there is one already made or are you just going to make one on a coffee break?
prkfsz said:
Odd indeed. And really frustrating. :-/
Have not tried with custom kernel but can of course do that, if it's simple. But, like i said - it's a T705, you mean there is one already made or are you just going to make one on a coffee break?
Click to expand...
Click to collapse
There's one already made I think. I'll see if I can find one and alert you when it's up. Obvs I can't do a check for safety without the hardware so make a full backup of the boot partition just in case. I'll make sure to find one with good reviews
CessnaBroon said:
There's one already made I think. I'll see if I can find one and alert you when it's up. Obvs I can't do a check for safety without the hardware so make a full backup of the boot partition just in case. I'll make sure to find one with good reviews
Click to expand...
Click to collapse
Not sure if i have the time to do it tonight or this weekend, but i will try as soon as i get the chance.
Very gratefull for all the help. I actually have two of them, with the same behaviour and i almost written them off, so..
prkfsz said:
Not sure if i have the time to do it tonight or this weekend, but i will try as soon as i get the chance.
Very gratefull for all the help. I actually have two of them, with the same behaviour and i almost written them off, so..
Click to expand...
Click to collapse
kernel - Google Drive
drive.google.com
Shouldn't take more than 5 minutes. Good luck!
CessnaBroon said:
kernel - Google Drive
drive.google.com
Shouldn't take more than 5 minutes. Good luck!
Click to expand...
Click to collapse
Thank you kindly, sir.
Will try right away, but can't really see if had any effect untill morning.
I thought first to ask you if it is possible to use this on stock too, but then it struck me how stupid idea that is, since it's not the same Android version. Because one of them is on stock and behaving the same way. Which basically leads me to believe that it actually is a hardware fault...
prkfsz said:
Thank you kindly, sir.
Will try right away, but can't really see if had any effect untill morning.
I thought first to ask you if it is possible to use this on stock too, but then it struck me how stupid idea that is, since it's not the same Android version. Because one of them is on stock and behaving the same way. Which basically leads me to believe that it actually is a hardware fault...
Click to expand...
Click to collapse
This should work on stock marshmallow too. I will give it a go and get back to you.
Thank you kindly!
lafinjack said:
Thank you kindly!
Click to expand...
Click to collapse
You're very welcome!
CessnaBroon said:
This should work on stock marshmallow too. I will give it a go and get back to you.
Click to expand...
Click to collapse
Sorry for delay in answering..
Unfortunatelly the error is still present. Like i said, probably a software issue.
Bit thanx anuway!
Thanks for creating a section specifically for the SM-T700! I hope that I can get some practical help on moving forward
On my post here (https://forum.xda-developers.com/t/...d-but-ok-with-resurrection-remix-why.4332701/) I describe my attempt to install a variation of LineageOS 17.1 on my device -- always running into 'E1001'. I eventually settled on an older Resurrection Remix, since someone mentioned that it would ultimately make it possible to move to LineageOS (I have not tried that yet).
Here are some of my questions:
1) In a much larger/older thread (https://forum.xda-developers.com/t/...t700-sm-t705-sm-t800-sm-t800-sm-p600.4270943/) the first step is "Flash latest official Samsung Firmware with ODIN". Is this even relevant to me?
2) In preparation for successfully installing LineageOS, what TWRP clearing/formatting options should I be using? On a completely different device, the instructions were to delete *everything*. Could my wrong choices when doing this for my SM-T700 have contributed to my failures?
3) Now that I (currently) have Resurrection Remix on my SM-T700, can I expect -- with the binaries mentioned in this new subgroup -- to be able to install LineageOS 17.1 *without* running into the 'E1001' problem?
Thanks for any help!
darethehair said:
Thanks for creating a section specifically for the SM-T700! I hope that I can get some practical help on moving forward
On my post here (https://forum.xda-developers.com/t/...d-but-ok-with-resurrection-remix-why.4332701/) I describe my attempt to install a variation of LineageOS 17.1 on my device -- always running into 'E1001'. I eventually settled on an older Resurrection Remix, since someone mentioned that it would ultimately make it possible to move to LineageOS (I have not tried that yet).
Here are some of my questions:
1) In a much larger/older thread (https://forum.xda-developers.com/t/...t700-sm-t705-sm-t800-sm-t800-sm-p600.4270943/) the first step is "Flash latest official Samsung Firmware with ODIN". Is this even relevant to me?
2) In preparation for successfully installing LineageOS, what TWRP clearing/formatting options should I be using? On a completely different device, the instructions were to delete *everything*. Could my wrong choices when doing this for my SM-T700 have contributed to my failures?
3) Now that I (currently) have Resurrection Remix on my SM-T700, can I expect -- with the binaries mentioned in this new subgroup -- to be able to install LineageOS 17.1 *without* running into the 'E1001' problem?
Thanks for any help!
Click to expand...
Click to collapse
Hey there! I'll take a closer look once I'm home. Speak to you then
darethehair said:
Thanks for creating a section specifically for the SM-T700! I hope that I can get some practical help on moving forward
On my post here (https://forum.xda-developers.com/t/...d-but-ok-with-resurrection-remix-why.4332701/) I describe my attempt to install a variation of LineageOS 17.1 on my device -- always running into 'E1001'. I eventually settled on an older Resurrection Remix, since someone mentioned that it would ultimately make it possible to move to LineageOS (I have not tried that yet).
Here are some of my questions:
1) In a much larger/older thread (https://forum.xda-developers.com/t/...t700-sm-t705-sm-t800-sm-t800-sm-p600.4270943/) the first step is "Flash latest official Samsung Firmware with ODIN". Is this even relevant to me?
2) In preparation for successfully installing LineageOS, what TWRP clearing/formatting options should I be using? On a completely different device, the instructions were to delete *everything*. Could my wrong choices when doing this for my SM-T700 have contributed to my failures?
3) Now that I (currently) have Resurrection Remix on my SM-T700, can I expect -- with the binaries mentioned in this new subgroup -- to be able to install LineageOS 17.1 *without* running into the 'E1001' problem?
Thanks for any help!
Click to expand...
Click to collapse
Hey! Sorry for the delay. You should flash the latest firmware (it's on updato.com) Using Odin, and then twrp with Odin, and then the custom ROM from twrp, wiping data dalvik and cache before rebooting. Other two are in the mirror.
CessnaBroon said:
Hey! Sorry for the delay. You should flash the latest firmware (it's on updato.com) Using Odin, and then twrp with Odin, and then the custom ROM from twrp, wiping data dalvik and cache before rebooting. Other two are in the mirror.
Click to expand...
Click to collapse
Just an FYI...I was reluctant to start everything over again with Odin and latest Samsung firmware, so I opted to take a chance and merely 'adb push' the LineageOS and GApps that you have on your Google drive (along with some cache erasures as you suggested) and everything seemed to upgrade properly from Resurrection Remix to LineageOS 17.1
A few minor problems so far: camera doesn't work, and initial signon to the tablet with a PIN doesn't work so well (seems to take multiple attempts). In any case, now running Android 10!
These were issues that I faced too - I never found a way to fix them. Neither did the original Dev, but apparently updating to the latest webview fixes chrome crashes. PIN you need to wait 30seconds after boot. Camera works only with clean install and even then sometimes doesn't work.
Hope this helps,
Cessna
I was trying to install TWRP but after reboot when I go to the Recovery mode there is no TWRP. I installed the LOS on my Tab Pro 8.4 and wanted to install LOS on Tab S 8.4 but can't flash the TWRP. Any ideas what I'm doing wrong?
Thanks