Database Develop

[BUG] Magisk refuses to install modules from repo (The zip is not a Magisk Module!)

I've had magisk installed since version 6, I've published some magisk modules already and never had a problem until today.
After a full clean reinstall of Nougat NBD90Z (with wipe) on my Nexus 6 and then flashing Magisk, phh's superuser for magisk, installing phh's superuser apk from play store and magisk manager apk I stumbled upon a previously reported (without details) bug where magisk manager would refuse to install modules from repo claiming they are not magisk modules.
I've struggled trying everything I could including the full wipe (more details here: http://forum.xda-developers.com/apps/magisk/module-app-systemizer-t3477512/69230448#69230448) and bounced some ideas off @pnwsr6 who's had the similar problem on Nexus 6 device.
I've achieved a partially working Magisk Manager (manual installs of ZIP files work, but installs from repo still fail) and here's the list of steps which lead to me having semi-working magisk manager again:
1. I flashed ZIP files of some modules in twrp (I'm attaching App Systemizer and Nexus 6 LED Enabler which I flashed)
2. After the phone booted up I saw the modules active and working
3. Within Magisk Manager I then added the ZIP file of the phh's superuser module from that thread (http://forum.xda-developers.com/attachment.php?attachmentid=3893967&d=1475554052)
4. Now at least manual installation of modules within Magisk Manager are working fine.
@topjohnwu -- I've enabled verbose logging and extra logging for bash commands, but I'm still not seeing anything in the log on top of the regular output.

Created an issue against Magisk Manager so it's easier to track for developers: https://github.com/topjohnwu/MagiskManager/issues/20

Looks like that even after flashing some modules in twrp, Magisk Manager only allows to install from zip only exactly the same ZIP I've already flashed (even a minor change and bump of versionCode results in "This ZIP is not a Magisk Module!"). So it might be an issue of Magisk Manager being unable to write to /magisk despite having storage permission and being granted root access.

Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!

I've seen this error as well on my Nexus 6 NBD90Z with Magisk v8. Started with v7 after some heavy modification on my part .
I was sometimes able to fix it by simply extracting the zip and then Magisk Manager would somehow recognize it as a module.. Other times I could extract the zip and then re-archive the contents and Magisk Manager would recognize that as a module. Weird, but doable.

stangri said:
Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!
Click to expand...
Click to collapse
I probably won't try again until next update, and hope the wipe just wasn't clearing something. I have the zip installed through twrp and working for now so I'm good till then.

just wondering if you're still having this issue with v9? I had modules installed fine under v6, but never really installed any modules under v8 to see if this problem occurred for me. now that I'm on v9, which has been wiped clean to start, I can no longer install any modules via Downloads or in the Modules section... any suggestions?

I have the same issue when trying to install viper with v9 on Nexus 6P DP2
Skickat från min Nexus 6P via Tapatalk

Same here. Find a fix ?

From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.

stangri said:
From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.
Click to expand...
Click to collapse
Just an FYI, I do still have this problem, but can install the zip through twrp. Maybe 10 will be the solution.

I had the same problem, I cleared magisk manager data and it works fine now

Didn't help
Sent from my SM-G532F using Tapatalk

I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.

stangri said:
I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.
Click to expand...
Click to collapse
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.

Meowdib said:
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.
Click to expand...
Click to collapse
Weird, do you have the same problem with magisk manager 161223?

stangri said:
Weird, do you have the same problem with magisk manager 161223?
Click to expand...
Click to collapse
Same

I need a Help to download modules using magisk
Lastest version, Included phh root, manager is from G. play,
But Modules download function is not working
Say "No modules found" for download to install via magisk.

No SU binary installed (SuperSU)

Hello
I have Resurrection Remix with OMS installed on my 3T and /data currently not encrypted. Everytime I flash SuperSU, it's working after boot, but then root stops working and SuperSU says "No su binary installed." In the recovery.log i can see that my boot image is full, but I have no idea how to fix that or if it's even the main problem. I tried SuperSU 2.79 Stable, SR1 and SR2.
Thanks for help

i ran into the same problem today after flashing tugapower 7.1.
after boot, root only works for a few minutes.
what i did then:
https://forum.xda-developers.com/moto-x-play/general/switching-supersu-to-phhs-su-t3495080
1. unroot via supersu app (settings)
2. reboot into android again
3. flash phh-supersu zip in recovery
4. install phh-supersu app from store

Problem with magiskmanager

I had rooted with superSU than switched to magisk root which is now updated to Magisk v15.2(Magisk Manager 5.5.3) and I have some problems
Every Modules I intall gives Installation error(magisk_merge.img merge failed)
tried flashing modules via recovery but not showing into magisk manager
safetynet check failed what to do?
can i install viper4android or ARISE sound system(cant install from magisk modules)
If anybody can help would be great

Odds are good you didn't remove su properly

flash the unSU zip file to uninstall superSU

doesnt work

The root permission request is no longer displayed

I have the root with Magisk in Android 8.0. At first, the warning always came out asking if you wanted to grant root rights to the application that you just opened. However, this warning is no longer displayed, even though the configuration of Magisk Manager is configured in this way.
In the Magus Superuser section, I do not see any trace of the applications that I can not 'root'.
I have updated Magisk Manager, but the error continues. I also removed BusyBox, but the error continues.
I can not give root permission to any other application. But the mobile is rooted, since the first applications that I installed that require root continue to function normally. I can even deactivate the root and then activate it again.
Reinstalling the applications is not solved. With Dalvik and Caché wipe either.
That could be happening? How is it solved?
____
Magisk Manager has all the permissions of everything (memory, background, manual battery mode). I have tried to reinstall Magisk Manager and nothing.
Deactivating BusyBox (Magisk module) and Xposed and restarting still does not work.
Returning to install the Magisk image by TWRP or Fastboot is not fixed either.
I have removed all the fret that I had done to the phone (BusyBox, Xposed, root Magisk and boot modified for the root) and the problem has not been solved. I do not know what may be happening. I do not have other rare applications.
I have installed Device Control and the TWRP application. I have not gotten the root request to skip (although it has activated that option in Magisk Manager).
Definitely, it is not the fault of the new applications, which was the first question I wanted to solve.
Magisk version:
19.3 (19300)
And from Manager 7.2.0 (213), although I have also tried 7.3.2 (224).
The root is done with patching (via Magisk) of RAMDISK.IMG.
I understand that some applications are not compatible with systemless. But I'm not going any of the new ones that I'm trying. Interestingly, other applications compatible with Magisk (except those that installed the first days of the mobile) do not work either.
I have installed Magisk Manager 7.0.0 (and also 6.1.0), but the bug is still there. It seems that it does not depend on the APK.
As my Magisk file to root consists of a patch of RAMDISK.IMG created directly from Magisk Manager I do not know how to create one based on a lower version (for example, version 18.1). It only gives me the option to patch with the latest Magisk Manager version (if I have a lower one, it asks me to update the APK).
Whenever I generate the IMG of my patched RAMDISK.img it is based on 19.3.
How could I generate a patched IMG based on a lower version?
I have microG, not the GApps. Could that influence? Does Magisk need them?

@rovo89

@topjohnwu

https://www.didgeridoohan.com/magisk/MagiskHelp

I have added much more information.

Reinstall firmware???

LoneWolfz said:
Reinstall firmware???
Click to expand...
Click to collapse
I'm going to do it today. Will I lose data if I install SYSTEM.img via Fastboot?

535iu said:
I'm going to do it today. Will I lose data if I install SYSTEM.img via Fastboot?
Click to expand...
Click to collapse
No maybe but i suggest you to backup all your data etc. just to be safe

Magisk manager showing Magisk not installed after reboot

Phone: Huawei P20 Lite
ROM: Omni
Magisk: 20.3
Downloaded the Magisk.zip file through Magisk manager.
Flashing the Magisk zip using TWRP is success.
But rebooting to system showing Magisk isn't installed.
So I was to try flash it again. But booting TWRP is failed.
It ended up booting to system. At this time Magisk manager showing it as installed.
To be concluded:
1) Rebooting to system will delete Magisk root.
2) Rebooting to recovery (TWRP) will fail and boot to system. In that case Magisk manager saying root installed
Any solution to make root access stable and keep TWRP in recovery partition?

4n3y3 said:
Phone: Huawei P20 Lite
ROM: Omni
Magisk: 20.3
Downloaded the Magisk.zip file through Magisk manager.
Flashing the Magisk zip using TWRP is success.
But rebooting to system showing Magisk isn't installed.
So I was to try flash it again. But booting TWRP is failed.
It ended up booting to system. At this time Magisk manager showing it as installed.
To be concluded:
1) Rebooting to system will delete Magisk root.
2) Rebooting to recovery (TWRP) will fail and boot to system. In that case Magisk manager saying root installed
Any solution to make root access stable and keep TWRP in recovery partition?
Click to expand...
Click to collapse
you can patch magisk to your firmware and install (flash) it with odin. but from my experience, the jhonwu method is really work (magisk in system as root) but I am unable to install twrp alongside that system. I mean yes indeed I can flash twrp into the device but then I lose root access. (many case I got random restart all over again).
now I am kinda confused because I need root and also that twrp is really usefull tool for idiot like me.
FYI; I already try install twrp pre-patched magisk from geiti, but its very unstable. random reboot, and sometimes I am losing the magisk it self (magisk manager suddenly show that magisk isnt intall). thats why I am kinda prefer to root with jhon wu method,
can you guys help me how to flash twrp without ruin magisk that already installed on patched stock firmware?