; expected even though there allready is one - Android Studio

my java class in android studio is asking me to add ; but its already there. ive done the things youd usually do like delete the ; and put it in again and rebuild the project also restart my pc. nothing seems to work
package com.sudafly.charts;
import android.support.v7.app.AppCompatActivity;
/**
* Created by Dragos on 25/01/2017.
*/
public class HomeScreen extends AppCompatActivity home_screen{
}
Click to expand...
Click to collapse

dragos_popa said:
my java class in android studio is asking me to add ; but its already there. ive done the things youd usually do like delete the ; and put it in again and rebuild the project also restart my pc. nothing seems to work
Click to expand...
Click to collapse
Hi,
Android studio is right, there is something wrong in the code, the "home_screen" after AppCompatActivity should not be there.
Code:
public class HomeScreen extends AppCompatActivity {
}
If "home_screen" is an interface
Code:
public class HomeScreen extends AppCompatActivity implements home_screen {
}
Hope it helps, good luck

Related

[GUIDE] Communication without a context object

Okay guys.
I have seen a lot of posts where people need to trigger an action inside their own app from the xposed class they hooked. Sometimes (quite often) there is no context object to obtain where we could usually send a broadcast or start a service or even maybe an activity from our own apps we wrote.
This guide will allow me to show you how this is possible without the use of a context object. I have used this myself in multiple modules and it works quite wonderfully. I am going to provide as much code as possible without being too specific, that is where you will need your own intuition to figure out some simple things.
Now for the guide
First, obviously, we need to create a new xposed module. That's another thread found here. For the duration of this guide, I am going to assume you have read that. If you have not, stop reading this, and click that link and go read that please Its fun!
Alright, our module has been created, all manifest declarations established all jars imported. Sweet.
Now we are looking at an empty class file that implements the IXPosedHookLoadPackage.
Next, we need to create a class that extends Service. You can either create a nested class inside the Xposed class, or, my personal choice, create an entirely new class inside your package. ***(Don't forget to add this service to your manifest!!!)
Next, we need to create a boot receiver that will start our newly created service when our device gets booted so its already up and running. (Google that if you don't know how to do that.) here is a great read on how to do this.
Now, go back to your service class (either nested or its own file) and create the "onCreate" method. (If not done already)
Inside the onCreate method of your service, we will need to create a file inside the apps files directory. You can do this in the constructor as well if you please. I have the code below showing how to create your new file.
Code:
@Override
public void onCreate() {
super.onCreate();
File myCommands = new File(this.getFilesDir(), "commands");
}
Yes its that
Now that we have our file object created, we need to actually create the file as follows:
Code:
if(!myCommands.exists()) { //Make sure the file doesn't already exist first.
try {
myCommands.createNewFile();
} catch (IOException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
}
However, there are some things we need to do to allow the xposed hooked method permissions to read them, which are simple and as follows.
Code:
myCommands.setReadable(true, false);
myCommands.setWritable(true, false);
We need to use the method "setReadable" and "setWriteable" to set the files permission. The first boolean argument sets the file writeable or readable, the second boolean argument restricts it to the owner only, which since we used false, means that everyone can read and write to this file.
So, now lets take a look at our entire onCreate method thus far:
Code:
@Override
public void onCreate() {
super.onCreate();
File myCommands = new File(this.getFilesDir(), "commands");
if(!myCommands.exists()) {
try {
myCommands.createNewFile();
} catch (IOException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
}
myCommands.setReadable(true, false);
myCommands.setWritable(true, false);
}
Pretty simple. Now, we need to actually do something with this file. This is where the magic begins to happen
After our file is created, we need to create what is called a FileObserver. The following code explains how to do that.
Code:
FileObserver myActionsObserver = new FileObserver(myCommands.getAbsolutePath()) {
@Override
public void onEvent(int event, String path) {
// This is where things are done. Every time you open, write to, close etc a file. This method is executed.
}
};
Now our file observer is created. However, it is doing nothing. As of now, it does not even listen for file changes. I want to further define what to do on a file change first before I start receiving the changes.
The "onEvent(int event, String path)" method is what we will be defining.
The "event" argument determines what type of event was acted upon the file. For a full explanation, click here. The "CONSTANTS" table shows the different types of events acted upon a file. For this guide, I will be using the constant "CLOSE_WRITE".
So inside the onEvent method we should have this:
Code:
@Override
public void onEvent(int event, String path) {
// This is where things are done. Every time you open, write to, close etc a file. This method is executed.
if(event == FileObserver.CLOSE_WRITE) {
//This is where we are notified that something has happened.
//This is where we can communicate from the xposed hooked method to our own app where we can do whatever we need to do :)
}
}
Now we are notified of the "CLOSE_WRITE" action onto our file. The next step would be to read the text file for our actual command. For instance, we need to start up an activity. So, for the instance of this guide, I will use the command "startActivity".
Once our "onEvent" method is executed and we see that its action was CLOSE_WRITE, we are going to read the file for the action. This is simple, I really don't feel like I should/have to go into this, but I will to make the guide full.
Here we are going to read the file, I am using a BufferedReader for this.
Code:
try {
BufferedReader br = new BufferedReader(new FileReader(myCommands));
String action = br.readLine();
br.close();
} catch(Exception e) {
e.printStackTrace();
}
Now we got a string object of the contents of the file to determine the necessary actions to take. Don't forget to change the myCommands file to final
Now that we have all that setup, we can finally start receiving actions for the file. We simply do this by calling the "startWatching" method of FileObserver as follows.
Code:
myActionsObserver.startWatching();
Now, whenever that file is written to, we will get notified of it in our service
So now that our service is setup, we need to setup our xposed hooked method to write to the file.
I am going to make something up that prolly doesn't exist in android source, but its just an example method that I am going to hook
The only thing to note when creating the file is that we need to hard code the file's path.
Code:
@Override
protected void afterHookedMethod(MethodHookParam param) {
boolean status = (Boolean)XposedHelpers.getObjectField(param.thisObject, "status");
if(status) {
File myCommand = new File(Environment.getDataDirectory() + <your package name here>, "commands");
FileWriter fw = new FileWriter(myCommands);
fw.write("startActivity");
fw.close();
}
Now we have written to our file and our service will receive the action.
That about sums it up You can also do the reverse, you can create a FileObserver inside your xposed hooked method, and use your own activity or service to write to it and then have the xposed hooked method do some actions regarding the command being written to the file.
Please hit thanks and donate if I helped you out! Don't hesitate to ask questions either!
Thanks!
need help
Hi I`m using your code and it`s work I seccessed to comunicate between the module and the FileObserver.
But my problem is that I want to activate some class or send a intent to activate some function from the FileObserver and I don`t find a way to do it.
Do you have any solution for me??
Thanks
doronmazor said:
Hi I`m using your code and it`s work I seccessed to comunicate between the module and the FileObserver.
But my problem is that I want to activate some class or send a intent to activate some function from the FileObserver and I don`t find a way to do it.
Do you have any solution for me??
Thanks
Click to expand...
Click to collapse
This method is beyond hackey. TBH, I'd be embarrassed to use it in my code.
If you want to communicate from Xposed to your main app, add a broadcast reciever and talk to it via intent and putextra. Provided you're not passing sensitive data, this works wonderfully.
digitalhigh said:
This method is beyond hackey. TBH, I'd be embarrassed to use it in my code.
If you want to communicate from Xposed to your main app, add a broadcast reciever and talk to it via intent and putextra. Provided you're not passing sensitive data, this works wonderfully.
Click to expand...
Click to collapse
lol
Why would you be embarrassed? This works perfectly when we have no context object in the class/method being hooked. If coded properly, it functions the exact same way as a broadcast receiver. Where is your solution to communicating without a context object? Not exactly sure why you think this method doesn't work...
elesbb said:
lol
Why would you be embarrassed? This works perfectly when we have no context object in the class/method being hooked. If coded properly, it functions the exact same way as a broadcast receiver. Where is your solution to communicating without a context object? Not exactly sure why you think this method doesn't work...
Click to expand...
Click to collapse
Look, not trying to be mean...it's just a very hacky solution. There are other ways to resolve the context of the class/method being hooked, and better ways to communicate between xposed and the apk code besides writing a file to the /data partition and then watching it. Sure, it works, but IMHO, it's...well...hacky.
digitalhigh said:
Look, not trying to be mean...it's just a very hacky solution. There are other ways to resolve the context of the class/method being hooked, and better ways to communicate between xposed and the apk code besides writing a file to the /data partition and then watching it. Sure, it works, but IMHO, it's...well...hacky.
Click to expand...
Click to collapse
I am not taking you as being mean. Not one bit. Just trying to expand my knowledge and better my code. You said there are other ways to resolve the context of the class/method being hooked, what are they? You said there are better ways to communicate between xposed and the apk code other than writing and listening to a file, well what are they? lol. I am asking so I can use them.
I have done ample research when I wrote this guide, and there were no other ways to communicate when you couldn't get a context object. I do know you can call other methods and such using xposed to get objects, but that in itself is also hacky. I really would like to know what other ways there are so I can use them instead of the current method. A lot of "helper" class files have issues where there is no context because its not needed. Say you have a class file labeled "MathHelper" and you want to hook the method "getFirstZero" and in that method the user wrote something simple like this:
Code:
private int firstZero(String address) {
int returnValue = address.indexOf("0");
return returnValue;
}
THIS IS JUST A POOR EXAMPLE.
You have no context object. And the class is huge. You want your app to, i don't know, show a notification and perform some task when the address is equal to some explicit value. There is no way of telling your app what the address is.
So what would you personally do to resolve this aside from simply creating a method inside the xposed class with the proper actions. I'm honestly curious.

[Q] setBooleanField can't find field?

I feel like I'm missing a piece of the puzzle here.
Basically, I'm trying to hook a constructor with a Context for an argument. The field I'm trying to access is initialized in the same class but outside of the constructor. Neither the constructor nor the field are static, but they are both private (if that makes a difference).
But for whatever reason I just can't find the field in order to modify it (the module throws NoSuchFieldError). What am I doing wrong, and is there a workaround?
My code:
Code:
public void initZygote(final StartupParam sp) throws Throwable {
if (devicePlatformVersion >= 4.0) {
final Class<?> clsViewConfig = ViewConfiguration.class;
try {
final Constructor<?> cstViewConfig = XposedHelpers.findConstructorExact(clsViewConfig, Context.class);
XposedBridge.hookMethod(cstViewConfig, new XC_MethodHook(XCallback.PRIORITY_HIGHEST) {
protected void beforeHookedMethod(final MethodHookParam mhp) {
XposedBridge.log("Inside beforeHookedMethod routine from ViewConfiguration callback....");
XposedHelpers.setBooleanField(mhp.thisObject, "sHasPermanentMenuKeySet", true);
}
});
} catch (Throwable t) {
XposedBridge.log(t);
}
try {
XposedHelpers.findAndHookMethod(clsViewConfig, "hasPermanentMenuKey", XC_MethodReplacement.returnConstant(false));
} catch (Throwable t) {
XposedBridge.log(t);
}
}
}
And here's the target class:
https://github.com/android/platform...core/java/android/view/ViewConfiguration.java
Thanks!
I may have found out why the error is being thrown.
The setBooleanField method tries to call the findField method. findField returns the field as a Field object back to the calling method (setBooleanField). However, if the field is null, findField throws a NoSuchFieldError.
From the XposedHelpers class:
Code:
public static Field findField(Class<?> clazz, String fieldName) {
StringBuilder sb = new StringBuilder(clazz.getName());
sb.append('#');
sb.append(fieldName);
String fullFieldName = sb.toString();
if (fieldCache.containsKey(fullFieldName)) {
Field field = fieldCache.get(fullFieldName);
if (field == null)
throw new NoSuchFieldError(fullFieldName);
return field;
}
try {
Field field = findFieldRecursiveImpl(clazz, fieldName);
field.setAccessible(true);
fieldCache.put(fullFieldName, field);
return field;
} catch (NoSuchFieldException e) {
fieldCache.put(fullFieldName, null);
throw new NoSuchFieldError(fullFieldName);
}
}
Since the field I'm trying to find has only been initialized, it doesn't yet have a value, making findField catch and throw an exception that isn't exactly true. There is such a field, it's just hasn't been set.
Is anyone aware of this potential problem?
I'm going to see if I can get my code to work by catching the exception, hiding the error, and seeing if the field can, in fact, be set with a true.
You might want to open an issue at GitHub. Regarding your problem, couldn't you use afterHookedMethod instead of beforeHookedMethod to set the variable to the value you want?
Thanks for the reply!
I'm using the "before" variant as I want to set the field before the code inside the constructor is executed. Unless I'm overlooking something?
I recently switched to the findAndHookConstructor method to help simplify things a bit, and I tried getting the context from args[0] to see if I could set the field with that. But no matter what I try, NoSuchFieldError keeps getting thrown.
Sent from my SAMSUNG-SGH-I747
(I suggested using afterHookedMethod if the constructor didn't access sHasPermanentKey. Since it does, ignore that suggestion. )
If I understand what you want to do correctly, you could hook the hasPermanentMenuKey method instead?
Anyway, after reading your question again and checking the classes, I think the problem is that the field really isn't there.
getField is just a helper that uses normal reflection, and it should definitely find the field if it exists. I'm guessing you're using a different Android version than the one you're checking the source for, or you're not running AOSP and it's been modified.
If that doesn't help, you could decompile framework.jar (if memory serves right) and make sure the field exists.
I have the method that returns a boolean hooked already, and that works fine. However, many apps use the "get" method to generate a new configuration from the constructor when a context is provided. Hence why I also want to hook the constructor.
I'll definitely find out if my device actually has the field tonight.
Sent from my SAMSUNG-SGH-I747
Well. This explains a lot.
https://github.com/CyanogenMod/andr...core/java/android/view/ViewConfiguration.java
I feel like an idiot now. I have no idea why I just automatically assumed that CM would have kept that field from AOSP. Well, now I just need to dig around in CM's source for a bit.
One more question:
Is there a way to programatically check to see which flavor of Android ROM the user is running? I know there's a check for version/API level, but is there a better way than, say, looking for a file only found in CM releases to verify the user is in fact running CM (as opposed to AOSP, Omni, and anything else that has an original base)?
Thanks!
JJohnson1988 said:
One more question:
Is there a way to programatically check to see which flavor of Android ROM the user is running? I know there's a check for version/API level, but is there a better way than, say, looking for a file only found in CM releases to verify the user is in fact running CM (as opposed to AOSP, Omni, and anything else that has an original base)?
Thanks!
Click to expand...
Click to collapse
As far as I know, the only way would require you to would require you to know every ROM out there. Usually it's enough to just use a try/catch statement for each ROM dependent hook/action.

[Q] Changing a returned object's property

Hello,
Please consider the following scenario
Code:
public class Document {
...
protected boolean dirty;
...
void setDirty(boolean value) {...}
public boolean getDirty() {...}
}
public class DocumentManager {
...
public Document getDocument(String Id) {...}
...
}
Now I'm hooking getDocument method just fine, but I need to change the returned object's 'dirty' property.
How can I accomplish this?
Thanks in advance for your help.
Call XposedHelpers.setBooleanField(…) on a Document object for "dirty" or hook getDirty() and use param.setResult(…) (or the XC_MethodReplacement.returnConstant(…) shortcut) to set the result you want.
GermainZ said:
Call XposedHelpers.setBooleanField(…) on a Document object for "dirty" or hook getDirty() and use param.setResult(…) (or the XC_MethodReplacement.returnConstant(…) shortcut) to set the result you want.
Click to expand...
Click to collapse
XposedHelpers.setBooleanField did the trick. The class sometimes access the 'dirty' member without going through the getter. That's why I needed to change the field instead of hooking getDirty.
Thanks mate.
Cheers.

[Q] Hooking overriden methods in extended classes

So I'm (attempting) to write my first Xposed module. I'm a little hung up so I'm looking for some help.
I'm trying to hook into the onStartCommand method of the AlarmKlaxon class in com.android.deskclock (link). The AlarmKlaxon class extends "Service" and onStartCommand (the method I want to hook) has the @override identifier.
I would think, I would be able to do something like this:
public class AlarmHandler implements IXposedHookLoadPackage {
public void handleLoadPackage(final LoadPackageParam lpparam) throws Throwable {​
if (!lpparam.packageName.equals("com.android.deskclock"))​return;​
XposedBridge.log("Found Package!");​
findAndHookMethod("com.android.deskclock.AlarmKlaxon", lpparam.classLoader, "onStartCommand", new XC_MethodHook() {​@override​protected void beforeHookedMethod(MethodHookParam param) throws Throwable {​XposedBridge.log("Found Method!");​}​});​}​}
Click to expand...
Click to collapse
When I test out the application, I get "ClassNotFound" exceptions when I hit findAndHookMethod. What seems very strange is that if I try to hook a method in a class that does not extend another class, it seems to work... For example, if I hook AlarmAlertWakeLock class (link), I don't see the exceptions....
Is there something special with the extended classes? When defining the class string, do I need to state that AlarmKlaxon extends another (e.g. "com.android.deskclock.Service.AlarmKlaxon")
Figured it out. Apparently the Cyanogenmod source code I was looking at wasn't the correct version or something. I needed to call the class "com.android.deskclock.alarm.AlarmKlax on"
This thread can be marked as solved.

Help needed with a View class.

Hi, this is my first post here so please forgive me if I have put this in the wrong section, it was a bit confusing.
I have an application that takes the touch coordinates from onTouchEvent and and puts them in to an SQLite Database.
My three relevant classes:
Main class: TouchDetector.
Custom View class: TouchDetectorView.
Database class: TouchDatabaseHandler.
TouchDetectorView captures the touches and stores the x, y values in variables. I need to access the TouchDatabaseHandler class from this view class in order to send them to the database.
Constructor inside TouchDatabaseHandler class where data is sent to database:
Code:
public TouchDatabaseHandler(Context context, String name, SQLiteDatabase.CursorFactory factory, int version) {
super(context, DATABASE_NAME, factory, DATABASE_VERSION);
}
View class constructor.
Code:
public TouchDetectorView(Context context, AttributeSet attrs) {
super(context, attrs);
dbHandler = new TouchDatabaseHandler([COLOR="Red"][U]this[/U][/COLOR], null, null, 1);
}
What do I replace the this with to make my code work? The tutorial I was following had the dbHandler inside the onCreate but since I am in a View class I do not have on. I apologise if this is very vague, I am a beginner and would appreciate any help and/or feedback.

Categories

Resources