[MODULE] Volume Steps Increase (for Magisk v10+) - Magisk

This module doubles the number of steps in volume adjustment for both media and in-call volume.
WARNING: Apparently doesn't work on all devices, for example OnePlus 3 according to this.

what about a collection thread for build prop tweaks to use in Magisk?

Thanks for the module. It's got a funny bump going louder until the middle of the scale, then getting suddenly significantly quieter again and going louder until the end, for media playback.

Bettik said:
Thanks for the module. It's got a funny bump going louder until the middle of the scale, then getting suddenly significantly quieter again and going louder until the end, for media playback.
Click to expand...
Click to collapse
Could be hardware/driver-dependant. I've used a (non-systemized) prop modification before on a tablet and it was pretty smooth.

time comes, good modules too :good:

Just a reminder for those who encounter problems. ro.config.vc_call_vol_steps=14
ro.config.media_vol_steps=30 won't work for all devices, such as OnePlus 3, at least on its official OxygenOS.
Once you change your media volume steps from default 15 to the 30, using the script above which is included in the module, on your OnePlus 3. The steps are increased, while it's just a loop. The volume drop back to the lowest again at the 16th step and totally silent at some steps bigger than 20.
BTW, the xposed module VolumeSteps+ won't work on OnePlus 3 either.

accidentally quoted OP instead of editing it.

changes couldn't be reseted after removing the system.prop or the module. Any thing to do?

chjun90 said:
changes couldn't be reseted after removing the system.prop or the module. Any thing to do?
Click to expand...
Click to collapse
Remove module, reboot. When asking for help, provide logs.

stangri said:
Remove module, reboot. When asking for help, provide logs.
Click to expand...
Click to collapse
i do that many times. i have removed the module days ago, but the chages still on my phone. i found the bug in all the modules with system.prop not only yours. thinking it's bugs of magisk v11.1.

chjun90 said:
i do that many times. i have removed the module days ago, but the chages still on my phone. i found the bug in all the modules with system.prop not only yours. thinking it's bugs of magisk v11.1.
Click to expand...
Click to collapse
Would be great if you had created an issue against Magisk on github then. Probably uninstalling magisk (from recovery) and re-installing it would start you with a clean slate.
Alternatively, there're unofficial builds of the next-gen magisk available, maybe they would fix the issue.

stangri said:
Would be great if you had created an issue against Magisk on github then. Probably uninstalling magisk (from recovery) and re-installing it would start you with a clean slate.
Alternatively, there're unofficial builds of the next-gen magisk available, maybe they would fix the issue.
Click to expand...
Click to collapse
i had

Is it compatible with the latest 11.6 magisk? Anyone tested?

Angelos N. said:
Is it compatible with the latest 11.6 magisk? Anyone tested?
Click to expand...
Click to collapse
11.0.0 version is and I have.

Angelos N. said:
Is it compatible with the latest 11.6 magisk? Anyone tested?
Click to expand...
Click to collapse
Causes systemui FC.
This is because of system.prop. I had this same issue when changing.
To 11.6.

ahrion said:
Causes systemui FC.
Click to expand...
Click to collapse
As evident from the screenshots below it works fine.
Care to post link to the github issue where 11.6 has broken system.prop support?

stangri said:
As evident from the screenshots below it works fine.
Care to post link to the github issue where 11.6 has broken system.prop support?
Click to expand...
Click to collapse
I had the same issue with my mods, removing system.prop fixed this issues. 11.6 broke resetprop for certain people. I don't see any issues on the GitHub for magisk, but I know this is an issue because me on my own mods and others have reported this same issue. I've tested it and that's what I have found.
It doesn't happen to all phones but I think it's a magisk issue with resetprop, something that was not an issue in 11.5.

ahrion said:
I had the same issue with my mods, removing system.prop fixed this issues. 11.6 broke resetprop for certain people. I don't see any issues on the GitHub for magisk, but I know this is an issue because me on my own mods and others have reported this same issue. I've tested it and that's what I have found.
It doesn't happen to all phones but I think it's a magisk issue with resetprop, something that was not an issue in 11.5.
Click to expand...
Click to collapse
I think you're making way to large assumptions here. From my experience, there's no issue with resetprop. This module and many others I've tried and use on v11.6, that utilises system.prop and resetprop work just fine.
Yes, when I tested your module my device wouldn't boot unless I removed the system.prop from the audmodlib. But I don't think that had anything to do with the system.prop itself, but rather what you'd put in it...

Didgeridoohan said:
I think you're making way to large assumptions here. From my experience, there's no issue with resetprop. This module and many others I've tried and use on v11.6, that utilises system.prop and resetprop work just fine.
Yes, when I tested your module my device wouldn't boot unless I removed the system.prop from the audmodlib. But I don't think that had anything to do with the system.prop itself, but rather what you'd put in it...
Click to expand...
Click to collapse
I'm not making assumptions. I'm literally telling you what issues I've experienced with my 9 modules and I'm not the only one It worked before 11.5/11.6 until I removed system.prop, which was the issue. The issue itself was not present before on previous versions. This was happening for me when upgrading to 11.6.
This is a reproduceable issue that was introduced once resetprop changes were introduced in 11.5/11.6 which did not occur before then, with the same exact zips updated to v3 module template. If you check the magisk release notes it CLEARLY states he made changes to resetprop. Which obviously confirms what I'm saying now.
Audmodlib lib has literally nothing in it that would bootloop your device. All it does is copy your system files into its own magisk folder. Nothing else. It makes ZERO edits to those files if you look at the code. The additional mods that edit audmodlib are what make edits to your existing device code.
I was just seeing if we could figure out a solution to this issue and to pinpoint why this is happening.

ahrion said:
I'm not making assumptions. I'm literally telling you what issues I've experienced with my 9 modules and I'm not the only one It worked before 11.5/11.6 until I removed system.prop, which was the issue. The issue itself was not present before on previous versions. This was happening for me when upgrading to 11.6.
This is a reproduceable issue that was introduced once resetprop changes were introduced in 11.5/11.6 which did not occur before then, with the same exact zips updated to v3 module template. If you check the magisk release notes it CLEARLY states he made changes to resetprop. Which obviously confirms what I'm saying now.
Audmodlib lib has literally nothing in it that would bootloop your device. All it does is copy your system files into its own magisk folder. Nothing else. It makes ZERO edits to those files if you look at the code. The additional mods that edit audmodlib are what make edits to your existing device code.
I was just seeing if we could figure out a solution to this issue and to pinpoint why this is happening.
Click to expand...
Click to collapse
I get it that you're trying to promote use of your own audmodlib template over the standard magisk template. Have you personally tried using *this* module *without* any other borked/broken modules? If so, please list the HW/SW (ROM, kernel, magisk and magisk manager versions, list of installed modules) combination which results in a bootloop.
PS. This is not a support thread for other broken modules.

Related

[MODULE] Enable Android Wear on CM14.1

Edit: As far as I can tell this is no longer needed on the latest Lineage OS 14.1 builds.
I edited another module I found here to do what I needed it to do. Basically, Android Wear won't run on CM14.1 Nightlies because they are UserDebug so I made a script to get around this issue. I think that as long as Magisk is enabled that it should persist with each update instead of having to manually edit the build.props yourself each time. I take no credit for the script except my small edits.
The original script is for enabling Google Assistant and can be found here.
This has no warranty in the very unlikely event bad things happen I'm not responsible. I made this for myself and just thought it would be useful to others.
Special Thanks to stangri and Setialpha for their hard work on their modules that I used to make this.
Awesome, but why not just edit build.prop? Why are the nightlies set to userdebug in the first place?
I'm pretty sure they've always been like that. The reason why you would use this is it's a hassle to manually edit it every day when you update to the new nightly.
Jisifus said:
Awesome, but why not just edit build.prop? Why are the nightlies set to userdebug in the first place?
Click to expand...
Click to collapse
The whole point of magisk is to NOT modify the actual build.prop or make ANY changes in /system
How do you enable magisk?
Sent from my A0001 using XDA-Developers mobile app
This is how Android wear works on cm 14.1
https://youtu.be/NasiUcEnkoo
ashokmor007 said:
This is how Android wear works on cm 14.1
https://youtu.be/NasiUcEnkoo
Click to expand...
Click to collapse
My script basically does the same thing except you don't have to manually edit the file they time you update your os because it always makes sure it's the correct property. So using magisk and my script is a much better solution.

[MODULE] DisableMultiUserMod (build.props) v1.3 (for Magisk 14.0)

Thats my first productive creation for XDA, so dont be to hard to me
I don't like to have features, which I never use, so I always disable or remove everythink i dont need.
On my custom roms I always diable the multi user mode by adding the following line to the build.prop:
Code:
fw.max_users=1
I was annoyed to edit this file after each ROM update.
So I created this module. It just adds the above mentioned line to the build.prop.
It is really simple, but now I don't need to edit the build.prop.
Maybe for someone this can be useful.
It works with:
- Android 6.x (Tested on OnePlus X and OnePlus 3 with CM13)
- Android 7.x (Tested on LOS 14.1 and OxygenOS 4.5.x)
v1.3: Update to Magisk Template 1400 (14.0).
Looks good but I would change the modid to something other than template. This is in the config.sh file and defines the folder it uses under /magisk. Anyways I used your zip as a template for my own build.prop edits that I will post shortly. I'll throw a little credit your way too.
Sorry, I was on vacation and than really busy...
@shinji257: Thank you for the hint. I changed it and uploaded the mod as v 1.1.
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
dima-82 said:
Sorry, I was on vacation and than really busy...
@shinji257: Thank you for the hint. I changed it and uploaded the mod as v 1.1.
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
Click to expand...
Click to collapse
That module probably still works (haven't updated it since posted) but the Magisk template is not updated.
My module does pretty much the same thing as yours, there is only one more line on the prop that I add.
fw.show_multiuserui=0
This disable all the UI and configurations sections for multiuser. Its not obligatory, but for me it makes sense to disable the interface aswell if you are disabling the function.
You can add that if the multiuser options keep showing even after disabling multiuser.
FHC1998 said:
That module probably still works (haven't updated it since posted) but the Magisk template is not updated.
My module does pretty much the same thing as yours, there is only one more line on the prop that I add.
fw.show_multiuserui=0
This disable all the UI and configurations sections for multiuser. Its not obligatory, but for me it makes sense to disable the interface aswell if you are disabling the function.
You can add that if the multiuser options keep showing even after disabling multiuser.
Click to expand...
Click to collapse
When I looked for the build.prop settings to disable multi user functionality I found the mentioned line as well.
But I cannot see any difference if I add it. At least it has not effect on my phone (OnePlus 3, CM13).
dima-82 said:
When I looked for the build.prop settings to disable multi user functionality I found the mentioned line as well.
But I cannot see any difference if I add it. At least it has not effect on my phone (OnePlus 3, CM13).
Click to expand...
Click to collapse
It depends on the device, I originally tested on a few, and some needed this line.
For instance, I tested your module on my device (ZenFone 2 laser) and it worked perfectly without the line, but on my friend's ZenFone 2 it kept showing the UI even though not allowing creating more users.
@dima-82 Module works great for me. I'm running a OP3T on offical LineageOS. All the multiuser stuff is gone from the settings and notification shade.
Sent from my ONEPLUS A3000 using Tapatalk
mp3deviant721 said:
@dima-82 Module works great for me. I'm running a OP3T on offical LineageOS. All the multiuser stuff is gone from the settings and notification shade.
Sent from my ONEPLUS A3000 using Tapatalk
Click to expand...
Click to collapse
Thanks for the feedback.
The official LineageOS for OP3T is Android 7.x? Nightly builds?
dima-82 said:
Thanks for the feedback.
The official LineageOS for OP3T is Android 7.x? Nightly builds?
Click to expand...
Click to collapse
The build I'm running is 7.1.1. Haven't tried 7.1.2 yet. Yes on the "nightly" build.
Sent from my ONEPLUS A3000 using Tapatalk
@dima-82,
Hello, I used your module to enable multi user mode, all I did is edited the file inside the .zip where the string to disable the multi user mode is located, and replaced it with the two strings to enable it.
Now I was wondering since this works, could I make a thread with the mod?
I would obviously credit You, and link to Your profile and this thread.
Here is the module on my device :silly:
dariomrk said:
@dima-82,
Hello, I used your module to enable multi user mode, all I did is edited the file inside the .zip where the string to disable the multi user mode is located, and replaced it with the two strings to enable it.
Now I was wondering since this works, could I make a thread with the mod?
I would obviously credit You, and link to Your profile and this thread.
Click to expand...
Click to collapse
Of course you can do.
But as mentioned in post #3 there was already a similar module. I think it does exactly what you need.
dima-82 said:
Of course you can do.
But as mentioned in post #3 there was already a similar module. I think it does exactly what you need.
Click to expand...
Click to collapse
Oh, I didn't see that, I will check if it does the exactly same thing (probably yes)...
---------- Post added at 03:06 PM ---------- Previous post was at 03:05 PM ----------
Just checked it out, and yes it does the exactly same thing
Please I need multiuser enable magisk module​ for Android 6
dima-82 said:
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
Click to expand...
Click to collapse
Here
Got bootloop after the install of this module.
Device: Zuk Z2
ROM: AEX 4.4
Unofficial Magisk 13.2 (170716)
I am running it on official Magisk 13.2 without any issues.
Did you also install other modules?
dima-82 said:
I am running it on official Magisk 13.2 without any issues.
Did you also install other modules?
Click to expand...
Click to collapse
Yes have other 5 modules
You installed / activated only this very one module and got a bootloop?
Before I created this module I edited the build.prop manually. And if you make a mistake there, you will get a bootloop as well.
May be your OS does not support this property.
I tested on my devices only, and it worked always.
Eventually you can try an other module from @FHC1998, which should do the same:
https://forum.xda-developers.com/showpost.php?p=71936097&postcount=3
jhobc said:
Got bootloop after the install of this module.
Device: Zuk Z2
ROM: AEX 4.4
Unofficial Magisk 13.2 (170716)
Click to expand...
Click to collapse
You could eventually try this mod:
https://forum.xda-developers.com/apps/magisk/module-single-user-mod-t3639486#post73160966 by @seebz

please delete thread

Ainur JamesDSP is now available in Magisk Manager. Thanks to the devs for their great work. Enjoy!
Not working on pixel xl with magisk 14.3. Repeatedly showing the app has shut down unexpectedly. And then my system started an automatic factory wipe (good thing I forced shut down before the wipe started)
biribiribiri said:
Not working on pixel xl with magisk 14.3. Repeatedly showing the app has shut down unexpectedly. And then my system started an automatic factory wipe (good thing I forced shut down before the wipe started)
Click to expand...
Click to collapse
Yikes. I wonder if AML doesn't support Pixel yet. I will look into it and add a note to the OP. Thanks for the heads up.
biribiribiri said:
Not working on pixel xl with magisk 14.3. Repeatedly showing the app has shut down unexpectedly. And then my system started an automatic factory wipe (good thing I forced shut down before the wipe started)
Click to expand...
Click to collapse
By the way, were you running any other audio mods at the time?
s8m said:
By the way, were you running any other audio mods at the time?
Click to expand...
Click to collapse
no
I am getting a blank screen when opening jamesDSP upon flashing and rebooting. Then if I got to recovery and wipe cache and dalvik and reboot it just does a constant FC, over and over. I provided a log through ADB. I am running ABC ROM, Android O, Angler. As you can also see I have audmodlib and ainur audio as well. Also, before I wiped cache and dalvik and the JamesDSP screen was just blank it did show in notification. Basically, Not working at all here. Thanks for the work bud. The first link is the constant FC with ADB, and the second link is Matlog with the blank JamesDSP screen when opening.
https://haste.blamealexcruz.com/WoNVF1m7XX.swift
https://haste.blamealexcruz.com/8EdpzPLtrU.pl
yung40oz84 said:
I am getting a blank screen when opening jamesDSP upon flashing and rebooting. Then if I got to recovery and wipe cache and dalvik and reboot it just does a constant FC, over and over. I provided a log through ADB. I am running ABC ROM, Android O, Angler. As you can also see I have audmodlib and ainur audio as well. Also, before I wiped cache and dalvik and the JamesDSP screen was just blank it did show in notification. Basically, Not working at all here. Thanks for the work bud. The first link is the constant FC with ADB, and the second link is Matlog with the blank JamesDSP screen when opening.
https://haste.blamealexcruz.com/WoNVF1m7XX.swift
https://haste.blamealexcruz.com/8EdpzPLtrU.pl
Click to expand...
Click to collapse
Thanks - very helpful! Looking quickly at your logcat this may be related to libjamesDSPImpulseToolbox.so being placed inside /system/lib/ instead of /system/lib64/ (my device is ARM64 but accepts /system/lib/). I'll look into a workaround and update this in next build.
s8m said:
Thanks - very helpful! Looking quickly at your logcat this may be related to libjamesDSPImpulseToolbox.so being placed inside /system/lib/ instead of /system/lib64/ (my device is ARM64 but accepts /system/lib/). I'll look into a workaround and update this in next build.
Click to expand...
Click to collapse
Great! Looking forward to it.
When users provide logs...
I already submitted this to the repo. Why are you posting our module as yours? V1.1 is BETA. There's a reason why it is unreleased.
Please have this thread removed. You're going to cause issues for other users, which is already happening.
ahrion said:
I already submitted this to the repo. Why are you posting our module as yours? V1.1 is BETA. There's a reason why it is unreleased.
Please have this thread removed. You're going to cause issues for other users.
Click to expand...
Click to collapse
I'm confused... this is built off a fork of your AM3D repo but my fork is not your repo. V1.1-beta is the version I created. Like the OP says I created this module, combining your AML/Unity framework and james34602's JamesDSPManager.
If you are working on a JamesDSPManager module that is news to me (hence why I made this module). If you are working on a module that is also v1.1-beta that is quite a coincidence! Are you saying you don't want other devs building off of your AML library and sharing with the community? I thought that was welcome (you are planning a template after all) but I will remove this module if you would rather control development.
s8m said:
I'm confused... this is built off a fork of your AM3D repo but my fork is not your repo. V1.1-beta is the version I created. Like the OP says I created this module, combining your AML/Unity framework and james34602's JamesDSPManager.
If you are working on a JamesDSPManager module that is news to me (hence why I made this module). If you are working on a module that is also v1.1-beta that is quite a coincidence! Are you saying you don't want other devs building off of your AML library and sharing with the community? I thought that was welcome (you are planning a template after all) but I will remove this module if you would rather control development.
Click to expand...
Click to collapse
Ahhhh. I didn't check the GitHub repo. I thought you just built the thread with my GitHub repo (which I submitted through Magisk).
That's so weird lol.
You're good then, but using the latest sources will cause things to be wonky with the current stable version of the other mods. It will cause FC all day.
False alarm. Sorry about that! I'm still gonna make a thread for this however.
ahrion said:
Ahhhh. I didn't check the GitHub repo. I thought you just built the thread with my GitHub repo (which I submitted through Magisk).
That's so weird lol.
You're good then, but using the latest sources will cause things to be wonky with the current stable version of the other mods. It will cause FC all day.
False alarm. Sorry about that! I'm still gonna make a thread for this however.
Click to expand...
Click to collapse
OK no worries! That's a good point that using unreleased sources can cause other unwanted problems. I will take this down if you are creating a separate thread. It's probably better for everyone if you are able to manage the development of AML modules.
s8m said:
OK no worries! That's a good point that using unreleased sources can cause other unwanted problems. I will take this down if you are creating a separate thread. It's probably better for everyone if you are able to manage the development of AML modules.
Click to expand...
Click to collapse
It's up to you man. I submitted the stuff yesterday to the Magisk repo, along with a V4A as well as Unity Xposed.
Since you're looking from outside, in. Was Unity easy to configure for you? The entire point for AML is to link everything to together for Magisk. Then we created Unity to be an all in one installer. Any AML modules are encouraged and welcome. Ainur is running AML currently.
Yeah I must say Unity is really well done. I've only ever done very simple Magisk modules (for personal use) so I may not be the best judge, but there wasn't much learning curve at all with Unity. The way the patching and multi-arch handling is set up is really intuitive and logical. This module was really simple to create compared to your ViPER4Android module but it was nice not to have to think about modifying the install-binary or add custom sed commands. All in all - #impressed !
s8m said:
Yeah I must say Unity is really well done. I've only ever done very simple Magisk modules (for personal use) so I may not be the best judge, but there wasn't much learning curve at all with Unity. The way the patching and multi-arch handling is set up is really intuitive and logical. This module was really simple to create compared to your ViPER4Android module but it was nice not to have to think about modifying the install-binary or add custom sed commands. All in all - #impressed !
Click to expand...
Click to collapse
Awesome. You can thank @Zackptg5
Another addition is SETools-inject for Android, that functions like sepolicy inject that MagiskSU/SuperSU have. Essentially, it allows rootless and other forms of root to also use it via init.d. As of yet, no one has actually used SETools for this.
We've also added init.d patching, for rootless and other root methods. Essentially, ramdisk will be automatically patched for AML system modules to use init.d (even if your rom didn't support it before). So init.d patch for all Android versions, MM/N+, has been added. Currently nearly all (if not all) init.d support is broken.
ahrion said:
I already submitted this to the repo. Why are you posting our module as yours? V1.1 is BETA. There's a reason why it is unreleased.
Please have this thread removed. You're going to cause issues for other users, which is already happening.
Click to expand...
Click to collapse
I hope your mod will be in the repo soon, topjohnwu has been very picky with your soubd mods.
24imelqui said:
I hope your mod will be in the repo soon, topjohnwu has been very picky with your soubd mods.
Click to expand...
Click to collapse
It's not that he has been picky. It's just it takes some time to get approved.
Topjohnwu is a busy man.
BTW, Unity allows system mode installation natively if Magisk is not installed, includes addon..d as well.
Magisk is not required for any Unity zips.
ahrion said:
It's up to you man. I submitted the stuff yesterday to the Magisk repo, along with a V4A as well as Unity Xposed.
Click to expand...
Click to collapse
It may be a dumb question, but does your Ainur JamesDSP module require Ainur or can it run independently without Ainur installed?

[MOD] Audio Modification Library v4.2

Audio Modification Library is a library of known audio mods. It'll search your magisk directory for any supported audio mods and incorporate them into itself. It's been completely redone to act as a standalone module so devs no longer need to worry about using a framework for their audio mods and users no longer are limited to just mods using that framework.
Some history
Originally, Unity Installer and AML were combined into one. That's what's archived on ahrions github.
Nowadays, unity is its own thing and AML was completely redesigned into what it is today. The whole purpose of aml is to combine the audio effect/policy/mixer/etc files from multiple audio mods into one set because only one copy of a file can be active mounted at any given time. With non-magisk installs, the actual copies of those audio files are all modified by various mods (aka they all work with the same copy) and so there's no need for aml
What is the purpose of this?
Audio mods often function in part by modifying some audio files (such as audio_effects, mixer_paths, etc.). The problem here is that each mod has it's own copy of the files and magisk can only mount 1 copy of each, so only 1 mod will completely work. AML functions by combining them all into one set of files to remedy this issue.
So how does it work?
It's now a standalone zip that is flashed once and forgetten about. It's magisk only for obvious reasons and will incorporate all supported audio mods into itself automatically during install, and then during each boot if any changes were detected. So it will adjust for any changes in audio mods such as new ones being installed, some being removed, or an existing one being updated.
Where the Mod is Located:
This is more of the nitty gritty for anyone interested but the aml specific copies of audio files and the mod itself are stored in the aml folder in the magisk directory like a typical module. However, it moves any detected audio files out of the folder of any audio mods so they won't be mounted by magisk and conflict. They're moved to .core/aml for safe keeping so they can be restored back to the mod later if you choose to uninstall aml or if upgrading aml
When do I flash this?
Unlike with older version of aml, order doesn't matter. However, it's best to flash aml FIRST. The reason for this is that an increasing number of audio mods look for aml and behave differently if it doesn't yet exist.
Troubleshooting:
If a mod didn't work before you flashed aml, it probably won't work after. Take up the issue on the mod's thread.
Otherwise, if a mod works before flashing aml and doesn't after: First, try uninstalling all audio mods and then reinstalling them (including aml). If that doesn't work, then I'll need you to make a post with this in it:
Recovery log after flashing AML
List of Audio Mods Installed
AML version last working on (if applicable)
Zip attachment of your aml magisk module (/data/adb/modules/aml) folder (note that there's a debug.log file in here that's shows everything)
Zip attachment of your aml backup folder (/data/adb/aml) folder
Currently Supported Mods:
AM3D
AudioWizard
V4AFX
V4AXhifi
Dolby Atmos (ahrion's ports)
Dolby Atmos Axon 7 Oreo (guitardedhero's port)
Dolby Digital Plus
Bang&Olufsen ICEPower (only tested ainur version)
Arkamys (only tested ainur version)
Dirac (only tested ainur version)
Dirac Hexagon (only tested ainur version)
JamesDSP
MaxX Audio 3
Audio Compatibility Patch (formerly universal deep_buffer remover)
Ainur Sauron
SquareSound
Sony Xperia Z2 Sound System
Ainur Narsil
Ainur DTSX
Ainur DTS Ultra
Dolby Atmos Pie/Q+ (guitardedhero's ports)
Want an audio mod added to AML?
Make a post about it and I'll see if it's eligible. No guarantees that I'll add it but these are things that it must have to even be considered:
Original/unique (so not a repackaging of other audio mods)
Universal(ish) (support a large number of devices - not specific to a handful of devices)
Patches files rather than replaces them (the whole point of aml is to be a collection of patches)
Patches must be static (won't be changing with each mod update)
Audio Mod Can't be Added to AML Directly? You can still add it in!
If it doesn't meet these requirements, you can still make it aml compatible.
You just need your mod to create a file called ".aml.sh" in the root of the mod directory ($MODPATH typically). It'll need to have the patches for your mod in a format that aml can understand:
For patching audio_effect files, AML includes a 'patch_cfgs' function that makes life much easier. So if you have an effect and library to add:
Code:
patch_cfgs <effect_name> <UUID> <library_name> <library_path>
For example:
Code:
patch_cfgs v4a_fx 41d3c987-e6cf-11e3-a88a-11aba5d5c51b v4a_standard_fx /vendor/lib/soundfx/libv4a_fx.so
Note that this patch_cfgs function is for audio effects files only. If you're patching audio policy or mixer_paths files, then you'll need to make the patches the old fashioned way yourself.
So if you're not patch audio effects files, skip on down to the 'Some other variables/options' section
'patch_cfgs' has several flags that can be used (the format followed by an example for each is listed here as well):
-l: patch library
Code:
patch_cfgs -l <library_name> <library_path>
Code:
patch_cfgs -l v4a_fx /vendor/lib/soundfx/libv4a_fx.so
-e: patch effect
Code:
patch_cfgs -e <effect_name> <UUID> <library_name>
Code:
patch_cfgs -e v4a_standard_fx 41d3c987-e6cf-11e3-a88a-11aba5d5c51b v4a_fx
-o: patch output_session_processing (postprocessing). Typically used with both 'l' and 'e' flags as well
Code:
patch_cfgs -ole <osp_section> <effect_name> <UUID> <library_name> <library_path>
Code:
patch_cfgs -ole music atmos 9d4921da-8225-4f29-aefa-aacb40a73593 atmos /vendor/lib/soundfx/libatmos.so
-q: patch pre_processing (preprocessing). Typically used with both 'l' and 'e' flags as well
Code:
patch_cfgs -qle <pp_section> <effect_name> <UUID> <library_name> <library_path>
Code:
patch_cfgs -qle music atmos 9d4921da-8225-4f29-aefa-aacb40a73593 atmos /vendor/lib/soundfx/libatmos.so
-p: patch proxy effect (note that since this is a special kind of effect, it cannot be used with '-e'). When used by itself
Code:
patch_cfgs -p <proxy_effect_name> <proxy_UUID> <sw_library_name> <sw_UUID> <hw_library_name> <hw_UUID>
Code:
patch_cfgs -p dax 9d4921da-8225-4f29-aefa-6e6f69726861 dax_sw 6ab06da4-c516-4611-8166-6168726e6f69 dax_hw a0c30891-8246-4aef-b8ad-696f6e726861
But it's typically used with 'l'
Code:
patch_cfgs -pl <proxy_effect_name> <proxy_UUID> <sw_library_name> <sw_UUID> <sw_library_path> <hw_library_name> <hw_UUID> <hw_library_path>
Code:
patch_cfgs -pl dax 9d4921da-8225-4f29-aefa-6e6f69726861 dax_sw 6ab06da4-c516-4611-8166-6168726e6f69 /vendor/lib/soundfx/libswdax.so dax_hw a0c30891-8246-4aef-b8ad-696f6e726861 /vendor/lib/soundfx/libhwdax.so
-r: replace. Normally, aml will only apply any of the above if it doesn't exist in the audio cfg file. With this flag enabled however, it'll replace any existing effects. It's pretty rare that this would be needed (none of the mods patches built-in to aml have this)
no flag specified: if no flags are specified, patch_cfgs will use -le by default (patch library and effect). This is what's typically used (like in the first example before this list)
For patching other files: just add you script logic like it it was in your mod.
If you're patching mixers for example:
Code:
for i in $(find $MODPATH/system -type f -name "*mixer_paths*.xml"); do
<add_patch_here> for mixer '$i'
done
MODPATH is equivalent to aml's directory since it's running the aml.sh script
Then when AML is installed, it'll detect this .aml.sh file and apply the patches accordingly
Source
Download
Awesome work! Excited to try it out. Will the usual AML mods such as ainur and v4a be updated or can I go ahead and test out with the current v2.9 zips?
nonchalantroller said:
Awesome work! Excited to try it out. Will the usual AML mods such as ainur and v4a be updated or can I go ahead and test out with the current v2.9 zips?
Click to expand...
Click to collapse
Just finished updating everything. Usual aml mods are now unity mods so you don't even need to worry about that anymore. I'll put a list of supported mods to the op in a min
Edit: OP updated, ainur mods will likely be released tomorrow so you'll need to hold off until then to use them
Here's the install log from Magisk where Viper is asking for drivers.
MrBrady said:
Here's the install log from Magisk where Viper is asking for drivers.
Click to expand...
Click to collapse
Can you try this test zip and send the recovery log?
Zackptg5 said:
Can you try this test zip and send the recovery log?
Click to expand...
Click to collapse
Sure! Installation failed. Log attached.
MrBrady said:
Sure! Installation failed. Log attached.
Click to expand...
Click to collapse
Danget, dumb error on my part. I reuploaded the attachment in my last post so try that. Sorry!
Zackptg5 said:
Danget, dumb error on my part. I reuploaded the attachment in my last post so try that. Sorry!
Click to expand...
Click to collapse
Installed the updated file. Still asking to install drivers. Log attached.
MrBrady said:
Installed the updated file. Still asking to install drivers. Log attached.
Click to expand...
Click to collapse
Dang, still same error on recovery log but now I'm starting to hone in on the problem. Thanks!
MrBrady said:
Installed the updated file. Still asking to install drivers. Log attached.
Click to expand...
Click to collapse
Does this aml work for you? (Post recovery log and aml folder please)
Zackptg5 said:
Does this aml work for you? (Post recovery log and aml folder please)
Click to expand...
Click to collapse
Installing this caused V4A to ask for drivers again. Folder and log attached.
MrBrady said:
Installing this caused V4A to ask for drivers again. Folder and log attached.
Click to expand...
Click to collapse
Think I got it. I'll need the same stuff as before
Zackptg5 said:
Think I got it. I'll need the same stuff as before
Click to expand...
Click to collapse
Bingo! That works now. Attached is the directory and log.
MrBrady said:
Bingo! That works now. Attached is the directory and log.
Click to expand...
Click to collapse
Sweet! Thanks for all your help, I really appreciate it :good:
Zackptg5 said:
Sweet! Thanks for all your help, I really appreciate it :good:
Click to expand...
Click to collapse
My pleasure! Thanks for making this mod! I know we all really appreciate it, even if it's not voiced often enough.
AML has been updated to v1.1! Main changes are fixes or xml cfg files (should fix issues with pixel 2's) and some other minor fixes. Thanks to @MrBrady for the troubleshooting help
v1.2 has been dropped. Hopefully this will be the last release for a while.
Changelog: Fixed janky bootmode stuff, Fix uninstall/upgrade when a supported audio mod has just been upgraded in bootmode
So basically any weird things that happened when flashing in magisk manager are now fixed
Zackptg5 said:
v1.2 has been dropped. Hopefully this will be the last release for a while.
Changelog: Fixed janky bootmode stuff, Fix uninstall/upgrade when a supported audio mod has just been upgraded in bootmode
So basically any weird things that happened when flashing in magisk manager are now fixed
Click to expand...
Click to collapse
Thanks! Seems to be working right on Pixel 2 XL now.
Safety net got tripped,RR unofficial 7.1.2, I passed again after uninstalling aml.
Gonna try again but install from twrp...seemed to fix my viper issues, might do the same for aml
---------- Post added at 08:27 AM ---------- Previous post was at 08:18 AM ----------
preference said:
Safety net got tripped,RR unofficial 7.1.2, I passed again after uninstalling aml.
Gonna try again but install from twrp...seemed to fix my viper issues, might do the same for aml
Click to expand...
Click to collapse
Yep, twrp install works with no safety net trip. I've never had this many issues using the direct install in magisk. I doubt that it's a module issue, I'm probably messing up the process.
Dropped v1.3. Fixes issues with output_session_processing patching - mainly applicable to dolby oreo

[Help] I can't get the new module template working.

As anyone who works on Magisk modules knows there is a new module template out, and for the life of me I can not get it working whatsoever. No matter what the install will always fail in my test builds. If anyone can be kind enough to submit a pull request with the updated template applied to my 2 modules, F-Droid Privileged Extension and Systemless TZData I would be extremely thankful.
EDIT: I might just have been overthinking due to life at the moment.
ryaniskira said:
As anyone who works on Magisk modules knows there is a new module template out, and for the life of me I can not get it working whatsoever. No matter what the install will always fail in my test builds. If anyone can be kind enough to submit a pull request with the updated template applied to my 2 modules, F-Droid Privileged Extension and Systemless TZData I would be extremely thankful.
EDIT: I might just have been overthinking due to life at the moment.
Click to expand...
Click to collapse
I have a funny feeling it is because the updater-binary is now empty and has to be manually replaced with a proper installer script. Read more here.

Categories

Resources