Database Develop

[BUG] Magisk refuses to install modules from repo (The zip is not a Magisk Module!)

I've had magisk installed since version 6, I've published some magisk modules already and never had a problem until today.
After a full clean reinstall of Nougat NBD90Z (with wipe) on my Nexus 6 and then flashing Magisk, phh's superuser for magisk, installing phh's superuser apk from play store and magisk manager apk I stumbled upon a previously reported (without details) bug where magisk manager would refuse to install modules from repo claiming they are not magisk modules.
I've struggled trying everything I could including the full wipe (more details here: http://forum.xda-developers.com/apps/magisk/module-app-systemizer-t3477512/69230448#69230448) and bounced some ideas off @pnwsr6 who's had the similar problem on Nexus 6 device.
I've achieved a partially working Magisk Manager (manual installs of ZIP files work, but installs from repo still fail) and here's the list of steps which lead to me having semi-working magisk manager again:
1. I flashed ZIP files of some modules in twrp (I'm attaching App Systemizer and Nexus 6 LED Enabler which I flashed)
2. After the phone booted up I saw the modules active and working
3. Within Magisk Manager I then added the ZIP file of the phh's superuser module from that thread (http://forum.xda-developers.com/attachment.php?attachmentid=3893967&d=1475554052)
4. Now at least manual installation of modules within Magisk Manager are working fine.
@topjohnwu -- I've enabled verbose logging and extra logging for bash commands, but I'm still not seeing anything in the log on top of the regular output.

Created an issue against Magisk Manager so it's easier to track for developers: https://github.com/topjohnwu/MagiskManager/issues/20

Looks like that even after flashing some modules in twrp, Magisk Manager only allows to install from zip only exactly the same ZIP I've already flashed (even a minor change and bump of versionCode results in "This ZIP is not a Magisk Module!"). So it might be an issue of Magisk Manager being unable to write to /magisk despite having storage permission and being granted root access.

Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!

I've seen this error as well on my Nexus 6 NBD90Z with Magisk v8. Started with v7 after some heavy modification on my part .
I was sometimes able to fix it by simply extracting the zip and then Magisk Manager would somehow recognize it as a module.. Other times I could extract the zip and then re-archive the contents and Magisk Manager would recognize that as a module. Weird, but doable.

stangri said:
Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!
Click to expand...
Click to collapse
I probably won't try again until next update, and hope the wipe just wasn't clearing something. I have the zip installed through twrp and working for now so I'm good till then.

just wondering if you're still having this issue with v9? I had modules installed fine under v6, but never really installed any modules under v8 to see if this problem occurred for me. now that I'm on v9, which has been wiped clean to start, I can no longer install any modules via Downloads or in the Modules section... any suggestions?

I have the same issue when trying to install viper with v9 on Nexus 6P DP2
Skickat från min Nexus 6P via Tapatalk

Same here. Find a fix ?

From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.

stangri said:
From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.
Click to expand...
Click to collapse
Just an FYI, I do still have this problem, but can install the zip through twrp. Maybe 10 will be the solution.

I had the same problem, I cleared magisk manager data and it works fine now

Didn't help
Sent from my SM-G532F using Tapatalk

I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.

stangri said:
I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.
Click to expand...
Click to collapse
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.

Meowdib said:
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.
Click to expand...
Click to collapse
Weird, do you have the same problem with magisk manager 161223?

stangri said:
Weird, do you have the same problem with magisk manager 161223?
Click to expand...
Click to collapse
Same

I need a Help to download modules using magisk
Lastest version, Included phh root, manager is from G. play,
But Modules download function is not working
Say "No modules found" for download to install via magisk.

Magic v11 installation question

Hi, do i need install systemless SuperSU always in twrp before install magisk v11 if I want use new MagiskSU instead??
If I try install Magisk v11 with superSU uninstalled and phone unrooted TWRP give me error and installation fails and if I install superSU and after Magisk v11, Magisk manager say system is using SuperSU instead MagiskSU. How do I install Magisk with MagiskSU??
I have Samsung Galaxy S4 with optimized LineageOS 14.1

Read the pinned Magisk thread...
Unroot again using unSu by osm0sis (Google) before flashing magisk

Installation Instructions
If you're already rooted with MagiskSU, Magisk phh's superuser (not original), or Official Systemless SuperSU
Install/upgrade Magisk Manager from Play Store
Install/upgrade Magisk as prompted in the application
Reboot and you're done!!
If you're not rooted, or something went wrong and you need a clean start
(Recommended) Restore your boot image back to stock
Download the latest Magisk zip file
If you choose to use SuperSU (only support Android 6.0+), first flash SuperSU in systemless mode
Flash Magisk zip
Reboot, and update the stub Magisk Manager to the latest from Play Store
Click to expand...
Click to collapse
I read 200 times but when I install Magisk without SuperSU (because I want MagiskSU) TWRP give me an error and install fail... read my initial post first please....
Error:
Code:
! SU image mount failed...
! Please immediately flash SuperSU now
! Installation will complete after flashing SuperSU
[B]Updater process ended with ERROR: 1
Error installing zip file 'sdcard/Download/Magisk v11.1/Magisk-v11.1.zip[/B]

dhaern said:
I read 200 times but when I install Magisk without SuperSU (because I want MagiskSU) TWRP give me an error and install fail... read my initial post first please....
Error:
Click to expand...
Click to collapse
You need to FULLY unflash superSU using the zip that the other person told you to google.

PartyPlease said:
You need to FULLY unflash superSU using the zip that the other person told you to google.
Click to expand...
Click to collapse
Ok I will try unflash with the zip, I was using unroot inside superSU menu but installation instructions dont say nothing about the unflash with an extrenal script

dhaern said:
Ok I will try unflash with the zip, I was using unroot inside superSU menu.
Click to expand...
Click to collapse
Yeah that button doesn't work for systemless superSU. It doesn't roll back your boot.IMG like it should.
Worst case scenario, flash the stock boot.img and then flash magisk.

Thanks guys, I installed Magisk v11.1 with MagiskSU working, Magisk Hide enabled but I have CTS mismatch error now in Safetynet test. I guess I cant do nothing about this error. Optimized LineageOS 14.1 and Samsung Galaxy S4
EDIT: Finally I passed the Safetynet test (no CTS mismatch error) disabling ADB interface in developer options. Thanks for Magisk, amazing.

PartyPlease said:
Yeah that button doesn't work for systemless superSU. It doesn't roll back your boot.IMG like it should.
Worst case scenario, flash the stock boot.img and then flash magisk.
Click to expand...
Click to collapse
ahh, this would explain why my boot.img was not the same after "unrooting"! thanks for clearing this up for me...

dhaern said:
Thanks guys, I installed Magisk v11.1 with MagiskSU working, Magisk Hide enabled but I have CTS mismatch error now in Safetynet test. I guess I cant do nothing about this error. Optimized LineageOS 14.1 and Samsung Galaxy S4
EDIT: Finally I passed the Safetynet test (no CTS mismatch error) disabling ADB interface in developer options. Thanks for Magisk, amazing.
Click to expand...
Click to collapse
By disabling ADB interface, do you mean the USB debugging part? for some reason I am still getting Safetynet error.

vicky_ag said:
By disabling ADB interface, do you mean the USB debugging part? for some reason I am still getting Safetynet error.
Click to expand...
Click to collapse
Yeah I said USB debugging option, when I disabled this I passed Safetynet test.

dhaern said:
Yeah I said USB debugging option, when I disabled this I passed Safetynet test.
Click to expand...
Click to collapse
Thanks but doesn't seem to work for me.

dhaern said:
Yeah I said USB debugging option, when I disabled this I passed Safetynet test.
Click to expand...
Click to collapse
Thanks for this hint; got my build "passed" now appreciate it

What settings are you guys using in Magisk? I have disabled BusyBox, enabled Magisk Hide and systemless hosts. Superuser options are Access to "Apps and ADB" and Automatic Response set to prompt

I'm still having an issue installing Magisk on my phone with RAMROM V10. It gives me an ERROR 1.
It has been suggested that I should re-flash my boot.img with TWRP following the instruction:
Place your BOOT.img on your sdcard
Reboot into TWRP recovery
Tap "Install"
In the bottom right corner tap "Install Image"
Select your BOOT.img
Select the Boot Partition, then swipe to confirm Flash
However, when I follow the step, my TWRP cannot seem to find BOOT.IMG in my SD Card (I know it is there). What did I do wrong? Can anyone help?

i think the .img thingy is only for twrp.img files. You have to use another method to place your boot image like. -> make a backup of only your boot image via twrp backup function. Then duplicate that backup folder of twrp containing only the newly just regernated files, in the twrp folder. Then replace the su-modified boot file there with your original boot file, you obviously have to rename your boot image to fit the right name. (eg. with the logo image -> logo.bin changes to logo.emmc.win -> etc;.) Then use the twrp restore function to restore your "original" boot logo.
Hierarchy folder view would be like:
TWRP->folder 1 (original folder, in case something goes wrong)-> boot file and others
->folder 2 (our modified folder)-> files

sm00th4f3 said:
i think the .img thingy is only for twrp.img files. You have to use another method to place your boot image like. -> make a backup of only your boot image via twrp backup function. Then duplicate that backup folder of twrp containing only the newly just regernated files, in the twrp folder. Then replace the su-modified boot file there with your original boot file, you obviously have to rename your boot image to fit the right name. (eg. with the logo image -> logo.bin changes to logo.emmc.win -> etc;.) Then use the twrp restore function to restore your "original" boot logo.
Hierarchy folder view would be like:
TWRP->folder 1 (original folder, in case something goes wrong)-> boot file and others
->folder 2 (our modified folder)-> files
Click to expand...
Click to collapse
FIY: Flashing regular boot.img files works just fine with "Install Image" in TWRP (of course, YMMV, depending on your device).

[solved] Uninstall Magisk module offline/without Magisk?

(other thread here)
It seems that a Magisk module that I have recent installed (no idea which one) is preventing my phone to boot correctly. I know that because reflashing the latest OTA update removes Magisk and then it works perfectly. As soon as I flash Magisk, it doesn't boot anymore.
Even after flashing SuperSU, Magisk Manager doesn't let me see/remove installed modules.
Is there a way to do that?

zdimension said:
(other thread here)
It seems that a Magisk module that I have recent installed (no idea which one) is preventing my phone to boot correctly. I know that because reflashing the latest OTA update removes Magisk and then it works perfectly. As soon as I flash Magisk, it doesn't boot anymore.
Even after flashing SuperSU, Magisk Manager doesn't let me see/remove installed modules.
Is there a way to do that?
Click to expand...
Click to collapse
Use mount-magisk.zip found in collection of modules thread and delete the folder via twrp in /magisk

@duxishere Thanks so much!
I searched for "Magisk module offline uninstall" but did find anything. This was exactly what I needed! The culprit was App Systemizer. I've had it installed for some time and it didn't cause any problems. I uninstalled it, and it worked! Flashing it again restored the boot problem.

zdimension said:
@duxishere Thanks so much!
I searched for "Magisk module offline uninstall" but did find anything. This was exactly what I needed! The culprit was App Systemizer. I've had it installed for some time and it didn't cause any problems. I uninstalled it, and it worked! Flashing it again restored the boot problem.
Click to expand...
Click to collapse
How did you uninstalled the troubled module?
I'm having the same problem with a module but I don't even have a /magisk folder.

gonsa said:
How did you uninstalled the troubled module?
I'm having the same problem with a module but I don't even have a /magisk folder.
Click to expand...
Click to collapse
Start reading the thread from the beginning and you'll find it.

gonsa said:
How did you uninstalled the troubled module?
I'm having the same problem with a module but I don't even have a /magisk folder.
Click to expand...
Click to collapse
Install "Uninstaller Mod Magisk" from TWRP. Then go in the TWRP terminal and type uninmod_magisk and follow the instructions.

please post the link to thread unistaller magisk module, to other users follow the solution!
edit:
there is https://forum.xda-developers.com/showpost.php?p=72542167&postcount=242

nodio said:
please post the link to thread unistaller magisk module, to other users follow the solution!
edit:
there is https://forum.xda-developers.com/showpost.php?p=72542167&postcount=242
Click to expand...
Click to collapse
Not working for me!
I will uninstall "Audio Compatibility Patch" V1.0 from zackptg5 & ahrion
In Magisk Manger Status is always " Module will be updated at the next start"
If i use the "TWRP-Uninstaller" the Modul is not in List!

dewois said:
Not working for me!
I will uninstall "Audio Compatibility Pach" V1.0 from zackptg5 & ahrion
In Magisk Manger Status is always " Module will be updated at the next start"
If i use the "TWRP-Uninstaller" the Modul is not in List!
Click to expand...
Click to collapse
https://www.didgeridoohan.com/magisk/Magisk#hn_Module_will_be_updated_at_next_reboot

Didgeridoohan said:
https://www.didgeridoohan.com/magisk/Magisk#hn_Module_will_be_updated_at_next_reboot
Click to expand...
Click to collapse
".... Go the module folder under /sbin/.core/img ..."
I dont have this folder in /sbin!

tobi14 said:
".... Go the module folder under /sbin/.core/img ..."
I dont have this folder in /sbin!
Click to expand...
Click to collapse
If you have a current version of Magisk installed, yes you do. Enable viewing hidden files and folders in your file explorer. The dot at the beginning of the folder name means it's hidden...

zdimension said:
(other thread here)
It seems that a Magisk module that I have recent installed (no idea which one) is preventing my phone to boot correctly. I know that because reflashing the latest OTA update removes Magisk and then it works perfectly. As soon as I flash Magisk, it doesn't boot anymore.
Even after flashing SuperSU, Magisk Manager doesn't let me see/remove installed modules.
Is there a way to do that?
Click to expand...
Click to collapse
If you can launch TWRP then :
Check magisk.img exist
1. Go to "advanced" and then click on "File Explorer".
2. Check there is "magisk.img" file under "/data"
Backup magisk.img
1. Go to "advanced" and then click on "terminal command".
2. type following command
Code:
cp /data/magisk.img /data/magisk.img.bk
Mount magisk.img
1. Make a temp folder
Code:
mkdir /mktmp
2. Mount magisk.img to /mktmp
Code:
mount -o loop /data/magisk.img /mktmp
3. Navigate to mktmp and remove your module
Code:
cd /mktmp
rm -rf /mktmp/xxxx
Unmount magisk.img and reboot to check if it's work
1. Unmount magisk.img
Code:
umont /mktmp
2. Leave terminal and reboot the phone
3. Enjoy!

mklee11224 said:
If you can launch TWRP then :
Check magisk.img exist
1. Go to "advanced" and then click on "File Explorer".
2. Check there is "magisk.img" file under "/data"
Backup magisk.img
1. Go to "advanced" and then click on "terminal command".
2. type following command
Code:
cp /data/magisk.img /data/magisk.img.bk
Mount magisk.img
1. Make a temp folder
Code:
mkdir /mktmp
2. Mount magisk.img to /mktmp
Code:
mount -o loop /data/magisk.img /mktmp
3. Navigate to mktmp and remove your module
Code:
cd /mktmp
rm -rf /mktmp/xxxx
Unmount magisk.img and reboot to check if it's work
1. Unmount magisk.img
Code:
umont /mktmp
2. Leave terminal and reboot the phone
3. Enjoy!
Click to expand...
Click to collapse
Thanks mate ! it worked like a charm !
just use "ls" command on step 3 after changing directory to mktmp , to show installed modules.:silly:
My Phone Specification : Moto X Play ------ 7.1.1 Stock Firmware -------- Squid kernel --------- rooted using Magisk ------ systemless xposed module "xposed_25" installed using magisk module(Uninstalled by this method !) .:victory:

Tanks a lot!
Crossbreeder lite made my phone unusable. Working fine again!

magisk.img not found in /data
This works like charm, if you can't find the magisk.img in `/data` check `/data/adb` ... I hope this work .

Didgeridoohan said:
https://www.didgeridoohan.com/magisk/Magisk#hn_Module_will_be_updated_at_next_reboot
Click to expand...
Click to collapse
Own domain huh? Business growing? Hehehe I only came for the uninstall zip, hey quick question, I'm on a micro sd-less phone (big news), still a flashaholic, kinda, but my phone so happens to require a data format every time for gsi's, where would you recommend keeping the "things to keep on your device" (Magisk related) so i don't have to carry an otg and drive everywhere i go? Thank you sir, you almost get more thanks than posts! Talk about reputation!

culiacanazo said:
Own domain huh?
Click to expand...
Click to collapse
I keep a few of them around. It was nice to finally find a good use for that one...
but my phone so happens to require a data format every time for gsi's, where would you recommend keeping the "things to keep on your device" (Magisk related) so i don't have to carry an otg and drive everywhere i go?
Click to expand...
Click to collapse
Do you have to completely wipe the device? Or can you keep internal storage intact? If not, it sounds like you're out of luck.
Nice thread hijack, by the way... :laugh:

Didgeridoohan said:
Do you have to completely wipe the device?
Click to expand...
Click to collapse
Well i do a factory reset, flash system img and reboot, let it loop because it will, and then do a data format before it will boot, so system, caches, and data go... (Huawei, see)
Didgeridoohan said:
Nice thread hijack, by the way... :laugh:
Click to expand...
Click to collapse
I kinda stayed on topic didn't i? :crying:
You linked to your help guide which i read the beginning of that by the way has nothing to do with the help you offered to the op and reminded me of my struggles with a totally different device and problem!!
It's like how I'm related to my grandma's cousin's wife's sister's doctor's neighbor's son's friend, ain't it?
Sent from my Huawei Mate 10 Pro using XDA Labs

Would be cool if someone could share the adb solution. In the FAQ is just written "email me for this" wtf?!? It is ****ing anoying to reflash the whole system everytime a module isnt working (yeah thats what you need to do if your device doesnt have twrp, and a lot of a/b devices dont have twrp). Also you need to delete all user datas because you flashed the system new and the new system doesnt know the encryption key for the user datas. There need to be a better solution than using twrp or email the dev for adb solution.
The easiest way would be to make it possible that magisk manager can manage (remove/deactivate) the modules while there is no patched boot.img installed. This would solve all problems related to a/b devices without twrp and magisk modules (not booting or anything else) just flash stock boot.img remove the problematic module flash patched boot.img and done. This is not possible because the module section in magisk manager is hidden when there is no patched boot.img installed.
Second thing i noticed, magisk manager doesnt reset the active modules when you wipe the app data. This should be a MUST. Would also solve the problem of not booting modules without wiping the whole system on a/b devices without twrp.

Apply .disable_magisk
saturday_night said:
Would be cool if someone could share the adb solution. In the FAQ is just written "email me for this" wtf?!? It is ****ing anoying to reflash the whole system everytime a module isnt working (yeah thats what you need to do if your device doesnt have twrp, and a lot of a/b devices dont have twrp). Also you need to delete all user datas because you flashed the system new and the new system doesnt know the encryption key for the user datas. There need to be a better solution than using twrp or email the dev for adb solution.
The easiest way would be to make it possible that magisk manager can manage (remove/deactivate) the modules while there is no patched boot.img installed. This would solve all problems related to a/b devices without twrp and magisk modules (not booting or anything else) just flash stock boot.img remove the problematic module flash patched boot.img and done. This is not possible because the module section in magisk manager is hidden when there is no patched boot.img installed.
Second thing i noticed, magisk manager doesnt reset the active modules when you wipe the app data. This should be a MUST. Would also solve the problem of not booting modules without wiping the whole system on a/b devices without twrp.
Click to expand...
Click to collapse
Hi!. I have this user of XDA Dev. hanging out for a time... well the fact is I'm new. My problem (not the only one) maybe merge a kind of solution to this. And this could be putting the ".disable_magisk" blank file inside the cache partition as an ADB Sideload update.
Next to this. I've found that to do that it's not as simply as it seems to be cause I'm on a Samsung Galaxy S7 Nougat 7.0 Version. And all the examples with update-binary file I have, are from downgrade versions...
I'm stuck in a bootloop due to the Magisk Xposed SDK 24 module. I think this module & encription is not good (as I've read on the Xpose module thread).
So, here I'm asking how to make an script to run directly on the Stock recovery using ADB Sideload, which will put the blank ".disable_magisk" file inside the /cache partition. I need just this, and I think this could help some people who are stuck on this issue.
Now, I have this Thread. But really I need the advice of an expert telling me what to do in order to achieve this. As I think this is an easy labor, but you have to know how to do it... If someone is able to clarify please, I will appreciate so much.
Thanks!
---------- Post added at 05:51 PM ---------- Previous post was at 05:41 PM ----------
neromanello said:
Hi!. I have this user of XDA Dev. hanging out for a time... well the fact is I'm new. My problem (not the only one) maybe merge a kind of solution to this. And this could be putting the ".disable_magisk" blank file inside the cache partition as an ADB Sideload update.
Next to this. I've found that to do that it's not as simply as it seems to be cause I'm on a Samsung Galaxy S7 Nougat 7.0 Version. And all the examples with update-binary file I have, are from downgrade versions...
I'm stuck in a bootloop due to the Magisk Xposed SDK 24 module. I think this module & encription is not good (as I've read on the Xpose module thread).
So, here I'm asking how to make an script to run directly on the Stock recovery using ADB Sideload, which will put the blank ".disable_magisk" file inside the /cache partition. I need just this, and I think this could help some people who are stuck on this issue.
Now, I have this Thread. But really I need the advice of an expert telling me what to do in order to achieve this. As I think this is an easy labor, but you have to know how to do it... If someone is able to clarify please, I will appreciate so much.
Thanks!
Click to expand...
Click to collapse
I need to know how to locate the mount point of my /cache partition at the stock recovery ADB Sideload. Then, to mount it, transfer the blank file to it, and then unmount /cache. I think it's an easy labor. So here my incomplete updater-script:
ui_print("Trying to make an script with ADB Sideload..."); CRLF
ui_print("Creating file to disable Magisk Modules..."); CRLF
I NEED THE MOUNT POINT HERE CRLF
ifelse package_extract_file(".disable_magisk", "/cache/.disable_magisk") == "t", ui_print("OK!"), ui_print("Failed!"); CRLF
UNMOUNT COMMAND HERE. CRLF
--last blank line--
So, I need to complete that, BUT things gets difficult when I need the update-binary for my Nougat 7.0 version, and to sign the whole .zip file in order my stock recovery recognizes it. I think this last thing could be made by this Thread. But really I don't know. Please help.
Thanks!.

Error installing zip file '/sdcard/MAGISK/Magisk-v16.0.zip'

Good evening from Spain.
I tried to flash Magisk onto my SM-J530F (Samsung Galaxy J5 2017) but not successfully.
Here's the log:
Updating partition details...
...done
Full SELinux support is present.
MTP Enabled.
Installing zip file '/sdcard/MAGISK/Magisk-v16.0.zip'
Checking for Digest file...
Skipping Digest check: no Digest file found
********************
* Magisk v16.0 Installer
********************
- Mounting /system, /vendor
- Found boot/ramdisk image: /dev/block/mmcblk0p10
- Device platform: arm
- Constructing environment
- Unpacking boot image
- Checking ramdisk status
! Boot image patched by other programs.
! Please restore stock boot image
- Unmounting partitions
Updater process ended with ERROR: 1
Error installing zip file '/sdcard/MAGISK/Magisk-v16.0.zip'
Updating partition details...
Failed to mount '/system' (Device or resource busy)
...done
Consider that I did the following:
- Flashed stock rom (J530FXXU2ARB3_J530FPHE2ARB3_PHE.zip content)
- Flashed "CF-Auto-Root-j5y17lte-j5y17ltexx-smj530f.tar" in Download mode via Odin, to root and install SuperSU, since it's needed
for flashing TWRP to avoid any bootloop.
- Flashed TWRP.
- Since I already have TWRP, I tried to uninstall SuperSU from the very app, in Options > Full unroot but gave "Uninstallation error", so then I tried to uninstall SuperSU by flashing "UPDATE-unSU.zip" on TWRP.
- Once that is done, I tried to flash "Magisk-v16.0.zip" and it throwed the log I've above mentioned.
- Since it says: "! Boot image patched by other programs.
! Please restore stock boot image", I rebooted it onto Download Mode, and flashed ONLY the BL (bootloader/boot) slot. Came back to TWRP, I flashed again "Magisk-v16.0.zip" but still have the same problem.
Hope there's any solution to install Magisk onto my SM-J530F. Thank you.

Your issue is that the boot image still is patched by SuperSU. Until you restore the stock boot image you won't be able to install Magisk.
https://www.didgeridoohan.com/magisk/Magisk#hn_Boot_image_patched_by_other_programs
Edit: I don't do Samsung, but from what I remember, you might need to flash AP (or something like that).

Didgeridoohan said:
Your issue is that the boot image still is patched by SuperSU. Until you restore the stock boot image you won't be able to install Magisk.
https://www.didgeridoohan.com/magisk/Magisk#hn_Boot_image_patched_by_other_programs
Edit: I don't do Samsung, but from what I remember, you might need to flash AP (or something like that).
Click to expand...
Click to collapse
Well, something changed!!!
The problem related with the boot image is solved but I still have the " Failed to mount '/system' "
Updating partition details...
...done
Full SELinux support is present.
MTP Enabled.
Installing zip file '/sdcard/MAGISK/Magisk-v16.0.zip'
Checking for Digest file...
Skipping Digest check: no Digest file found
********************
* Magisk v16.0 Installer
********************
- Mounting /system, /vendor
- Found boot/ramdisk image: /dev/block/mmcblk0p10
- Device platform: arm
- Constructing environment
- Unpacking boot image
- Checking ramdisk status
- Stock boot image detected
- Backing up stock boot image
- Patching ramdisk
- Repacking boot image
- Flashing new boot image
- Unmounting partitions
- Done
Updating partition details...
Failed to mount '/system' (Device or resource busy)
...done
Thank you very much.
EDIT: Despite this problem: "Failed to mount '/system' (Device or resource busy)", your solution was correct! Now I have Magisk correctly installed.
Thank you

Nice to hear it worked. Just for the record, the "Failed to mount /system" message is a TWRP thingy. The Magisk installation is done at the "-Done" line.

Hi, I have the same problem of error 1 while trying to install Magisk from TWRP.
I looked everywere and they say that it is related to a boot image that have to be reinstalled. I did that and no luck, I tryed with boot.img, no working, I even restored ALL the ROM Stock from Samsung ( AP, BL, CP and CSC) and it is not working. I dont know what to do anyware...
Regeet the time was easy to root Samsung with CF autoRoot,
I tried that and ask me to restore all thephone, so still no root??
Some can help please??
Thx

saoudien07 said:
Hi, I have the same problem of error 1 while trying to install Magisk from TWRP.
I looked everywere and they say that it is related to a boot image that have to be reinstalled. I did that and no luck, I tryed with boot.img, no working, I even restored ALL the ROM Stock from Samsung ( AP, BL, CP and CSC) and it is not working. I dont know what to do anyware...
Regeet the time was easy to root Samsung with CF autoRoot,
I tried that and ask me to restore all thephone, so still no root??
Some can help please??
Thx
Click to expand...
Click to collapse
Provide a recovery log or it's going to be impossible to say what the issue is...

Didgeridoohan said:
Provide a recovery log or it's going to be impossible to say what the issue is...
Click to expand...
Click to collapse
Thx for the reply, I am trying to open the content and upload the report here, but no luck. how can I open the log??? can not get a program to do so .......

saoudien07 said:
Thx for the reply, I am trying to open the content and upload the report here, but no luck. how can I open the log??? can not get a program to do so .......
Click to expand...
Click to collapse
The log is just a text file. Did you check the link I posted? In TWRP: Advanced - Copy log, and then post the resulting file.

Didgeridoohan said:
The log is just a text file. Did you check the link I posted? In TWRP: Advanced - Copy log, and then post the resulting file.
Click to expand...
Click to collapse
I got a file "recovery.log" thats why I can not open it, maybe change the extention to "txt" ???

saoudien07 said:
I got a file "recovery.log" thats why I can not open it, maybe change the extention to "txt" ???
Click to expand...
Click to collapse
That would work, but you should be able to open it directly with pretty much any text editor as well. If you're going to post the log text directly, please at least use HIDE tags...

So here what I just did:
I wanted to do a last try to get that error 1 msg and get the repport directly to publicate it here...
So I decide to go to a clean basis. So,
1- Install all the stock ROM with odin. I choose the Home_CSC
Was another just CSC without Home, dont know exactly which one I had to choose, I choose Home_CSC.
2- Turn the fone off
3- Turn it back to download mode
4- Install the TWRP recovery, and I did not reboot.
5- Turn off the fone.
6- Turn on to recovery mode.
7- Format the data (yes)
8- Reboot to Recovery mode.
9- Install Magisk!
AT MY BIG SURPRISE I DID NOT GET ANY ERROR MSG!!! The installation finished without error!
So I continued...
10- install No verity
11- install SuperUS 2.82
13- Reboot the phone.
I was thinking that the root was ok, now I have a new pb. When I tryed to verify with Root Checker, it says no root. When I entered the app, it said BINARY OCCUPIED.
So any suggestion?

saoudien07 said:
9- Install Magisk!
...
11- install SuperUS 2.82
Click to expand...
Click to collapse
Say what...? You've misunderstood something, somewhere. Use Magisk OR SuperSU. Magisk is it's own root solution...
Are you by any chance using some old and outdates guides? Previously you could use SuperSU with Magisk, but that has not been the case since v13.0, well over a year ago, and MagiskSU has been around since v11.0, introduced a year and a half ago.

Didgeridoohan said:
Say what...? You've misunderstood something, somewhere. Use Magisk OR SuperSU. Magisk is it's own root solution...
Are you by any chance using some old and outdates guides? Previously you could use SuperSU with Magisk, but that has not been the case since v13.0, well over a year ago, and MagiskSU has been around since v11.0, introduced a year and a half ago.
Click to expand...
Click to collapse
You guessed right, I am not using a so old tuto, it says it is for oreo...
So I have to use or Magisk or SuperSU,right?
The thing is that i thought SuperSu is to install the SuperSU app, I did notknow that it root also the phone...
I am kind of newby to Android world, u figured it already...
So what are insterest of using Magisk or no-verity??
---------- Post added at 08:22 PM ---------- Previous post was at 08:17 PM ----------
Didgeridoohan said:
Say what...? You've misunderstood something, somewhere. Use Magisk OR SuperSU. Magisk is it's own root solution...
Are you by any chance using some old and outdates guides? Previously you could use SuperSU with Magisk, but that has not been the case since v13.0, well over a year ago, and MagiskSU has been around since v11.0, introduced a year and a half ago.
Click to expand...
Click to collapse
Can I put a link to the tuto here??
For you guys to have a lock at it?

saoudien07 said:
You guessed right, I am not using a so old tuto, it says it is for oreo...
So I have to use or Magisk or SuperSU,right?
The thing is that i thought SuperSu is to install the SuperSU app, I did notknow that it root also the phone...
I am kind of newby to Android world, u figured it already...
So what are insterest of using Magisk or no-verity??
---------- Post added at 08:22 PM ---------- Previous post was at 08:17 PM ----------
Can I put a link to the tuto here??
For you guys to have a lock at it?
Click to expand...
Click to collapse
The root management app for Magisk/MagiskSU is the Magisk Manager. SuperSU and it's accompanying app is a whole different root solution (that has been sold by @Chainfire and seemingly abandoned by it's new owners).
Magisk usually takes care of dm-verity itself, so there shouldn't be any need for an extra no-verity zip. Sometimes it is needed, but I would skip it until you've tried using Magisk only. If you don't know, dm-verity is used by Android to determine if your device has been tampered with. If you wan't to root your device (tampering), you usually have to disable dm-verity or the device won't boot at all.
If you want root with Magisk, do your list again, but skip step 10 and 11. If it doesn't boot after that, go back to TWRP and flash the no-verity zip.

Didgeridoohan said:
The root management app for Magisk/MagiskSU is the Magisk Manager. SuperSU and it's accompanying app is a whole different root solution (that has been sold by @Chainfire and seemingly abandoned by it's new owners).
Magisk usually takes care of dm-verity itself, so there shouldn't be any need for an extra no-verity zip. Sometimes it is needed, but I would skip it until you've tried using Magisk only. If you don't know, dm-verity is used by Android to determine if your device has been tampered with. If you wan't to root your device (tampering), you usually have to disable dm-verity or the device won't boot at all.
If you want root with Magisk, do your list again, but skip step 10 and 11. If it doesn't boot after that, go back to TWRP and flash the no-verity zip.
Click to expand...
Click to collapse
I just repeated all the procedure, this time just with Magisk, like you said. its installation finished without any error.
I just tryed ROOT Checker, any I finally have the root on my fone!! Thanx you very much for the support, and the explanation.
Can I use Backup/Restoration with TWRP knowing that I rooted with Magisk??

saoudien07 said:
I just repeated all the procedure, this time just with Magisk, like you said. its installation finished without any error.
I just tryed ROOT Checker, any I finally have the root on my fone!! Thanx you very much for the support, and the explanation.
Can I use Backup/Restoration with TWRP knowing that I rooted with Magisk??
Click to expand...
Click to collapse
Great to hear! :good:
You can use TWRP without any issues. Magisk has no impact on it and TWRP has it's own su.

Didgeridoohan said:
Great to hear! :good:
You can use TWRP without any issues. Magisk has no impact on it and TWRP has it's own su.
Click to expand...
Click to collapse
Thx you one more time. Going to install some of my app and configure my new fone then do a backup, for a clean restoration in some months...

I have a problem for the Backup with TWRP. When I want to do a Backup, I get this msg:
failed to mount /data (Invalid argument)
I ve looked on google to fix it, the solution I found is to change data to ext2, then back to ext4.
The pb is that it is removing everything from my phone?
Anyone is having the same issue??

Didgeridoohan said:
Your issue is that the boot image still is patched by SuperSU. Until you restore the stock boot image you won't be able to install Magisk.
https://www.didgeridoohan.com/magisk/Magisk#hn_Boot_image_patched_by_other_programs
Edit: I don't do Samsung, but from what I remember, you might need to flash AP (or something like that).
Click to expand...
Click to collapse
Hi, i am rooting samsung a5 a520w. I am following the steps in the instructions (https://forum.xda-developers.com/sa...w-to/guide-root-install-twrp-samsung-t3747535).
Now I met a problem like this:
! Boot image patched by other programs!
! Please restore stock boot image
Updater process ended with ERROR:1
Error installing zip file '/sdcard/MagiskManager/Magisk-v17.1.zip'
I have no idea where is the boot.img located. All documents in the external card is:
RMM-State_Bypass;
no-verity-opt-encrypt-6.0;
Magisk_17.1

@imcn001 Your answer is in the link from the post you quoted.

[CLOSED][DEV] Magisk Canary Channel - Bleeding Edge Builds

Canary Magisk Manager: Link
Canary Magisk Manager (Debug): Link
Latest Release Notes: Link
All Canary Files: Link​
The Canary Builds are similar to Google Chrome's: bleeding edge of the source.
Be warned: Canary can be unstable.
The binaries from debug channel are built with debug flag ON
Install Canary Magisk Manager and go to Settings > Update Channel and switch to either Canary or Canary (Debug)
If you need a clean start, download the Canary Uninstaller to uninstall any version of Magisk
How to Report:
Only report bugs/logs using the debug channel!!
Magisk installation failure:
In TWRP: Upload the recovery logs (pull the file /tmp/recovery.log, or select "Advanced > Copy Log" and upload)
In MagiskManager: Choose to save logs after installation and upload
Magisk bugs:
Magisk logs are placed in /cache/magisk.log (For A/B devices, they are actually in /data/cache/magisk.log)
If you cannot boot or stuck in bootloops, grab logcats (and kernel dmesg if possible) on boot
Magisk Manager bugs:
Grab logcat (NOT magisk logs) when the crash occurs, upload the logs and report how to reproduce
SafetyNet / CTS / XXX app won't work after enabling MagiskHide:
Ignored

I just installed this on one of my Nextbook Ares 8A's, x86, Android 6.0.1. It was previously on @ianmacd 's unofficial build. So far, it appears to be working great. I un-installed my previous MM, before I install the new one, downloaded the Magisk.zip in MM and flashed it through TWRP.
How much overhead does the extra logging create? I don't notice any difference. Do you think it will affect battery life?
When I check the magisk.log it does appear that it is continuously logging, because each time I check it the time stamp is updated.
If I am not mistaken, on non debug builds the magisk.log is only created at boot and not updated again until next boot?
Thanks, @topjohnwu for creating this new channel for testers.

Wew, downloading and testing on my 7.1.2, so far so good. Thanks.

Aye official snapshots! Awesome. Been using @kantjers up until now. Thanks for this
Sent from my LG Nexus 5X using XDA Labs

Testing now. Thanks ?
No issues with any of my used modules ?

When patching boot image as install method you should check for storage permission first.
Currently if storage permission hasn't been granted the patch will fail at the very end (when it goes to write the patched image to internal storage), with no indication as to why. The error will just state that it failed.

jcmm11 said:
When patching boot image as install method you should check for storage permission first.
Currently if storage permission hasn't been granted the patch will fail at the very end (when it goes to write the patched image to internal storage), with no indication as to why. The error will just state that it failed.
Click to expand...
Click to collapse
Yes, I think Magisk Manager should ask for the storage permission on first launch and not later when the actual storage permission is need. I have been bit by the storage permission a few time in other instances of using MM.
Good find @jcmm11 , I have not used that option to patch the boot.img.

Any way to fix the phone off charging issue? To recap. When phone is powered of and plugged in. The charging battery icon.stays on and freezes the screen. Only hard reboot gets phone started.

New Canary Build up for Testing!
Support bypassing FGO, CrackProof protections, and Fortnite!
jcmm11 said:
When patching boot image as install method you should check for storage permission first.
Currently if storage permission hasn't been granted the patch will fail at the very end (when it goes to write the patched image to internal storage), with no indication as to why. The error will just state that it failed.
Click to expand...
Click to collapse
This issue is resolved, thank you for your report!
def-g said:
Any way to fix the phone off charging issue? To recap. When phone is powered of and plugged in. The charging battery icon.stays on and freezes the screen. Only hard reboot gets phone started.
Click to expand...
Click to collapse
I'm aware of this issue, will try to figure out the cause of the issue

topjohnwu said:
New Canary Build up for Testing!
Support bypassing FGO, CrackProof protections, and Fortnite!
This issue is resolved, thank you for your report!
I'm aware of this issue, will try to figure out the cause of the issue
Click to expand...
Click to collapse
Cool. To be honest, only a minor inconvenience. Your work is greatly appreciated.

I just installed this build and it appears to be fine on my device. The logcat was taken in Logcatx using the per app logcat for Magisk Manager. If you would like a full system logcat, let me know, or if you would like any other info such as last_kmsg or dmsg, let me know.
I have been installing through TWRP, since recently I have twice experienced data corruption issues with the direct install method in unofficial builds, noted in the unofficial thread.
As always, Thanks

Hi, after fullwipe the MM is not installed on first Phone start? Is this a Bug?
I use a S7 Edge with SM 2.8.
Please Help.

BustedFly said:
Hi, after fullwipe the MM is not installed on first Phone start? Is this a Bug?
I use a S7 Edge with SM 2.8.
Please Help.
Click to expand...
Click to collapse
I suggest you download MM from here and try to install it. I have been flashing Unofficial builds of Magisk for some time and this appears to be a common issue. It should not happen if you did a full wipe of the ROM though.
The latest Canary Magisk Manager.apk download:
https://github.com/topjohnwu/magisk_files/blob/master/canary_builds/app-full-debug.apk
Direct download for all of the latest Canary builds:
https://github.com/topjohnwu/magisk_files/tree/master/canary_builds

Thx.
I try a few build... Offi and unoffi.... The only one without this Bug ist the builds from kantjer. All other cant install the MM after a fullwipe. I try this many times

BustedFly said:
Thx.
I try a few build... Offi and unoffi.... The only one without this Bug ist the builds from kantjer. All other cant install the MM after a fullwipe. I try this many times
Click to expand...
Click to collapse
By fullwipe, I presume you mean full wipe of the ROM? If not, you must remove the Magisk Manager of the unofficial build before installing this one, as it is signed with a different key.

Yes.. I mean fullwipe by twrp and clean Installation of the Rom

BustedFly said:
Yes.. I mean fullwipe by twrp and clean Installation of the Rom
Click to expand...
Click to collapse
After flashing Magisk and rebooting, the app-full-debug.apk will not install? That is a strange issue. Maybe someone else can help.
On one device with @kantjer 's latest build, I first un-installed his Magisk Manager, installed the app-full-debug.apk, opened it, set up the custom update channel to the link in the op: https://bit.ly/2MPKGY5 and hit install, download Zip only, then rebooted to TWRP and installed that downloaded Magisk.zip and rebooted to a working Magisk install.

Hey @topjohnwu,
I've noticed a line just after rebooting using the Canary:
Code:
09-09 14:34:38.542 3913 3913 D Magisk : resetprop: decode with protobuf from [/data/property/persistent_properties]
09-09 14:34:38.542 3913 3913 D Magisk : resetprop: prop [persist.magisk.hide] does not exist
I'm not sure if it's important or not for magisk functionality, however I wanted to report it just in case something is off.
I'm using OnePlus 6 with Open Beta 2 (Pie, 9.0).

I'm going to make it my duty to delete any and all posts that are not relevent to what the developer wants or is asking for.
I'll be checking this thread daily from here on out. If I find myself deleting a ton of any reoccurring member's posts, I'll be escalating to consequences.
Please, thoroughly give your posts some thought prior to submitting them, and ask yourself if whether or not it fits into how or what the OP is asking.
Thank you

So, tried last canary, nothing critical to report apart that FGO doesn't work (it crashes like before with error 61), here there are both magisk log and catlog.
Catlog (too big for xda, dunno why): https://mega.nz/#!LUoBQY6L!X--KKkCCzQn4SLwaIX1hYsmrKzzNfx1TTSGCh1b-0E4
Magisk log attached.
OnePlus 6 OOS 5.1.11, 8.1 July Patch
If anything else is needed I'll provide it right away