Database Develop

[BUG] Magisk refuses to install modules from repo (The zip is not a Magisk Module!)

I've had magisk installed since version 6, I've published some magisk modules already and never had a problem until today.
After a full clean reinstall of Nougat NBD90Z (with wipe) on my Nexus 6 and then flashing Magisk, phh's superuser for magisk, installing phh's superuser apk from play store and magisk manager apk I stumbled upon a previously reported (without details) bug where magisk manager would refuse to install modules from repo claiming they are not magisk modules.
I've struggled trying everything I could including the full wipe (more details here: http://forum.xda-developers.com/apps/magisk/module-app-systemizer-t3477512/69230448#69230448) and bounced some ideas off @pnwsr6 who's had the similar problem on Nexus 6 device.
I've achieved a partially working Magisk Manager (manual installs of ZIP files work, but installs from repo still fail) and here's the list of steps which lead to me having semi-working magisk manager again:
1. I flashed ZIP files of some modules in twrp (I'm attaching App Systemizer and Nexus 6 LED Enabler which I flashed)
2. After the phone booted up I saw the modules active and working
3. Within Magisk Manager I then added the ZIP file of the phh's superuser module from that thread (http://forum.xda-developers.com/attachment.php?attachmentid=3893967&d=1475554052)
4. Now at least manual installation of modules within Magisk Manager are working fine.
@topjohnwu -- I've enabled verbose logging and extra logging for bash commands, but I'm still not seeing anything in the log on top of the regular output.

Created an issue against Magisk Manager so it's easier to track for developers: https://github.com/topjohnwu/MagiskManager/issues/20

Looks like that even after flashing some modules in twrp, Magisk Manager only allows to install from zip only exactly the same ZIP I've already flashed (even a minor change and bump of versionCode results in "This ZIP is not a Magisk Module!"). So it might be an issue of Magisk Manager being unable to write to /magisk despite having storage permission and being granted root access.

Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!

I've seen this error as well on my Nexus 6 NBD90Z with Magisk v8. Started with v7 after some heavy modification on my part .
I was sometimes able to fix it by simply extracting the zip and then Magisk Manager would somehow recognize it as a module.. Other times I could extract the zip and then re-archive the contents and Magisk Manager would recognize that as a module. Weird, but doable.

stangri said:
Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!
Click to expand...
Click to collapse
I probably won't try again until next update, and hope the wipe just wasn't clearing something. I have the zip installed through twrp and working for now so I'm good till then.

just wondering if you're still having this issue with v9? I had modules installed fine under v6, but never really installed any modules under v8 to see if this problem occurred for me. now that I'm on v9, which has been wiped clean to start, I can no longer install any modules via Downloads or in the Modules section... any suggestions?

I have the same issue when trying to install viper with v9 on Nexus 6P DP2
Skickat från min Nexus 6P via Tapatalk

Same here. Find a fix ?

From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.

stangri said:
From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.
Click to expand...
Click to collapse
Just an FYI, I do still have this problem, but can install the zip through twrp. Maybe 10 will be the solution.

I had the same problem, I cleared magisk manager data and it works fine now

Didn't help
Sent from my SM-G532F using Tapatalk

I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.

stangri said:
I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.
Click to expand...
Click to collapse
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.

Meowdib said:
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.
Click to expand...
Click to collapse
Weird, do you have the same problem with magisk manager 161223?

stangri said:
Weird, do you have the same problem with magisk manager 161223?
Click to expand...
Click to collapse
Same

I need a Help to download modules using magisk
Lastest version, Included phh root, manager is from G. play,
But Modules download function is not working
Say "No modules found" for download to install via magisk.

How to use Magisk??? (add lost txt)

Hi to all
I have rooted OP3T and every time when I install new update, BETA small or full version zip file, I need again to install stock.zip from boatloader , then again, install TWRP and Super Su.
I hear that with Magisk I can easy install any update without lost TWRP and Root. I have flash Magisk and install from Google Store Magisk Manager.
So my question is how to install new update with Magisk and dont lost TWRP and Root?
Please tell me step by step
thx a lot for your answers

Magisk doesn't touch the recovery. And you'll still have to flash the Magisk zip since the boot image is updated whenever you update your system (Magisk modifies the boot image).
What does stay after an update (as long as you don't wipe /data) is any Magisk modules that you have installed. If you have a bunch of modules that change build.prop values, debloat system apps, change screen density, replaces system UI sounds, etc, you won't have to do those changes again after an update. They are found in the Magisk image in /data and will be loaded by Magisk at boot.
Even if you've wiped /data, it's just a matter of flashing the Magisk and module zips in TWRP after updating your system. No tedious manual editing of build.prop or deleting apps, etc. It literally takes seconds...
If you have issues with loosing TWRP after an update, you can easily fix that, right after updating. Just keep a copy of the recovery image on your device and flash it in TWRP.

Some modules install without errors, but do nothing

So i recently decided to try out some of the different roms that were released for the moto e4. I decided to go back to Resurrection Remix, and when i tried to install the modules I had been using, found that some of them weren't working properly. There are no errors when they install, but seem to have no effect, such as the volume step increase, or the injected youtube background player...
other modules, like the app systemizer seem to be working just fine...

HigherStateD said:
So i recently decided to try out some of the different roms that were released for the moto e4. I decided to go back to Resurrection Remix, and when i tried to install the modules I had been using, found that some of them weren't working properly. There are no errors when they install, but seem to have no effect, such as the volume step increase, or the injected youtube background player...
other modules, like the app systemizer seem to be working just fine...
Click to expand...
Click to collapse
Did you do a clean install? (Completely wipe data and not restore it again in twrp). Some ROMs have trouble with some modules. Get logs and ask in the modules threads (the ones not working).

Clean install, full wipe, same as before, modules worked fine last install on the same rom, restore failed to boot, which is why I needed to reinstall the previously working modules

HigherStateD said:
Clean install, full wipe, same as before, modules worked fine last install on the same rom, restore failed to boot, which is why I needed to reinstall the previously working modules
Click to expand...
Click to collapse
I had a similar-ish problem on Moto g4 plus RRO.... If you still can't get it to work, here's what I did:
Rom, gapps, boot (usual steps)
Download Magisk APK from XDA
Give it storage permissions
From Magisk Manager, select install
It should ask of you want to direct patch (recommended)- select this option
Reboot and try modules again
I think it's something to do with storage permissions etc. When Magisk tries to patch boot IMG. Check your file systems too. Data partition should be fsfs and all others ext4.
If the steps above don't work try the fsfs Magisk loopback module. It's in the repo and mentions some of the Moto devices having issues with with patching boot img etc for Magisk. The module is installed via TWRP.
:good:

Got it working, somewhat similar process, ROM, gapps, MM apk, then uninstalled the magisk that came built into the ROM, and used the manager installer... Then encrypted, and then opt-enceypt... A script in sbin for my fingerprint from the original ROM and got safetynet passing.

Android 4.2 and 4.4 Mediatek bootloop after installing Magisk 18.1

Hello everybody.
I've read that 18.1 supports 4.2+ so I've tried to install in two MTK6589T devices I've. One running 4.2, the other running 4.4
CMW/TWRP gave an error mounting system, so I mounted system manually and it started flashing. Firstly it detected old root installed and disabled the old root. But when it tried to find the boot, installation was aborted because installator claims cannot find the boot on both phones.
Then I though, okay, lets reboot back to android, I will try to install a few days later, maybe its buggy now, but both phones cannot boot.
I can easily fix them by flashing rom again I guess, but I would like to know where's the issue and also post it for more people could face the same problem.
Any idea where's the problem/how to fix without rom reflashing? I've tried magisk uninstaller but after mounting system in recovery it is also giving error.
Thanks
UPDATE: For now, if no other solution is found, bootloop can be bypassed by dirty installing the rom again. But it has to be an easier workaround...
We know now that the problem is caused because of two factors merging:
1- Using Magisk.zip installer through custom recovery
2-In the case that the custom recovery CMW/TWRP installed in the phone is very old (for instance, CMW automade for MTK6589X or TWRP 2.5.0).
While installing, Magisk tries to send commands to the custom recovery that cant be understood by it, leaving the installation incomplete after some modifications in /system (read below recovery log).
Acording to the recovery, it seems that Magisk did some modifications without running correctly survival script - Adding addon.d survival script ("Unrecognized option '-Xnodex2oat'") and .zip installer is not designed to revert actions in this case.
Also, Magisk couldn't reach the boot modification step, so boot is not damaged, therefore workarounds for restoring boot won't work.
Using Magisk Unistaller.zip is also not possible as the uninstaller is mainly designed for boot backup restoration, and again, this is not the case.
Currently needed: Find what's wrong in system due to the incomplete Magisk installation to revert it back to the original state (before faulty magisk.zip installation).
Recovery log:
************************
* Magisk v18.1 Installer
************************
- Mounting /system, /vendor
- Target image: /dev/bootimg
- Device platform: arm
- Removing system installed root
- Constructing environment
- Adding addon.d survival script
Unrecognized option '-Xnodex2oat'

up!

I' also having the same problem. My Samsung J2 Prime stuck at logo after updating to 18.1. Any tips on how to fix it without resetting my phone? Thanks.
Update: Bootloop fixed. I used TWRP to restore boot image. I then update Magisk by flashing zip file from TWRP. Everything went back to normal. Hope this help.

trol_sg said:
Hello everybody.
I've read that 18.1 supports 4.2+ so I've tried to install in two MTK6589T devices I've. One running 4.2, the other running 4.4
CMW/TWRP gave an error mounting system, so I mounted system manually and it started flashing. Firstly it detected old root installed and disabled the old root. But when it tried to find the boot, installation was aborted because installator claims cannot find the boot on both phones.
Then I though, okay, lets reboot back to android, I will try to install a few days later, maybe its buggy now, but both phones cannot boot.
I can easily fix them by flashing rom again I guess, but I would like to know where's the issue and also post it for more people could face the same problem.
Any idea where's the problem/how to fix without rom reflashing? I've tried magisk uninstaller but after mounting system in recovery it is also giving error.
Thanks
Click to expand...
Click to collapse
If you have a backup of your boot image, you can just restore it using TWRP. But in case that you have no backup of boot image, you can try to get boot image from the internet and restoring using it. In my case, this is what I did.
1. Go to TWRP and then make backup of boot image of the faulty phone*. (Folder 1)
2. I used another J2 prime to create a boot image backup. (Folder 2)
3. Once that is done, copy and replace the files inside the Folder 2 into Folder 1.
4. Reboot to TWRP again then use that to restore the boot image on my stuck J2.
Tips: make backup in SD card so you can easily swap it in between the bad and good phone.
*This is to create a folder of the backup file. I did tried to directly copy and paste the backup boot image file from another good phone but TWRP didn't detect it. So this is the workaround that I come with. And it worked for me.

Thanks for your answer but I doubt your case is mine. Your device is much newer than mine and according to your comment, you've sucesfully installed previous version of Magisk without issues. This is not a problem while updating, as Magisk v. earlier than 18.1 was not compatible with android 4.2+. I think Magisk is not compatible with MT6589T even if they run 4.2 or 4.4.
I think that it cannot be a boot problem as TWRP/CWM displayed msg 'Boot cannot be found' while installing Magisk, so that I don't think boot was replaced or modified in any ways. Moreover, the bootloop is not in the boot loading, as phone can pass boot image without any problem, but it is stuck in android loading image. I'm thinking in some script or root modification that Magisk did before trying to unpack the boot, however I'm not that deep into the Magisk install to find the proper workaround.
I can restore boot backup and also I can take boot file from the original rom and flash, because in Mediatek-based devices, boot.img is inside de zip, but I dont think it will solve the problem. Anyhow I'll get back ASAP with the answer.
Any more ideas??

Nothing, boot/uboot restoration or flashing again just the boot won't fix the problem, so it's something that Magisk installator touch in /system or /data I guess, but what?

trol_sg said:
Nothing, boot/uboot restoration or flashing again just the boot won't fix the problem, so it's something that Magisk installator touch in /system or /data I guess, but what?
Click to expand...
Click to collapse
Have you read/tried this?
didgeridoohan(dot)com/magisk/MagiskIssues

Ato09 said:
Have you read/tried this?
didgeridoohan(dot)com/magisk/MagiskIssues
Click to expand...
Click to collapse
Yes, I've read them before I made the post. I've also looked for a solution in some of the threads and using search, but couldn't find a way.

Here I attach recovery.log if someone is interested to see the detailed problem.
Also, here below I attach the lines concerning the installation. All other is uninstallation tries and so on:
************************
* Magisk v18.1 Installer
************************
- Mounting /system, /vendor
- Target image: /dev/bootimg
- Device platform: arm
- Removing system installed root
- Constructing environment
- Adding addon.d survival script
Unrecognized option '-Xnodex2oat'
dalvikvm: [options] class [argument ...]
dalvikvm: [options] -jar file.jar [argument ...]
The following standard options are recognized:
-classpath classpath
-Dproperty=value
-verbose:tag ('gc', 'jni', or 'class')
-ea[:<package name>... |:<class name>]
-da[:<package name>... |:<class name>]
(-enableassertions, -disableassertions)
-esa
-dsa
(-enablesystemassertions, -disablesystemassertions)
-showversion
-help
The following extended options are recognized:
-Xrunjdwp:<options>
-Xbootclasspath:bootclasspath
-Xcheck:tag (e.g. 'jni')
-XmsN (min heap, must be multiple of 1K, >= 1MB)
-XmxN (max heap, must be multiple of 1K, >= 2MB)
-XssN (stack size, >= 1KB, <= 256KB)
-Xverify:{none,remote,all}
-Xrs
-Xint (extended to accept 'ortable', ':fast' and ':jit')
These are unique to Dalvik:
-Xzygote
-Xdexopt:{none,verified,all,full}
-Xnoquithandler
-Xjniopts:{warnonly,forcecopy}
-Xjnitrace:substring (eg NativeClass or nativeMethod)
-Xstacktracefile:<filename>
-Xgc:[no]precise
-Xgc:[no]preverify
-Xgc:[no]postverify
-Xgc:[no]concurrent
-Xgc:[no]verifycardtable
-XX:+DisableExplicitGC
-X[no]genregmap
-Xverifyopt:[no]checkmon
-Xcheckdexsum
-Xincludeselectedop
-Xjitop:hexopvalue[-endvalue][,hexopvalue[-endvalue]]*
-Xincludeselectedmethod
-Xjitthreshold:decimalvalue
-Xjitcodecachesize:decimalvalueofkbytes
-Xjitblocking
-Xjitmethod:signature[,signature]* (eg Ljava/lang/String\;replace)
-Xjitclass:classname[,classname]*
-Xjitoffsetffset[,offset]
-Xjitconfig:filename
-Xjitcheckcg
-Xjitverbose
-Xjitprofile
-Xjitdisableopt
-Xjitsuspendpoll
Configured with: debugger profiler hprof jit(armv7-a-neon) smp show_exception=1
Failed to initialize runtime (check log for details)
- Unpacking boot image
MagiskBoot v18.1(18100) (by topjohnwu) - Boot Image Modification Tool
Parsing boot image: [/dev/bootimg]
No boot image magic found!
! Unable to unpack boot image
- Unmounting partitions
E:Error executing updater binary in zip '/sdcard/Magisk-v18.1.zip'
Error flashing zip '/sdcard/Magisk-v18.1.zip'

@trol_sg I'm gonna guess it's got to do with the absolutely ancient TWRP you're using. It just can't handle everything that the Magisk installation script is trying to do...
Your best bet (if Magisk will work at all on your device) is to patch the boot image with the Magisk Manager and then flash the patched image manually. There are new and shiny installation instructions available here: https://topjohnwu.github.io/Magisk/

Didgeridoohan said:
@trol_sg I'm gonna guess it's got to do with the absolutely ancient TWRP you're using. It just can't handle everything that the Magisk installation script is trying to do...
Your best bet (if Magisk will work at all on your device) is to patch the boot image with the Magisk Manager and then flash the patched image manually. There are new and shiny installation instructions available here: https://topjohnwu.github.io/Magisk/
Click to expand...
Click to collapse
Thank you so much for your answer. So it's the recovery, but can't find newer ones, sadly. Too old phones I know, but just curious if I could make Magisk working on them, lol.
I was going into the boot modification manually right now, but in order to patch the boot I need manager installed first, and phone couldn't boot so I did dirty flash of the rom to be able to boot into it again.
Lets see what happens then. I'll be right back.
Anyhow, this is not a solution to fix the problem of bootloop that I am requesting help in case someone could face the same and did not make a backup of the phone and didn't want to make dirty re-flash. Any idea?
Update: After I did dirty flash of the rom, and now Jiayu g3s android 4.4 booted.

UPDATE: So, after patching manually boot and installing (using restore in TWRP 2.5 as image flash is not yet implemented AFAIK), phone booted and yes Magisk is working.
Magisk installation .zip through a very old recovery is making the bootloop. So that, a thing learnt now.
But, for other people facing this bootloop, can we do a research to find what magisk.zip did to the phones to leave them in bootloop? Maybe we can revert without rom flashing easily if we knew what's the issue...
Thanks in advance!

Doing a bit more tests I found that magisk.zip did something in /system so that it is left in bootloop, but still no idea why/whats causing that...

There are delay complete boot like 4 5 second in j7 prime. I didn't love this version

any more help?? up!!

trol_sg said:
Yes, I've read them before I made the post. I've also looked for a solution in some of the threads and using search, but couldn't find a way.
Click to expand...
Click to collapse
Try this.
Quote:
Originally Posted by void74
I faced this problem too this morning.
I have a Redmi Note 5 with AOSiP ROM, I don't know if it's the right way to do it, but I solved the bootloop problem this way:
- volume up and then boot to TWRP
- copied magisk uninstall to phone memory
- installed magisk uninstall
- rebooted in fastboot/bootloader mode
- flashed original boot.img extracted from stock image zip file ("fastboot flash boot boot.img")
- rebooted to TWRP
- installed magisk 17.0 zip file
- rebooted to system, all OK!
Only problem is that I lost previous magisk configuration, but it's a snap to reconfigure it!
Quote:
Originally Posted by Mangraviti
Here is what to do, if you HAVE NOT installed the new version:
1) Do not update via Magisk Manager.
2) Do not update via TWRP using the zip you can download via Magisk Manager.
3) Uninstall Magisk using Magisk uninstaller (ZIP).
4) Boot to Android.
5) Reboot to TWRP
6) Install V17 ZIP via TWRP and boot to Android.
If you HAVE INSTALLED and got a bootloop:
1) Download the uninstaller ZIP.
2) Enter TWRP during the bootloop.
3) Uninstall using the uninstaller ZIP.
4) Boot to Android.
5) Download V17.
6) Reboot to TWRP and flash the V17.
7) Boot to Android it it should be working.
-------------
Original post. https://forum.xda-developers.com/apps/magisk/bootloop-magisk-update-t3836904
Hope it help.

Ato09 said:
Try this.
Quote:
Originally Posted by void74
I faced this problem too this morning.
I have a Redmi Note 5 with AOSiP ROM, I don't know if it's the right way to do it, but I solved the bootloop problem this way:
- volume up and then boot to TWRP
- copied magisk uninstall to phone memory
- installed magisk uninstall
- rebooted in fastboot/bootloader mode
- flashed original boot.img extracted from stock image zip file ("fastboot flash boot boot.img")
- rebooted to TWRP
- installed magisk 17.0 zip file
- rebooted to system, all OK!
Only problem is that I lost previous magisk configuration, but it's a snap to reconfigure it!
Quote:
Originally Posted by Mangraviti
Here is what to do, if you HAVE NOT installed the new version:
1) Do not update via Magisk Manager.
2) Do not update via TWRP using the zip you can download via Magisk Manager.
3) Uninstall Magisk using Magisk uninstaller (ZIP).
4) Boot to Android.
5) Reboot to TWRP
6) Install V17 ZIP via TWRP and boot to Android.
If you HAVE INSTALLED and got a bootloop:
1) Download the uninstaller ZIP.
2) Enter TWRP during the bootloop.
3) Uninstall using the uninstaller ZIP.
4) Boot to Android.
5) Download V17.
6) Reboot to TWRP and flash the V17.
7) Boot to Android it it should be working.
-------------
Original post. https://forum.xda-developers.com/apps/magisk/bootloop-magisk-update-t3836904
Hope it help.
Click to expand...
Click to collapse
Hello, thanks
This method won't work in my case as in the step:
- installed magisk uninstall = gives error
Note 5 is much newer phone with a recent recovery TWRP that allows all Magisk.zips commands, but unluckyly not this case.
Also, this method is for wrong boot installation/damaged boot. In my case what Magisk damage is /system, not boot.
I wish it could be boot, because that is very easy to fix (flashing through fastboot/SP Flash tools in the case of MTK, recovering boot twrp "backup" even if you didn't make backup...) as you mentioned.
Hope someone have a great idea to revert system to origin, then we could post the solution for those who would like to install Magisk in 4.2+ old phones, and instead of doing boot flash manually, they try to flash magisk.zip and they got bootloop.

Main post updated with all thread information. Up!

Nothing?? Up!!

trol_sg said:
Hope someone have a great idea to revert system to origin, then we could post the solution for those who would like to install Magisk in 4.2+ old phones, and instead of doing boot flash manually, they try to flash magisk.zip and they got bootloop.
Click to expand...
Click to collapse
The only part of the Magisk installation that actually touches /system is if it installs the addon.d survival script. The log you posted earlier shows that it's trying to do this, for some reason, and failiing. I'd start looking there...

Update lineageos OTA update and keep root access.

Hi
I installed LineageOS 20 on OnePlus 9 with the instructions on official wiki. Then I root my phone with Magisk. I install Magisk by sideloading the Magisk ZIP file and then install the apk as it's been explained in this video. Now I can't update the OS with updater in system settings. I find this guide that explained I need to uninstall and restore images in magisk then update my phone and reinsatall magisk before reboot. But magisk didn't create a backup during installation.
I followed this instructions to fix magisk stock backup does not exist
I create a backup with this guide and lineageos boot.img file and I can now restore images in magisk but I get the same error when trying to install the updates. I noticed that there is also dtbo in backup function and I did the same thing for backing up dtbo.img and it doesn't solve the problem. Is there anything I'm missimg. Should I use vendor-boot.img instead of boot.img?

mtuxz said:
Hi
I installed LineageOS 20 on OnePlus 9 with the instructions on official wiki. Then I root my phone with Magisk. I install Magisk by sideloading the Magisk ZIP file and then install the apk as it's been explained in this video. Now I can't update the OS with updater in system settings. I find this guide that explained I need to uninstall and restore images in magisk then update my phone and reinsatall magisk before reboot. But magisk didn't create a backup during installation.
I followed this instructions to fix magisk stock backup does not exist
I create a backup with this guide and lineageos boot.img file and I can now restore images in magisk but I get the same error when trying to install the updates. I noticed that there is also dtbo in backup function and I did the same thing for backing up dtbo.img and it doesn't solve the problem. Is there anything I'm missimg. Should I use vendor-boot.img instead of boot.img?
Click to expand...
Click to collapse
I just learned that Magisk doesn't work after an OTA update. What I do is I normally update, uninstall Magisk, boot into Lineage Recovery, sideload the Magisk .zip file via ADB, reboot, and finish setting up Magisk through the app. There are other ways to do this, but this method works well and doesn't need anything special. Works for me!
Alteratively, look here.

mtuxz said:
Hi
I installed LineageOS 20 on OnePlus 9 with the instructions on official wiki. Then I root my phone with Magisk. I install Magisk by sideloading the Magisk ZIP file and then install the apk as it's been explained in this video. Now I can't update the OS with updater in system settings. I find this guide that explained I need to uninstall and restore images in magisk then update my phone and reinsatall magisk before reboot. But magisk didn't create a backup during installation.
I followed this instructions to fix magisk stock backup does not exist
I create a backup with this guide and lineageos boot.img file and I can now restore images in magisk but I get the same error when trying to install the updates. I noticed that there is also dtbo in backup function and I did the same thing for backing up dtbo.img and it doesn't solve the problem. Is there anything I'm missimg. Should I use vendor-boot.img instead of boot.img?
Click to expand...
Click to collapse
ethical_haquer said:
I just learned that Magisk doesn't work after an OTA update. What I do is I normally update, uninstall Magisk, boot into Lineage Recovery, sideload the Magisk .zip file via ADB, reboot, and finish setting up Magisk through the app. There are other ways to do this, but this method works well and doesn't need anything special. Works for me!
Alteratively, look here.
Click to expand...
Click to collapse
I was exactly looking for this for my SM-T290, which also runs LineageOS 20. I think it is the most easy to deinstall Magisk root from the Magisk Manager, apply the update and then reinstall it. I think this also works with TWRP???

Minionguyjpro said:
I was exactly looking for this for my SM-T290, which also runs LineageOS 20. I think it is the most easy to deinstall Magisk root from the Magisk Manager, apply the update and then reinstall it. I think this also works with TWRP???
Click to expand...
Click to collapse
I'm installing an update right now. I would imagine it works with TWRP as well, but I only recently started using it.

I realize that this may be a late reply, however, there is no need to do any of these convoluted processes.
Here is what I do, flash the Magisk as a .zip in Lineage recovery once and set everything up. Once the Magisk install is working you can apply OTA updates normally without Magisk and root being removed. On my OnePlus 7 Pro which is an A/B device I just install the OTA and hit reboot with Magisk seamlessly persisting and nothing else being required to preserve or reinstall it. The reason that this works is because the Magisk.zip installs an addons.d script which automatically runs after OTA updates and takes care of Magisk for you.
I installed many Lineage OS 20 OTAs and I never had to touch Magisk at all, it is always installed and working with no intervention whatsoever. Keep in mind that this will only work on A/B devices with Lineage recovery (which you should all be using anyway).

droidman1992 said:
I realize that this may be a late reply, however, there is no need to do any of these convoluted processes.
Here is what I do, flash the Magisk as a .zip in Lineage recovery once and set everything up. Once the Magisk install is working you can apply OTA updates normally without Magisk and root being removed. On my OnePlus 7 Pro which is an A/B device I just install the OTA and hit reboot with Magisk seamlessly persisting and nothing else being required to preserve or reinstall it. The reason that this works is because the Magisk.zip installs an addons.d script which automatically runs after OTA updates and takes care of Magisk for you.
I installed many Lineage OS 20 OTAs and I never had to touch Magisk at all, it is always installed and working with no intervention whatsoever. Keep in mind that this will only work on A/B devices with Lineage recovery (which you should all be using anyway).
Click to expand...
Click to collapse
Well, I came to the fact I have a problem with TWRP. It uses OpenRecoveryScript for OTA updates and should also run addon.d scripts after it (Magisk uses this to survive an OTA). The only problem is that the scripts should run after the OTA flash, but for me, it doesn't. So I need to manually reflash Magisk and Gapps after installing an update. My data is encrypted, but I edited the addon.d script to flash the ZIP from the external SD card.