Making a magisk module - Magisk

Hello, I've been using a camera mod on my phone for a while now and I switched to magisk a couple weeks ago
I need some help to convert the flashable zip into a magisk module but i dont know how
If anyone is willing to help I would really appreciate it

I don't have an opportunity to help with that, but start here:
https://github.com/topjohnwu/Magisk/blob/master/docs/modules.md
It's quite easy to make a Magisk module... Just follow the instructions above, and the ones you'll find in the module template.

Can you repeat the tutorial on how to make modules?

You'll find the link to the new documentation in the release thread or on the Magisk GitHub.

Related

[UNOFFICIAL] next version Magisk and MagiskManager snapshots

MOD EDIT: PLEASE MIGRATE TO THE OFFICIAL CANARY BUILDS
THIS THREAD IS ABOUT UNOFFICIAL COMMUNITY BUILDS. OFFICIAL BETAS THREAD IS HERE: https://forum.xda-developers.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589.
This thread is dedicated to the community-built next versions of Magisk and MagiskManager using latest source files posted by @topjohnwu. If you want to contribute in any way -- create a PR/issue on github.
These might be very unstable builds, especially in the early stages of development. You're highly advised to read the rest of this post and at least a few last pages of the discussion.
Downloads are here: https://github.com/TheComputerGuy96/MagiskFiles. Keep reading if this is your first visit to this thread or for the updates at the bottom of this post.
Current builds are courtesy of @kantjer. This project wouldn't have happened without @Deic's module to track the snapshot updates (which may be hindered by recent @topjohnwu changes in versioning) and his contributions to the build script, as well as major contributions in supporting fellow community members by @Captain_Throwback, @Didgeridoohan and @DodoGTA.
Installation:
Magisk: flash magisk snapshot from recovery, it should install over any previous version just fine.
Magisk Manager: The snapshot APK is signed with a different key than the release APK so you can't install snapshot magisk manager over magisk manager from Play Store. You will need to uninstall existing Magisk Manager and install the snapshot APK afterwards.
Commits Logs:
Magisk (master branch)
Magisk Manager (master branch)
IF SOMETHING DOESN'T WORK AND/OR CRASHING:
No support of any kind is implied, however it's a community forum so some users (including local experts) might be willing to help your and/or your report might be helpful to @topjohnwu, but please make sure to follow the below:
Magisk Manager crashing? Problem with Magisk module? Post installed versions of magisk, magisk manager, versions of all installed modules and the magisk log + logcat.
Downloads: https://github.com/TheComputerGuy96/MagiskFiles
Source code: https://github.com/TheComputerGuy96/Magisk (branch travisci-dev)
Travis-CI link: https://travis-ci.org/TheComputerGuy96/Magisk
That's nice of you. What is the change log?
Cool! I'm gonna give this a try and see if some of my issues are resolved.
Filip013 said:
That's nice of you. What is the change log?
Click to expand...
Click to collapse
We can check the commits log for now: https://github.com/topjohnwu/Magisk/commits/master and https://github.com/topjohnwu/MagiskManager/commits/master.
@topjohnwu, what's the reasoning for disabling MagiskHide when SuperSu is installed?
gamer765 said:
@topjohnwu, what's the reasoning for disabling MagiskHide when SuperSu is installed?
Click to expand...
Click to collapse
Because Magisk Hide don't work with SuperSU? Maybe...
Viper4android is working well S7 nougat
Verstuurd vanaf mijn SM-G930F met Tapatalk
Didgeridoohan said:
Because Magisk Hide don't work with SuperSU? Maybe...
Click to expand...
Click to collapse
I have MagiskHide working perfectly with SuperSu 2.79 on Nougat. I can use PoGo and AP. The latest Github commit breaks it.
gamer765 said:
I have MagiskHide working perfectly with SuperSu 2.79 on Nougat. I can use PoGo and AP. The latest Github commit breaks it.
Click to expand...
Click to collapse
Ok, cool... Did not know that was possible. Since topjohnwu himself have stated that Magisk Hide can NOT hide SuperSU, I assume he has a good reason to do what he does.
Think about saying stupid things, you should have respect for the guy. Just turn on magisk hide, do not tick supersu in gui
Verstuurd vanaf mijn SM-G930F met Tapatalk
afcaajax said:
Think about saying stupid things, you should have respect for the guy. Just turn on magisk hide, do not tick supersu in gui
Verstuurd vanaf mijn SM-G930F met Tapatalk
Click to expand...
Click to collapse
Not sure if you're directing that at me, but no one here is saying stupid things, except maybe you. Plus, I'm a dev/hacker myself so it doesn't really bother me, since I can always fix it myself.
gamer765 said:
I have MagiskHide working perfectly with SuperSu 2.79 on Nougat. I can use PoGo and AP. The latest Github commit breaks it.
Click to expand...
Click to collapse
If you haven't yet, please consider creating an issue for that on github and let @topjohnwu know.
AFAIK you can checkout the code one commit before the problematic one and build your own v10.
PS. Please don't feed the trolls.
gamer765 said:
I have MagiskHide working perfectly with SuperSu 2.79 on Nougat. I can use PoGo and AP. The latest Github commit breaks it.
Click to expand...
Click to collapse
That's unexpected, it never worked previously, I just added the detection I should have done in ages.
I'll try it myself when I got time, once confirmed working I'll revert this change
gamer765 said:
I have MagiskHide working perfectly with SuperSu 2.79 on Nougat. I can use PoGo and AP. The latest Github commit breaks it.
Click to expand...
Click to collapse
I'm not sure how you're accomplishing this, but it shouldn't be possible, unless you're also using some other hiding method (suhide, RootSwitch). Magisk Hide cannot hide SuperSU. I just installed it and tried it to confirm, since your post piqued my curiosity, but not surprisingly, SafetyNet came up all red, and my AirWatch app shows compromised.
Can you explain in detail what your setup is and confirm you're ONLY using SuperSU and Magisk Hide, and pass with green for SafetyNet?
Ah, well I am using suhide and rootswitch as well and everything works perfectly fine for me.
I've attached screenshots of SafetyNet passing for me. By all means, it's your project, you may do whatever you wish with it, I'll just fork it and make my own private builds where SuperSU does not disable MagiskHide..
gamer765 said:
Ah, well I am using suhide and rootswitch as well and everything works perfectly fine for me.
I've attached screenshots of SafetyNet passing for me. By all means, it's your project, you may do whatever you wish with it, I'll just fork it and make my own private builds where SuperSU does not disable MagiskHide..
Click to expand...
Click to collapse
Let me take a moment and just lay my palm against my forehead...
I'm gonna go out on a limb and guess what you're really using Magisk Hide for is hiding your unlocked bootloader with resetprop. There are other ways of doing that, you don't need Magisk Hide.
No, I do not. I use it for other stuff as well. All my mods are systemless. I'm on completely stock system with a custom kernel that does not pass bootloader unlock flags. I'm not a dumb person, but I see I'm being treated that way. I do things the way I do them for a reason. I will no longer partake in this conversation, I have better things to do. Maybe it's better to just stick to stock because ignorance is bliss. I need a break anyways from my work. Bye and thank you.
gamer765 said:
No, I do not. I use it for other stuff as well. All my mods are systemless. I'm on completely stock system with a custom kernel that does not pass bootloader unlock flags. I'm not a dumb person, but I see I'm being treated that way. I do things the way I do them for a reason. I will no longer partake in this conversation, I have better things to do. Maybe it's better to just stick to stock because ignorance is bliss. I need a break anyways from my work. Bye and thank you.
Click to expand...
Click to collapse
Well if you want to use SuperSU with Magisk Hide, just manually revert the change that disallowed it. That takes 10 seconds to do.
Captain_Throwback said:
Well if you want to use SuperSU with Magisk Hide, just manually revert the change that disallowed it. That takes 10 seconds to do.
Click to expand...
Click to collapse
His question still stands, if MagiskHide does work with SuperSu installed and there're viable use cases for that, why disable it?
stangri said:
His question still stands, if MagiskHide does work with SuperSu installed and there're viable use cases for that, why disable it?
Click to expand...
Click to collapse
I don't think @topjohnwu was considering those extended use cases when he disabled it. Maybe now that he knows, he'll revert that change. I think he was thinking that Magisk Hide can't directly hide it so it would always be detected. With several other tools, it's apparently possible to hide it, which is good to know. Personally, I'll just be sticking with the open-source solution anyway, so it doesn't really affect me.
EDIT: Besides the fact that there are many people who will enable it, not knowing that Magisk Hide can't hide SuperSU. I think the change was in an effort to prevent those types of questions.

Xposed SDK25 ALL Magisk [Unofficial]

Refering the post on XDA at https://forum.xda-developers.com/xposed/xposed-android-nougat-sdk-25-arm64-t3639221
we've found this on repo
XposedMagisk-SDK25-ALL.zip
Edit: tried here and systemui got broken, needed to recover the nandroid
Edit2: removed the link and the attachment, there is a warning on original thread, saying: "For now don't use magisk module contain in magisk folder!!!", so then , i removed the attachment, feel free to download it on original thread by you own risk, for me dont worked at now
i think that Xposed at now is so Near than Far, so lets go wait a couple days to see the roll update
Edit3: Installed both, standalone xposed and magisk xposed sdk25 arm, and all give me a bootloop
nodio said:
Refering the post on XDA at https://forum.xda-developers.com/xposed/xposed-android-nougat-sdk-25-arm64-t3639221
we've found this on repo
XposedMagisk-SDK25-ALL.zip
Edit: tried here and systemui got broken, needed to recover the nandroid
Edit2: removed the link and the attachment, there is a warning on original thread, saying: "For now don't use magisk module contain in magisk folder!!!", so then , i removed the attachment, feel free to download it on original thread by you own risk, for me dont worked at now
i think that Xposed at now is so Near than Far, so lets go wait a couple days to see the roll update
Edit3: Installed both, standalone xposed and magisk xposed sdk25 arm, and all give me a bootloop
Click to expand...
Click to collapse
tried already, my E6653 work properly so far, but safetynet can't pass, so i remove it.
i think xposed can be abandoned if magisk have more modules released like gravitybox (my favorite)
For anyone being excited about this, please bear in mind that these versions of Xposed for Nougat (7.1) popping up are nothing but a hack, based on some code released for integrating Xposed into new ROMs.
They are not to be considered stable and will most likely cause a whole lot of issues...
And, if anyone's interested, here are some thoughts from the man himself: https://github.com/rovo89/Xposed/issues/230#issuecomment-316560803

How do I delete xposed from Fulmics?

Hi! I want to remove xposed so I can use snapchat, how do I go about doing that? I don't know if it's different on Fulmics, that's why I ask, do I just download the uninstaller zip for xposed and flash it? I have that Magisk manager app so I don't know if that has anything to do with it. I see in Fulmics thread they said I shouldn't ask about xposed there so I ask here, thanks guys!
Use the uninstaller:
http://dl-xda.xposed.info/framework/
matze779 said:
Use the uninstaller:
http://dl-xda.xposed.info/framework/
Click to expand...
Click to collapse
Thank you man, I just wanted to confirm if it is that simple cause I see all kinds of different youtube video tutorials! Take care

Xposed 302 error

hi
i have been getting this message a lot on xposed SDK19 "dl.xposed.info/repo.xml.gz failed:302 (Moved temporarily)" cause of which am not able to receive the list of modules available, I am using "XposedInstaller_v2.6.1_by_SolarWarez_20151129" the only version that gets installed with updates for SDK19 on CM 11.
I know this is an old version which also means it can be solved with easy if any one can kindly help me out here..
You need an updated version of the xposed installer. There are changes on how the packages are downloaded and the installer must be updated. I know that the xposed installer from @DVDandroid has received this update as a modded version but I don't know the exact thread anymore. I only remember that the thread is in this category like this thread in "Xposed General".
I hope this information helps you a little bit to find a solution.
Edit: found it! It was an error regarding "converting http to https".
This is the thread: https://forum.xda-developers.com/xposed/material-design-xposed-installer-t3137758
And this is the commit itself if you need it for your version of the installer: https://github.com/DVDAndroid/XposedInstaller/commit/4ae125835c24c3db3f8542faa56de42416070fb2
hurray said:
You need an updated version of the xposed installer. There are changes on how the packages are downloaded and the installer must be updated. I know that the xposed installer from @DVDandroid has received this update as a modded version but I don't know the exact thread anymore. I only remember that the thread is in this category like this thread in "Xposed General".
I hope this information helps you a little bit to find a solution.
Edit: found it! It was an error regarding "converting http to https".
This is the thread: https://forum.xda-developers.com/xposed/material-design-xposed-installer-t3137758
And this is the commit itself if you need it for your version of the installer: https://github.com/DVDAndroid/XposedInstaller/commit/4ae125835c24c3db3f8542faa56de42416070fb2
Click to expand...
Click to collapse
thx a lot.. i didnt have any idea that there was a new update to xposed installer, for a long time i was holding on to the old version until it started giving issues .. now i can finally get my modules working again..
but just one more thing, the old version of xposed could easily be detected by snapchat, is it the same with xposed that DVDandroid has updated???
I don't use Snapchat and I have no idea how too deal with it.
Nice that your modules are working again and I am able to help.

Question No modules showing under Magisk?

Hi guys
I have installed twrp and magisk 24.1 i believe on my Mi 11 Ultra but under modules nothing shows?? i managed to download yt vanced that installed okay but when i try to install busy box and debloater they both fail to do so?
How do i get around this please?
EDIT: Opps i think i might of posted under wrong section, can mods move this to Mi 11 ultra section pls. Thx
Regards
AliasFaux said:
Hi guys
I have installed twrp and magisk 24.1 i believe on my Mi 11 Ultra but under modules nothing shows?? i managed to download yt vanced that installed okay but when i try to install busy box and debloater they both fail to do so?
How do i get around this please?
EDIT: Opps i think i might of posted under wrong section, can mods move this to Mi 11 ultra section pls. Thx
Regards
Click to expand...
Click to collapse
This isn't phone specific. It's just the way magisk works now. The magisk github change log explains why
Zinnz said:
This isn't phone specific. It's just the way magisk works now. The magisk github change log explains why
Click to expand...
Click to collapse
Hi
Thankyou for getting back, after researching further i found out the above and regarding installing them manually i also learnt that as they come in folders zipped up they need to be extracted and rezipped in .zip format..all seems to working at the moment, have magisk twrp and safety net passed.
Regards
AliasFaux said:
Hi
Thankyou for getting back, after researching further i found out the above and regarding installing them manually i also learnt that as they come in folders zipped up they need to be extracted and rezipped in .zip format..all seems to working at the moment, have magisk twrp and safety net passed.
Regards
Click to expand...
Click to collapse
Find Fox's Magisk Module Manager.
They are all there.
ptr21 said:
Find Fox's Magisk Module Manager.
They are all there.
Click to expand...
Click to collapse
OMG thank you so much.
Regards

Categories

Resources