Database Develop

CM-su still being detected by Magisk, Magisk Hide not working

Hi,
I'm currently so confused as to why my Magisk isn't working. I'm currently running the last CM 13 snapshot for the Galaxy S5 (G900F, klte), and root and Xposed work fine via Magisk.
However, what isn't working is Magisk Hide, and I'm not sure why. However, I'm noticing that even though I fully unrooted cm-su (using SuperSU, in a way that means the only root I can select in Dev Options is ADB only), I'm still getting cm-su detected by Magisk.
I'm confused -- is there anyway I can remove it? I've tried looking through TWRP file manager, but whenever I do so, I can't even see /system/ files, and mounting only mounts to USB, but that's unrelated.
Thanks for any help!

intcompetent said:
Hi,
I'm confused -- is there anyway I can remove it? I've tried looking through TWRP file manager, but whenever I do so, I can't even see /system/ files, and mounting only mounts to USB, but that's unrelated.
Click to expand...
Click to collapse
I don't think SuperSU removes the in-built CM superuser. Use the UNSU zip by osmosis instead. https://forum.xda-developers.com/showthread.php?t=2239421
Also magisk hide will NOT hide Xposed. Yes not even systemless 87.1 Xposed.

SuperSU removed its own root only, CM root is unaffected.
Also, Magisk hide only works with Magisk's own phh root.
And, as far as I know, it can't successfully hide Xposed either. Doesn't matter if it is systemless or not.

Cheers for the replies.
I wasn't aware that Magisk Hide didn't hide Xposed, that's my bad.
As for the presence of CM-SU, SuperSU did do something, as the Developer Options root option is now ADB only while previously it offered the option to Apps too. I'll try unsu.
Here's what I'm meaning btw: imgur.com /a /yTOTw (sorry for the link bypass, there's no other way for me to simply demonstrate the issue) (as you can see in the first screenshot, Magisk detects "cm-su" along with phh. When phh was disabled before I removed cm-su, it only detected cm-su, hence leading me to believe cm-su remains).
e: tried unsu, still cm-su remains. At this point, I'll leave it -- I presume that it's permanently ingrained into the ROM. I've gotten around the restriction I was facing anyway, and I'll adjust. Thanks anyway!

intcompetent said:
Cheers for the replies.
I wasn't aware that Magisk Hide didn't hide Xposed, that's my bad.
As for the presence of CM-SU, SuperSU did do something, as the Developer Options root option is now ADB only while previously it offered the option to Apps too. I'll try unsu.
Here's what I'm meaning btw: imgur.com /a /yTOTw (sorry for the link bypass, there's no other way for me to simply demonstrate the issue) (as you can see in the first screenshot, Magisk detects "cm-su" along with phh. When phh was disabled before I removed cm-su, it only detected cm-su, hence leading me to believe cm-su remains).
e: tried unsu, still cm-su remains. At this point, I'll leave it -- I presume that it's permanently ingrained into the ROM. I've gotten around the restriction I was facing anyway, and I'll adjust. Thanks anyway!
Click to expand...
Click to collapse
If there are SU files in /system/bin and /system/xbin, then CM root was not removed. Not completely.
To actually remove it you have to delete those files.

Pwnycorn said:
If there are SU files in /system/bin and /system/xbin, then CM root was not removed. Not completely.
To actually remove it you have to delete those files.
Click to expand...
Click to collapse
@intcompetent Osmosis's unsu zip removes those files. If those files are still there after flashing the unsu zip, I'd ask in his thread.

knpk13 said:
@intcompetent Osmosis's unsu zip removes those files. If those files are still there after flashing the unsu zip, I'd ask in his thread.
Click to expand...
Click to collapse
Or just remove them manually, jeez. It's just two files.
I've been doing it manually for months and everything works as intended.

As an a closer, there's nothing there. I presume that Magisk is picking up something freaky from somewhere, or something's up, but I'm good guys. I won't need anymore help.
Cheers!

I found this zip around somewhere. I believe it works to remove all root (systemless as well) and I've always flashed it before rooting normally. It should also remove CM root afaik.
As a test, after flashing, check and see if you pass safetynet before installing magisk

intcompetent said:
As an a closer, there's nothing there. I presume that Magisk is picking up something freaky from somewhere, or something's up, but I'm good guys. I won't need anymore help.
Cheers!
Click to expand...
Click to collapse
I
L

[Magisk][Module] su xbin_bind v1.2-20170417

Intro
Expose your su to standard location /system/xbin/su systemless-ly.
Though it helps grant root permission to some apps, this trick breaks safetynet.
Just made a simple module try to solve the /sbin/su not detectable problem. This module will look for existing su binary, and create a link as /magisk/su_xbin_bind/system/xbin/su pointing to the real su. The link will also be mounted as /system/xbin/su systemless-ly later.
Installation
Flash it in Magisk manager or through recovery, then reboot. You will find a link /system/xbin/su. All the work is done systemless-ly.
Uninstallation
Open Magisk Manager, go to Modules, disable or uninstall the module called "Su xbin_bind". Then it will disappear after reboot.
su-xbin-bind on github
Changelog
v1.2 20170417
Add Magisk v12 support.
v1.1 20170323
- make it compatible with Magisk v11.5/11.6
Update 20170228
- Since a little syntax error in the mounting script from Magisk v11.0-v11.5, mounting links systemless-ly won't success. Hence we choose to copy but not to link the su binary for v11.0-v11.5. Don't worry, both methods are systemless.

Reserved.

Hi, will this not make safetynet fail?

kartikb said:
Hi, will this not make safetynet fail?
Click to expand...
Click to collapse
It will obviously. Because su is exposed to /system/xbin/su and will be detected.

laggardkernel said:
It will obviously. Because su is exposed to /system/xbin/su and will be detected.
Click to expand...
Click to collapse
Wouldn't magiskhide unmount that and therefore pass safetynet?

I used your module to fix TiBackup freeze when restorins apps.
TiBackup troubleshooting (http://www.titaniumtrack.com/kb/tit...l#tb-hangs-while-freezing-apps-restoring-apps) reports that this issue is connected with wrong su permissions in /system/bin and /system/xbin. Since these are not available due to systemless root, I though that your module would represent an elegant fix... and it did!
Thanks!

leonardus_magnus said:
I used your module to fix TiBackup freeze when restorins apps.
TiBackup troubleshooting (http://www.titaniumtrack.com/kb/tit...#tb-hangs-while-freezing-apps-restoring-apps) reports that this issue is connected with wrong su permissions in /system/bin and /system/xbin. Since these are not available due to systemless root, I though that your module would represent an elegant fix... and it did!
Thanks!
Click to expand...
Click to collapse
Does ur safety net fail with this module?

Xennet said:
Does ur safety net fail with this module?
Click to expand...
Click to collapse
Oh c'mon, you cannot be serious... On Xda forums you have threads with hundreds of pages and I would admit you did not read all of them... but your answer has already been replied on post n. 4 in this page... I can' believe it...

leonardus_magnus said:
Oh c'mon, you cannot be serious... On Xda forums you have threads with hundreds of pages and I would admit you did not read all of them... but your answer has already been replied on post n. 4 in this page... I can' believe it...
Click to expand...
Click to collapse
Yah i saw it lol....
But magisk usually dismounts xbin folder...
Then it unusual to get it detected unless it is physically present der...
So just wanted to confirm it before flashing...

Xennet said:
Yah i saw it lol....
But magisk usually dismounts xbin folder...
Then it unusual to get it detected unless it is physically present der...
So just wanted to confirm it before flashing...
Click to expand...
Click to collapse
Ok safety net not passed on my device... but it's not an issue at all for me...

Unfortunately, doesn't fix the Titanium Backup issue (freezing or restoring app) for me on Galaxy S6 Android 6.0. This also broke SafetyNet for me, even after uninstalling the module from Xposed and rebooted.

chaoscreater said:
Unfortunately, doesn't fix the Titanium Backup issue (freezing or restoring app) for me on Galaxy S6 Android 6.0. This also broke SafetyNet for me, even after uninstalling the module from Xposed and rebooted.
Click to expand...
Click to collapse
If you mean you are using xposed, obviously safetynet will be broken. MagiskHide couldn't hide xposed.
This module tries to fix the su detectable problem. If your titanium backup could get root permission after installing the module, it means the module worked.

My TB is working fine, but I have another app that can't detect it, will give it a test run, thanks for your work!

HI! Just a quick feedback: this module works with Helium Backup that now correctly asks for root permission! :good:
Thank you!

Thanks for the module!! It was the key for me getting Termux su working ?

Hello, I flashed this without error and titanium backup as well as ES file explorer both report I do not have root. Magisk v12 states i do have root.
nevermind...i realized Magisk SU isn't installed as it didn't auto install. I had installed phh's superuser r266-2.
proceeded to rewipe and reflash everything.
Nexus 6P
[ROM][6P][7.1.2_r8]★ Pure Nexus ★ Substratum | Fi | WiFi Calling ★[05/09/17]
ex 4.09
Magisk v13 beta
no issues and all superuser root requests appear.

Big big BIG THANK YOU to you. Fixed the most important app for custom ROMs- Kernel adiutor:highfive: (Both play store:good: and modded versions:laugh and secure settings tasker plugin

Please update the script for the new template v4 for Magisk v13!
:good:

If *enabled* in magisk 13, titanium backup can't get root.
I had to disable it.

Hi,
Work with Magisk Version 13.3 ???

[Module] [Magisk] init.d link v1.3 | require Magisk 12.0+

Note: This module won't work with v10-v11.6 since some syntax err in the mounting scripts. More info here. https://github.com/topjohnwu/Magisk/commit/624b7616d082feced71bff0474c64c1b4afd5cc0
If you're using a beta one newer than v11.6. Try this module.
Init.d Link (Magisk)
Intro
The module solves the situation when /system/etc/init.d doesn't exist, some app, let's say Kernel Auditor Beta, doesn't recognize the *.d folder provided by MagiskSU and tries to create the init.d folder by itself. So we'd better symlink one from an available *.d — post-fs-data.d, service.d or su.d.
- The module symlinks a *.d folder as init.d,
- or simply create one systemlessly.
- Init.d scripts will be run by an existing superuser — MagiskSU, phh's superuser or SuperSU — or the kernel,
- but NOT by the module itself, in case of collision with the func of kernel.
Symlink Priority:
1. /magisk/.core/service.d (Magisk v12)
2. /magisk/.core/post-fs-data.d (Magisk v11)
3. /magisk/phh/su.d
4. /su/su.d
5. /magisk/.core/post-fs-data.d (Magisk v12)
6. /magisk/.core/service.d (Magisk v11)
The last resort will be the creation of a systemless init.d folder.
NOTE: init.d will be symlinked only if available *.d foler exists.
Installation
Flash it in RECOVERY ONLY.
Credit
https://github.com/laggardkernel/init.d-link by laggardkernel
Changelog
v1.3
- Fix mount of su.img
v1.2
- Update to module template v3
- Add link target info into module.prop.
- Reorder init.d link priority for Magisk v12:
1. /magisk/.core/service.d (Magisk v12)
2. /magisk/.core/post-fs-data.d (Magisk v11)
3. /magisk/phh/su.d
4. /su/su.d
5. /magisk/.core/post-fs-data.d (Magisk v12)
6. /magisk/.core/service.d (Magisk v11)
- There is also a post-fs-data branch keep post-fs-data.d at high priority by force.

Reserved.

How to use this module?

ngtung84 said:
How to use this module?
Click to expand...
Click to collapse
Just download the zip and flash it in your recovery. Then the module will create a /system/etc/init.d link directing to /magisk/.core/post-fs-data.d SYSTEMLESS. This will solve the pain that some apps, like Kernel Manager beta, don't recognize Magisk's post-fs-data.d and create a init.d itself to put their init scripts.

laggardkernel said:
Just download the zip and flash it in your recovery. Then the module will create a /system/etc/init.d link directing to /magisk/.core/post-fs-data.d SYSTEMLESS. This will solve the pain that some apps, like Kernel Manager beta, don't recognize Magisk's post-fs-data.d and create a init.d itself to put their init scripts.
Click to expand...
Click to collapse
I have some scripts. Can I put them into /system/etc/init.d created by this module?

You make some really nice little modules. I really believe you should submit them to the repo... It's gonna need some updating to the latest template and maybe also some updates for v12 though. From the v12 release notes:
It is recommended to run most scripts in the service mode (service.d/service.sh), except a. mounting files; b. patching system props; c. time critical operations
Click to expand...
Click to collapse

Didgeridoohan said:
You make some really nice little modules. I really believe you should submit them to the repo... It's gonna need some updating to the latest template and maybe also some updates for v12 though. From the v12 release notes:
Click to expand...
Click to collapse
Gotta disagree with you here. This module is ALL OVER THE PLACE. The code in the startup scripts is doing TONS of unadvertised stuff:
There is code related to @ahrion Dolby Atmos (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L108) that will potentially put your device into Permissive Mode without telling you.
No idea what this code is doing, but certainly doesn't relate to init.d symlinks (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L93).
Appears to attempt to install a non-existent APK called '*.apk' with package name '*.*.*' (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L68).
And that's all on every startup.
I would be careful with this module...

Jman420 said:
Gotta disagree with you here. This module is ALL OVER THE PLACE. The code in the startup scripts is doing TONS of unadvertised stuff:
There is code related to @ahrion Dolby Atmos (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L108) that will potentially put your device into Permissive Mode without telling you.
No idea what this code is doing, but certainly doesn't relate to init.d symlinks (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L93).
Appears to attempt to install a non-existent APK called '*.apk' with package name '*.*.*' (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L68).
And that's all on every startup.
I would be careful with this module...
Click to expand...
Click to collapse
Hm... Thank's for pointing that out. I'm not at all fluent enough in scripting to have caught that without some serious scrutiny, and I've not had the time for that today.
Perhaps we'll get an explanation from @laggardkernel about what's going on.

Didgeridoohan said:
Hm... Thank's for pointing that out. I'm not at all fluent enough in scripting to have caught that without some serious scrutiny, and I've not had the time for that today.
Perhaps we'll get an explanation from @laggardkernel about what's going on.
Click to expand...
Click to collapse
Best guess i can come up with is that stuff is left over from other experiments. He seems to be using the same repo for multiple projects and separating them with branches. That seems to have caused some cross contamination in his branches.
As a general development rule you should have one project/solution per repo. Your branches usually represent new features for the project.

Jman420 said:
Best guess i can come up with is that stuff is left over from other experiments. He seems to be using the same repo for multiple projects and separating them with branches. That seems to have caused some cross contamination in his branches.
As a general development rule you should have one project/solution per repo. Your branches usually represent new features for the project.
Click to expand...
Click to collapse
If you look in config.sh you'll see that the module isn't even using post-fs-data.sh (POSTFSDATA=false). And the files on GitHub doesn't match the files in the module zip. Look at update-binary in the zip and then on GitHub. In the zip you'll find the symlinking, but not on GitHub...
So yeah, I guess we're talking about a bunch of code left over from previous experiments.

Jman420 said:
Gotta disagree with you here. This module is ALL OVER THE PLACE. The code in the startup scripts is doing TONS of unadvertised stuff:
There is code related to @ahrion Dolby Atmos (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L108) that will potentially put your device into Permissive Mode without telling you.
No idea what this code is doing, but certainly doesn't relate to init.d symlinks (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L93).
Appears to attempt to install a non-existent APK called '*.apk' with package name '*.*.*' (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L68).
And that's all on every startup.
I would be careful with this module...
Click to expand...
Click to collapse
I took all of that setenforce stuff out of my script. And in my release notes it clearly stated when I release v1.2 that I added the script to AudModLib. However I removed it because I found a workaround in v1.3.
With Audmodlib we have only audio server media server, and system prop contextd permissible for ONLY system and priv apps. Which is what I had to replace with the setenforce stuff.
He's not doing anything shady when looking at the code, it looks like he was following my example. I would submit a git issue to tell him to update the mod.
Hope this clears things up man.

Jman420 said:
Gotta disagree with you here. This module is ALL OVER THE PLACE. The code in the startup scripts is doing TONS of unadvertised stuff:
There is code related to @ahrion Dolby Atmos (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L108) that will potentially put your device into Permissive Mode without telling you.
No idea what this code is doing, but certainly doesn't relate to init.d symlinks (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L93).
Appears to attempt to install a non-existent APK called '*.apk' with package name '*.*.*' (https://github.com/laggardkernel/magisk-module-template/blob/init.d/common/post-fs-data.sh#L68).
And that's all on every startup.
I would be careful with this module...
Click to expand...
Click to collapse
1. Look into the config.sh;
2. Post-fs-data.sh, service.sh are NOT enabled;
3. Post-fs-data.sh, service.sh will NOT be copied to your device.
4. I use a template with some additional features myself. Maybe I'm too laggard to clean up unused codes. But I'm sure I commented out, disabled all unnecessary parts.

laggardkernel said:
Maybe I'm too laggard to clean up unused codes.
Click to expand...
Click to collapse
Ha ha!
But yeah, like it shows, you're gonna scare some people leaving it in there.
True, you'll only get scared if you don't look at the entire thing, but still...

laggardkernel said:
Maybe I'm too laggard to clean up unused codes.
Click to expand...
Click to collapse
hehehe, i see what you did there.
laggardkernel said:
1. Look into the config.sh;
2. Post-fs-data.sh, service.sh are NOT enabled;
3. Post-fs-data.sh, service.sh will NOT be copied to your device.
4. I use a template with some additional features myself. Maybe I'm too laggard to clean up unused codes. But I'm sure I commented out, disabled all unnecessary parts.
Click to expand...
Click to collapse
Yeah, deeper review does show that those scripts aren't installed or used. But leaving them there makes reviewing the module much harder since you have to go looking for that 1 flag which indicates they aren't used. As a developer if I see code in a script I expect that it's meant to be executed and a reviewer won't necessarily know which piece is correct (the flag disabling the script or the script itself).
The module is definitely benign, but on a quick surface review the dead code seems strange in the context of the module itself. Just a suggestion, but cleaning up that dead code would make the module easier to review and avoid having that code get executed accidentally or misinterpreted.
Didgeridoohan said:
But yeah, like it shows, you're gonna scare some people leaving it in there.
True, you'll only get scared if you don't look at the entire thing, but still...
Click to expand...
Click to collapse
Even a full review would raise some concerns with me. Mainly which is correct; having the script disabled or enabled. That concern can only be addressed through a discussion like this. A full review would make me feel a bit more secure since the script isn't executed, but would make me question whether the full functionality of the module is actually in place.
@laggardkernel This is all good work, so I hope you don't take any of this the wrong way. I just happen to do development (more accurately software engineering) as a career and see this kind of stuff all over the place in enterprise software and it makes my eyes bleed every time I see it. Now that I've gotten into a cyber security role I'm even more sensitive to this stuff since they end up constituting security holes (either maliciously or accidentally, usually the latter).

Flash it from recovery, it say Error... because there is already has init.D folder ?
So i have to delete the folder first ?

Vuska said:
Flash it from recovery, it say Error... because there is already has init.D folder ?
So i have to delete the folder first ?
Click to expand...
Click to collapse
If you already have init.d support you don't need this module.
And if you want proper help, where's your recovery log?

Does this module already support Magisk 13.1?

Magisker said:
Does this module already support Magisk 13.1?
Click to expand...
Click to collapse
Not yet. I haven't migrated to v13+ and I'm still waiting for the update of the all-in-one wiki.

laggardkernel said:
Not yet. I haven't migrated to v13+ and I'm still waiting for the update of the all-in-one wiki.
Click to expand...
Click to collapse
The template v4 is already there tho
https://github.com/topjohnwu/magisk-module-template

magisk 14 does not mount magisk.img. It creates a different set up. There is no magisk folder at root containing post-fs-data.d and service.d folders. If they are not there in magisk 14, where are the scripts to be placed for running at boot. Anybody could help on this.

[MOD]: Sqlite3 (v3.8.11.1) binary.

Hello everyone
Well... Not much to say.
I've made that very simple module for my personal use and just sharing it with the community in case anyone needs it.
What it does it really simple.
It installs (or replaces) sqlite3 binary in /system/bin to be used by any app or from terminal.
It's for ARM7 only.
Have fun
Credits: @topjohnwu for the template and @tech128 for the binary used.

Thank you for your effort... Do you have binary of sqlite of 64bit?

lssong99 said:
Thank you for your effort... Do you have binary of sqlite of 64bit?
Click to expand...
Click to collapse
I'm currently on G5 which is 64bit and binary works just fine.

Yes, it will work. However my situation is a bit complex that I call sqlite from Tasker and there is a bug in Tasker's that Tasker will invoke 64 bit libraries and throw error even if sqlite is 32 bit.
There is a work around but a bit complex so I am searching for 64 bit binary...

Sorry but what is SQLite

kwanthenewbie said:
Sorry but what i SQLite
Click to expand...
Click to collapse
You don't need it probably xD
It's the "program" to manipulate sqlite databases.

lssong99 said:
Yes, it will work. However my situation is a bit complex that I call sqlite from Tasker and there is a bug in Tasker's that Tasker will invoke 64 bit libraries and throw error even if sqlite is 32 bit.
There is a work around but a bit complex so I am searching for 64 bit binary...
Click to expand...
Click to collapse
https://github.com/stockrt/sqlite3-android
Build one by yourself. I guess you need arm64-v8a ?

DenyDarko said:
I'm currently on G5 which is 64bit and binary works just fine.
Click to expand...
Click to collapse
DenyDarko said:
https://github.com/stockrt/sqlite3-android
Build one by yourself. I guess you need arm64-v8a ?
Click to expand...
Click to collapse
Haha! Thanks.... Actually I had been trying very hard to resist the urge to build one myself (too lazy....). Maybe I should starting setup the tool train now....
Anyway thanks!

lssong99 said:
Haha! Thanks.... Actually I had been trying very hard to resist the urge to build one myself (too lazy....). Maybe I should starting setup the tool train now....
Anyway thanks!
Click to expand...
Click to collapse
It's not that hard and it's fun. Plus this git contains a customised sqlite for android.
It's not like building a kernel or smth. Give it a try xD

Hi @DenyDarko,
Please, can you update your module? It doesn't install with last version of Magisk. Futhermore, it will be interesting to include all binaries: sqlite3.arm; sqlite3.arm64; sqlite3.x64; etc. and add a symlink for the run architecture to "sqlite3". And last, publish it in the official repository.
Thank you!

manos78 said:
Hi @DenyDarko,
Please, can you update your module? It doesn't install with last version of Magisk. Futhermore, it will be interesting to include all binaries: sqlite3.arm; sqlite3.arm64; sqlite3.x64; etc. and add a symlink for the run architecture to "sqlite3". And last, publish it in the official repository.
Thank you!
Click to expand...
Click to collapse
@ianmacd added an updated version to the official repo already

DenyDarko said:
@ianmacd added an updated version to the official repo already
Click to expand...
Click to collapse
Ha. I didn't know there was already an SQLite module. I checked the official Magisk repo and didn't find one, so I made one for my own use and submitted it so that others could hopefully benefit from the work.

ianmacd said:
Ha. I didn't know there was already an SQLite module. I checked the official Magisk repo and didn't find one, so I made one for my own use and submitted it so that others could hopefully benefit from the work.
Click to expand...
Click to collapse
I even use yours now myself xD

@DenyDarko
Can you somehow check if this sqlite3 works ?

ianmacd said:
Ha. I didn't know there was already an SQLite module. I checked the official Magisk repo and didn't find one, so I made one for my own use and submitted it so that others could hopefully benefit from the work.
Click to expand...
Click to collapse
Hi @ianmacd,
I installed your Magisk module. However, I found a trouble: when enabling your module, the SafetyNet check never completes or indicates "the response is invalid".
So, please verify or review your module. Only disabling it the SafetyNet continues working well.
Or almost, put this info in the description, because your module is now in the official repository.
Regards.

manos78 said:
Hi @ianmacd,
I installed your Magisk module. However, I found a trouble: when enabling your module, the SafetyNet check never completes or indicates "the response is invalid".
So, please verify or review your module. Only disabling it the SafetyNet continues working well.
Or almost, put this info in the description, because your module is now in the official repository.
Regards.
Click to expand...
Click to collapse
The issue might be that the module mounts the binary to /system/xbin, and that your device doesn't have a xbin folder by default. This has been known to cause issues, and seem to be even more prevalent on recent Magisk releases. Try changing the modules xbin folder to bin and reboot, to see if it makes any difference.
@ianmacd It's a good idea to look for the existence of xbin at installation and use bin instead if it doesn't exist.

Didgeridoohan said:
The issue might be that the module mounts the binary to /system/xbin, and that your device doesn't have a xbin folder by default. This has been known to cause issues, and seem to be even more prevalent on recent Magisk releases. Try changing the modules xbin folder to bin and reboot, to see if it makes any difference.
@ianmacd It's a good idea to look for the existence of xbin at installation and use bin instead if it doesn't exist.
Click to expand...
Click to collapse
Thanks for the tip, @Didgeridoohan.
I'll have to read up on the Magisk installation environment to ensure that I write the logic in a sane way. By that, I mean, for example, that I'm unsure whether I can just check for [ -d /system/xbin ], or whether I might get a false positive if some other module has erroneously faked the existence of this directory.

ianmacd said:
Thanks for the tip, @Didgeridoohan.
I'll have to read up on the Magisk installation environment to ensure that I write the logic in a sane way. By that, I mean, for example, that I'm unsure whether I can just check for [ -d /system/xbin ], or whether I might get a false positive if some other module has erroneously faked the existence of this directory.
Click to expand...
Click to collapse
Good point... Check for /sbin/.core/mirror/system/xbin. That's the untouched /system mirror.

ianmacd said:
Thanks for the tip, @Didgeridoohan.
I'll have to read up on the Magisk installation environment to ensure that I write the logic in a sane way. By that, I mean, for example, that I'm unsure whether I can just check for [ -d /system/xbin ], or whether I might get a false positive if some other module has erroneously faked the existence of this directory.
Click to expand...
Click to collapse
Alternately you can just use bin and forget about xbin. There's really no technical reason to use xbin unless you're installing alternate forms of existing commands.

jcmm11 said:
Alternately you can just use bin and forget about xbin. There's really no technical reason to use xbin unless you're installing alternate forms of existing commands.
Click to expand...
Click to collapse
That's actually also been known to cause issues on some systems. While investigating issues like this, a while back, I believe it was found that it was most compatible to use xbin if it exists and bin if it doesn't.

! /data/adb/magisk_merge.img mount failed

Hello.
Unable to flash magisk modules.
! /data/adb/magisk_merge.img mount failed.
Even via twrp recovery is no possible to flash magisk modules, says something like error 1.
The device is a doogee mix 2.
I was forced to install the normal xposed framework just to use it.
Root works; only modules have problems.
Can some expert find a solution, please?
Thank you in advance to everyone gives good news!

MasterSheea said:
Hello.
Unable to flash magisk modules.
! /data/adb/magisk_merge.img mount failed.
Even via twrp recovery is no possible to flash magisk modules, says something like error 1.
The device is a doogee mix 2.
I was forced to install the normal xposed framework just to use it.
Root works; only modules have problems.
Can some expert find a solution, please?
Thank you in advance to everyone gives good news!
Click to expand...
Click to collapse
Hi, Can you attach logs while flashing ?? from both MM and recovery

MasterSheea said:
Hello.
Unable to flash magisk modules.
! /data/adb/magisk_merge.img mount failed.
Even via twrp recovery is no possible to flash magisk modules, says something like error 1.
The device is a doogee mix 2.
I was forced to install the normal xposed framework just to use it.
Root works; only modules have problems.
Can some expert find a solution, please?
Thank you in advance to everyone gives good news!
Click to expand...
Click to collapse
Known issue on some MTK devices. Loop mounting doesn't work.
There are lots of reports like this for Doogee... There's been some investigating into it in the beta thread, but as of yet there's no solution, I believe.

Hello!
Yes, of course!
Logs of magisk installer and TWRP recovery here:
https://drive.google.com/file/d/11vzWdbQfTtlmdc7VchaKxSGU4RkaOcog/view?usp=drivesdk
Ignore the crittografy error; I have tried to disable the crittografy and all is the same. Same problem.
In more, yesterday I had another annoying problem with magisk: before the options of the magisk app disappeared (there is the pic in the folder I attached. Then magisk is totally disappeared: magisk is not installed anymore in your device.
Tried to re-install magisk: nothing happens.
I have re-flashed the ROM and re- installed magisk: at moment is working.
Root files and SuperSU are not working.
I will open a new forum discussion for this problem.
Thank you in advance.
Greetings

MasterSheea said:
Hello!
Yes, of course!
Logs of magisk installer and TWRP recovery here:
https://drive.google.com/file/d/11vzWdbQfTtlmdc7VchaKxSGU4RkaOcog/view?usp=drivesdk
Ignore the crittografy error; I have tried to disable the crittografy and all is the same. Same problem.
In more, yesterday I had another annoying problem with magisk: before the options of the magisk app disappeared (there is the pic in the folder I attached. Then magisk is totally disappeared: magisk is not installed anymore in your device.
Tried to re-install magisk: nothing happens.
I have re-flashed the ROM and re- installed magisk: at moment is working.
Root files and SuperSU are not working.
I will open a new forum discussion for this problem.
Thank you in advance.
Greetings
Click to expand...
Click to collapse
The file is not accessible

Sorry.
Try now, please.
https://drive.google.com/file/d/11vzWdbQfTtlmdc7VchaKxSGU4RkaOcog/view?usp=drivesdk

MasterSheea said:
Sorry.
Try now, please.
https://drive.google.com/file/d/11vzWdbQfTtlmdc7VchaKxSGU4RkaOcog/view?usp=drivesdk
Click to expand...
Click to collapse
Looks like recovery can't decrypt /data, so that's likely an issue there. But it'd be easier to tell if you had provided the recovery log rather than a screenshot (Advanced - Copy log after trying to flash).
And, it would also be very useful if you had provided a Magisk log rather than only installation logs.
But, it's probably a moot point anyway. Like I said earlier, this is a known issue with loop mounting on Doogee devices (and other devices using Mediatek). No solution as of yet...

Didgeridoohan said:
Looks like recovery can't decrypt /data, so that's likely an issue there. But it'd be easier to tell if you had provided the recovery log rather than a screenshot (Advanced - Copy log after trying to flash).
And, it would also be very useful if you had provided a Magisk log rather than only installation logs.
But, it's probably a moot point anyway. Like I said earlier, this is a known issue with loop mounting on Doogee devices (and other devices using Mediatek). No solution as of yet...
Click to expand...
Click to collapse
Same here, provide good logs

Ok, thanks.
I will try to send you good logs.
About encryption, I have tried to disable encryption and to install all without encryption: nothing changes.
Before I must understand why magisk disappears from system, then I will collect logs about modules installation. Magisk is the only way to root this damned phone, SuperSU does not works.
Thank you in advance

MasterSheea said:
Ok, thanks.
I will try to send you good logs.
About encryption, I have tried to disable encryption and to install all without encryption: nothing changes.
Before I must understand why magisk disappears from system, then I will collect logs about modules installation. Magisk is the only way to root this damned phone, SuperSU does not works.
Thank you in advance
Click to expand...
Click to collapse
There was no need to start a new thread about that... You've already got this one going.
The screenshot of the Manager you provided simply showed a Manager without internet access. Completely normal.
About losing root completely, make sure you don't have any aggressive battery optimisation on the Manager. More here:
https://www.didgeridoohan.com/magisk/Magisk#hn_Randomly_losing_root

Ok, good, I close the other thread
Yes true, that is a normal screenshot of magisk offline. Yesterday I did formatted data to disable encryption and I lost all the other screenshots, but was like this: before all options disappeared, then magisk disappeared.
No, no aggressive battery optimization running, but I have installed greenify and amplify... Perhaps one of this app makes problem?

I wish to close the other thread, but I do not know how to do it.
How to do it, please?

MasterSheea said:
Ok, good, I close the other thread
Yes true, that is a normal screenshot of magisk offline. Yesterday I did formatted data to disable encryption and I lost all the other screenshots, but was like this: before all options disappeared, then magisk disappeared.
No, no aggressive battery optimization running, but I have installed greenify and amplify... Perhaps one of this app makes problem?
Click to expand...
Click to collapse
Make sure the Manager is removed from Battery optimisation and that it isn't selected I'm Greenify. It's not certain that this is the issue, but it's worth ruling out.
Other than that, a logcat of it happening, or even just a screenshot of the Manager when things aren't working. A Magisk log is also useful, of course.
MasterSheea said:
I wish to close the other thread, but I do not know how to do it.
How to do it, please?
Click to expand...
Click to collapse
Just let it be...

Oki.
I removed magisk from battery optimization.
I hope that at least the root will work.
But I seen in another thread that there is a solution known as f2fs workaround bug fixer. But is still not working. I hope that someone will fix it soon.
Anyhow, thank you for all

Move to thread https://forum.xda-developers.com/apps/magisk/guide-magisk-official-version-including-t3577875. Flash last zip. Move to magisk manager, install updated (2018.3.6) version. All modules should now install fine.

Hello.
Thank you for the answer.
I have tried to flash the zip without success.
No magisk installation found or installed version is not supported.
Error process 1.
The magisk version I have installed is v16. - 5.6.4(112).
The last one, suppose.
Any suggestions, please?
Thank you in advance ?

I made also the this attempt: I have flashed a magisk module using flashify.
The flashing was successful, but the module is not in the magisk list.
Can be a permission problem? Someone knows where is the folder of installed magisk modules, please? Perhaps is a permission problem and changing permissions will work...

Download f2fs-loopback-bug-workaround-2018.1.31.zip from the thread. Place it in Download folder of internal storage. Reboot to recovery. Flash zip in twrp. Reboot. Open magisk manager. F2FS Loopback Bug Workaround should be installed in modules. I hope any module can be installed from now on.

Dear Pragnan Saha,
Thank you for your answer.
I have tried to flash f2fs-loopback-bug-workaround-2018.1.31.zip, but without success.
TWRP says: No magisk installation found or installed version is not supported. Error process 1.
Some suggestions, please?
Thank you in advance

Didgeridoohan said:
There was no need to start a new thread about that... You've already got this one going.
The screenshot of the Manager you provided simply showed a Manager without internet access. Completely normal.
About losing root completely, make sure you don't have any aggressive battery optimisation on the Manager. More here:
https://www.didgeridoohan.com/magisk/Magisk#hn_Randomly_losing_root
Click to expand...
Click to collapse
What thread? And is it about exact the same error ! /data/adb/magisk_merge.img ... What this thread is about?
Do you know if there's a fix already? I'm on ext4 so f2fs loopback makes no sense for me
And @MasterSheea do you have a fix?
I've got exactly the same error with flashing modules, after clean flask is possible to install modules but after 1 reboot it fails