Database Develop

[BUG] Magisk refuses to install modules from repo (The zip is not a Magisk Module!)

I've had magisk installed since version 6, I've published some magisk modules already and never had a problem until today.
After a full clean reinstall of Nougat NBD90Z (with wipe) on my Nexus 6 and then flashing Magisk, phh's superuser for magisk, installing phh's superuser apk from play store and magisk manager apk I stumbled upon a previously reported (without details) bug where magisk manager would refuse to install modules from repo claiming they are not magisk modules.
I've struggled trying everything I could including the full wipe (more details here: http://forum.xda-developers.com/apps/magisk/module-app-systemizer-t3477512/69230448#69230448) and bounced some ideas off @pnwsr6 who's had the similar problem on Nexus 6 device.
I've achieved a partially working Magisk Manager (manual installs of ZIP files work, but installs from repo still fail) and here's the list of steps which lead to me having semi-working magisk manager again:
1. I flashed ZIP files of some modules in twrp (I'm attaching App Systemizer and Nexus 6 LED Enabler which I flashed)
2. After the phone booted up I saw the modules active and working
3. Within Magisk Manager I then added the ZIP file of the phh's superuser module from that thread (http://forum.xda-developers.com/attachment.php?attachmentid=3893967&d=1475554052)
4. Now at least manual installation of modules within Magisk Manager are working fine.
@topjohnwu -- I've enabled verbose logging and extra logging for bash commands, but I'm still not seeing anything in the log on top of the regular output.

Created an issue against Magisk Manager so it's easier to track for developers: https://github.com/topjohnwu/MagiskManager/issues/20

Looks like that even after flashing some modules in twrp, Magisk Manager only allows to install from zip only exactly the same ZIP I've already flashed (even a minor change and bump of versionCode results in "This ZIP is not a Magisk Module!"). So it might be an issue of Magisk Manager being unable to write to /magisk despite having storage permission and being granted root access.

Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!

I've seen this error as well on my Nexus 6 NBD90Z with Magisk v8. Started with v7 after some heavy modification on my part .
I was sometimes able to fix it by simply extracting the zip and then Magisk Manager would somehow recognize it as a module.. Other times I could extract the zip and then re-archive the contents and Magisk Manager would recognize that as a module. Weird, but doable.

stangri said:
Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!
Click to expand...
Click to collapse
I probably won't try again until next update, and hope the wipe just wasn't clearing something. I have the zip installed through twrp and working for now so I'm good till then.

just wondering if you're still having this issue with v9? I had modules installed fine under v6, but never really installed any modules under v8 to see if this problem occurred for me. now that I'm on v9, which has been wiped clean to start, I can no longer install any modules via Downloads or in the Modules section... any suggestions?

I have the same issue when trying to install viper with v9 on Nexus 6P DP2
Skickat från min Nexus 6P via Tapatalk

Same here. Find a fix ?

From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.

stangri said:
From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.
Click to expand...
Click to collapse
Just an FYI, I do still have this problem, but can install the zip through twrp. Maybe 10 will be the solution.

I had the same problem, I cleared magisk manager data and it works fine now

Didn't help
Sent from my SM-G532F using Tapatalk

I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.

stangri said:
I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.
Click to expand...
Click to collapse
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.

Meowdib said:
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.
Click to expand...
Click to collapse
Weird, do you have the same problem with magisk manager 161223?

stangri said:
Weird, do you have the same problem with magisk manager 161223?
Click to expand...
Click to collapse
Same

I need a Help to download modules using magisk
Lastest version, Included phh root, manager is from G. play,
But Modules download function is not working
Say "No modules found" for download to install via magisk.

Magic v11 installation question

Hi, do i need install systemless SuperSU always in twrp before install magisk v11 if I want use new MagiskSU instead??
If I try install Magisk v11 with superSU uninstalled and phone unrooted TWRP give me error and installation fails and if I install superSU and after Magisk v11, Magisk manager say system is using SuperSU instead MagiskSU. How do I install Magisk with MagiskSU??
I have Samsung Galaxy S4 with optimized LineageOS 14.1

Read the pinned Magisk thread...
Unroot again using unSu by osm0sis (Google) before flashing magisk

Installation Instructions
If you're already rooted with MagiskSU, Magisk phh's superuser (not original), or Official Systemless SuperSU
Install/upgrade Magisk Manager from Play Store
Install/upgrade Magisk as prompted in the application
Reboot and you're done!!
If you're not rooted, or something went wrong and you need a clean start
(Recommended) Restore your boot image back to stock
Download the latest Magisk zip file
If you choose to use SuperSU (only support Android 6.0+), first flash SuperSU in systemless mode
Flash Magisk zip
Reboot, and update the stub Magisk Manager to the latest from Play Store
Click to expand...
Click to collapse
I read 200 times but when I install Magisk without SuperSU (because I want MagiskSU) TWRP give me an error and install fail... read my initial post first please....
Error:
Code:
! SU image mount failed...
! Please immediately flash SuperSU now
! Installation will complete after flashing SuperSU
[B]Updater process ended with ERROR: 1
Error installing zip file 'sdcard/Download/Magisk v11.1/Magisk-v11.1.zip[/B]

dhaern said:
I read 200 times but when I install Magisk without SuperSU (because I want MagiskSU) TWRP give me an error and install fail... read my initial post first please....
Error:
Click to expand...
Click to collapse
You need to FULLY unflash superSU using the zip that the other person told you to google.

PartyPlease said:
You need to FULLY unflash superSU using the zip that the other person told you to google.
Click to expand...
Click to collapse
Ok I will try unflash with the zip, I was using unroot inside superSU menu but installation instructions dont say nothing about the unflash with an extrenal script

dhaern said:
Ok I will try unflash with the zip, I was using unroot inside superSU menu.
Click to expand...
Click to collapse
Yeah that button doesn't work for systemless superSU. It doesn't roll back your boot.IMG like it should.
Worst case scenario, flash the stock boot.img and then flash magisk.

Thanks guys, I installed Magisk v11.1 with MagiskSU working, Magisk Hide enabled but I have CTS mismatch error now in Safetynet test. I guess I cant do nothing about this error. Optimized LineageOS 14.1 and Samsung Galaxy S4
EDIT: Finally I passed the Safetynet test (no CTS mismatch error) disabling ADB interface in developer options. Thanks for Magisk, amazing.

PartyPlease said:
Yeah that button doesn't work for systemless superSU. It doesn't roll back your boot.IMG like it should.
Worst case scenario, flash the stock boot.img and then flash magisk.
Click to expand...
Click to collapse
ahh, this would explain why my boot.img was not the same after "unrooting"! thanks for clearing this up for me...

dhaern said:
Thanks guys, I installed Magisk v11.1 with MagiskSU working, Magisk Hide enabled but I have CTS mismatch error now in Safetynet test. I guess I cant do nothing about this error. Optimized LineageOS 14.1 and Samsung Galaxy S4
EDIT: Finally I passed the Safetynet test (no CTS mismatch error) disabling ADB interface in developer options. Thanks for Magisk, amazing.
Click to expand...
Click to collapse
By disabling ADB interface, do you mean the USB debugging part? for some reason I am still getting Safetynet error.

vicky_ag said:
By disabling ADB interface, do you mean the USB debugging part? for some reason I am still getting Safetynet error.
Click to expand...
Click to collapse
Yeah I said USB debugging option, when I disabled this I passed Safetynet test.

dhaern said:
Yeah I said USB debugging option, when I disabled this I passed Safetynet test.
Click to expand...
Click to collapse
Thanks but doesn't seem to work for me.

dhaern said:
Yeah I said USB debugging option, when I disabled this I passed Safetynet test.
Click to expand...
Click to collapse
Thanks for this hint; got my build "passed" now appreciate it

What settings are you guys using in Magisk? I have disabled BusyBox, enabled Magisk Hide and systemless hosts. Superuser options are Access to "Apps and ADB" and Automatic Response set to prompt

I'm still having an issue installing Magisk on my phone with RAMROM V10. It gives me an ERROR 1.
It has been suggested that I should re-flash my boot.img with TWRP following the instruction:
Place your BOOT.img on your sdcard
Reboot into TWRP recovery
Tap "Install"
In the bottom right corner tap "Install Image"
Select your BOOT.img
Select the Boot Partition, then swipe to confirm Flash
However, when I follow the step, my TWRP cannot seem to find BOOT.IMG in my SD Card (I know it is there). What did I do wrong? Can anyone help?

i think the .img thingy is only for twrp.img files. You have to use another method to place your boot image like. -> make a backup of only your boot image via twrp backup function. Then duplicate that backup folder of twrp containing only the newly just regernated files, in the twrp folder. Then replace the su-modified boot file there with your original boot file, you obviously have to rename your boot image to fit the right name. (eg. with the logo image -> logo.bin changes to logo.emmc.win -> etc;.) Then use the twrp restore function to restore your "original" boot logo.
Hierarchy folder view would be like:
TWRP->folder 1 (original folder, in case something goes wrong)-> boot file and others
->folder 2 (our modified folder)-> files

sm00th4f3 said:
i think the .img thingy is only for twrp.img files. You have to use another method to place your boot image like. -> make a backup of only your boot image via twrp backup function. Then duplicate that backup folder of twrp containing only the newly just regernated files, in the twrp folder. Then replace the su-modified boot file there with your original boot file, you obviously have to rename your boot image to fit the right name. (eg. with the logo image -> logo.bin changes to logo.emmc.win -> etc;.) Then use the twrp restore function to restore your "original" boot logo.
Hierarchy folder view would be like:
TWRP->folder 1 (original folder, in case something goes wrong)-> boot file and others
->folder 2 (our modified folder)-> files
Click to expand...
Click to collapse
FIY: Flashing regular boot.img files works just fine with "Install Image" in TWRP (of course, YMMV, depending on your device).

The root permission request is no longer displayed

I have the root with Magisk in Android 8.0. At first, the warning always came out asking if you wanted to grant root rights to the application that you just opened. However, this warning is no longer displayed, even though the configuration of Magisk Manager is configured in this way.
In the Magus Superuser section, I do not see any trace of the applications that I can not 'root'.
I have updated Magisk Manager, but the error continues. I also removed BusyBox, but the error continues.
I can not give root permission to any other application. But the mobile is rooted, since the first applications that I installed that require root continue to function normally. I can even deactivate the root and then activate it again.
Reinstalling the applications is not solved. With Dalvik and Caché wipe either.
That could be happening? How is it solved?
____
Magisk Manager has all the permissions of everything (memory, background, manual battery mode). I have tried to reinstall Magisk Manager and nothing.
Deactivating BusyBox (Magisk module) and Xposed and restarting still does not work.
Returning to install the Magisk image by TWRP or Fastboot is not fixed either.
I have removed all the fret that I had done to the phone (BusyBox, Xposed, root Magisk and boot modified for the root) and the problem has not been solved. I do not know what may be happening. I do not have other rare applications.
I have installed Device Control and the TWRP application. I have not gotten the root request to skip (although it has activated that option in Magisk Manager).
Definitely, it is not the fault of the new applications, which was the first question I wanted to solve.
Magisk version:
19.3 (19300)
And from Manager 7.2.0 (213), although I have also tried 7.3.2 (224).
The root is done with patching (via Magisk) of RAMDISK.IMG.
I understand that some applications are not compatible with systemless. But I'm not going any of the new ones that I'm trying. Interestingly, other applications compatible with Magisk (except those that installed the first days of the mobile) do not work either.
I have installed Magisk Manager 7.0.0 (and also 6.1.0), but the bug is still there. It seems that it does not depend on the APK.
As my Magisk file to root consists of a patch of RAMDISK.IMG created directly from Magisk Manager I do not know how to create one based on a lower version (for example, version 18.1). It only gives me the option to patch with the latest Magisk Manager version (if I have a lower one, it asks me to update the APK).
Whenever I generate the IMG of my patched RAMDISK.img it is based on 19.3.
How could I generate a patched IMG based on a lower version?
I have microG, not the GApps. Could that influence? Does Magisk need them?

@rovo89

@topjohnwu

https://www.didgeridoohan.com/magisk/MagiskHelp

I have added much more information.

Reinstall firmware???

LoneWolfz said:
Reinstall firmware???
Click to expand...
Click to collapse
I'm going to do it today. Will I lose data if I install SYSTEM.img via Fastboot?

535iu said:
I'm going to do it today. Will I lose data if I install SYSTEM.img via Fastboot?
Click to expand...
Click to collapse
No maybe but i suggest you to backup all your data etc. just to be safe

No root prompt in Lineage OS 16.0 with Magisk installed

Dear XDA,
Model: Xiaomi Redmi 4X(Santoni)
Used TWRP:
Installed latest Lineage OS 16.0 of November 20, 2019 with formatting internals and wiping system, vendor, dalvik and cache.
Installed lastest Magisk v20.1 from GitHub page
Booted ROM and installed "MagiskManager-v7.4.0.apk" from above link
As the result:
MagiskManager shows everything green
No root prompt in any application and Root Checker shows that root is not installed.
"Settings -> System -> 'Developer options' -> 'Root access'" have only two options: Disabled and "ADB only"
Already have tried:
Disabling power optimization entry for MagiskManager
Reinstall Magisk using MagiskManager
What might be the reason of no prompt issue?
Why not SuperSU: is it worth to tell why? For example, basically Netflix won't work etc.
Thank you very much for any working suggestion.

This happened to me too once. What helped was simply re-flashing the 20.1 Magisk zip. It contains the Manager apk, so no need to install it separately.

I Have Nexus 5x and Lineage OS 15.1.
For me it was Lineage OS issue. Instead 20191118 I flashed 20191105. I had some other weird bugs too.

Ænimal said:
This happened to me too once. What helped was simply re-flashing the 20.1 Magisk zip. It contains the Manager apk, so no need to install it separately.
Click to expand...
Click to collapse
What do you mean by reinstall? Something like that:
Wipe phone
Install Lineage OS image
Install Magisk zip
Boot
Reboot into recovery
Install Magisk zip
Boot
Are above the full steps you suggesting?

vv77vv said:
What do you mean by reinstall? Something like that:
Wipe phone
Install Lineage OS image
Install Magisk zip
Boot
Reboot into recovery
Install Magisk zip
Boot
Are above the full steps you suggesting?
Click to expand...
Click to collapse
I thought I expressed myself pretty clearly. Well, a clean install of your system is always a good idea (given you backed up all your personal data) .You can also just extract the boot.img from your LOS image and flash that in twrp prior to flashing magisk. But what I did when the root prompt didn't pop up was simply flashing the magisk zip again in twrp, (maybe wiping caches as well) and after rebooting magisk su was working as intended.. Good luck

25.2 upgrade error (mine)

In 25.1, I'd enabled zygisk and used magiskhide then frozen the renamed magisk app using SDmaid in order to use banking app.
I upgraded to 25.2 via twrp but couldn't see the magisk app as it was frozen. At this point SD maid had lost root so I couldn't unfreeze the old app.
I installed the latest APK but it doesn't think magisk is installed and the only option given is to patch boot IMG which seems pointless as magisk 25.2 already flashed using recovery successfully (result 1.000).
Any ideas most welcome. Would prefer not to wipe data as a few of my apps need special manual verification by their support team each time they're installed which is cumbersome.