Magisk bricks my phone - Magisk

I'm doing a clean install of this rom on my Samsung S4 using the Aroma installer (Note: problem not related to aroma - see edits below).
The installer has an option to use Privacy Guard (for phones with a locked bootloader), SuperSU, or Magisk.
If I install Magisk, the phone is stuck at the Samsung logo indefinitely. If I choose either of the other options, it boots fine.
I've tried a number of different ways around this:
1. Choosing the Magisk option in the Aroma installer.
2. Choosing Privacy Guard for the rom install and then manually installing Magisk 16.0 afterwards.
3. Choosing Privacy Guard for the rom install and then manually installing Magisk 16.0 with the updater-script modified (commenting out the two lines) afterwards.
4. Choosing Privacy Guard for the rom install and then manually installing Magisk 16.6 afterwards.
5. Choosing Privacy Guard for the rom install and then manually installing Magisk 16.6 with the updater-script modified (commenting out the two lines) afterwards.
All of the above options - every way I can think of - results in bricking the device.
Is there a way to make this work?
Edit:
1. I'm using TWRP 3.1.1.0, if it matters. And yes, my S4 has an unlocked bootloader (MDL).
2. The phone will boot fine if I choose the Aroma SuperSU option, but I discovered that SuperSU is not installing correctly either. It just doesn't brick my phone.
3. I tried running the NON-aroma rom installer. Then I used UnSU to remove the non-functioning SuperSU, and ran the Magisk 16.0 installer (normal one). Bricked.
Rebooted into recovery, ran the Magisk Uninstaller - it failed, saying "Magisk is not installed".
So I tried installing Magisk again - which installed with no errors. And then I immediately ran the uninstaller, and again it failed, saying that Magisk was not installed. Maybe that's a clue as to what's going on. Because it's clearly not related to the aroma installer anymore.
4. I added the recovery log. This shows me doing a wipe, installing the rom linked to above, flashing Magisk, then flashing the Magisk uninstaller so you can see it say that Magisk was never installed in the first place.

I've been having zero luck getting this to work. Does anyone have any ideas?

Maybe you should read this, https://forum.xda-developers.com/ap...7-universal-systemless-t3473445/post77014053, sounds like the issue you're having and apparently Armoa breaks Magisk install. Also go to general support thread and post logs, etc. You will get more help there.

yung40oz84 said:
Maybe you should read this, https://forum.xda-developers.com/ap...7-universal-systemless-t3473445/post77014053, sounds like the issue you're having and apparently Armoa breaks Magisk install. Also go to general support thread and post logs, etc. You will get more help there.
Click to expand...
Click to collapse
Thank you. However, as I stated above, although I started with the aroma installer, I eventually tried the non-aroma installer and had the exact same problem.
In addition, I also tried the normal versions as well as ones that had been patched as per the instructions on the link you posted.
So whatever is causing this does not appear to be aroma related.

Haphim said:
So I tried installing Magisk again - which installed with no errors. And then I immediately ran the uninstaller, and again it failed, saying that Magisk was not installed. Maybe that's a clue as to what's going on. Because it's clearly not related to the aroma installer anymore.
Click to expand...
Click to collapse
It would be interesting to see the recovery log from that...
It kind of sounds like there's some issue with your recovery. Have you tried letting the Manager patch your ROM's boot image and then flash that to your device manually?

Didgeridoohan said:
It would be interesting to see the recovery log from that...
It kind of sounds like there's some issue with your recovery. Have you tried letting the Manager patch your ROM's boot image and then flash that to your device manually?
Click to expand...
Click to collapse
I tried letting the Manager patch the boot image. I got the boot image by extracting it from the LineageOS rom. However, it would appear that the rom installer Loki's it on the fly, so the extracted rom by itself didn't pass the kernel signature check. This wouldn't be a problem if Magisk Lokied it during the patching process, but apparently it doesn't.
If there's an easy way to get the already lokied boot image off of my phone, I would appreciate being pointed in the right direction and I'll try it again. When installing Magisk, it allegedly backs up the boot image - if so, is there a way for me to recover it?
In any case, I went through the full routine all over again so that I could get the recovery log. I added it to the top post. It shows me doing a wipe, installing the LineageOS rom linked to in the top post, flashing Magisk, then flashing the Magisk Uninstaller immediately afterwards so that you can see it say that Magisk was never installed in the first place.

I just tried using TWRP 3.1.0.0 instead of 3.1.1.0 - no change.
Is there an easy way to extract the current boot.img (not the one from the rom installer, since that hasn't been Loki patched)? If so, I can try the patching through the app again.
Otherwise, if there are any other ideas, I would love to hear them.
Otherwise, I may have no choice but to buy a new phone if this one can no longer be rooted.

Related

Magisk Manager constant crashes after reinstalling ROM

Hey,
I've been getting constant Magisk Manager crashes every time I try to run it even after multiple "full wipes" (except internal sdcard data) and I can't even get the logs because it doesn't let me access them and there's no folder with logs in them. What am I supposed to do? I already flashed the stock kernel and it didn't fix it. My ROM is the XtreStoLite and I'm using a Galaxy S6 920F. What could be causing it to crash even after "full" wipes?
Thanks
EDIT: Additionally, I can install Magisk without any problem in recovery but whenever I try to run an app that requires root rights, it shows the "Magisk Manager stopped working" error
I just did a complete wipe of literally everything I had on my phone, internal storage included and installed the rom back and magisk manager still crashes... what the hell?
Edit: Installed a logcat app to look at the logs when it crashes and here is the important part, I think:
E/AndroidRuntime(13780): Process: com.topjohnwu.magisk, PID:13780
E/AndroidRuntime(13780): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.topjohnwu.magisk/com.topjohnwu.magisk.SplashActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources android.content.Context.getResources()' on a null object reference
Click to expand...
Click to collapse
Edit 2: Alright I've no idea what's wrong but v4.1 works fine, v4.2 crashes all the time even though it was working literally yesterday. Welp, whatever
Im on Resurrection Remix and when I install a Rom update, the managers "loses the root" too, I download the zip (and flash it) again and its a lucky strike if when the phone reboots, the magisk returns to normal and regain the root.
GolpeadorMágico said:
Im on Resurrection Remix and when I install a Rom update, the managers "loses the root" too, I download the zip (and flash it) again and its a lucky strike if when the phone reboots, the magisk returns to normal and regain the root.
Click to expand...
Click to collapse
That does not sound like the issue in the OP...
After a ROM update you'll have to flash the Magisk zip again, since the ROM most likely also updates the boot image, thus removing the Magisk modifications (including MagiskSU).
Didgeridoohan said:
That does not sound like the issue in the OP...
After a ROM update you'll always (well, almost) have to flash the Magisk zip again, since the ROM most likely also updates the boot image, thus removing the Magisk modifications (including MagiskSU).
Click to expand...
Click to collapse
So you are saying that I have to flash it in the same process, all together*, not flash, reboot and later flash the magisk zip?
*(Flash> mount rom zip+gapps+magisk)
GolpeadorMágico said:
So you are saying that I have to flash it in the same process, all together*, not flash, reboot and later flash the magisk zip?
*(Flash> mount rom zip+gapps+magisk)
Click to expand...
Click to collapse
You can boot up after updating, to make sure it's working and then flash Magisk. Doesn't really matter...
I usually flash the update, custom kernel and lastly Magisk zip, all in one go.
Didgeridoohan said:
You can boot up after updating, to make sure it's working and then flash Magisk. Doesn't really matter...
I usually flash the update, custom kernel and lastly Magisk zip, all in one go.
Click to expand...
Click to collapse
Oks. that´s is how I usually do it. I´m going to try again.
Guys, I´m sorry for the double post but I reinstaled it and nothing, the magisk managers says that the phone is not rooted.
***NEW: The problem is busybox. Uninstall it, reinstall magisk and problem solved.

Bootloop - New fi Moto x4

I've just gotten my new fi Motorola x4 running Android 8.1.0 today. I've unlocked the boot loader via Motorola and I've rooted the device via Magisk. Since I had the Xposed framework on my old phone and loved some of the modules I wanted it on my new phone. Downloaded the Xposed Installed from the playstore, gave it root access with Magisk and attempted to install the framework. Phone is now stuck in a bootloop and it's been alternating between the androidone and motorola screens for about 45 minutes.
I tried to flash xposed-uninstaller-20180117-arm64.zip but got an error that it couldn't mount /system. Another page on the net had me holding down the power button and then spamming it ten times to tell Xposed no to load but that didn't seem to do anything at all. I created a disabled file as suggested on some sites but that did nothing to stop the bootloop:
touch /data/data/de.robv.android.xposed.installer/conf/disabled
I actually had to make the /conf directory manually since it wasn't there. Wiped the cache with no better results. Factory reset did nothing to improve the situation and I was unsuccessful with sideloading the Xposed disabler found here:
https://android.gadgethacks.com/how-to/xposed-101-temporarily-disable-xposed-fix-bootloop-0179446/
It's hard for me to grasp how a completely empty barebones android phone which has only been rooted using Magisk with no other actions taken or software installed can be be stuck in a bootloop trying to perform a standard install using the Xposed installer. Not sure you can find a cleaner environment than the one on my phone.
Anyway if anyone has thought I'd love to hear them. I can boot to TWRP without issue and my phone is visible to both fastboot and adb.
Thank you!
Laugh this is just getting worse. I uninstalled Magisk and now the phone boots straight into recovery whenever I restart it. I'd flash a stock rom but I can't find one. I think I'm in trouble...
Reinstalled Magisk and it at least tries to boot up again but it just loops.
Arsenal420 said:
I've just gotten my new fi Motorola x4 running Android 8.1.0 today. I've unlocked the boot loader via Motorola and I've rooted the device via Magisk. Since I had the Xposed framework on my old phone and loved some of the modules I wanted it on my new phone. Downloaded the Xposed Installed from the playstore, gave it root access with Magisk and attempted to install the framework. Phone is now stuck in a bootloop and it's been alternating between the androidone and motorola screens for about 45 minutes.
I tried to flash xposed-uninstaller-20180117-arm64.zip but got an error that it couldn't mount /system. Another page on the net had me holding down the power button and then spamming it ten times to tell Xposed no to load but that didn't seem to do anything at all. I created a disabled file as suggested on some sites but that did nothing to stop the bootloop:
touch /data/data/de.robv.android.xposed.installer/conf/disabled
I actually had to make the /conf directory manually since it wasn't there. Wiped the cache with no better results. Factory reset did nothing to improve the situation and I was unsuccessful with sideloading the Xposed disabler found here:
https://android.gadgethacks.com/how-to/xposed-101-temporarily-disable-xposed-fix-bootloop-0179446/
It's hard for me to grasp how a completely empty barebones android phone which has only been rooted using Magisk with no other actions taken or software installed can be be stuck in a bootloop trying to perform a standard install using the Xposed installer. Not sure you can find a cleaner environment than the one on my phone.
Anyway if anyone has thought I'd love to hear them. I can boot to TWRP without issue and my phone is visible to both fastboot and adb.
Thank you!
Click to expand...
Click to collapse
https://magiskroot.net/uninstall-magisk-module-twrp/
https://forum.xda-developers.com/showpost.php?p=72542167&postcount=242
In summary:
Step 1: Download the flasheable zip file from the Magisk module uninstaller from the following link to the PC
Step 2: Send the zip file to the SD card of the phones or to the internal memory using MTP (most of the recovery of TWRP is compatible with this method)
Step 3: Now, touch the Install button and choose the Zip file of the uninstaller of the Magisk module that you want to update.
Step 4: After the completion of the installation. Go back to the TWRP home page.
Step 5: Tap the advanced option from the TWRP homepage. Choose the terminal option now.
Step 6: Type uninmod in the terminal box and touch the input button.
Step 7: Now, you can see the list of Modules and you have to type the Number you want to uninstall (Check the screenshot below)
Step 8: Finally, the magisk module will be completely uninstalled.
Arsenal420 said:
. Downloaded the Xposed Installed from the playstore,
Click to expand...
Click to collapse
What xposed installer in playstore, playstore is not where xposed is gotten from...at all. The closest thing to it that I found is an asian trick your friends app.
Nergal di Cuthah said:
What xposed installer in playstore, playstore is not where xposed is gotten from...at all. The closest thing to it that I found is an asian trick your friends app.
Click to expand...
Click to collapse
You are right I got the apk from here:
https://forum.xda-developers.com/showthread.php?t=3034811
Do you have anything additional to offer?
Arsenal420 said:
You are right I got the apk from here:
https://forum.xda-developers.com/showthread.php?t=3034811
Do you have anything additional to offer?
Click to expand...
Click to collapse
Ok good, I got scared for you a bit there, my post was not meant to be mean spirited but maybe you read it as such. As far as the bootloop i'm afraid i'll be no help.

Stuck in Download mode bootloop after updating from v20.x to v21.x

Phone Model no : Samsung Galaxy S6 / SM-G920F
Security patch date: 01.10.2017
Android version: 7.0
Root status: Yes
Hey guys,
I rooted my phone several weeks ago for the first time via odin and everything went fine. I installed TWRP and Magisk and everything worked out.
Today I was trying to update Magisk from v20.x to v21.x with the inapp option, but now im stuck in a bootloop to download mode, screen says "Downloading... do not turn off target".
Even if I turn the phone off with Power + Home + Vol Down its just restarting right away and getting stuck in the same screen again.
Im still able to enter TWRP Recovery, but I dont know what to do to end the download mode problem when trying to start the phone.
I actually dont know/understand much about that stuff, so I dont know which other info I need to provide.
Is there something I could do without going through the whole flash/root process again?
should i try to delete magisk and install it again? if yes, how do i do it?
Help would be appreciated.
n00btuber said:
Phone Model no : Samsung Galaxy S6 / SM-G920F
Security patch date: 01.10.2017
Android version: 7.0
Root status: Yes
Hey guys,
I rooted my phone several weeks ago for the first time via odin and everything went fine. I installed TWRP and Magisk and everything worked out.
Today I was trying to update Magisk from v20.x to v21.x with the inapp option, but now im stuck in a bootloop to download mode, screen says "Downloading... do not turn off target".
Even if I turn the phone off with Power + Home + Vol Down its just resarting right away and getting stuck in the same screen again.
Im still able to enter TWRP Recovery, but I dont know what to do to end the downloading problem when trying to start the phone.
I actually dont know/understand much about that stuff, so I dont know which other info I need to provide.
Is there something I could do without going through the whole flash/root process again?
should i try to delete magisk and install it again? if yes, how do i do it?
Help would be appreciated.
Click to expand...
Click to collapse
I don't know much about your device but if you can enter TWRP, it's not that bad. First what you can try is to download Magisk uninstaller and flash it in TWRP from USB. However, I don't know what can you do to update Magisk safely. Would be best if you can check your device forum or ask the question there
Lord Sithek said:
I don't know much about your device but if you can enter TWRP, it's not that bad. First what you can try is to download Magisk uninstaller and flash it in TWRP from USB. However, I don't know what can you do to update Magisk safely. Would be best if you can check your device forum or ask the question there
Click to expand...
Click to collapse
Looked like my device forum is pretty dead, which is why I asked the question here again. Thanks for the fast respone
Its probably not possible to just install a Magisk version again and overwrite the current one, probably need to uninstall first and then install it again?
There is a Magisk Module Uninstaller and a Magisk Uninstaller. Are those different things or just the same?
How to Uninstall Magisk Module Using TWRP Recovery | MagiskRoot
Uninstall Magisk Module using TWRP Recovery or Offline whenever you stuck into bootloop. Magisk Module Uninstaller and Magisk Manager for Recovery methods.
magiskroot.net
How to Uninstall Magisk From Android [2 Easiest Method]
Are you facing issues with Magisk? You can uninstall magisk from your phone with these simple and easy steps.
magiskmanager.com
Because the 2nd guide says in the end
Keep in Mind – Whenever you use TWRP as a method to uninstall Magisk, it is imperative to flash the Magisk Module Uninstaller Zip onto your device.
Does this mean I need to do the magisk module one first?
@n00btuber Do not trust those websites. They're in no way official and are just trying to get adc revenue from Magisk's popularity. If you're really unlucky they'll also provide you with malicious zips...
Only download stuff from John's GitHub:
https://github.com/topjohnwu/Magisk
If you need to uninstall Magisk use the uninstall zips from the above linked Github repo, and if you need to uninstall modules (but those will also be removed by the Magisk uninstaller) you can do that directly from TWRP:
https://www.didgeridoohan.com/magisk/Magisk#hn_Uninstalldeletedisable_modules_from_recovery
A lot of times you can just flash another Magisk version over your installed one, but there are times where you do need to uninstall first. Since you have TWRP it can't really hurt to just try flashing whatever Magisk zip you want and it it doesn't work you can just use the uninstaller first.
One other thing to try would be the Canary release, mainly to see if you're affected by any bugs that is present in the current stable release but has been fixed upstream. You'll find the Canary app in the same Github link above.
Didgeridoohan said:
@n00btuber Do not trust those websites. They're in no way official and are just trying to get adc revenue from Magisk's popularity. If you're really unlucky they'll also provide you with malicious zips...
Only download stuff from John's GitHub:
https://github.com/topjohnwu/Magisk
Click to expand...
Click to collapse
Ok.
Was trying to use the uninstaller from his GitHub.
Trying to flash it leads to
"Updater process ended with ERROR:1
Error installing Zip file .....
Updating partition details"
So what to do now?
Trying to just flash any Magisk version to overwrite the current one leads to the same result.
I think it says Unsupported/Unknown image format
Your TWRP might be bugged/incompatible. I'd reflash your stock boot image and then patch the file manually (you'll find the instructions for that on GitHub as well).
Didgeridoohan said:
Your TWRP might be bugged/incompatible.
Click to expand...
Click to collapse
But TWRP worked fine when installing magisk the first time, I even tried the same zip folder I used to install it back then, but it wont work anymore.
Didgeridoohan said:
I'd reflash your stock boot image and then patch the file manually (you'll find the instructions for that on GitHub as well).
Click to expand...
Click to collapse
However, whats my stock boot image and how to reflash it? Cant find a guide for that on GitHub.
Would a Factory Reset wipe all Magisk stuff and my TWRP Partition as well?
Does anyone know what is going on between Magisk and Google? It seems Google has removed Magisk Manager from the Play Store AGAIN! What's more, I downloaded and installed the apk but when I try to use it to install the latest Magisk the install fails. Tried installing the Magisk zip via TWRP, and while it doesn't show any errors, I still don't have root.
Ok I really need some more help @Didgeridoohan
Meanwhile I tried to reinstall TWRP from within TWRP. There was no error so I think it should have worked, but didnt solve the problem.
As soon as I try to boot the system it directly boots download mode and gets stuck in it. The volume buttons wont work or do anything as they are supposed in download mode.
Im still able to get into TWRP, but I still dont know what to do to stop this crashed download mode that starts over and over again.
When trying to flash the magisk uninstall it states "cannot access /data", when trying to flash a magisk installer it states "unsupported/unknown image format"
I dont care about Magisk right now though, I can root and install magisk again as soon as im able to clear the download mode problem. I was just trying this because trying to update magisk from within magisk manager has caused this download mode problem to appear.
Just tell me please how to fix that or how to factory reset my phone so it is able to boot regular again.
Thank you
n00btuber said:
Ok I really need some more help @Didgeridoohan
Meanwhile I tried to reinstall TWRP from within TWRP. There was no error so I think it should have worked, but didnt solve the problem.
As soon as I try to boot the system it directly boots download mode and gets stuck in it. The volume buttons wont work or do anything as they are supposed in download mode.
Im still able to get into TWRP, but I still dont know what to do to stop this crashed download mode that starts over and over again.
When trying to flash the magisk uninstall it states "cannot access /data", when trying to flash a magisk installer it states "unsupported/unknown image format"
I dont care about Magisk right now though, I can root and install magisk again as soon as im able to clear the download mode problem. I was just trying this because trying to update magisk from within magisk manager has caused this download mode problem to appear.
Just tell me please how to fix that or how to factory reset my phone so it is able to boot regular again.
Thank you
Click to expand...
Click to collapse
Sounds to me like you need to reflash your ROM, not TWRP. According to your OP, you're running Android 7, but it doesn't say if it is stock or a custom ROM.. If it is stock, then use Frija.exe to download the ROM and then flash th AP, BL and HOME_CSC md5 files with Odin. If it is a custom ROM, use TWRP to flash the ROM and gapps. DO NOT try to flash Magisk. Right now there seems to be a problem with Google disabling Magisk. Wait till it is resolved before attempting to get root.
@n00btuber Dirty flashing your ROM is most likely the way to go, just like described above.
But @lewmur, what do you mean by "Google disabling Magisk"? If you're talking about SafetyNet there are ways around that (and it doesn't affect root)...
Didgeridoohan said:
@n00btuber Dirty flashing your ROM is most likely the way to go, just like described above.
But @lewmur, what do you mean by "Google disabling Magisk"? If you're talking about SafetyNet there are ways around that (and it doesn't affect root)...
Click to expand...
Click to collapse
I not talking about safety net. Look in Play Store for Magisk Manager. It is no longer there. And even if you download and install the apk, it won't install Magisk. Flashing Magisk from TWRP doesn't give root privileges. This just happened yesterday.
lewmur said:
I not talking about safety net. Look in Play Store for Magisk Manager. It is no longer there. And even if you download and install the apk, it won't install Magisk. Flashing Magisk from TWRP doesn't give root privileges. This just happened yesterday.
Click to expand...
Click to collapse
The Magisk Manager hasn't been on the Play Store for years... Edit: reference - https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-72508849
Nothing of what you describe has anything to do with Google "disabling Magisk".
Didgeridoohan said:
The Magisk Manager hasn't been on the Play Store for years... Edit: reference - https://forum.xda-developers.com/t/magisk-the-magic-mask-for-android.3473445/post-72508849
Nothing of what you describe has anything to do with Google "disabling Magisk".
Click to expand...
Click to collapse
That 's my mistake. Play Store would put up a lot of "Magisk Manager" stuff, but I never really tried any of it because flashing Magisk would give me the Manager. But even that "stuff" no longer shows up.
Butt Magisk Manager still won't install Magisk. It will download the zip file, but when it attemps to install it, it get an error saying Unsupported/Unknown image format. If I flash it from TWRP, and then open Magisk Manager, it still says N/A under Installed for Magisk.
lewmur said:
Then why won't Magisk Manager install Magisk. It will download the zip file, but when it attemps to install it, it get an error saying Unsupported/Unknown image format. If I flash it from TWRP, and then open Magisk Manager, it still says N/A under Installed for Magisk.
Click to expand...
Click to collapse
That will be an incompatibility between Magisk and your device and has nothing to do with Google (blame your OEM for doing weird stuff instead).
Thanks for the help guys, had to flash the ROM, now its working again.

Magisk 25.2 severely breaks LineageOS 18.1 on Samsung Galaxy Tab S5e (SM-T725)

For some odd reason Magisk breaks auto-rotation and sets selinux to permissive on boot after updating to 25.2 (from 25.1).
This is not the first time Magisk messes up Selinux rules. I usuall solved this by making a fresh OS install already with patched boot and by installing the managing app afterwards.
However, this time autorotation stopped working for some reason. And when i try to uninstall Magisk using its app -- OS no longer boots, as if it fails to restore initial boot image.
This selinux problem began since v25.
I use latest official build of Lineage OS 18.1. I have TWRP installed, which i use to install LineageOS.
What am i doing wrong? Has anyone experienced such issues?
I posted the same problem here (did not notice/checked SELinux back then and sound is probably also not working), figured out that all sensors do not work, checked with "Sensor Test" app. I was already considering a separate thread, thus I'll continue here, because this issue definitely deserves a separate thread. Documentation is so scattered and sometimes so confusionly described, that it was hard to make sense of it all...
(Disclaimer: Although I have necessary experience with installing custom ROMs etc., everything stated below is at my own understanding ).
My device: Samsung Galaxy Tab S5e LTE
My goal was: TWRP, LineageOS and Magisk. How hard can it be?
Problems are that (most of the) Samsung devices do not have a "ramdisk" partition where Magisk is normally installed, also the increasingly complexity of encryption en integrity checks makes this more annoying.
First, let me retrace my steps, as far as I can.
When reading the TWRP page, we get a clue where to start: "You are therefore strongly advised to first root your device with Magisk and then pre-root a TWRP image before flashing it to recovery", this is because "Both TWRP and Magisk-rooted Android boot using the recovery kernel, with the device's hardware keys used to choose between TWRP and Android at boot time".
(Magisk "hijacks" part of the recovery partition, since the absence of a ramdisk partition.)
Spoiler: later on you learn this is not completely the case any more, but I would still recommend to hold on to this method, because the TWRP page also states that: "The usual path of installing TWRP prior to rooting is problematic on this device, because the Magisk installer does not support installation to recovery from TWRP. Furthermore, prior rooting of the device with Magisk carries the significant advantage of disabling various device protection mechanisms that you will otherwise need to take care of manually.", and it continues with more scary warnings...
1. Thus followed the Samsung section of the Magisk documentation to have the bootloader unlocked and Magisk installed, but stock firmware is still installed, no problem whatsoever.
Then decipher the already mentioned instruction: "...pre-root a TWRP image before flashing it to recovery". This apparently means that Magisk has to patch the TWRP image, just like as was done with the Samsung firmware.
2. Downloaded the *.tar file of TWRP, extracted the image, patched with Magisk and repacked to the *.tar file with 7-Zip in order to be able to flash it with Odin (see step 4).
*3. I do not recall when I installed the "VBMeta file", although this is instructed in the Lineage OS installation instructions, when following the TWRP instructions it says "...you can now jump to its own section", thus skipping it?? (I did it somewhere in the process...)
Unknown: whether it is still required to patch and flash VBmeta (to disable some verification process)...
4. Flash TWRP recovery, see YouTube video below. This video mentions the use of "multidisabler-samsung", which disables "FBE, proca, Vaultkeeper and auto-reflash of stock recovery on Samsung Pie devices". Current latest version was 3.1, downloaded from this XDA post, I think.
Just as in the YouTube video, I also was stuck at the Samsung logo. After booting into the stock firmware you can check if Magisk still works.
Not sure: "multidisabler-samsung" needed?
5. Install LineageOS (and GApps). The most straightforward step, just install LineageOS, read the instructions. Then install GApps (e.g., BiTGApps).
6. After booting (power and volume + button) and setting up LineageOS, a Magisk icon should be visible in the app drawer, click it and the Magisk app is installed, when opened, Magisk is setting up a few more things and reboots the tablet.
*******************************************************************************************
This is the point were you finally think you made it, but no, here the issues arise.
Issues thus being SELinux permissive status (Xandros Darkstorm), no sound and non-working sensors, thus "auto rotating" feature is not working.
At this point I started to regret my purchase...
In the search of a solution to the problem I stumbled upon the following familiar and solved Magisk issue #4911 (LineageOS 18.1 no sound and no sensors after booting with Magisk), which refers to issue #4394 (Magisk > 21.4 is difficult to install on LineageOS (18.1) with TWRP (Direct Install not enabled unless you use old zip)).
In short: this post mentioned patching the boot image instead of the recovery image.
*******************************************************************************************
I. I extracted "boot.img" from the LineageOS zip file, patched it via Magisk (ramdisk is added to the boot image) and replaced the "boot.img" in the zip file with 7-Zip.
II. Booted into TWRP, flashed an original TWRP image, so recovery is replaced. (Rebooted I guess.)
III. Then wiped previously LineageOS installation and, flashed the LineageOS zip file with patched boot image and GApps and rebooted to system.
IV. After setting up, install Magisk, let is do its thing.
V. I installed "Root Checker Basic" in order to check I gained root checker. It was a PASS! And checked with "Sensor Test" if all sensors worked, they did! And sound also worked .
Yay!
Clearly, all of this can be optimized. Some questions remain, what steps are really necessary and I am also still wondering how to apply a LineageOS update... Anyhow at least it is working.
What resolved
Xandros Darkstorm said:
For some odd reason Magisk breaks auto-rotation and sets selinux to permissive on boot after updating to 25.2 (from 25.1).
This is not the first time Magisk messes up Selinux rules. I usuall solved this by making a fresh OS install already with patched boot and by installing the managing app afterwards.
However, this time autorotation stopped working for some reason. And when i try to uninstall Magisk using its app -- OS no longer boots, as if it fails to restore initial boot image.
This selinux problem began since v25.
I use latest official build of Lineage OS 18.1. I have TWRP installed, which i use to install LineageOS.
What am i doing wrong? Has anyone experienced such issues?
Click to expand...
Click to collapse
What fixed this for me is after re-flashing stock in Odin to get everything working again, just rename the magisk apk to install.zip and flash that in twrp, and open the magisk app once booted, no other steps needed for install, no image patching or anything.
Might be worth seeing if this is the same issue or if there's a more fundamental problem with 25.2
Hi,
I stumbled upon this thread while searching for a way to install Magisk on a S5e.
Following the guide here: https://wiki.lineageos.org/devices/gts4lvwifi/install I already unlocked the bootloader, flashed vbmeta.tar with Odin, flashed lineage-19.1-20221114-recovery-gts4lvwifi.img with Odin and flashed lineage-19.1-20221114-nightly-gts4lvwifi-signed.zip with TWRP-recovery.
Lineage is working fine, but I would also like to use Magisk.
I understood, that the order I follwed is not the recommended order for having both Magisk and Lineage. At least, that is, what you described at the beginning of your post.
But as with your last part you mentioned, that there where issues with sensors, ...
And the solution was to
I. Replace recovery with a patched boot.img of Lineage zip and wipe a prev. Lineage installation
I guess, I might be able to stiull do that though I already have Lineage on the S5e (currently with Lineage/TWRP recovery), right?
I can patch the boot.img from within lineage-19.1-20221114-nightly-gts4lvwifi-signed.zip with Magisk app, right?
Or would I have to patch lineage-19.1-20221114-recovery-gts4lvwifi.img
Is there anything to consider, when zipping the image with the patched boot.img again?
Which TWRP image did you choose to be flashed at step II.?
Barium said:
I. I extracted "boot.img" from the LineageOS zip file, patched it via Magisk (ramdisk is added to the boot image) and replaced the "boot.img" in the zip file with 7-Zip.
II. Booted into TWRP, flashed an original TWRP image, so recovery is replaced. (Rebooted I guess.)
III. Then wiped previously LineageOS installation and, flashed the LineageOS zip file with patched boot image and GApps and rebooted to system.
IV. After setting up, install Magisk, let is do its thing.
V. I installed "Root Checker Basic" in order to check I gained root checker. It was a PASS! And checked with "Sensor Test" if all sensors worked, they did! And sound also worked .
Yay!
Clearly, all of this can be optimized. Some questions remain, what steps are really necessary and I am also still wondering how to apply a LineageOS update... Anyhow at least it is working.
Click to expand...
Click to collapse
Thanks
If this is also a solution, can you please let me know, if there is anyhting to consider, when flashing the stock (got it from SAMMOBILE)? Can the lineage-19.1-20221114-recovery-gts4lvwifi.img still be left on the tab?
After re-flashing the stock, I guess you flashed lineage again, right?
Or did you stay with the stock and just flashed magisk (after renaming the apk to zip)?
Thanks
TheTofu said:
What fixed this for me is after re-flashing stock in Odin to get everything working again, just rename the magisk apk to install.zip and flash that in twrp, and open the magisk app once booted, no other steps needed for install, no image patching or anything.
Click to expand...
Click to collapse
I dared patching the TWRP recover for S5e and flashed it via Odin (AP).
S5e boots up in Lineage, Magisk is working fine.
But when I power off the tablet or restart, Lineage Recovery shows up telling me, that my data would be corrupt.
My only options are to try again or to do a factory reset.
Only way out of this is to re-flash the above mentioned recovery image again.
So how do I get the Magisk patched TWRP recovery permanent?
I wiped system? and re-flashed Lineage via TWRP, got "original" TWRP Recovery for S5e Magisk permanent.
I have to admid, I tried several things and got lucky I did not break something.
I had nearly, what I wanted - TWRP, Lineage and Magisk, but there were issues with the sensors (no auto rotate).
Again I helped myself:
1) flashed the original, unpatched TWRP Recovery for S5e
2) flashed unpatched Lineage for S5e
3) flashed MindTheGapps
4) flashed Magisk-v25.2.apk
No bootloop, original TWRP permanent, Magisks working fine, no issues with sensors.
Tried steps 1, 2 and 4 with the Lineage Recovery and it worked too.

Xposed for Android 8- help needed

Hello guys I recently rooted my xz premium dual sim and I currently have Magisk 22.1, I'm not an expert so
I need help please, what are a proper direct way to get xposed working properly on Android 8.0 ROM?
I mainly need to install XPrivacy, I tried to install EDXposed but it failed though and I'm not sure what to do
Thanks in advance
Since you need to install this with Magisk, do this:
Donwload the attached files
be sure to install the Xposed Magisk apk file first and open it it will show, thats it's not installed
then go to magisk and flash the xposed framework zip
and reboot
then (after your device is completely started with magisk and xposed) go to magisk, and check if the module's enabled. If it's NOT enabled, flash the zip again. If it's enabled, open xposed installer and check. (it's still not fully installed) and then there comes a message, that it's installed, but not really.
For the last step you need a custom recovery (like twrp or something)
Boot into your custom recovery and flash the xposed zip there (again)
Reboot and enjoy.
Another (way simpler) method would be to download it from magisk manager (if you have a older version) online repo.
I attached the Magisk version (with working repo)
In case xposed is installed but remains not active (yellow triangle instead of a green checkmark in the xposed installer app) follow the instructions of post #2 and don't worry you don't have to be an expert for this fix its fairly easy
Magisk + Xposed Framework is installed, but not active (XposedBridge.jar lacking)
Hi, new member here, who happened to lurk into XDA a few times in the past, and finally decided to register, hoping finding someone that would be able to help with my problem. I have Nexus 7 (2012), which became unusable with Android Lollipop...
forum.xda-developers.com

Categories

Resources