Database Develop

[BUG] Magisk refuses to install modules from repo (The zip is not a Magisk Module!)

I've had magisk installed since version 6, I've published some magisk modules already and never had a problem until today.
After a full clean reinstall of Nougat NBD90Z (with wipe) on my Nexus 6 and then flashing Magisk, phh's superuser for magisk, installing phh's superuser apk from play store and magisk manager apk I stumbled upon a previously reported (without details) bug where magisk manager would refuse to install modules from repo claiming they are not magisk modules.
I've struggled trying everything I could including the full wipe (more details here: http://forum.xda-developers.com/apps/magisk/module-app-systemizer-t3477512/69230448#69230448) and bounced some ideas off @pnwsr6 who's had the similar problem on Nexus 6 device.
I've achieved a partially working Magisk Manager (manual installs of ZIP files work, but installs from repo still fail) and here's the list of steps which lead to me having semi-working magisk manager again:
1. I flashed ZIP files of some modules in twrp (I'm attaching App Systemizer and Nexus 6 LED Enabler which I flashed)
2. After the phone booted up I saw the modules active and working
3. Within Magisk Manager I then added the ZIP file of the phh's superuser module from that thread (http://forum.xda-developers.com/attachment.php?attachmentid=3893967&d=1475554052)
4. Now at least manual installation of modules within Magisk Manager are working fine.
@topjohnwu -- I've enabled verbose logging and extra logging for bash commands, but I'm still not seeing anything in the log on top of the regular output.

Created an issue against Magisk Manager so it's easier to track for developers: https://github.com/topjohnwu/MagiskManager/issues/20

Looks like that even after flashing some modules in twrp, Magisk Manager only allows to install from zip only exactly the same ZIP I've already flashed (even a minor change and bump of versionCode results in "This ZIP is not a Magisk Module!"). So it might be an issue of Magisk Manager being unable to write to /magisk despite having storage permission and being granted root access.

Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!

I've seen this error as well on my Nexus 6 NBD90Z with Magisk v8. Started with v7 after some heavy modification on my part .
I was sometimes able to fix it by simply extracting the zip and then Magisk Manager would somehow recognize it as a module.. Other times I could extract the zip and then re-archive the contents and Magisk Manager would recognize that as a module. Weird, but doable.

stangri said:
Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!
Click to expand...
Click to collapse
I probably won't try again until next update, and hope the wipe just wasn't clearing something. I have the zip installed through twrp and working for now so I'm good till then.

just wondering if you're still having this issue with v9? I had modules installed fine under v6, but never really installed any modules under v8 to see if this problem occurred for me. now that I'm on v9, which has been wiped clean to start, I can no longer install any modules via Downloads or in the Modules section... any suggestions?

I have the same issue when trying to install viper with v9 on Nexus 6P DP2
Skickat från min Nexus 6P via Tapatalk

Same here. Find a fix ?

From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.

stangri said:
From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.
Click to expand...
Click to collapse
Just an FYI, I do still have this problem, but can install the zip through twrp. Maybe 10 will be the solution.

I had the same problem, I cleared magisk manager data and it works fine now

Didn't help
Sent from my SM-G532F using Tapatalk

I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.

stangri said:
I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.
Click to expand...
Click to collapse
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.

Meowdib said:
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.
Click to expand...
Click to collapse
Weird, do you have the same problem with magisk manager 161223?

stangri said:
Weird, do you have the same problem with magisk manager 161223?
Click to expand...
Click to collapse
Same

I need a Help to download modules using magisk
Lastest version, Included phh root, manager is from G. play,
But Modules download function is not working
Say "No modules found" for download to install via magisk.

Need help with Maskisk installation

I am looking for a ELI5 installation guide for Magisk. I have very little experience with rooting phones and the guides I have found confuse me. thank you in advanced for the help

Install TWRP.
Flash Magisk zip in TWRP.
Boot up your device.
Install Magisk Manager (for Magisk v12, from v13 it'll be installed automatically).
It's that easy. Of course, there might be compatibility issues, but let's assume there won't be for now and cross that bridge if we get to it.
Looking at the Unlock/Root/etc thread in the X Style forum, you almost had it with the TWRP install. You were doing the correct commands, but using the wrong file. You were trying to install an apk (an app), where you needed to us an image file (*.img). Go back to the thread and you'll see they gave you the link for the proper download.
Links for the Magisk zip and the Magisk Manager are in the release thread.
Also, here's a link to another thread started today on a similar subject. I put a bunch of links and tips in there that may also be useful for you.
Edit:
An important, basic tip when doing things to your device is to always have a backup of important files. Don't leave anything on there that you can't afford to lose.

I have a successfully installed magisk 14.0 from twrp still safety net was showing false so i tried to update through magisk manager but installation keeps on failing for magisk v14.2 now same error with 14.3 it says unable to unpack boot image, any help would be greatly appreciated

[HELP] Pixel3a Bootloop when Magisk Installed

Hey Guys,
I was experimenting with some SELinux context labeling rules a couple of days ago in Android10 related to JamesDSP and my own Audio Mod Project. I had tried to inject a new rule via 'magiskpolicy' (it was a name_transition rule which I was hoping would re-label the library files in /vendor/lib/soundfx from a system_file context to vendor_file) in a few ways; first via command line using the --live argument which resulted in a Segmentation Fault, then again without the --live argument which resulted in no error and then finally I added the rule to a Magisk Module and installed that. Neither of the command line attempts had any result on the running system and after installing the Magisk Module and rebooting I started hitting bootloops.
I managed to get out of the bootloop by flashing the entire Factory Stock Image, but now everytime I try to re-install Magisk (by putting the Stock Boot Image onto the phone, installing MagiskManager, selecting the Boot Image to patch and then using fastboot to flash the patched boot image) the resulting Magisk Boot Image causes a bootloop. I've found that, for some reason, this particular pre-patched boot image with modded kernel works : https://forum.xda-developers.com/pixel-3a/development/kernel-stock-kernel-plus-f2fs-t3945936 (specifically the stock-modified-android10-1203-magisk.img one; the latest one also causes my phone to bootloop).
I'm a bit stumped on this... wondering if anyone has any ideas? Maybe I somehow corrupted the device's SELinux Policy, but I expect that to be replaced when I flashed the Factory Stock Image...
Update : This is the SELinux Policy Rule that I tried to add (same rule for all 3 attempts) : name_transition hal_audio_default system_file file vendor_file libTestEffect

Have you cleared /data? If you haven't your Magisk module (in /data/adb/modules) will still be active as soon as you install Magisk again, hence the bootloop.
Take a look here for some tips on how to remove it:
https://didgeridoohan.com/magisk/Magisk#hn_Disablinguninstalling_modules_manually

Jman420 said:
I'm a bit stumped on this... wondering if anyone has any ideas? Maybe I somehow corrupted the device's SELinux Policy, but I expect that to be replaced when I flashed the Factory Stock Image...
Click to expand...
Click to collapse
Like was mentioned above, you need to remove your module. You could try this:.
Root your phone again. When you bootloops, fastboot boot one of the images here. One will boot core-only, the other remove magisk and all modules so that you should be able to root again without bootlooping.
https://forum.xda-developers.com/pi...disabler-booting-magisk-t3976621#post81547783

Tulsadiver said:
Like was mentioned above, you need to remove your module. You could try this:.
Root your phone again. When you bootloops, fastboot boot one of the images here. One will boot core-only, the other remove magisk and all modules so that you should be able to root again without bootlooping.
https://forum.xda-developers.com/pi...disabler-booting-magisk-t3976621#post81547783
Click to expand...
Click to collapse
The module is most definitely gone. While I was running Magisk 20.1 I ensured that the /data/adb/modules folder was empty and then tried the steps you suggested above. The boot images provided in that thread also cause bootloops on my phone, both of them. The only guess I can come up with is that the 'magiskpolicy' commands I ran somehow changed something that doesn't get overwritten...

Jman420 said:
The module is most definitely gone. While I was running Magisk 20.1 I ensured that the /data/adb/modules folder was empty and then tried the steps you suggested above. The boot images provided in that thread also cause bootloops on my phone, both of them. The only guess I can come up with is that the 'magiskpolicy' commands I ran somehow changed something that doesn't get overwritten...
Click to expand...
Click to collapse
The method I showed you was for fixing a problem where there is a module installed that you could not remove due to a bootloop. That is the only problem it was meant to fix. If your module was already gone then it was pointless to try it.

Tulsadiver said:
The method I showed you was for fixing a problem where there is a module installed that you could not remove due to a bootloop. That is the only problem it was meant to fix. If your module was already gone then it was pointless to try it.
Click to expand...
Click to collapse
Agreed... but I'm trying every port in this storm. It's such a strange issue... At this point I've got the phone running the latest Factory Image, but have flashed the boot image I mentioned above with Magisk 20.1 installed. Running correctly, no modules installed or visible... but if I try to update to 20.3 it bootloops.

So I figured out my problem and fixed my phone. I still find the situation that I ended up in very strange and can't come up with a complete explanation of what happened. But the root issue was that I had a remnant sepolicy.rule from a test module I was playing with on my Pixel's /persist/ partition. Since that particular sepolicy.rule caused a bootloop I was never able to remove it via MagiskManager, so the sepolicy.rule was left on the /persist/ partition and Magisk was trying to apply it on boot. The solution was to re-root using the boot image I mentioned above and remove the file from /persist/.
The issue has been mentioned to TopJohnWu and a fix will likely be included in the next release.

Unable to install Magisk - getting "Unable to repack boot image!" error

Good evening lads. I've been having problems installing Magisk.
I've successfully rooted my device (a Samsung J5 2016) and installed Magisk Manager. From there, I selected "Install" and after the confirmation that I want to install Magisk v20.4(204000) I choose "Direct Install" , which is also the recommended option but get an installation error.
Here's my log:
Code:
- Target image: /dev/block/mmcblk0p16
- Device platform: armeabi-v7a
- Unpacking boot image
- Checking ramdisk status
- Stock boot image detected
- Patching ramdisk
- Repacking boot image
! Unable to repack boot image!
! Installation failed
I'm very noob at this and barely have any idea with what I'm doing, so I'm asking you, what can I do? I checked other threads but their logs was very different.
I've never had any other problem with other root apps (Lucky Patcher, Titanium Backup, Root checker etc.) and all I want to do is hide my root so I can use the Nintendo Switch app, lol.
Thanks in advance for your help.

The usual answer is, into Recovery and flash Magisk Uninstaller, then install the Magisk file in Recovery.
I can't give any guarantees, but that always used to be the way to go, if Magisk did not install with Direct Install option.
Like I say, no guarantees.
Should have said, make a Recovery Backup before attempting.
Second thoughts, another poster has just reported a problem installing 20.4 in TWRP, so maybe it's not such a good idea after all.
I don't advise.
Sorry for wrong advice.
Sent from my SM-G965F using Tapatalk

if anyone is having trouble while installing magisk I have come up with solutions.​
if you have installed magisk but it never detects as it is installed the following would be solutions i have found for my self​
install magisk that is older than the one you are going to install in recovery with sideload for eg. to install magisk 25.00 from the recovery you need to install magisk 24.1 apk before that without shutting down your phone.​
the second step you need to do is you have to side-load the latest version after you have installed the older version from the recovery​
that is it simple as it is​

[Solved][Question] How to delete /system/xbin files via Magisk Module?

Today I have installed Built-In BusyBox module by zgfg to overwrite meefik's busybox binaries in /system/xbin which I couldn't remove due Resource or Device Busy error.
Then I found out that busybox is one of the ways to detect modified android so I want to remove it but module unfortunately doesn't come with uninstaller so I am stuck with busybox in my /system/xbin directory with no way to remove. All I found on Magisk's docs is to replace files or directories not remove them but 2018's version said that removal is possible, just that it is hassle or something.
Can anyone help?
Additional info: I don't have any Custom Recovery and don't tell me to get one.
Click to expand...
Click to collapse
NOTE! To help others with same problem I am planning to compile answer as Magisk Module so please open PR in this repo:
Click to expand...
Click to collapse
GitHub - UltraStudioLTD/BuiltIn-BusyBox-Uninstaller: Uninstall busybox
Uninstall busybox. Contribute to UltraStudioLTD/BuiltIn-BusyBox-Uninstaller development by creating an account on GitHub.
github.com

Have you tried removal via TWRP?
How to disable Magisk modules without Magisk and TWRP recovery
Hi, I installed an incompatible Magisk module in the past, which cause bootloop of my phone. Co I dirty flashed my ROM (Pixel Experience) to get my phone work again. My current situation is that I cannot flash Magisk because an incompatible...
forum.xda-developers.com

lemon567 said:
Have you tried removal via TWRP?
How to disable Magisk modules without Magisk and TWRP recovery
Hi, I installed an incompatible Magisk module in the past, which cause bootloop of my phone. Co I dirty flashed my ROM (Pixel Experience) to get my phone work again. My current situation is that I cannot flash Magisk because an incompatible...
forum.xda-developers.com
Click to expand...
Click to collapse
I don't have TWRP and I can't install any Custom Recovery.
Please don't tell me to follow that or this instructions to install them, I followed everything and still no luck.

What you could do is enter safmode of your phone (Google how to enter safe mode for your phone) and remove the files manually or use the BusyBox cleaner zip and flash it in magisk manager and if you're lucky it will remove it
Release v1.29.0-YDS-201807132149 · yashdsaraf/bb-bot
Bot to compile, package and release busybox for all android architectures - Release v1.29.0-YDS-201807132149 · yashdsaraf/bb-bot
github.com

Unfortunately safe mode in my phone is kinda broken, I think. Cause every 3rd party app was not only disabled but also disappeared like magic. Also I don't trust unknown ZIPs so I haven't tried that link.
**I solved problem by disabling every Magisk module I had, rebooting and after that it succeed in deletion with no problem**