Database Develop

[BUG] Magisk refuses to install modules from repo (The zip is not a Magisk Module!)

I've had magisk installed since version 6, I've published some magisk modules already and never had a problem until today.
After a full clean reinstall of Nougat NBD90Z (with wipe) on my Nexus 6 and then flashing Magisk, phh's superuser for magisk, installing phh's superuser apk from play store and magisk manager apk I stumbled upon a previously reported (without details) bug where magisk manager would refuse to install modules from repo claiming they are not magisk modules.
I've struggled trying everything I could including the full wipe (more details here: http://forum.xda-developers.com/apps/magisk/module-app-systemizer-t3477512/69230448#69230448) and bounced some ideas off @pnwsr6 who's had the similar problem on Nexus 6 device.
I've achieved a partially working Magisk Manager (manual installs of ZIP files work, but installs from repo still fail) and here's the list of steps which lead to me having semi-working magisk manager again:
1. I flashed ZIP files of some modules in twrp (I'm attaching App Systemizer and Nexus 6 LED Enabler which I flashed)
2. After the phone booted up I saw the modules active and working
3. Within Magisk Manager I then added the ZIP file of the phh's superuser module from that thread (http://forum.xda-developers.com/attachment.php?attachmentid=3893967&d=1475554052)
4. Now at least manual installation of modules within Magisk Manager are working fine.
@topjohnwu -- I've enabled verbose logging and extra logging for bash commands, but I'm still not seeing anything in the log on top of the regular output.

Created an issue against Magisk Manager so it's easier to track for developers: https://github.com/topjohnwu/MagiskManager/issues/20

Looks like that even after flashing some modules in twrp, Magisk Manager only allows to install from zip only exactly the same ZIP I've already flashed (even a minor change and bump of versionCode results in "This ZIP is not a Magisk Module!"). So it might be an issue of Magisk Manager being unable to write to /magisk despite having storage permission and being granted root access.

Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!

I've seen this error as well on my Nexus 6 NBD90Z with Magisk v8. Started with v7 after some heavy modification on my part .
I was sometimes able to fix it by simply extracting the zip and then Magisk Manager would somehow recognize it as a module.. Other times I could extract the zip and then re-archive the contents and Magisk Manager would recognize that as a module. Weird, but doable.

stangri said:
Well, it works now (you'll have to wipe again). So here's the sequence of events:
1. Flashed @RatchetPanda's busybox http://forum.xda-developers.com/attachment.php?attachmentid=3850579&d=1471875389 from twrp -- got stuck on a boot animation, rebooted again in twrp, flashed magisk uninstall and it didn't help for some reason.
2. So I force-rebooted into fastboot and flashed nbd90z with wipe.
3. After apps were restored and everything was set up, I booted into twrp (it didn't even ask me if I want to allow /system modifications for some reason), added magisk v8 and phh's r259 root to the list, flashed them both.
4. Once the phone booted I could again install modules from repo/zips.
Maybe something didn't get properly wiped first two times but it's working now @pnwsr6!
Click to expand...
Click to collapse
I probably won't try again until next update, and hope the wipe just wasn't clearing something. I have the zip installed through twrp and working for now so I'm good till then.

just wondering if you're still having this issue with v9? I had modules installed fine under v6, but never really installed any modules under v8 to see if this problem occurred for me. now that I'm on v9, which has been wiped clean to start, I can no longer install any modules via Downloads or in the Modules section... any suggestions?

I have the same issue when trying to install viper with v9 on Nexus 6P DP2
Skickat från min Nexus 6P via Tapatalk

Same here. Find a fix ?

From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.

stangri said:
From what I hear, ZIP/module management has been reworked in the upcoming magisk v10, so unless you want to go the route I went thru, you can just wait for that.
Click to expand...
Click to collapse
Just an FYI, I do still have this problem, but can install the zip through twrp. Maybe 10 will be the solution.

I had the same problem, I cleared magisk manager data and it works fine now

Didn't help
Sent from my SM-G532F using Tapatalk

I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.

stangri said:
I've published snapshot builds of magisk v10 and magisk manager v2.6, try these together to see if they'd help.
Click to expand...
Click to collapse
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.

Meowdib said:
I tried the latest one from the 26th, magisk manager keeps crashing when trying to install the downloaded dialer/contacts on HTC 10.
Click to expand...
Click to collapse
Weird, do you have the same problem with magisk manager 161223?

stangri said:
Weird, do you have the same problem with magisk manager 161223?
Click to expand...
Click to collapse
Same

I need a Help to download modules using magisk
Lastest version, Included phh root, manager is from G. play,
But Modules download function is not working
Say "No modules found" for download to install via magisk.

When update magisk no prompt for rooted apps

This issue has been for me since i started using magisk
Everytime i update root is gone and apps dont prompt for root
The only way which worked for me is this
1. Restore system image with twrp
2. Uninstall magisk completely in twrp
3. Install the magisk latest version
4. Wipe cache n dalvik cache and reboot
5. Install magisk latest manager
6. Open it and close it
7. Run root apps still dont asks root but press back after some time root pop up comes and grant it ,this has been same since v16 the first yime i used magisk
But somehow it works like this i just uodated to 18.1 from 18.0
If you guys still get this issue you may try these steps if it works for you,logs has no issue same as usual

[GUIDE] OTA updates with Magisk

If you have managed to root your phone with Magisk, getting updates after that for the stock ROM isn't always a smooth thing. Here are some steps to be successful with updates.
1. Open Magisk Manager and disable all installed modules by unchecking the circle for each.
{
"lightbox_close": "Close",
"lightbox_next": "Next",
"lightbox_previous": "Previous",
"lightbox_error": "The requested content cannot be loaded. Please try again later.",
"lightbox_start_slideshow": "Start slideshow",
"lightbox_stop_slideshow": "Stop slideshow",
"lightbox_full_screen": "Full screen",
"lightbox_thumbnails": "Thumbnails",
"lightbox_download": "Download",
"lightbox_share": "Share",
"lightbox_zoom": "Zoom",
"lightbox_new_window": "New window",
"lightbox_toggle_sidebar": "Toggle sidebar"
}
Please note that steps 2-4 can be done with the stock 1+ updater so long as it senses that you are rooted and offers to download a full rom. So a note about magisk hide which is used to hide root. Make sure you haven't managed to hide root for any process related to the 1+updater or it won't know you are rooted and will offer incremental updates.
2. Install Oxygen Updater (This app may become abandoned in 2019 requiring the use of the stock updater which is slower or manually downloading roms.) https://play.google.com/store/apps/details?id=com.arjanvlek.oxygenupdater
3. Open the app, verify that your device is identified correctly. Open it's settings and set Update Method to "Full Update"
4. Check for an update and download it. Make sure you end up with a full 2GB ROM image not an incremental small one. It will be in the root of internal storage.
DO NOT use Oxygen Updater to update the phone (unless you have TWRP and that is for a different GUIDE)
5. Open the built in OnePlus updater: Settings - System - System Updates - Gear - Local Upgrade and select the newly downloaded update. TAKE NOTE while it is installing which slot it is installing too. It will say something like "inactive slot a". Remember this as it is the "new" slot.
6. After it has installed DO NOT reboot the phone or you will lose root. Open Magisk Manager and install Magisk, even though it says "installed". Select the option when it prompts for "after OTA". This will install magisk in the boot partition of the new slot.
7. Reboot and If all went well you shouldn't boot loop and you'll be running the new slot. If you want TWRP (optional), install the zip now from Magisk->Modules->+ (sign) then select the TWRP zip file and install it. Do NOT reboot. Then do a "Direct Install" of Magisk again, then reboot.
8. Open Magisk Manager and go to the downloads section and reinstall the modules you want to use. Do this from the Downloads screen or using the + button on the Modules screen. This will install them in the current slot.
DO NOT simply reenable the modules with the check mark or you will boot loop. Some modules aren't listed in Magisk and can't be automatically moved from slot to slot. If you installed one of those previously, you must reinstall it with the plus button manually from the modules tab.
You should be done now.
Oh no I'm boot looping: Don't panic.
1. Make sure you have adb/fastboot 1.4.3 or newer on a PC https://forum.xda-developers.com/showthread.php?t=2317790
2. Boot the phone into Bootloader/fastboot either through the recovery menu or VolDn + Pwr
3. If in step 5 above the inactive slot was "a", issue the command from a PC command prompt:
fastboot --set_active=b
or vice versa
fastboot --set_active=a
If you are not sure which to use try one or fastboot getvar current-slot
4. Then: fastboot reboot
This will allow the phone to boot into the last good ROM version. Now you figure out what went wrong.
Another option If your phone didn't retain root, you can stay in the unrooted slot. download a rooted boot image of your firmware version, place it in the your fastboot pc directory, reboot the phone to fastboot and issue the command: fastboot boot boot.img (or whatever the downloaded image is called.) this is a temporary root that is non destructive. Then do a direct install from Magisk manager even though it already says installed. That will permanently root your boot copy. Then install your modules.
Here is the 9.5.11 1917AA rooted boot image https://www.dropbox.com/s/6csxd9zaa4mihwk/boot_a_backup_2019-08-04_19-05-29.img?dl=0
If your phone looped right after flashing, you may not have disabled Magisk modules properly. You can still disable them from the good slot, swap active slots again using fastboot and see if it boots into the new ROM. If not, swap back to the good old slot again and start over flashing again from the beginning.
If you looped after reenabling your modules, it is possible you only enabled one but didn't install it into the new slot. Again swap back to the good slot and disable the modules. Swap back to the new slot and install the modules again even if Magisk thinks they are there.
If all else fails, you can stay in the good old slot until you sort things. If you are looping in both slots then something really went bad and you have to flash back a full ROM from fastboot. See this thread
https://buzzfire.de/xda/t3931424
Then root again using the rooted boot image above.
You may be able to boot into the old rooted slot and root the new slot with the ota option also.
If you have issues where stuff like Wifi doesn't work, then somewhere along the line or previously you flashed a (boot) image that didn't match the /system image in the slot you were working on. This error will persist in that slot every time you use that slot until it gets a fixed set of images.
Hope this helps!

I updated to 9.5.7 yesterday with following process, which was very simple (also used the same exact process to update to 9.5.6 last week):
Note: This assumes your device is already bootloader unlocked and has developer options enabled.
Download latest twrp.zip to your phone
Download latest magisk.zip to your phone
Download latest twrp.img to your pc
Allow oxygen updater to download/install OTA. It will say 'your device is rooted, a full image will be downloaded'. (If you're not already rooted, this process will still work)
After it completes the installation, do not select reboot. Instead, hold power button and press reboot to bootloader (make sure you enabled Advanced reboot in settings to see that option)
In fastboot and connected to pc, run from pc: fastboot flash boot twrp-3.3.1-3-guacamole.img (or whatever latest version is - you need to do this step because the OTA wipes out twrp if you already had it installed)
Reboot phone to twrp recovery
Flash install the twrp.zip you downloaded above
Flash install the magisk.zip you downloaded above
Reboot System
Done
Using this method, I haven't needed to change the slots at all, as the OOS updater takes care of that and the twrp/magisk flash installs each to both slots. This method preserves all data/settings/root (but I still do a twrp backup just prior to doing the update). I had tried the magisk install OTA to inactive slot option a few times but it never worked for me. This method also eliminates the need to download any patched boot images.

If you are on bootloop, just simply flash magisk_uninstaller.zip on twrp
boot into system > then flash magisk on twrp again.

Perfect manual and working great

gtelnet said:
I updated to 9.5.7 yesterday with following process, which was very simple (also used the same exact process to update to 9.5.6 last week):
Note: This assumes your device is already bootloader unlocked and has developer options enabled.
Download latest twrp.zip to your phone
Download latest magisk.zip to your phone
Download latest twrp.img to your pc
Allow oxygen updater to download/install OTA. It will say 'your device is rooted, a full image will be downloaded'. (If you're not already rooted, this process will still work)
After it completes the installation, do not select reboot. Instead, hold power button and press reboot to bootloader (make sure you enabled Advanced reboot in settings to see that option)
In fastboot and connected to pc, run from pc: fastboot flash boot twrp-3.3.1-3-guacamole.img (or whatever latest version is - you need to do this step because the OTA wipes out twrp if you already had it installed)
Reboot phone to twrp recovery
Flash install the twrp.zip you downloaded above
Flash install the magisk.zip you downloaded above
Reboot System
Done
Using this method, I haven't needed to change the slots at all, as the OOS updater takes care of that and the twrp/magisk flash installs each to both slots. This method preserves all data/settings/root (but I still do a twrp backup just prior to doing the update). I had tried the magisk install OTA to inactive slot option a few times but it never worked for me. This method also eliminates the need to download any patched boot images.
Click to expand...
Click to collapse
You Sir are the good damn man i have spent 3hrs trying to update to 9.5.9 cheers boss!!

Will this method work if I was a TMobile OnePlus 7pro which converted to international running 9.5.8 currently?

Yes if you are offered the aa rom in the updater

@larsdennert I guess you may well know about this:
https://forum.xda-developers.com/oneplus-7-pro/help/oxygen-updater-shutting-november-t3948339

I just start the update under settings, system, syst update
It found new update and tell me he need to download full ROM (I have rmagisk installed).
While it was downloading full ROM I uninstall magisk from magisk app.
After update finish before restart I installed magisk again (option after ota update) and restart.
Now I'm updated and with magisk installed
Inviato dal mio GM1913 utilizzando Tapatalk

SlyUK said:
@larsdennert I guess you may well know about this:
https://forum.xda-developers.com/oneplus-7-pro/help/oxygen-updater-shutting-november-t3948339
Click to expand...
Click to collapse
Yes I'm thinking, In the worst case it may be possible to use the stock updater as it senses root and downloads the full update now. Simply substitute the step where oxygen updater is used to download with the stock updater.
There may be a slightly longer delay before the stock updater offers an update as 1+ does it in waves. I have to hand it to 1+for even offering updates as most phones won't.

hi experts,
what and where to set or unset to make sure there is NO auto OTA update?
How do I control the update time on my op7p?
I'd like to avoid surprise of getting update in background that would / can remove root, magisk and etc that were manually added?
as example I use xXx over magisk and I's like to be prepared ahead of time to apply the OTA update
thanks for the education.

The 1+ updater has a setting to auto download updates or not. You can change it.

If we have TWRP installed could we get a guide for using the updater app?

kirschdog1 said:
If we have TWRP installed could we get a guide for using the updater app?
Click to expand...
Click to collapse
This is the method i use. Screenshot it from a thread here on XDA and unfortunately cannot remember the posters name to give credit. But it is the job!

kirschdog1 said:
If we have TWRP installed could we get a guide for using the updater app?
Click to expand...
Click to collapse
I used a method that didn't require uninstalling Magisk modules or even booting into recovery (unless you have issues):
1.) Download FULL OTA from 1+ updater (should be approximately 2gb)
2.) Disable all Magisk modules and substratum themes
3.) Install OTA manually via the system updater in Settings > System > System Updates > Gear in upper right > Local Upgrade **DON'T REBOOT!!!**
4.) Search for TWRP Retention Script in Magisk, install **DON'T REBOOT!!!**
5.) Re-install Magisk from the main page in Magisk Manager App (OTA Option) **REBOOT**
6.) Re-enable Magisk modules and any substratum themes **REBOOT**
If you get stuck in a bootloop due to a Magisk module causing issues (EdXposed did this to me) you can:
Boot Into Recovery (Volume Down + Power Button) > Advanced > File Manager > Navigate to data/adb/modules > Click module you want to disable / delete > Hit bottom right checkmark > Delete > Hit Home > Reboot System
Magisk modules I'm currently running in 9.5.10 with no issues:
- Google Dialer Framework
- Google Product Sans
- liboemcrypto disabler
- OnePlus Google Launcher
- Renovate Ice
- Substratum
- ViperFX
- xxxNoLimitsxxx

i.Design said:
I used a method that didn't require uninstalling Magisk modules or even booting into recovery (unless you have issues):
1.) Download FULL OTA from 1+ updater (should be approximately 2gb)
2.) Install OTA manually via the system updater in Settings > System > System Updates > Gear in upper right > Local Upgrade **DON'T REBOOT!!!**
3.) Disable all Magisk modules and substratum themes
4.) Search for TWRP Retention Script in Magisk, install **DON'T REBOOT!!!**
5.) Re-install Magisk from the main page in Magisk Manager App **REBOOT**
6.) Re-enable Magisk modules and any substratum themes **REBOOT**
If you get stuck in a bootloop due to a Magisk module causing issues (EdXposed did this to me) you can:
Boot Into Recovery (Volume Down + Power Button) > Advanced > File Manager > Navigate to data/adb/modules > Click module you want to disable / delete > Hit bottom right checkmark > Delete > Hit Home > Reboot System
Magisk modules I'm currently running in 9.5.10 with no issues:
- Google Dialer Framework
- Google Product Sans
- liboemcrypto disabler
- OnePlus Google Launcher
- Renovate Ice
- Substratum
- ViperFX
- xxxNoLimitsxxx
Click to expand...
Click to collapse
Question. How do you know it was edxposed module? I'm currently trying to track down. Why I'm still getting SOD after updating from 9.5.9 to 9.5.10

Pvt WhoOkid said:
Question. How do you know it was edxposed module? I'm currently trying to track down. Why I'm still getting SOD after updating from 9.5.9 to 9.5.10
Click to expand...
Click to collapse
I assumed it was and disabled it first, did a reboot and booted up fine. It was a good guess
Best bet would be to delete all modules and start from scratch if you're not sure. It depends what kinds of modules you run.
I had issues of bootloop where I would get past the unlocked message and boot up animation but then would freeze with my background showing only (no launcher, no status bar, etc).

i.Design said:
I assumed it was and disabled it first, did a reboot and booted up fine. It was a good guess
Best bet would be to delete all modules and start from scratch if you're not sure. It depends what kinds of modules you run.
Click to expand...
Click to collapse
Yeah back to the drawing broad for me. Luckily I don't run many modules. Just edXposed , xXx and Riru Core.

Pvt WhoOkid said:
Yeah back to the drawing broad for me. Luckily I don't run many modules. Just edXposed , xXx and Riru Core.
Click to expand...
Click to collapse
I was running Riru Core, edXposed and ended up dropping both, it wasn't worth the hassle for me since I run Renovate Ice and it does most of the tweaks I want from GravityBox (reason I was running Xposed).

Pvt WhoOkid said:
Yeah back to the drawing broad for me. Luckily I don't run many modules. Just edXposed , xXx and Riru Core.
Click to expand...
Click to collapse
Try disabling all the modules and see if you can boot into 9.5.10 slot. If it does, reinstall them (then reenable them)

The root permission request is no longer displayed

I have the root with Magisk in Android 8.0. At first, the warning always came out asking if you wanted to grant root rights to the application that you just opened. However, this warning is no longer displayed, even though the configuration of Magisk Manager is configured in this way.
In the Magus Superuser section, I do not see any trace of the applications that I can not 'root'.
I have updated Magisk Manager, but the error continues. I also removed BusyBox, but the error continues.
I can not give root permission to any other application. But the mobile is rooted, since the first applications that I installed that require root continue to function normally. I can even deactivate the root and then activate it again.
Reinstalling the applications is not solved. With Dalvik and Caché wipe either.
That could be happening? How is it solved?
____
Magisk Manager has all the permissions of everything (memory, background, manual battery mode). I have tried to reinstall Magisk Manager and nothing.
Deactivating BusyBox (Magisk module) and Xposed and restarting still does not work.
Returning to install the Magisk image by TWRP or Fastboot is not fixed either.
I have removed all the fret that I had done to the phone (BusyBox, Xposed, root Magisk and boot modified for the root) and the problem has not been solved. I do not know what may be happening. I do not have other rare applications.
I have installed Device Control and the TWRP application. I have not gotten the root request to skip (although it has activated that option in Magisk Manager).
Definitely, it is not the fault of the new applications, which was the first question I wanted to solve.
Magisk version:
19.3 (19300)
And from Manager 7.2.0 (213), although I have also tried 7.3.2 (224).
The root is done with patching (via Magisk) of RAMDISK.IMG.
I understand that some applications are not compatible with systemless. But I'm not going any of the new ones that I'm trying. Interestingly, other applications compatible with Magisk (except those that installed the first days of the mobile) do not work either.
I have installed Magisk Manager 7.0.0 (and also 6.1.0), but the bug is still there. It seems that it does not depend on the APK.
As my Magisk file to root consists of a patch of RAMDISK.IMG created directly from Magisk Manager I do not know how to create one based on a lower version (for example, version 18.1). It only gives me the option to patch with the latest Magisk Manager version (if I have a lower one, it asks me to update the APK).
Whenever I generate the IMG of my patched RAMDISK.img it is based on 19.3.
How could I generate a patched IMG based on a lower version?
I have microG, not the GApps. Could that influence? Does Magisk need them?

@rovo89

@topjohnwu

https://www.didgeridoohan.com/magisk/MagiskHelp

I have added much more information.

Reinstall firmware???

LoneWolfz said:
Reinstall firmware???
Click to expand...
Click to collapse
I'm going to do it today. Will I lose data if I install SYSTEM.img via Fastboot?

535iu said:
I'm going to do it today. Will I lose data if I install SYSTEM.img via Fastboot?
Click to expand...
Click to collapse
No maybe but i suggest you to backup all your data etc. just to be safe

[Guide] Keep root after OTA update on 6T - no PC required!

Hey everyone, sorry if this has been covered already but I don't recall seeing these instructions anywhere. After doing the standard tethered re-root every time there was an OTA update I discovered that you don't need to tether. I've been doing it this way for the past several updates and it has worked perfectly every time. Not sure if this will work for major version updates though. As usual, YMMV, back up your data, I'm not responsible for data loss, bricks, etc. etc.
Install TWRP and Magisk the usual tethered way the first time you root. There's no way around this.
When an OTA update comes out, allow it to download but do not let it install itself.
Download the latest TWRP Fajita zip to your device if you don't already have it. https://dl.twrp.me/fajita/
Reboot to recovery and decrypt if necessary.
Back up your data if you don't feel like living on the edge.
Hit the install button and browse to /sdcard/.Ota and select the latest zip, which was downloaded automatically earlier.
Tap the button to add another zip, and select the TWRP zip that you downloaded earlier.
Swipe to install, reboot when done. It is crucial to install both zips without rebooting in between, otherwise you'll have to tether.
After the post-boot update process completes, open the Magisk Manager app and hit the Install button for Magisk (not Magisk Manager). Choose to download zip only.
Reboot to recovery and decrypt if necessary.
Hit the install button and browse to /sdcard/Download and select the Magisk zip that you just downloaded. Swipe to install, then reboot.
Magisk app should now show Magisk is installed again.
Profit.

If we have twrp retention script we simply can retain magisk and twrp, i think everyone knows that

what is the twrp retention script? have you a link?