Really simple module but I can't even do that lol ... - Magisk

Hello !
I'm trying to create simple as fk module... I edited system app and would like to replace already existing system app with it via magisk. I want to utilize magic mount to replace apk every time phone boots.
I tried reading guide on how to make module and the magic mount section says that everything is already in place for doing exactly this , I just need to place files inside module's system folder and everything is supposed to work but the first attempt went rly bad :
https://forum.xda-developers.com/attachments/ha-zip.5410919/?hash=036cbc145f7ed9195b564f943507950f
It didn't even get past unzipping no matter what I did - i made sure to keep all files in root of the folder , used various zip apps and levels but nothing...
Copying zip to temp directory
! Unzip error
So I obviously fled something up by creating module form ground up... Went and downloaded template from here :
GitHub - gedoor/magisk-module-template: template
template. Contribute to gedoor/magisk-module-template development by creating an account on GitHub.
github.com
Added my files to system folder , update description and edited the config.sh to add REPLACE="
/system/app/PowerKeeper
"
Zipped it and more errors... At least it unzips it alright now but idk what this error means during install :
- Copying zip to temp directory
- Installing Ha2.zip
/data/user/0/com.topjohnwu.magisk/cache/flash/update-binary: line 146: /data/magisk/sepolicy-inject: not found
/data/user/0/com.topjohnwu.magisk/cache/flash/update-binary: source: line 167: config.sh: not found
Archive: /data/user/0/com.topjohnwu.magisk/cache/flash/install.zip
inflating: config.sh
! Installation failed
I realize the template that I've downloaded might be broken ... If anyone could look into my first link that I've shared or the file that I've attached that would be great! I'm not sure what or where to start from in order to get this working...
Ty!

You've got everything you need, but the update-binary and updater-script files need to be in the META-INF directory tree, see here for details on what the installer needs to look like:
https://topjohnwu.github.io/Magisk/guides.html#magisk-module-installer
The template you found failed because it's 4 years old. A lot has happened since then and Magisk's internals are very different nowadays.

Didgeridoohan said:
You've got everything you need, but the update-binary and updater-script files need to be in the META-INF directory tree, see here for details on what the installer needs to look like:
https://topjohnwu.github.io/Magisk/guides.html#magisk-module-installer
The template you found failed because it's 4 years old. A lot has happened since then and Magisk's internals are very different nowadays.
Click to expand...
Click to collapse
Thanks a lot !!!
I see you help other people too years ago , I was hoping you'd help me out too but didn't really think pming you based on some years old thread is the best idea and here you are lmao o:
It installed well now ! I'll go reboot , fingers crossed I don't end up in some bootloop (• ▽ •
Ty again!

Usually, the best way to summon me is to turn off the lights and say my name three times into the mirror. But posting in the Magisk forum works too (this is pretty much my home here on XDA and I always keep a close eye on what's going on here)...
Glad I could help and good luck with the modules.

Didgeridoohan said:
Usually, the best way to summon me is to turn off the lights and say my name three times into the mirror. But posting in the Magisk forum works too (this is pretty much my home here on XDA and I always keep a close eye on what's going on here)...
Glad I could help and good luck with the modules.
Click to expand...
Click to collapse
Ah can u help w bootloop now xD
Safe mode doesnt get magisk to disable module gotta delete it now... How though?
Idk if I wanna mess with magisk module uninstaller or if uninstalling whole magisk gets rid of module...
Will going to /data/adb/module and removing module fodler from there fix it ?

Rstment ^m^ said:
Ah can u help w bootloop now xD
Safe mode doesnt get magisk to disable module gotta delete it now... How though?
Idk if I wanna mess with magisk module uninstaller or if uninstalling whole magisk gets rid of module...
Will going to /data/adb/module and removing module fodler from there fix it ?
Click to expand...
Click to collapse
Ha ha! Not uncommon when testing modules you've made...
Removing the module from /data/adb/modules is almost always a surefire way of fixing things.
Interesting that Safe Mode didn't work... You had the Magisk patched boot image installed still?

Related

lockscreen disabler for magisk

I'm looking for a module to be created, or if I could do it not sure. Something to do the same as "lockscreen disabler" did in Xposed. Willing to donate. App in question for exchange email is "Email MOTOEMAIL.00.05.0072". Currently running XT1254, 6.0.1, stock rom. Thank you.
Shtiff1 said:
I'm looking for a module to be created, or if I could do it not sure. Something to do the same as "lockscreen disabler" did in Xposed. Willing to donate. App in question for exchange email is "Email MOTOEMAIL.00.05.0072". Currently running XT1254, 6.0.1, stock rom. Thank you.
Click to expand...
Click to collapse
maybe it is enough if you download the module-template edit config.sh and module.prop to an ID if your choice and in config.sh also the REPLACE part with /system/app or priv-app/Lockscreen/ ?
something like this maybe? but here ends my know-how
Shtiff1 said:
I'm looking for a module to be created, or if I could do it not sure. Something to do the same as "lockscreen disabler" did in Xposed. Willing to donate. App in question for exchange email is "Email MOTOEMAIL.00.05.0072". Currently running XT1254, 6.0.1, stock rom. Thank you.
Click to expand...
Click to collapse
First, that's not a donation you're talking about, it's a bounty.
Second, if it can't be done without Xposed, it can't be done with Magisk. So don't hold your breath.
wiQbold said:
maybe it is enough if you download the module-template edit config.sh and module.prop to an ID if your choice and in config.sh also the REPLACE part with /system/app or priv-app/Lockscreen/ ?
Click to expand...
Click to collapse
What? I don't think you understand what the REPLACE part of the config.sh file does.
During installation, that little entry puts a file called "replace" in each folder listed, in the module folder structure. Every time Magisk mounts a module and finds that file it will completely wipe (systemlessly, of course) the corresponding folder in /system.
If you want to replace a file on your device with one you've edited, all you have to do is to put that file in the module zip, under the same folder structure it can be found on your device. After that Magisk's Magic Mount will do it's thing...
Didgeridoohan said:
First, that's not a donation you're talking about, it's a bounty.
Second, if it can't be done without Xposed, it can't be done with Magisk. So don't hold your breath.
What? I don't think you understand what the REPLACE part of the config.sh file does.
During installation, that little entry puts a file called "replace" in each folder listed, in the module folder structure. Every time Magisk mounts a module and finds that file it will completely wipe (systemlessly, of course) the corresponding folder in /system.
If you want to replace a file on your device with one you've edited, all you have to do is to put that file in the module zip, under the same folder structure it can be found on your device. After that Magisk's Magic Mount will do it's thing...
Click to expand...
Click to collapse
right. my consideration was to wipe the lockscreen folder in system to disable it
wiQbold said:
right. my consideration was to wipe the lockscreen folder in system to disable it
Click to expand...
Click to collapse
Ok. In that case I believe you haven't quite understood the request...
Didgeridoohan said:
Ok. In that case I believe you haven't quite understood the request...
Click to expand...
Click to collapse
that could be true. do not have any device older then nougat and can t try the xposed-module.
thought it disable only the lockscreen.
wiQbold said:
that could be true. do not have any device older then nougat and can t try the xposed-module.
thought it disable only the lockscreen.
Click to expand...
Click to collapse
From what I can tell it disables the lockscreen while tricking apps that require a lockscreen into thinking it's enabled.
Easy-ish with Xposed, impossible with Magisk unless you manually edit the app in question to not detect the lockscreen state and then use a Magisk module to mount it to your device.
Didgeridoohan said:
From what I can tell it disables the lockscreen while tricking apps that require a lockscreen into thinking it's enabled.
Easy-ish with Xposed, impossible with Magisk unless you manually edit the app in question to not detect the lockscreen state and then use a Magisk module to mount it to your device.
Click to expand...
Click to collapse
That is correct. When i opened phone before it just had swipe up to open. Now I have to enter lock code every time. I haven't done anything with adb before, always do everything from the phone. I've seen the apk "exchangenopin" but I can't try it, cause I can't download the apk anywhere. Those from other thread seem to go to ad sites. I figured that it wouldn't of been that difficult because the exchangenopin "supposedly" works w/o Xposed. That's why I was hoping for a module. I found something to replace my "insert custom text" module from Xposed, now just need something to replace for lockscreen. Lol. Liking Magisk though.
I experienced the same problem with my realme 5i smartphone, I tried to install the latest Magisk via the OrangeFox recovery because I had never rooted my smartphone before. but I have installed pixel 5 archipelago project. In this case, after installing magisk and successfully entering the lockscreen, here the problem occurs because I can't enter the lockscreen PIN and can't do anything, I can't even turn off my phone. But here I found a solution, namely using a google account and trying to wipe data via the Google Play application, namely find my devices and then delete it there and it worked for me

LiveBoot module not working on Nougat?

So I've been using the LiveBoot module from this post on MM, but today I've updated to Nougat and it does not seems to work. Does anyone knows something about this?
I think the LiveBoot app do work, can anyone confirm?
Thanks.
eXtremeDevil said:
So I've been using the LiveBoot module from this post on MM, but today I've updated to Nougat and it does not seems to work. Does anyone knows something about this?
I think the LiveBoot app do work, can anyone confirm?
Thanks.
Click to expand...
Click to collapse
you can get it working pretty easilyg without a module having to be installed, just install it like a normal app on your phone and then put the file it makes after it installs into the magisk.img (while its mounted) in the post-fs-data folder.
It will look like this:
/magisk/.core/post-fs-data.d/0000liveboot
the contents of my working 0000liveboot script is:
#!/system/bin/sh
/system/bin/sh /data/user_de/0/eu.chainfire.liveboot/files/liveboot &
If for any reason the file called is not in that spot, you'll gave to find it manually and change the script to reflect where it is on your particular phone. Possible locations might be /data/user/0/ or /data/data/
Best case is you can just use the 0000liveboot script exactly like I have it. Try that first. If you have no log overlay next boot, you'll have to did where the I installed liveboot app you have is keeping its data and simply change the script so it reflects wherever you find it, then try rebooting again and it should work!
I should mention I'm using v1.60 of chainfire's app
the attachment here is just the script that I know works, just in case anyone wants it.
Sent from my LG V20 using XDA Labs
Thanks, I'll try and tell you. And nice signature by the way haha
I installed the app but I can't go further if I don't allow the installation of the script in the system partition, and that's what I'm trying to avoid…
Sent from my ONE A2003 using Tapatalk
eXtremeDevil said:
I installed the app but I can't go further if I don't allow the installation of the script in the system partition, and that's what I'm trying to avoid…
Sent from my ONE A2003 using Tapatalk
Click to expand...
Click to collapse
Try the init.d linker module in the Magisk repo (in Downloads in the Manager).
Didgeridoohan said:
Try the init.d linker module in the Magisk repo (in Downloads in the Manager).
Click to expand...
Click to collapse
How? I don't know exactly what you mean
eXtremeDevil said:
How? I don't know exactly what you mean
Click to expand...
Click to collapse
All the LiveBoot app needs is a working init.d. If your ROM doesn't have that already, the easiest way to achieve this with Magisk is to symlink /magisk/.core/post-fs-data.d to /system/etc/init.d.
I haven't tried it myself, but you should simply be able to install the init.d linker module, reboot, install LiveBoot and then let it do it's thing. Nice and systemless.
Reading your previous posts again I see that the app already has asked to install the script, meaning you already have init.d support. Why not just let it install the script? If you have init.d you don't have to worry about official OTAs anyway and it is very unlikely it'll trip SafetyNet (if that's what you're worried about). Or, just use the above mentioned module.
OK, I installed the app, let it do it's thing, then moved the script from init.d folder to post-fs-data.d magisk folder, created a symlink back to init.d folder so the app doesn't complain about script not installed (and also to be able to edit its settings), rebooted and it's working again!
Thanks so much for the help
eXtremeDevil said:
OK, I installed the app, let it do it's thing, then moved the script from init.d folder to post-fs-data.d magisk folder, created a symlink back to init.d folder so the app doesn't complain about script not installed (and also to be able to edit its settings), rebooted and it's working again!
Thanks so much for the help
Click to expand...
Click to collapse
Hi,
I am sorry , I am not able to find the init.d folder and post-fs-data folder.could you please guide me with the full path for these.Thank you.
Rhaegar85 said:
Hi,
I am sorry , I am not able to find the init.d folder and post-fs-data folder.could you please guide me with the full path for these.Thank you.
Click to expand...
Click to collapse
You have Magisk installed? The full path is /magisk/.core/post-fs-data.d
Sent from my ONE A2003 using Tapatalk
eXtremeDevil said:
You have Magisk installed? The full path is /magisk/.core/post-fs-data.d
Click to expand...
Click to collapse
Thanks.Yes, I have. Found the path and managed to create a symlink, still not working. I used sdmaid to move files and Mount the partition and terminal to symlink.I am using MI 5 Gemini with ViperOS 3.1. Can this be done on my device?
Do you have LiveBoot installed? Does it work on it's own? What do you mean by mounting? I didn't need to mount anything.
The init.d path is /system/etc/init.d.
That's where the liveboot script should place itself once the app installs. That's the first step, do you have it there? Does it work?
Thanks.
eXtremeDevil said:
Do you have LiveBoot installed? Does it work on it's own? What do you mean by mounting? I didn't need to mount anything.
The init.d path is /system/etc/init.d.
That's where the liveboot script should place itself once the app installs. That's the first step, do you have it there? Does it work?
Thanks.
Click to expand...
Click to collapse
Thanks for your help. Yes, I had the file on that path. It was not working even after moving the 0000liveboot file to magisk/.core/post-data-fs.d. I have now done a clean install of Viper with SuperSU rather than magisk. And now it's working like a charm. I never had the liveboot working with Magisk except for test run. Thanks for your help.
eXtremeDevil said:
You have Magisk installed? The full path is /magisk/.core/post-fs-data.d
Click to expand...
Click to collapse
Hi,
Yes, sorry, I moved the file to magisk/.core/post-fs-data.d, and created a symlink as well, but it was not working. And I really don't want to leave viper or liveboot either, so I installed SuperSU. But can this be done using Magisk? I am using mi5 Gemini, Viper OS 3.1.1. Thank you again.
eXtremeDevil said:
Do you have LiveBoot installed? Does it work on it's own? What do you mean by mounting? I didn't need to mount anything.
The init.d path is /system/etc/init.d.
That's where the liveboot script should place itself once the app installs. That's the first step, do you have it there? Does it work?
Thanks.
Click to expand...
Click to collapse
Ha! Finally it's working now on magisk . I copied the liveboot file in magisk directory and installed init.d linker on magisk. Instead of creating a symlink using terminal, just moved the initlinker.sh file to the original source and Bingo! Thank you very much mate. I almost lost hope using liveboot with magisk. It was possible for you, THANK YOU?
(Magisk 15.1 / init.d enabler v2.2 , LiveBoot v1.6 )
I can also confirm that the Official Liveboot v1.60 from Playstore in combination with Magisk 15.1 works as soon as it finds a working /system/etc/init.d.
The Linker Modul does its job as expected by Didgeridoohan.
The Test Run works perfect.
When i boot up the phone i can see that Liveboot starts, as the screen is flickering shortly in the transition from Boot-Bootscreen and System-Bootscreen (same logo).
But the scrolling liveboot log itsself just shows up for half a second, when the boot screen switches to "home" respective Lockscreen respective the launcher.
From the previous state (SuperSu/Magisk 12) i know thats it is supposed to appear very soon on the screen.
The liveboot option "overlay on top of the boot animation" changes the appearance of that mentioned half second, but not the timing of the appearance.
Any ideas ? Which Logs ?
Thanks, Greets and a happy 2018
Just put the (liveboot) script in /magisk/.core/service.d, works like a charm.
Confirmed !
Now works like expected. Thank you !
Any way to get this to work on pixel 2 xl ? I tried the above and it fails The closest ive gotten so far is the google logo changed to an android one and the test on the liveboot app works.
Im confused I tried all the steps again but from fromflash fire and it failed, but flash fire itself reboots and scrolls the catlog while its flashing. ( think it reboots twice )

Remove/rename bootanimation (during post-fs stage)?

[deleted]
0xE2 said:
I'm currently working on a way to inject multiple different bootanimations on Samsung phones (because they support both .qmg and .mp4 for some reason). Now to use the video as a bootanimation I need to first get rid of the original bootanimation in /system/media/bootsamsung.qmg by either deleting it or renaming it. This needs to happen at the post-fs stage if I understood the documentation correctly.
Is there a way to do that or is this not possible using Magisk?
Click to expand...
Click to collapse
How Magisk works is that there is no need to remove or rename any files. If you would like to replace the current files, add the files to the replace section of the config.sh file. My module, MidnightCore, supports Samsung's .qmg format, what i do is simply replace the existing file by placing the bootanimation in /system/media. Magisk takes care of the rest. Basically don't remove or rename anything:good:
The thing about bootanimations though is that they need to be loaded much earlier in the boot process. This is done with a post-fs-data script. you can take a look at the one in my module to see what I did. Credits got to @osm0sis though, i got it from there.
Sent from my OnePlus5T using XDA Labs
[deleted]
0xE2 said:
I'm currently working on a way to inject multiple different bootanimations on Samsung phones (because they support both .qmg and .mp4 for some reason). Now to use the video as a bootanimation I need to first get rid of the original bootanimation in /system/media/bootsamsung.qmg by either deleting it or renaming it. This needs to happen at the post-fs stage if I understood the documentation correctly.
Is there a way to do that or is this not possible using Magisk?
Click to expand...
Click to collapse
You can bind mount over the existing one by placing your animation at /cache/magisk_mount/system/media/bootsamsung.qmg. But since it is post-fs mode, you can not delete or rename it, That can only be done at post-fs-data mode.
MCMotherEffin' said:
You can bind mount over the existing one by placing your animation at /cache/magisk_mount/system/media/bootsamsung.qmg. But since it is post-fs mode, you can not delete or rename it, That can only be done at post-fs-data mode.
Click to expand...
Click to collapse
This is what i was referring to @0xE2:good:
Sent from my OnePlus5T using XDA Labs
@OldMid, just to make you aware, there's a plan right now to move the /cache/magisk_mount stuff to /data/adb and have it run at post-fs-data instead of post-fs (which should still be early enough; that's when the bind runs with SuperSU). It hasn't been implemented yet, but probably in the next Magisk beta or so. :good:
osm0sis said:
@OldMid, just to make you aware, there's a plan right now to move the /cache/magisk_mount stuff to /data/adb and have it run at post-fs-data instead of post-fs (which should still be early enough; that's when the bind runs with SuperSU). It hasn't been implemented yet, but probably in the next Magisk beta or so. :good:
Click to expand...
Click to collapse
Hi @osm0sis,
I was planning to create a one single module, say a 'Systemless system modifier', which will let users manage /system and /vendor systemlessly via Magisk. Currently only CLI, I'm not yet mastered the GUI and Java, etc. Is there a plan of shipping such an app along with Magisk to allow users use it rather than creating their own modules ?? Would you recommend I go ahead with my plan ??
MCMotherEffin'
MCMotherEffin' said:
Hi @osm0sis,
I was planning to create a one single module, say a 'Systemless system modifier', which will let users manage /system and /vendor systemlessly via Magisk. Currently only CLI, I'm not yet mastered the GUI and Java, etc. Is there a plan of shipping such an app along with Magisk to allow users use it rather than creating their own modules ?? Would you recommend I go ahead with my plan ??
MCMotherEffin'
Click to expand...
Click to collapse
Well, you can already do that with the /cache/magisk_mount functionality (which will eventually switch to /data/adb as I said). Doesn't need a UI because all you need is a file explorer.
osm0sis said:
@OldMid, just to make you aware, there's a plan right now to move the /cache/magisk_mount stuff to /data/adb and have it run at post-fs-data instead of post-fs (which should still be early enough; that's when the bind runs with SuperSU). It hasn't been implemented yet, but probably in the next Magisk beta or so. :good:
Click to expand...
Click to collapse
That sounds like a step forward. For instance, on my device, there is no cache partition so I'm unable to change my boot animation systemlessly as I've done previously on other devices. I just wanted to know if there's a workaround for it:
oreo27 said:
So I've run into an issue that I can't seem to get past.
I used to replace my old device's boot animation systemlessly by placing a modified version of it in /cache/magisk_mount/system/media/bootanimation.zip but as mentioned in the readme:
- https://github.com/topjohnwu/Magisk/blob/master/docs/details.md#simple-mount-details
And this is exactly the case as my new device is utilizing the A/B partition scheme. However, the readme doesn't state how one can get around this.
In my personal mod (This is not published anywhere except Github) - https://github.com/0reo27/mia1module
0. I've tried as described above (by placing a modified version of it in /cache/magisk_mount/system/media/bootanimation.zip)
1. I've tried replacing the boot animation by simply placing it in the path.
2. I've also tried adding the file into config.sh like so:
Code:
REPLACE="
/system/media/bootanimation.zip
"
However, as far as I understand, this is only for entire directories.
Perhaps someone can point me in the right direction?
Click to expand...
Click to collapse
DELETED
osm0sis said:
@OldMid, just to make you aware, there's a plan right now to move the /cache/magisk_mount stuff to /data/adb and have it run at post-fs-data instead of post-fs (which should still be early enough; that's when the bind runs with SuperSU). It hasn't been implemented yet, but probably in the next Magisk beta or so. :good:
Click to expand...
Click to collapse
Interesting, appreciate the heads up!
Sent from my OnePlus5T using XDA Labs

Magisk Module Template Extended (MMT-Ex) [TEMPLATE]

In the past couple years, magisk has come a long ways to the point that it's the de-facto root solution. I have been developing and maintaining the Unity template for the past couple years but it's now reached a point where there's no longer a need for it - it's simply not worth the effort anymore. There are very few use cases where someone would want to stay rootless and still install a bunch of mods and every other root solution is pretty much deprecated at this point. So I switched gears from Unity to a magisk only template.
Consider this the spiritual successor of the Unity Template
So what is Magisk Module Template Extended (MMT-Ex)?
MMT-Ex is just as the name describes - it's the magisk module template but with the best features of Unity added to it
What does this mean?
This means that MMT-Ex is an easy way to make a magisk module regardless of how basic or advanced it is.
Where do I start?
Follow the readme on the main repo here and you'll be setup in no time
Questions?
Post them here, I'll try to help out when I have the chance but hopefully you won't have any
So much for the smooth release. Small bug fix pushed
@Zackptg5 I write here since there's no issue section in the repo, but there are two uninstall.sh files, one in common and the other one in the main directory, I think that's a bit confusing.
My ideas would be:
-merge the two files;
- rename the one in common in remove.sh , MMT-exuninstall.sh or similar names
MarcAnt01 said:
@Zackptg5 I write here since there's no issue section in the repo, but there are two uninstall.sh files, one in common and the other one in the main directory, I think that's a bit confusing.
My ideas would be:
-merge the two files;
- rename the one in common in remove.sh , MMT-exuninstall.sh or similar names
Click to expand...
Click to collapse
I could do a better drop explaining things in the wiki
The one in root gets copied as is to modpath and will uninstall any files outside modpath if removed via magisk manager
The one in common is like the old unity_uninstall one. The only reason I had the common ones named unity_whatever back in the day is because one of the past magisk module templates unzipped everything with the -j option (ignores directories) and so files would overwrite each other if they had the same name
I disabled issues on most of my repos because noobs would post stupid stuff on it so I redirected all support to here instead
Zackptg5 said:
I could do a better drop explaining things in the wiki
The one in root gets copied as is to modpath and will uninstall any files outside modpath if removed via magisk manager
The one in common is like the old unity_uninstall one. The only reason I had the common ones named unity_whatever back in the day is because one of the past magisk module templates unzipped everything with the -j option (ignores directories) and so files would overwrite each other if they had the same name
I disabled issues on most of my repos because noobs would post stupid stuff on it so I redirected all support to here instead
Click to expand...
Click to collapse
So far so good here.
@Zackptg5 it appears system.prop and sepolicy.rule still need to be placed in the root of the mod, and not in common in order to propagate on-device.
Which is fine, as i know thats how to fix it. But wasnt sure if that was your intent, it sounds like you want everything running script-wise out of common (which makes sense). Attached my magisk log, and my mod has a new sepolicy.rule and system.prop. I tried this the way i maentioned above and every loads as it should.
Hello, if I develop a Module with your template, I will be able to install it on my device. But I don't think it will be accepted as a valid module submission here (https://github.com/Magisk-Modules-Repo/submission/issues) because it does not respect the new module format.
Can you confirm?
aer0zer0 said:
@Zackptg5 it appears system.prop and sepolicy.rule still need to be placed in the root of the mod, and not in common in order to propagate on-device.
Which is fine, as i know thats how to fix it. But wasnt sure if that was your intent, it sounds like you want everything running script-wise out of common (which makes sense). Attached my magisk log, and my mod has a new sepolicy.rule and system.prop. I tried this the way i maentioned above and every loads as it should.
Click to expand...
Click to collapse
Common folder scripts should copy over but I've seen this issue in another module. I'll look into it later this week when I'm off work
lapwat said:
Hello, if I develop a Module with your template, I will be able to install it on my device. But I don't think it will be accepted as a valid module submission here (https://github.com/Magisk-Modules-Repo/submission/issues) because it does not respect the new module format.
Can you confirm?
Click to expand...
Click to collapse
mmtex is the new template with some modifications so you shouldn't have any problems there
DELETED
lapwat said:
I don't understand because on the Developer Guides there isn't any common folder anymore: https://topjohnwu.github.io/Magisk/guides.html
Click to expand...
Click to collapse
That's on of the modifications I made although there appears to be a bug with it that I'll need to work out
Zackptg5 said:
That's on of the modifications I made although there appears to be a bug with it that I'll need to work out
Click to expand...
Click to collapse
If I was to guess it would be something in lines 208-214 of the functions.sh. but I'm way to stoned to be of any actual assistance.
Edit: Clearly too stoned. I meant to reply to the system.prop not being applied when in common not what I actually replied to lol
Found the problem real quick. Seems I mixed up Unity with MMT-Ex logic:
The main boot scripts and such (service.sh, post-fs-data.sh, sepolicy.rule, and system.prop) should all be in root of installer like with regular template. Any extras can go into common. I'll push an update to the wiki on that shortly
Zackptg5 said:
Found the problem real quick. Seems I mixed up Unity with MMT-Ex logic:
The main boot scripts and such (service.sh, post-fs-data.sh, sepolicy.rule, and system.prop) should all be in root of installer like with regular template. Any extras can go into common. I'll push an update to the wiki on that shortly
Click to expand...
Click to collapse
That was my second guess!
Zackptg5 said:
Found the problem real quick. Seems I mixed up Unity with MMT-Ex logic:
The main boot scripts and such (service.sh, post-fs-data.sh, sepolicy.rule, and system.prop) should all be in root of installer like with regular template. Any extras can go into common. I'll push an update to the wiki on that shortly
Click to expand...
Click to collapse
that did the trick, much appreciated.
Updated MMT-Ex to v1.1! Been pushing some fixes for a while now and I feel like it's good to go for the next version. See the wiki for changelog: https://github.com/Zackptg5/MMT-Extended/wiki/Changelog
Subscribed. Appreciate your efforts!
Minimun Magisk version?
panchogg said:
Minimun Magisk version?
Click to expand...
Click to collapse
It follows official magisk template so 19 is minimum currently
MMT-Ex has been updated to v1.2! I anticipate this being the last update for a while unless something comes up - think I got it at a good state.
Changelog can be found same place as always: https://github.com/Zackptg5/MMT-Extended/wiki/Changelog
Some notable changes are:
MMT-Ex now has the same behavior as mainstream magisk module template - it always uninstalls/installs Furthermore, to simplify things, it'll only work in magisk manager. If you flash it in TWRP, it'll trigger automatic removal - this was kept in as a save from a module causing a bootloop
common/uninstall and upgrade scripts are gone now - no need for them anymore. There are very few instances where you'd need custom uninstall logic now since MMT-Ex handles all file removal automatically but if you do have something, you can place it in the TOP of the uninstall file at root of installer
ORIGVEN variable is gone - turns out that original vendor is always $ORIGDIR/vendor so you can just use that
Zackptg5 said:
MMT-Ex has been updated to v1.2! I anticipate this being the last update for a while unless something comes up - think I got it at a good state.
Changelog can be found same place as always: https://github.com/Zackptg5/MMT-Extended/wiki/Changelog
Some notable changes are:
MMT-Ex now has the same behavior as mainstream magisk module template - it always uninstalls/installs Furthermore, to simplify things, it'll only work in magisk manager. If you flash it in TWRP, it'll trigger automatic removal - this was kept in as a save from a module causing a bootloop
common/uninstall and upgrade scripts are gone now - no need for them anymore. There are very few instances where you'd need custom uninstall logic now since MMT-Ex handles all file removal automatically but if you do have something, you can place it in the TOP of the uninstall file at root of installer
ORIGVEN variable is gone - turns out that original vendor is always $ORIGDIR/vendor so you can just use that
Click to expand...
Click to collapse
Took you a while to find a proper avatar..

Downloaded a module from magiskroot.net - safe?

So like a total dumbass I didn't check the source and downloaded a module (fde.ai) from magiskroot.net . Seemed to install fine, boot took a bit longer than usual, after boot the module was not listed in Magisk manager.
Is that site safe?
Thanks!
PS I guess I'm asking opinions about the specific site...
I would investigate and open the zip and look what it changes? Did you install it in recovery or in magisk?
I don't know that site.
McFlypants said:
I would investigate and open the zip and look what it changes? Did you install it in recovery or in magisk?
I don't know that site.
Click to expand...
Click to collapse
In Magisk. I'm trying to search for added files in the system right now, nothing found so far. I have also opened the zip (just before your reply) but I'm not sure I'll be able to decipher...
krakout said:
In Magisk. I'm trying to search for added files in the system right now, nothing found so far. I have also opened the zip (just before your reply) but I'm not sure I'll be able to decipher...
Click to expand...
Click to collapse
a magisk module wouldn't change system files it'll just create a folder in data/adb/modules so look there for strange folders
jons99 said:
a magisk module wouldn't change system files it'll just create a folder in data/adb/modules so look there for strange folders
Click to expand...
Click to collapse
Only the few, known modules there. Should I assume I'm ok then?
krakout said:
Only the few, known modules there. Should I assume I'm ok then?
Click to expand...
Click to collapse
not sure it might have done something else like put a script that magisk run on boot or something maybe send me this module in pm and I'll look at what's in there
Sure thing, thanks. Also, here is the Magisk log:
jons99 said:
not sure it might have done something else like put a script that magisk run on boot or something maybe send me this module in pm and I'll look at what's in there
Click to expand...
Click to collapse
Sure thing, thanks. Also, here is the Magisk boot log:

Categories

Resources