Database Develop

[UNOFFICIAL] TWRP for Lenovo Yoga Tab 3 Plus (YTX703F/YTX703L)

It has been bugging me for quite some time that the Lenovo Yoga Tab 3 Plus has a portrait (phone) 10" screen mounted in a landscape body, and TWRP didn't have the necessary code to adjust its graphics rendering so as to compensate for this, so I just decided to patch it myself.
With these unofficial recoveries (officials can be found here and here), you get the following improvements:
Graphics are rendered in the landscape orientation
Compiled from LineageOS 15.1 sources plus LineageTWRP => much easier to maintain
(For development) Pstore/ramoops active, can retrieve the Android kernel's log on reboot or panic
Mouse pointer in the middle of the screen is gone
Factory reset commands from Android are no longer broken
Removed their prompt to install the TWRP app in Android when you try to reboot
Also be aware that flashing unofficial cm14 zips is not supported with these TWRP images!
If any of the items above bug you as well, these TWRP builds may be for you. At the moment they are optional (not required - you may use other TWRP recoveries just as well) if you are a user of LineageOS 15.1 for YTX703F/YTX703L. However, in the future we will be making steps to replace the official TWRP recoveries with these ones over here.
Known issues
None so far.
Downloads
TWRP 3.2.3: [YTX703F (Wifi)] | [YTX703L (LTE)]
Installation instructions
If your device is new to the custom ROM flashing process, you need to unlock its bootloader:
Code:
fastboot oem unlock-go
If you are not fully decided and just want to try out these TWRP images, you can just hot-boot them into RAM, without writing them permanently to flash storage:
Code:
fastboot boot twrp-3.2.3-UNOFFICIAL-YTX703L.img
If you don't like it, it's not persistent (rebooting again will get you the old recovery back)
If you're sold on the new recovery image, here's how to permanently flash it:
Code:
adb reboot bootloader # Do this only if you're not in fastboot mode right now (with the orange Lenovo image)
fastboot flash recovery twrp-3.2.3-UNOFFICIAL-YTX703L.img
fastboot continue # Will boot into Android
Build instructions
Add the following to .repo/local_manifests/roomservice.xml in a lineage-15.1 tree:
Code:
<?xml version="1.0" encoding="UTF-8"?>
<manifest>
<remote fetch="https://github.com/omnirom" name="omnirom" review="gerrit.omnirom.org" revision="android-8.1" />
<project groups="pdk" name="android_bootable_recovery" path="bootable/recovery-twrp" remote="omnirom" />
</manifest>
Run the following:
Code:
$ repo sync bootable/recovery-twrp
$ source build/envsetup.sh
$ repopick -P bootable/recovery-twrp -g https://gerrit.omnirom.org 31454
$ repopick -P bootable/recovery-twrp -g https://gerrit.omnirom.org 31630
$ repopick -P bootable/recovery-twrp -g https://gerrit.omnirom.org 28622
$ lunch lineage_YTX703L-eng
$ WITH_TWRP=true mka recoveryimage
$ adb reboot bootloader
$ fastboot boot out/target/product/YTX703L/recovery.img

vladimiroltean said:
It has been bugging me for quite some time that the Lenovo Yoga Tab 3 Plus has a portrait (phone) 10" screen mounted in a landscape body, and TWRP didn't have the necessary code to adjust its graphics rendering so as to compensate for this, so I just decided to patch it myself.
With these unofficial recoveries (officials can be found here and here), you get the following improvements:
Graphics are rendered in the landscape orientation
Compiled from LineageOS 15.1 sources plus LineageTWRP => much easier to maintain
(For development) Pstore/ramoops active, can retrieve the Android kernel's log on reboot or panic
Mouse pointer in the middle of the screen is gone
Factory reset commands from Android are no longer broken
Removed their prompt to install the TWRP app in Android when you try to reboot
Also be aware that flashing unofficial cm14 zips is not supported with these TWRP images!
If any of the items above bug you as well, these TWRP builds may be for you. At the moment they are optional (not required - you may use other TWRP recoveries just as well) if you are a user of LineageOS 15.1 for YTX703F/YTX703L. However, in the future we will be making steps to replace the official TWRP recoveries with these ones over here.
Known issues
None so far.
Downloads
TWRP 3.2.3: [YTX703F (Wifi)] | [YTX703L (LTE)]
Installation instructions
If your device is new to the custom ROM flashing process, you need to unlock its bootloader:
If you are not fully decided and just want to try out these TWRP images, you can just hot-boot them into RAM, without writing them permanently to flash storage:
If you don't like it, it's not persistent (rebooting again will get you the old recovery back)
If you're sold on the new recovery image, here's how to permanently flash it:
Click to expand...
Click to collapse
Can I also install this new recovery image using the twrp app instead adb?
Or can i try the new Image to execute the Codes directly in the tablet with the terminal emulator App instead connecting to the PC?

tombraga said:
Can I also install this new recovery image using the twrp app instead adb?
Click to expand...
Click to collapse
I've never used that, as I consider it bloatware. If it allows you to flash a local disk image (and not only ones downloaded from twrp.me) into the recovery partition, then I suppose you can. But then again, that'd require giving it root permissions, and I don't think I'd trust it that much just because I'm lazy.

vladimiroltean said:
I've never used that, as I consider it bloatware. If it allows you to flash a local disk image (and not only ones downloaded from twrp.me) into the recovery partition, then I suppose you can. But then again, that'd require giving it root permissions, and I don't think I'd trust it that much just because I'm lazy.
Click to expand...
Click to collapse
Thanks for Information, one more question:
Can i try the new Image to execute the Codes directly in the tablet with the terminal emulator App instead connecting to the PC?
I got some problem right now with my pc and cannot use it with my tablet

tombraga said:
Thanks for Information, one more question:
Can i try the new Image to execute the Codes directly in the tablet with the terminal emulator App instead connecting to the PC?
I got some problem right now with my pc and cannot use it with my tablet
Click to expand...
Click to collapse
You can try to do this:
Code:
su
dd if=/sdcard/Download/twrp-3.2.3-UNOFFICIAL-YTX703L.img of=/dev/block/bootdevice/by-name/recovery
sync
But keep in mind that interactive "su" sessions are kinda broken (tab completion, Ctrl-c and other stuff), this patch fixes that but its's not merged yet. So your mileage might vary. If you just cut and paste the commands (make sure they match your device though!) it should work.

vladimiroltean said:
You can try to do this:
But keep in mind that interactive "su" sessions are kinda broken (tab completion, Ctrl-c and other stuff), this patch fixes that but its's not merged yet. So your mileage might vary. If you just cut and paste the commands (make sure they match your device though!) it should work.
Click to expand...
Click to collapse
Thanks, but this is too hot for, better I wait and fix my pc first, thanks
At least perhaps a stupid question: can i flash your new twrp img directly from my actual official 3.2.0-0 twrp choosing install image and then your img.file?

tombraga said:
Thanks, but this is too hot for, better I wait and fix my pc first, thanks
At least perhaps a stupid question: can i flash your new twrp img directly from my actual official 3.2.0-0 twrp choosing install image and then your img.file?
Click to expand...
Click to collapse
There are countless ways you can do it, but like you said, it's not a good idea to reflash your recovery if you're don't have a plan B if anything goes wrong.

vladimiroltean said:
There are countless ways you can do it, but like you said, it's not a good idea to reflash your recovery if you're don't have a plan B if anything goes wrong.
Click to expand...
Click to collapse
i could fix my laptop now i made it with adb as you teached and explained, worked wityout any problems
I like very much the new TWRP, waiting so long for this landscape mode and without questions to install TWRP app.
Now i uninstall the TWRP app and have a very nice TWRP recovery which is fine for my Lenovo tablet, thank you so much.
Problem: no i cannot uninstall more the TWRP app, even tried with titanium pro, but could not find the system app was the message...
should i freez the twrp app now with titanium pro?
When your twrp will go official???? I hope soon.
---------- Post added at 05:21 PM ---------- Previous post was at 05:06 PM ----------
tombraga said:
i could fix my laptop now i made it with adb as you teached and explained, worked wityout any problems
I like very much the new TWRP, waiting so long for this landscape mode and without questions to install TWRP app.
Now i uninstall the TWRP app and have a very nice TWRP recovery which is fine for my Lenovo tablet, thank you so much.
Problem: no i cannot uninstall more the TWRP app, even tried with titanium pro, but could not find the system app was the message...
should i freez the twrp app now with titanium pro?
When your twrp will go official???? I hope soon.
Click to expand...
Click to collapse
made even a first backup right now with the new TWRP, without any problem and very fast. great!

tombraga said:
Problem: no i cannot uninstall more the TWRP app, even tried with titanium pro, but could not find the system app was the message...
should i freez the twrp app now with titanium pro?
Click to expand...
Click to collapse
If it really bothers you, I would wipe the system partition and install everything else all over again (LineageOS, the exact same Gapps package, etc).
tombraga said:
When your twrp will go official???? I hope soon.
Click to expand...
Click to collapse
Probably not very soon, hence the reason why I decided to release it unofficially for a while. I contacted the TWRP project maintainers and they said they're caught at the moment with other stuff (merging with Android P codebase) and they can't review my display rotation patch until that activity is finished. So we're probably talking about the timeframe when the first official TWRP and LineageOS builds based on Android P are going to get released.

vladimiroltean said:
If it really bothers you, I would wipe the system partition and install everything else all over again (LineageOS, the exact same Gapps package, etc).
Probably not very soon, hence the reason why I decided to release it unofficially for a while. I contacted the TWRP project maintainers and they said they're caught at the moment with other stuff (merging with Android P codebase) and they can't review my display rotation patch until that activity is finished. So we're probably talking about the timeframe when the first official TWRP and LineageOS builds based on Android P are going to get released.
Click to expand...
Click to collapse
It's ok, I can live with it.

I see two things in new version
1) graphical bug inside list of files (overlapping)
2) cannot access NTFS formatted sd-card (while older version working fine)

janforman said:
I see two things in new version
1) graphical bug inside list of files (overlapping)
2) cannot access NTFS formatted sd-card (while older version working fine)
Click to expand...
Click to collapse
1. Screenshot? (I think it's vol-up + power)
2. That might be my oversight on my part. NTFS is indeed not enabled in the kernel because Android uses the ntfs-3g FUSE implementation. I think that's not available in TWRP though.

vladimiroltean said:
1. Screenshot? (I think it's vol-up + power)
2. That might be my oversight on my part. NTFS is indeed not enabled in the kernel because Android uses the ntfs-3g FUSE implementation. I think that's not available in TWRP though.
Click to expand...
Click to collapse
I flashed older TWRP version and NTFS is working well. I'm using it for flashing and backup. In new version sdcard is not mounted and in "mount" option greyed out (i cannot select it).

I had an issue flashing a custom boot animation zip and font zip, they appeared to flash fine in recovery but the boot animation and font was not changed. I flashed the latest official TWRP and these zips flashed and took effect fine. No issues with ROM zip, gapps or magisk though

scoobyjenkins said:
I had an issue flashing a custom boot animation zip and font zip, they appeared to flash fine in recovery but the boot animation and font was not changed. I flashed the latest official TWRP and these zips flashed and took effect fine. No issues with ROM zip, gapps or magisk though
Click to expand...
Click to collapse
Can you give a link to the boot animation and font you flashed.
I know you are the graphics expert around here so will be nice if you can point us to some compatible boot animations for our device.
I really don't want to sound unappreciative but the Lineage 'stock' boot animation seriously needs a facelift

Finefeather said:
Can you give a link to the boot animation and font you flashed.
I know you are the graphics expert around here so will be nice if you can point us to some compatible boot animations for our device.
I really don't want to sound unappreciative but the Lineage 'stock' boot animation seriously needs a facelift
Click to expand...
Click to collapse
The animation is nothing to do with Lineage, but if you like Raphael of TMNT, feel free to try this: https://drive.google.com/open?id=0B260dxr9nvchTG0xR2pYelhuNHc
I have noticed that with an animation that fills more of the screen than the lineage logo, there seems to be a black overlay taking up about a 3rd of the screen at the right, which obscures my animation a little but only for a couple of seconds.
As I say, I can flash this with official TWRP but it doesn't seem to take with this one

This version of TWRP is unfortunately not compatible with GApps+Aroma. (The standard version works fine.)

Rueddi_ger said:
@vladimiroltean
How do I compile this TWRP? I found the twrp.mk in our devicetree/recovery directory. I pasted all flags to the end of BoardConfigCommon and the BoarConfig of the F/L version. It compiles well, but doesn't recognize those flags, I think. When I boot the img The touchscreen is completely inverted and is weird. Apart from that it isn't in landscape mode, but in portrait ( even thought the flags include TW_THEME := landscape_hdpi) Can you give me an idea where the problem is?
You can find my device tree here: Github
Click to expand...
Click to collapse
Added instructions in the top post.

Rueddi_ger said:
Actually I forgot to mention that I do not want to build TWRP exactly, but OrangeFox (which is based on TWRP). The problem is I cannot use the lineageOS tree, I think, because OrangeFox requires to be initialized with the minimal Omni manifest (see here: https://gitlab.com/OrangeFox/Manifest ). Do you have an idea what I can do?
Click to expand...
Click to collapse
What have you tried to do and what were the errors you were faced with?

Rueddi_ger said:
Apart from that it didn't seem to recognize any TWRP flags as the theme is not landscape, although I put those flags like everywhere
Click to expand...
Click to collapse
Hate to break it to you, but rotating the recovery framebuffer is an operation that is quite a bit more involved than setting "TW_THEME := landscape" (assuming that's what you were trying to say).
Did you even bother to look at the patches linked in the top post? What about this one:
Code:
From 2a8821faf98f8c26a88e9bbe8a8a6d31015b938b Mon Sep 17 00:00:00 2001
From: Vladimir Oltean <[email protected]>
Date: Tue, 3 Jul 2018 00:04:03 +0300
Subject: [PATCH] TW_HWROTATION: add flag to handle hardware-rotated display
panels
* The existence of TW_HWROTATION that implements this feature at the
level of calls to libpixelflinger API closely mirrors the existence of
ro.sf.hwrotation for surfaceflinger in LineageOS.
* A brute-force approach was previously attempted via the
BOARD_HAS_FLIPPED_SCREEN makefile flag. That code iterated over the
active display surface in a double-buffered setup, and performed a
"smart" memcpy from the UI drawing surface (gr_draw) onto the display
surface. The problem was that, without heavy loop optimizations, that
code could have never scaled for 90 and 270 degree rotation.
I tried and you could literally see the for loop with the naked eye
while the display surface was updating.
* That code is now gone, but support for BOARD_HAS_FLIPPED_SCREEN := true
is still there (now means TW_HWROTATION := 180).
* This patch relies on the assumption that it is impossibly difficult
and non-portable to rotate whole framebuffer display surfaces, in a
way that is not dependent upon the graphics backend (adf, fbdev, drm,
overlay etc). Therefore, it identifies the rendering primitives that
the TWRP graphics stack exposes to the GUI application above, and
implements hwrotation inside each of those calls instead:
- gr_line(), gr_fill() - 2D geometric shapes (lines, rectangles)
- gr_blit() - graphical image resources
- gr_ttf_textExWH() - font rendering
- gr_fb_width(), gr_fb_height() - framebuffer resolution
* The gist is to keep the backend and framebuffer (dimensions, row size
etc) unchanged (because making changes there is asking for trouble),
but present an altogether different reality to the calling API,
according to the compile-time constant TW_HWROTATION.
* All (x, y) API coordinates and shapes are transformed before being
actually rendered as (x_disp, y_disp) display coordinates.
* With TW_HWROTATION := 90 or 270 you can turn a landscape device into
a portrait one, because the GUI is fooled by the reversed dimensions
reported by gr_fb_width() and gr_fb_height() and renders the UI as
for a different device.
* For blit and text rendering operations, figuring out the transformed
coordinates in display space is not enough, as the surfaces that are
to be rendered have to be rotated themselves. This is handled by
allocating an intermediary rotated surface on each rendering
operation (not ideal), so the code with the intermediary surface
is compiled out for the TW_HWROTATION := 0 case.
* This is still not as bad as rotating the whole framebuffer though, and
on a msm8976 device the performance hit is not even noticeable (for
software rendering).
* Currently there is no attempt to make a connection between the
TW_HWROTATION and the { RECOVERY_TOUCHSCREEN_SWAP_XY,
RECOVERY_TOUCHSCREEN_FLIP_X, RECOVERY_TOUCHSCREEN_FLIP_Y } settings.
Change-Id: Ic8966ad5360c8a499649fdb16e242286640fd992
Signed-off-by: Vladimir Oltean <[email protected]>

[ROM][Pie] Unofficial LineageOS 16.0

This is an unofficial build of LineageOS 16.0 for the Motorola razr I, (XT890/SMI).
Lots of thanks to Hazou. This rom is based on his los-14 rom and I got help from him with los-16.
This rom has full hardware support and should run stable. It has been tested by me in daily use. I'm using the rom without google apps, but with microg. Installing google apps requires some apps to move to data partition because of limited system size. See install description for more info.
Special Features
-All features of Hazous 14.1 rom
-MicroG signature spoofing patch is included.
-Adaptive icons can be disabled in homescreen settings.
I can include more features if requested
Known Bugs
-The camera preview image sometimes shakes at random
Download
https://mega.nz/#F!5fBWlIAQ!Jlq9Bj789iJ0iIIptK00tg
Update
If you already run an earlier version of this rom, just boot to twrp and install the latest flashable zip file
Install
1. Backup everything you don't want to loose.
2. Download and install TWRP 3.2.3 (download in attachments. Can be flashed with fastboot or with another recovery)
3. If you come from another rom do a full wipe with twrp
4. Download and install the rom flashable zip (download from mega.nz link is in section download)
5. If you want to install opengapps or need system partition space for other things. Install the move_to_data.zip file from the attachments. This will move the Webview and the LatinIME app to data partition.
6. Choose one of the following options:
-either install google apps (download form https://opengapps.org/. Choose x86 9.0 nano or pico)
-or install MicroG (can be installed with the unofficial installer https://forum.xda-developers.com/android/development/microg-unofficial-installer-t3432360) this is lighter in ram and cpu usage but you will get problems with google chrome and other apps
7. If you want root access install the addonsu-16.0-x86.zip (download in the attachments)
8. Reboot the phone. First reboot will take some time
Changelog
Code:
20191018:
fixed problem with sms receiving
20191012:
mobile network connection works now after boot
Fixed problems with network switching
Show taps option is working now
intel art extension enabled
Call recording enabled
text relocation warnings disbaled
(untested) encryption. Needs special configuration (see below)
20190819:
SELinux is now enforcing
Notification access feature enabled
solved crashes with houdini emulated apps
20190713:
usb configuration works properly
battery light works now
July security patches
20190704:
first stable release of this rom
DATA Encryption
If you want to enable data encryption this would break the pds partition backup. To prevent this, the cache partition can be used as backup location:
-edit /system/bin/pdsbackup.sh
-change PDS_FILE=/data/misc/pds/pdsdata.img to PDS_FILE=/cache/misc/pds/pdsdata.img
-resize data partition in TWRP:
Code:
umount /data
umount /sdcard
e2fsck -f /dev/block/mmcblk0p17
resize2fs /dev/block/mmcblk0p17 1367079
-reboot the phone
XDA:DevDB Information
unonfficial LineageOS 16.0, ROM for the Motorola RAZR i
Contributors
julianwi, Hazou
Source Code: https://github.com/julianwi/android_device_motorola_smi/tree/lineage-16.0
ROM OS Version: 9.x Pie
ROM Kernel: Linux 3.0.x
Based On: LineageOS
Version Information
Status: Stable
Stable Release Date: 2019-08-19
Created 2019-07-04
Last Updated 2019-08-19

This if I did not expect it, I'll try to see how it goes. Thank you.

Download links and install description are up now. Download from mega.nz because xda download section is broken at the moment. I'm waiting for your test reports

It's really great works, thank you!!
I quickly tried and found several points.
- USB connection with PC
All USB connection option including File Transfer, USB tethering, PTP are grayed out.
Disabling/Enabling android debug in setting didn't work.
- Wifi with storage encryption
When you enable storage encryption, WiFi always become disabled, not be able to enable.
Just FYI, it required deleting /system/bin/pdsbackup.sh AND reducing partition size of 'data' (/dev/block/mmcblk0p17).
- SElinux
Although it is designated as permissive in device.mk, it's actually worked as "disabled".
I'm not sure it's related or not, however, when building "user build", it's failed with "ERROR: permissive domains not allowed in user builds".
I know "user build" is not officially supported in Lineage release, however, it's really helpful if we can do it for AFW usage.
Previously I could use Lineage 14.1 smi build for AFW and safetynet app with user build.
BTW, performance is really great, seems to be almost same as Lineage 11.

dumkm said:
It's really great works, thank you!!
I quickly tried and found several points.
- USB connection with PC
All USB connection option including File Transfer, USB tethering, PTP are grayed out.
Disabling/Enabling android debug in setting didn't work.
Click to expand...
Click to collapse
I also noticed that. Will see how this can be fixed. It is just a problem with the option dialog. Usb connection works fine. As a workaround you can set a default USB configuration in developer options
dumkm said:
- Wifi with storage encryption
When you enable storage encryption, WiFi always become disabled, not be able to enable.
Just FYI, it required deleting /system/bin/pdsbackup.sh AND reducing partition size of 'data' (/dev/block/mmcblk0p17).
Click to expand...
Click to collapse
I have not tested storage encryption yet. Will have a look at it later
dumkm said:
- SElinux
Although it is designated as permissive in device.mk, it's actually worked as "disabled".
I'm not sure it's related or not, however, when building "user build", it's failed with "ERROR: permissive domains not allowed in user builds".
I know "user build" is not officially supported in Lineage release, however, it's really helpful if we can do it for AFW usage.
Previously I could use Lineage 14.1 smi build for AFW and safetynet app with user build.
Click to expand...
Click to collapse
I think lineage trust doesn't differentiate between permissive and disabled. Selinux support is planned for future releases

Thank you for quick check.
Regarding USB connection, I also confirmed that Ubuntu can recognize as external storage with above option, besides Windows still does not recognize. Maybe depending on my environment.
Also I noticed that Chrome, Chrome Beta and Chrome Canary (therefore another Chrome based apps such as Maps Go) always crash. This is also maybe my environment only, though. BTW, I could install MicroG, besides couldn't install OpenGapps 9.0 pico due to partition size limit.
Additionally, I couldn't find any LED settings, currently LED is always off during charge or any notification.

dumkm said:
Thank you for quick check.
Regarding USB connection, I also confirmed that Ubuntu can recognize as external storage with above option, besides Windows still does not recognize. Maybe depending on my environment.
Also I noticed that Chrome, Chrome Beta and Chrome Canary (therefore another Chrome based apps such as Maps Go) always crash. This is also maybe my environment only, though. BTW, I could install MicroG, besides couldn't install OpenGapps 9.0 pico due to partition size limit.
Additionally, I couldn't find any LED settings, currently LED is always off during charge or any notification.
Click to expand...
Click to collapse
Notification Led should work. Can be configured under settings->apps and notifications->notifications->notification light. I don't know what happened with the battery light. It will hopefully come back if I upgrade the driver to hidl.
Google Chrome is a known problem with MicroG. It requires official gapps. I will check if some of the unprivileged lineage apps can be moved to data partition to make place for google apps

Newbie question
Hi all, I know someone who's selling her old RAZR i XT890 and I'm interested (for experimental reasons but also the oddity that it's Intel powered). I've never owned a RAZR i so I've got some questions:
-The phone is from 2012 so quite old and has 1GB RAM, does it work well with this Lineage 16? Because usually newer software would perform bad on older SoC (I used to have iOS 7 on iPhone 4 back in the day and it was painfully slow compared to 6).
-On Lineage 16, can it run any Android app as a standard new Android Pie phone? I ask because this is an Intel x86 CPU, so can it still run Android apps as normal or are most of them only designed for ARM and therefore unusable?
If I get the good news, I may buy the phone and try this Lineage OS custom ROM.

Regarding LED, maybe it became working after modifying some option of notification light. Battery connection light is still always off.
Regarding opengapps, I moved webview and LatinIME from app directory to external SD in TWRP, then installed as normal app after system boot. Webview worked fine besides LatinIME always crash. I'm using different IME, so it's no problem. With this environment, opengapps nano can be installed, then Chrome, Maps and other google apps worked.

dumkm said:
Regarding LED, maybe it became working after modifying some option of notification light. Battery connection light is still always off.
Regarding opengapps, I moved webview and LatinIME from app directory to external SD in TWRP, then installed as normal app after system boot. Webview worked fine besides LatinIME always crash. I'm using different IME, so it's no problem. With this environment, opengapps nano can be installed, then Chrome, Maps and other google apps worked.
Click to expand...
Click to collapse
That's good. Than we can make a flashable zip to automatically move and symlink them to data partition.
I will provide a new build till end of the week with improved usb and notification LED implementation. I already got it working in my local setup
flameseewa said:
Hi all, I know someone who's selling her old RAZR i XT890 and I'm interested (for experimental reasons but also the oddity that it's Intel powered). I've never owned a RAZR i so I've got some questions:
-The phone is from 2012 so quite old and has 1GB RAM, does it work well with this Lineage 16? Because usually newer software would perform bad on older SoC (I used to have iOS 7 on iPhone 4 back in the day and it was painfully slow compared to 6).
-On Lineage 16, can it run any Android app as a standard new Android Pie phone? I ask because this is an Intel x86 CPU, so can it still run Android apps as normal or are most of them only designed for ARM and therefore unusable?
If I get the good news, I may buy the phone and try this Lineage OS custom ROM.
Click to expand...
Click to collapse
Newer android versions have been designed while keeping low ram devices in mind. Ram hungry special features like the picture in picture mode are excluded from builds for older device. So the situation is much better then on iOS. But a newer phone would run better thought.
Most android apps are available for x86. But some are still arm only and get automatically emulated. The intel houdini emulator integrates these apps natively into the system but they are a bit slower then x86 apps. These are for example Skype and a few unity based games

julianwi said:
Newer android versions have been designed while keeping low ram devices in mind. Ram hungry special features like the picture in picture mode are excluded from builds for older device. So the situation is much better then on iOS. But a newer phone would run better thought.
Most android apps are available for x86. But some are still arm only and get automatically emulated. The intel houdini emulator integrates these apps natively into the system but they are a bit slower then x86 apps. These are for example Skype and a few unity based games
Click to expand...
Click to collapse
Thanks for the response. So I should be alright with it then, hopefully. I just hope it won't lag on that old SoC. I'd love if you could upload a quick video of it in action.

TWRP error 70
julianwi said:
This is an unofficial build of LineageOS 16.0 for the Motorola razr I, (XT890/SMI).
Lots of thanks to Hazou. This rom is based on his los-14 rom and I got help from him with los-16.
This rom has full hardware support and should run stable. It has been tested by me in daily use. I'm using the rom without google apps, but with microg. I don't know how smooth it runs with official gapps.
Special Features
-All features of Hazous 14.1 rom
-MicroG signature spoofing patch is included.
-Adaptive icons can be disabled in homescreen settings.
I can include more features if requested
Known Bugs
-Mobile cell connection doesn't connect after boot. You have to turn airplane mode on and off to let it work.
-selinux is set to permissive for now (reduced security)
Please report more bugs if you test this rom
Install
1. Backup everything you don't want to loose.
2. Download and install TWRP 3.2.3 (download in attachments. Can be flashed with fastboot or with another recovery)
3. If you come from another rom do a full wipe with twrp
4. Download and install the rom flashable zip (download from mega.nz https://mega.nz/#!ICwXRC6D!VZqe3o5zeWbmMiZvka_BtUTW5T_V7_OdMS57Oe9CbMk)
5. Choose one of the following options:
-either install MicroG (can be installed with the unofficial installer https://forum.xda-developers.com/android/development/microg-unofficial-installer-t3432360)
-or install google apps (download form https://opengapps.org/. Choose x86 9.0 pico)
6. If you want root access install the addonsu-16.0-x86.zip (download in the attachments)
7. Reboot the phone. First reboot will take some time
XDA:DevDB Information
unonfficial LineageOS 16.0, ROM for the Motorola RAZR i
Contributors
julianwi, Hazou
Source Code: https://github.com/julianwi/android_device_motorola_smi/tree/lineage-16.0
ROM OS Version: 9.x Pie
ROM Kernel: Linux 3.0.x
Based On: LineageOS
Version Information
Status: Stable
Stable Release Date: 2019-07-04
Created 2019-07-04
Last Updated 2019-07-05
Click to expand...
Click to collapse
I've installed the OS without problems, but when i try to get GApps Pico or any other version TWRP prompt error 70. How should i proceed? There is any additional configuration needed?

Kazvko said:
I've installed the OS without problems, but when i try to get GApps Pico or any other version TWRP prompt error 70. How should i proceed? There is any additional configuration needed?
Click to expand...
Click to collapse
Yes, system partition size is limited on this phone. To install GApps some files need to be moved to data partition.
I created a flashable zip to automate this process. Take a look at the modified install description in the first post

New build is up now.
flameseewa said:
Thanks for the response. So I should be alright with it then, hopefully. I just hope it won't lag on that old SoC. I'd love if you could upload a quick video of it in action.
Click to expand...
Click to collapse
Sorry don't have enough time to make a video in the near future. Maybe someone else can record a video of it

I could confirm that notification LED and USB storage works fine with lineage-16.0-20190713-UNOFFICIAL-smi. Thanks.
Still WiFi with storage encryption does not work.

julianwi said:
New build is up now.
Sorry don't have enough time to make a video in the near future. Maybe someone else can record a video of it
Click to expand...
Click to collapse
Alright, thanks. I bought my friend's RAZR i and I am planning to use it as a daily driver with this ROM (I'm a light user anyway), I can't thank you enough for making this LineageOS for such an old device. I wonder if such a recent Lineage has been developed for the 2011 Atrix, haven't seen one.
I have questions though, firstly I've never used a custom ROM before, can I simply follow the instructions on this thread to get it working, or is there anything that has to be done beforehand like rooting? Secondly, are any other OSs successfully booting on this x86 phone, as I can't find it on XDA? (it surprisingly hasn't gotten much attention as a hackable device like HTC HD2 or Nokia N900 got).

dumkm said:
I could confirm that notification LED and USB storage works fine with lineage-16.0-20190713-UNOFFICIAL-smi. Thanks.
Still WiFi with storage encryption does not work.
Click to expand...
Click to collapse
I know, haven't looked at the storage encryption for now. It will maybe be in the next update next month
flameseewa said:
Alright, thanks. I bought my friend's RAZR i and I am planning to use it as a daily driver with this ROM (I'm a light user anyway), I can't thank you enough for making this LineageOS for such an old device. I wonder if such a recent Lineage has been developed for the 2011 Atrix, haven't seen one.
I have questions though, firstly I've never used a custom ROM before, can I simply follow the instructions on this thread to get it working, or is there anything that has to be done beforehand like rooting? Secondly, are any other OSs successfully booting on this x86 phone, as I can't find it on XDA? (it surprisingly hasn't gotten much attention as a hackable device like HTC HD2 or Nokia N900 got).
Click to expand...
Click to collapse
If the phone never had a custom rom yet, you have to unlock the bootloader first. Description is in this thread: https://forum.xda-developers.com/showthread.php?t=1928551

julianwi said:
If the phone never had a custom rom yet, you have to unlock the bootloader first. Description is in this thread: https://forum.xda-developers.com/showthread.php?t=1928551
Click to expand...
Click to collapse
That's an old guide, will everything still work?

flameseewa said:
That's an old guide, will everything still work?
Click to expand...
Click to collapse
Yes, it should still work the same. If some links are outdated you can google them yourself

Thank you for bringing my old RAZR i back to life! I really appreciate the time and effort you spent for this obselete phone. Looking forward for more updates and for a bug free ROM. Using it now
dumkm said:
- Wifi with storage encryption
When you enable storage encryption, WiFi always become disabled, not be able to enable.
Just FYI, it required deleting /system/bin/pdsbackup.sh AND reducing partition size of 'data' (/dev/block/mmcblk0p17).
Click to expand...
Click to collapse
I'm not sure if I misunderstood but when you said "it required deleting....." and "reducing partition size of data", did you mean you can get WiFi to work if you do those things? I'm no expert at these but I can atleast apply the "fix" (if it really is) given that you guide me, if it's okay with you. Thanks!

[GUIDE] Re-locking the bootloader on the OnePlus 6t with a self-signed build of LOS

What is this tutorial?
This tutorial will:
Creating an unofficial build of LineageOS 17.1 suitable for using to re-lock the bootloader on a OnePlus 6/6t
Take you through the process of re-locking your bootloader after installing the above
This tutorial will NOT:
Remove *all* warning messages during boot (the yellow "Custom OS" message will be present though the orange "Unlocked bootloader" message will not)
Allow you to use official builds of LineageOS 17.1 on your device with a re-locked bootloader (more details near the end of the tutorial)
This tutorial will assume you are working on an Ubuntu 18.04 installation, if you are using Windows or another Linux distro, the commands may be different.
Supported devices:
Current both the OnePlus 6 (enchilada) and 6t (fajita) have been tested, but newer phones should work as well.
For simplicities sake, all further references will only be to the 6t (fajita).
Pre-requisites:
a mid level knowledge of terminal commands and features
a supported phone
a PC with enough CPU/RAM to build LineageOS 17.1 (recommended 8 cores, 24g of RAM)
a working USB cable
fastboot/adb installed and functional
LineageOS 17.1 source code downloaded
at least one successful build of LineageOS
at least one successful signing of your build with your own keys
Misc. notes:
the basics of building/signing of LineageOS is outside the scope of this tutorial, refer to the LineageOS Wiki for details on how to complete these tasks
you'll be modifying some code in LineageOS, so if you are not comfortable using basic editing utilities as well as patch, do not proceed any further
the path to your LineageOS source code is going to be assumed to be ~/android/lineageos, if it is somewhere else, substitute the correct path in the tutorial
the path to your private certificate files is going to be assumed to be ~/android-certs, if it is somewhere else, substitute the correct path in the tutorial
*** WARNING ****
This process may brick your device. Do not proceed unless you are comfortable taking this risk.
*** WARNING ****
This process will delete all data on your phone! Do not proceed unless you have backed up your data!
*** WARNING ****
Make sure you have read through this entire process at least once before attempting, if you are uncomfortable with any steps include in this guide, do not continue.
And now on with the show!
Step 1: Basic setup
You need a few places to store things, so create some working directories:
Code:
mkdir ~/android/fajita
mkdir ~/android/fajita/oos
mkdir ~/android/fajita/images
mkdir ~/android/fajita/images_raw
mkdir ~/android/fajita/patches
mkdir ~/android/fajita/pkmd
You also need to add "~/android/lineageos/out/host/linux-x86/bin" to your shell's profile path. Make sure to close and restart your session afterwards otherwise the signing will fail later on with a "file not found" error message .
Step 2: Download the latest OxygenOS from OnePlus
Go to https://www.oneplus.com/support/softwareupgrade and download the latest OOS update, store it in ~/android/fajita/oos
Step 3: Extract the vendor.img from OOS
Run the following commands to extract the vendor.img from OOS:
Code:
cd ~/android/fajita/oos
unzip [oos file name you downloaded] payload.bin
cd ../images_raw
python ~/android/lineageos/lineage/scripts/update-payload-extractor/extract.py --partitions vendor --output_dir . ../oos/payload.bin
You should now have a ~1g file named vendor.img in the images_raw directory.
Step 4: Update fajita's BoardConfig.mk
You will need to add a few parameters to the end of ~/android/lineageos/device/oneplus/fajita/BoardConfig.mk, they are:
Code:
BOARD_PREBUILT_VENDORIMAGE := /home/<userid>/android/fajita/images_raw/vendor.img
AB_OTA_PARTITIONS += vendor
BOARD_AVB_ALGORITHM := SHA256_RSA2048
BOARD_AVB_KEY_PATH := /home/<userid>/.android-certs/releasekey.key
Note you cannot use "~"" in the path names above to signify your home directory, so give the full absolute path to make sure the files are found.
Step 5: Update sdm845-common's BoardConfigCommon.mk (optional)
LineageOS by default disables Android Verified Boot's partition verification, but you can enable it now as all the required parts will be in place. However, you may not want to if you intend to make other changes to the system/boot/vendor partitions (like Magisk, etc.) after you have re-locked the bootloader.
To enable partition verification do the following:
Code:
cd ~/android/lineageos/devices/sdm845-common
sed -i 's/^BOARD_AVB_MAKE_VBMETA_IMAGE_ARGS += --flag 2/#BOARD_AVB_MAKE_VBMETA_IMAGE_ARGS += --flag 2/' BoardConfigCommon.mk
Step 6: Patch the AOSP/LineageOS releasetools
Two releasetools included with LineageOS need to be patched as they otherwise will not properly process a pre-built vendor.img.
The required patches can be found here:
https://raw.githubusercontent.com/W.../source/add_img_to_target_files.py-17.1.patch
https://raw.githubusercontent.com/W...r/source/sign_target_files_apks.py-17.1.patch
Download both and store in ~/android/fajita/patches.
Now apply them with the following commands:
Code:
cd ~/android/lineageos/build/tools/releasetools
patch add_image_to_target_files.py ~/android/fajita/patches/add_image_to_target_files.py-17.1.patch
patch sign_target_files_apks.py ~/android/fajita/patches/sign_target_files_apks.py-17.1.patch
Step 7: Build LineageOS
You are now ready to build:
Code:
cd ~/android/lineageos
source build/envsetup.sh
croot
breakfast fajita
mka target-files-package otatools
Step 8: Prepare vendor.img
As part of the build process above, your raw vendor.img will been copied to the $OUT directory and a new hashtree (what AVB uses to verify the image) will have been added to it.
You need to use this new version in the signing process but due to how the build system works, this is not done by default.
So, let's put it where it is needed:
Code:
cp $OUT/obj/PACKAGING/target_files_intermediates/lineage_fajita-target_files-eng.*/IMAGES/vendor.img ~/android/fajita/images
Step 9: Sign the APKs
You are now ready to sign the apks with sign_target_files_apks:
Code:
./build/tools/releasetools/sign_target_files_apks -o -d ~/.android-certs --prebuilts_path ~/android/fajita/images $OUT/obj/PACKAGING/target_files_intermediates/*-target_files-*.zip signed-target_files.zip
Note the new "--prebuilts_path" option, which points to where your new vendor.img file is located.
Step 10: Build the OTA
Now it is time to complete the OTA package:
Code:
./build/tools/releasetools/ota_from_target_files -k ~/.android-certs/releasekey --block signed-target_files.zip lineage-17.1-[date]-UNOFFICIAL-fajita-signed.zip
Note, replace [date] with today's date in YYYYMMDD format.
Step 11: Create pkmd.bin for your phone
Before you can lock your phone, you have to tell it what your public key is so it knows it can trust your build.
To do this you need to create a pkmd.bin file:
Code:
~/android/lineageos/external/avb/avbtool extract_public_key --key ~/.android-certs/releasekey.key --output ~/android/fajita/pkmd/pkmd.bin
Step 12: Flashing your LineageOS build
It's time to flash your build to your phone. The following steps assume you have already unlocked your phone and have flashed an official version of LineageOS to it. You don't need to have flashed LineageOS yet, you could use TWRP through "fastboot boot" if you prefer.
Reboot your phone in to recovery mode
In LineageOS Recovery select "Apply update"
From your PC, run:
Code:
adb sideload ~/android/lineageos/lineage-17.1-[date]-UNOFFICIAL-fajita-signed.zip
When the sideload is complete, reboot in to LineageOS. Make sure everything looks good with your build.
You may also need to format your data partition at this time depending on what you had installed on your phone previously.
Step 13: Flashing your signing key
Now it's time to add your signing key to the Android Verified Boot process. To do so, do the following:
Reboot your phone in to fastboot mode
From your PC, run:
Code:
fastboot flash avb_custom_key ~/android/fajita/pkmd/pkmd.bin
fastboot reboot bootloader
fastboot oem lock
On your phone, confirm you want to re-lock and it will reboot
Your phone will then factory reset and then reboot in to LineageOS.
Which of course means you have to go through the first time setup wizard, so do so now.
Step 14: Disable OEM unlock
Congratulations! Your boot loader is now locked, but you can still unlock it again using fastboot, so it's time to disable that as well.
Unlock you phone and go to Settings->About phone
Scroll to the bottom and find "Build number"
Tap on it you enable the developer options
Go to Settings->System->Advanced->Developer options
Disable the "OEM unlocking" slider
Reboot
Step 15: Profit!
Other things
The above will build a standard USERDEBUG version of LineageOS, however this will still allow LineageOS Recovery to sideload non-signed files. If you have implemented step 5 above, then this protects your system/vendor/boot/dtbo partitions, but none of the others. Likewise USERDEBUG builds will allow for rolling back to a previous version. To increase security and disallow both of these scenarios you may want to build a USER version of LineageOS to install. However this brings in other issues, such as flashing newer firmware from OnePlus so make sure you understand the implications of both choices. For more details on build types, see https://source.android.com/setup/develop/new-device#build-variants.
In the above example the releasekey from your LineageOS install has been used to sign AVB, but AVB supports other key strengths up to SHA512_RSA8192. You could create a key just for signing AVB that used different options than the default keys generated to sign LineageOS.
If you want to remove you signing key from your phone, you can do it by running "fastboot erase avb_custom_key".
The changes you made to the make files and releasetools may conflict with future updates that you pull from LineageOS through repo sync, if you have to reset the files to get repo sync to complete successfully, you'll have to reapply the changes afterwards.
So why can't I do this with official LineageOS builds?
For Android Verified Boot (AVB) to work, it must have the hash values for each of the system/vendor/boot/dtbo partitions stored in vbmeta. Official LineageOS builds do not include the vendor.img in them (for fajita at least, other phones may), instead simply using the existing partition on the phone.
That means that there is no vendor.img information in vbmeta for the official builds, which means AVB will fail to verify it during boot and give the red corruption message and halt the boot process after you have re-locked the bootloader.
And since you cannot add to vbmeta without the LineageOS private key, which only the LineageOS signing server has, you cannot add it.
This means you must do a full build with new signing keys to make it work.
Theoretically you could pick apart a LineageOS release, rehash the system/vendor/boot/dtbo and then recreate vbmeta and the payload.bin file, but that brings a host of other issues. For example, since such a "build" would look like a full LinageOS release, if you ever accidentally let the updater run it would brick (soft) that slot and you'd have swap back to your other slot to boot again. In an extreme case, if you managed to corrupt the second slot somehow you'd have to wipe your entire and recover from the brick with one of the available tools to do so.
Ok, what messages do I see during the boot process then?
During a boot you will of course see the standard OnePlus power up screen, followed by the yellow "custom os" message an then the stardard LineageOS boot animation.
For more details on AVB boot messages, see https://source.android.com/security/verifiedboot/boot-flow
So what do those two patches to the release tools do?
AOSP/LineageOS's add_image_to_target_files.py detects if a vendor.img file already exists, and if so, simply includes it in the build process. The patch adds one extra step, so that AVB is being enabled for the build, it will replace the existing hashtree on vendor.img using the same salt and other options as will be used on system/boot/dtbo. This ensure that when vbmeta is generated, it has the right information from vendor.img.
The script is called from the make system as part of the "mka target-files-package otatools" and the appropriate parameters from the make system, like "BOARD_PREBUILT_VENDORIMAGE", are used to create arguments to the script to build the standard image files as well as include the prebuilt vendor.img.
This script is used both during the initial build as well as the signing process, but this change is only targeted at the build time implementation. During signing, the script uses whatever hashtrees are in place and does not regenerate them.
AOSP/LineageOS's sign_target_files_apks.py is responsible for signing the APKs that have been built as part of "mka target-files-package otatools", unfortunately it is not part of the "make" system, so settings like "BOARD_PREBUILT_VENDORIMAGE" do not impact the script. This means that sign_target_files_apks.py does not have any knowledge that it should be including a pre-built vendor.img, even though it is in the $OUT directory waiting to be used.
The patch adds a new parameter to the script (--prebuilts_path), so that during the signing process, any image files found in the provided path, will be included in the process. So make sure that only vendor.img is in the provided directory. This is a directory instead of a single file as future uses may be to include things like firmware, other partition types, etc. in to the signing process.
Thank you's
Obviously to all of the members of the LineageOS team!
LuK1337 for supporting fajita
optimumpro for the OnePlus 5/5t re-locking guide (https://forum.xda-developers.com/oneplus-5/how-to/guide-relock-bootloader-custom-rom-t3849299) which inspired this one
Quark.23 for helping with the process and testing on enchilada

Nice , Will this enable widewine L1?

jsidney96 said:
Nice , Will this enable widewine L1?
Click to expand...
Click to collapse
I don't believe there is a connection between the two.

WhitbyGreg said:
I don't believe there is a connection between the two.
Click to expand...
Click to collapse
If you unlock bootloader on phones supporting L1 they drop to L3. I know some Oneplus phones (op6 etc.) did not support L1 even on stock.

cowgaR said:
If you unlock bootloader on phones supporting L1 they drop to L3. I know some Oneplus phones (op6 etc.) did not support L1 even on stock.
Click to expand...
Click to collapse
Yeah.. It brings it to L1
Great writeup @WhitbyGreg
As Android security gets tighter and tighter, hoping one day all ROMs would support AVB by default..
---------- Post added at 06:16 PM ---------- Previous post was at 05:48 PM ----------
Curious question here,
WhitbyGreg said:
*** will build a standard USERDEBUG version of LineageOS, however this will still allow LineageOS Recovery to sideload non-signed files. If you have implemented step 5 above, then this protects your system/vendor/boot/dtbo partitions, but none of the others. Likewise USERDEBUG builds will allow for rolling back to a previous version. To increase security and disallow both of these scenarios you may want to build a USER version of LineageOS to install. However this brings in other issues, such as flashing newer firmware from OnePlus so make sure you understand the implications of both choices***
Click to expand...
Click to collapse
After a launch of any phone, how drastic are such firmware updates to bother about? In other words, Unless we're in stock ROM is it mandatory to update phone firmware?

arvindgr said:
Yeah.. It brings it to L1
Click to expand...
Click to collapse
Good to know.
arvindgr said:
Great writeup @WhitbyGreg
As Android security gets tighter and tighter, hoping one day all ROMs would support AVB by default..
Click to expand...
Click to collapse
That would be nice but more importantly, more phones need to support re-locking.
arvindgr said:
Curious question here,
After a launch of any phone, how drastic are such firmware updates to bother about? In other words, Unless we're in stock ROM is it mandatory to update phone firmware?
Click to expand...
Click to collapse
Reasonably important, after all, if you never get firmware updates you'll have outdated security patching for the firmware. Some official LOS builds require newer versions of the firmware as they are released and won't install without it.

This guide was very helpful to me when re-locking my Oneplus 7T and enabling hash/hashtree verification. A dude on telegram had actually sent me the link and I only briefly skimmed over. Ironically when looking for patches to fix my issues after attempting to include pre-built vendor/odm and failing I cross referenced and ended up back here.
Here's where I originally found them:
https://review.lineageos.org/c/LineageOS/android_build/+/278015
https://review.aosip.dev/c/AOSIP/platform_build/+/13385
I myself have made some more patches to ensure every possible pre-built image gets signed on my builds. After some experimentation I have found it possible to have Magisk with hash verification enabled
https://github.com/Geofferey/omni_android_build/commits/geofferey/android-10
There is also a fix to ensure appropriate args get passed when regenerating hashtree for pre-built vendor.

Geofferey said:
This guide was very helpful to me when re-locking my Oneplus 7T and enabling hash/hashtree verification.
Click to expand...
Click to collapse
So you can confirm you have relocked the bootloader on the 7T with AVB enabled?
Geofferey said:
A dude on telegram had actually sent me the link and I only briefly skimmed over. Ironically when looking for patches to fix my issues after attempting to include pre-built vendor/odm and failing I cross referenced and ended up back here.
Here's where I originally found them:
https://review.lineageos.org/c/LineageOS/android_build/+/278015
https://review.aosip.dev/c/AOSIP/platform_build/+/13385
Click to expand...
Click to collapse
Yes, those are my patches that I've submitted to LOS, I also have two other patches submitted to allow for other prebuilt images (aka firmware images) to be included in the build process.
Geofferey said:
I myself have made some more patches to ensure every possible pre-built image gets signed on my builds. After some experimentation I have found it possible to have Magisk with hash verification enabled
https://github.com/Geofferey/omni_android_build/commits/geofferey/android-10
There is also a fix to ensure appropriate args get passed when regenerating hashtree for pre-built vendor.
Click to expand...
Click to collapse
I'll take a look and see if I need to update any of my submissions, thanks.

I will have to update those commits with you as author. I messed that up and set person who picked yours as author. I am sorry. BTW thank you for those patches they were a lifesaver and inspired me.
Yes, I can confirm re-lock with AVB enabled on 7T works and also with hash verification. If I flash an image not signed by the build process with hash verification enabled I go red. Currently I am working on getting magisk directly integrated with build instead of using prebuilt patched imgs that cause builds to not pass CTS.

Geofferey said:
Currently I am working on getting magisk directly integrated with build instead of using prebuilt patched imgs that cause builds to not pass CTS.
Click to expand...
Click to collapse
Why do you want to put Magisk if you went to all the trouble of having avb with a locked bootloader? Isn't rooting defeating the purpose of avb?

quark23 said:
Why do you want to put Magisk if you went to all the trouble of having avb with a locked bootloader? Isn't rooting defeating the purpose of avb?
Click to expand...
Click to collapse
No, it does not defeat the purpose... Hashtree verification will still happen since root can be included in the build as opposed to flashing after the fact. In a way it's actually even more advised. The way I think, having root may lead to a means of being exploited but true AVB closes the door to any persistent rootkits that may try to modify partitions at block level. If ANYTHING modifies the verified partitions phone will refuse to boot and I will be protected. Doing exactly what AVB is supposed to do, verify the phone is in it's intended state. I also think of phone as a computer, you have root access on Linux, Windows and even Mac for Christ sake, why shouldn't it be the same for phones? The ONLY reason we don't by default is so manufacturers and carriers can stay in control. I've been rooting and modifying phones for years without AVB and yet to have a known breech of my data besides the Google apps constantly collecting on me. This just adds another level of security that I used to sacrifice in order to have root access.
Here is my PoC to include Magisk in builds so dm-verity can be kept enabled. Just two commits. If someone could make this better that would be really cool.
https://github.com/Geofferey/omni_android_build/commit/d60958780e6b26d7cb0cec5939b82df3df74a68f
https://github.com/Geofferey/android_vendor_magisk

I have rooted for testing and you don't gen any warning. The way avb works on my phone is it discards any modification after reboot. With no warning at boot time. If you get hacked, you can have persistent hacks with root. Make a modification from twrp with avb enabled and see for yourself.
You break the Android security model by rooting the phone. If you need certain things you can include them at build time, such as a custom hosts file.
Also, what can you do with root that does not alter the hashtree?
The power you mention is of no real use yet you expose yourself by having it. Sure, you can go by without any issues. The problem is if you happen to get hacked, the attacker has full control over your phone. You won't br able to get rid of it by rebooting.
Also I see no way for google to collect data in this setup, with or without root. Afwall has an equivalent in android 10 (that mobile data & wifi setting) and inter process comms are the real issue if you are worried about rogue apps. Afwall leaks dns requests like crazy anyway.
I say you are better off letting root go and include what you need at build time. I see that as better spent effort than trying to add root.

quark23 said:
I have rooted for testing and you don't gen any warning. The way avb works on my phone is it discards any modification after reboot. With no warning at boot time. If you get hacked, you can have persistent hacks with root. Make a modification from twrp with avb enabled and see for yourself.
Click to expand...
Click to collapse
So you built your ROM from source with root included, had TWRP go through signing and was able to modify system and other partitions without receiving a device corrupt message? I highly doubt AVB is even implemented appropriately if you were able to do so. If it is implemented it sounds like the old version, tho I remember if I violated FS too much it wouldn't be able to fix and failed to boot. Having a locked bootloader because AVB is enabled does not mean dm-verity is enabled. Also, it should be nearly impossible to just write things like files to /system or w.e. if you are on a device that ships with 10.
quark23 said:
You break the Android security model by rooting the phone. If you need certain things you can include them at build time, such as a custom hosts file.
Click to expand...
Click to collapse
I know it does, but I am not doing such small things as modifying a host file. The kinds of things I include in my personal ROMs require such a high level of access to the point where I can not write SE polices that will allow me to pass CTS and spit out user builds without serious modifications to the build env.
quark23 said:
Also, what can you do with root that does not alter the hashtree?
The power you mention is of no real use yet you expose yourself by having it. Sure, you can go by without any issues. The problem is if you happen to get hacked, the attacker has full control over your phone. You won't b able to get rid of it by rebooting.
Click to expand...
Click to collapse
The act of flashing Magisk is what breaks AVB, if you include it in the ROM at build time like I am doing then it doesn't need to be flashed. It makes modifications to the system by binding data from the wipeable data partition to /system/. If something utilizes that to install a backdoor or tunnel it goes bye-bye when I wipe. If something utilizes it to flash anything or modify system device no boot.
quark23 said:
Also I see no way for google to collect data in this setup, with or without root. Afwall has an equivalent in android 10 (that mobile data & wifi setting) and inter process comms are the real issue if you are worried about rogue apps. Afwall leaks dns requests like crazy anyway.
Click to expand...
Click to collapse
You're kidding right? Android solely exist as a mean for Google to collect data. That was the whole idea behind Android. Buy & develop an OS that any manufacturer can put on their device, let them certify for Google Play Services and collect the data that powers their ad platform. They certainly didn't opensource their baby for free. If you allow ports 80 and 443 out with inbound related allowed, that's all they need.
quark23 said:
I say you are better off letting root go and include what you need at build time. I see that as better spent effort than trying to add root.
Click to expand...
Click to collapse
I'd just rather the manufactures and Google would implement a root solution that plays nice with Androids security instead of making us resort to violating it. It's funny to me that we find it acceptable for these fools to maintain control of something you purchased with your hard earned dollars because they think we are too stupid to have it. Like I stated root and admin privileges are fully available to us on nearly any PC but phones for some reason are an exception.
_________________________________________________
I could rant and debate about this forever... Fact of matter is, you don't have to disable every Android security feature to have root.

I didn't build with magisk, I just flashed after building.
But you can try and modify anything on /system or /vendor from twrp, without magisk, without locking the bootloader, and see what happens. Avb discards the modification, but doesn't warn you. Curious of your findings regarding this. If you then flash magisk, you ofc break the hashtree and avb and the mods remain persistent.
I understand that you are building with magisk included in the hashtree. What I am wondering is what exactly are you wanting root for? What are you doing with root that does not break the hashtree?
Regarding the data collection, you lost me. What exactly is being collected on a LOS userbuild without google services? Got any dns logs or mitm wireshark packets to show? What service exactly is collecting what kind of data? Google's dns servers can be replaced before building, Greg has some scripts for that. Captive portal can also be replaced or turned off. Apart from that, and any apps you add yourself, what kind of data is being collected as I want to check it out myself. I've monitored my phone and it's pretty silent. Whatever goes out is from additional apps I use. But I don't see anything from LOS. Really curious about this.
Regarding your last point I think it's something akin to risking shooting yourself in the foot by having root by default. I understand (somewhat) the security model and I find it smart to not have it by default. Also Android uses selinux more than your standard linux distro does. There are some differences in the security models between android and pc linux distro.
I'm really hapoy that AOSP exists. Also pretty happy with the LOS project. My problem is with the outdated blobs. Maybe I'll get a Pixel at some point and give GrapheneOS a go. Seems like a really nice project.
Managed to get hardened malloc + Vanadium on LOS atm and I'm liking the browser. Overall I think AOSP is a great project. Not a fan of google's privacy policy but they do make great stuff.

quark23 said:
I understand that you are building with Magisk included in the hashtree. What I am wondering is what exactly are you wanting root for? What are you doing with root that does not break the hashtree?
Click to expand...
Click to collapse
Ah, there lies the real question. I am including in my personal builds a Debian Linux chroot that gets extracted to /data/ so I can run Linux services, etc. I have customized the chroot with Openvpn so that it connects to my server and essentially allows me back into device wherever it may lay. Basically I am adding in the stuff of nightmares that all this security is supposed to prevent. That is why I want dm-verity, because I know I am leaving my self partially open by doing so. I have a decent understanding of dm-verity and have confirmed that it does and will protect me against the scenarios I imagine. BTW it operates completely differently in locked state vs. unlocked.
quark23 said:
Regarding the data collection, you lost me. What exactly is being collected on a LOS userbuild without google services?
Click to expand...
Click to collapse
Well, if you're the type of person who doesn't require Google Play Services, nothing of course. I was merely stating that Google had open sourced Android in hopes that manufacturers would adopt the OS and qualify their devices for Google PS so that it could be used as a data collection platform. You won't easily see all the information Google collects in a Wireshark log because it is encrypted of course. LOS better be silent as hell without it or I'd contact that dev with a strongly worded message lmfao.
quark23 said:
Regarding your last point I think it's something akin to risking shooting yourself in the foot by having root by default. I understand (somewhat) the security model and I find it smart to not have it by default. Also Android uses selinux more than your standard linux distro does. There are some differences in the security models between android and pc linux distro.
Click to expand...
Click to collapse
Oh I DO NOT think it should just be enabled by default. If I had my way it would be enabled in dev ops requiring authentication and protected via a different password than the one you use to unlock the device once setup. You'd also require those "root" privileges to OEM unlock once enabled. While those features were enabled you'd be warned on boot as well but without locking you out of apps etc because that kind of sensitive data should be handled by TEE and TZ. In a real Linux operating system that hasn't been fundamentally raped to offer a false sense of security in the name of protecting carriers and manufactures you can modify SE linux policies etc, not while live but without compiling from source. A lot of us forget most these security features exist more to protect their interest and attempt to hide what's going on behind the scenes. I've actually heard of some pretty shady stories where manufacturers in China place ad-tappers that run in background on devices running GooglePS to be sold in US, so it definitely doesn't protect you if the person building your phone is shade.
quark23 said:
I'm really hapy that AOSP exists. Also pretty happy with the LOS project. My problem is with the outdated blobs. Maybe I'll get a Pixel at some point and give GrapheneOS a go. Seems like a really nice project.
Managed to get hardened malloc + Vanadium on LOS atm and I'm liking the browser. Overall I think AOSP is a great project. Not a fan of google's privacy policy but they do make great stuff.
Click to expand...
Click to collapse
Me too mate. . AOSP has taught me a lot about development and coding in general. Sadly outdated blobs are a usually a by-product of using pre-builts from manufacturers that don't update as often. Pixel would be way to go if that's a concern. I honestly just think a lot of the security is abused to suit their needs. I am just trying to turn it around to work for me where it can.

If you repo sync you should run the vendor files script as there's a couple of new files added. The Muppets github has been updated with them as well. If you don't your build will fail at first power on.

A quick question, forgive me if this is obvious: am I correct in assuming that one the above has been completed and the device is using a locally-built copy of Lineage OS, that I cannot take advantage of OTA updates? I just want to know what I'm getting in to before wiping my phone multiple times.
Thanks in advance, this thread is massively helpful.

nictabor said:
A quick question, forgive me if this is obvious: am I correct in assuming that one the above has been completed and the device is using a locally-built copy of Lineage OS, that I cannot take advantage of OTA updates? I just want to know what I'm getting in to before wiping my phone multiple times.
Thanks in advance, this thread is massively helpful.
Click to expand...
Click to collapse
Correct, though if you setup your own update server you can still use the inbuilt updater app if you want.

I just happened across this thread searching for a proper way to generate the custom avb key. I thought i had found it at one time on aosp documentation but i lost/forgot where it was.
Anyways, I have a quick q about this. Would I be correct in assuming that if i wanted gapps to be available in my build, I would need to include it during build time and not be able to flash it as per the typical methods?
I am pretty sure I won't be able to but wanted to ask here for you guys' experiences.
Also, @WhitbyGreg you should be able to i believe. just setup the url properly and host it somewhere with direct download links. (This also requires setup of json for the updater to monitor for updates)

klabit87 said:
Would I be correct in assuming that if i wanted gapps to be available in my build, I would need to include it during build time and not be able to flash it as per the typical methods?
Click to expand...
Click to collapse
Correct (at least as far as I know), once the bootloader is relocked any modification of the system partition (like adding the play services) would trigger an AVB failure.

How To Guide Battery Charge Limit on custom ROM

If you are on custom ROM like LineageOS and want to limit battery charge to e.g. 80%, I can show you how it works on the Asus Zenfone 8. [Tested with LineageOS18.1]
What you need is:
Device with root access -> Use Magisk, some hints can be found here.
Then install Battery Charge Limit (BCL). There is also Advanced Charging Controller but I found it to be less reliable, with random crashes and restarts. Just stick to BCL, it is minimalist and stable.
Next, you need to set a custom control file. Go to BCL settings, check to use a custom / configurable control data, then configure the control data with this:
Path: /sys/class/asuslib/charger_limit_en
Enable value: 0
Disable value: 1
(Note that the 0 and 1 is reversed compared to default, that's on purpose!)
If it doesn't work, there might already be a cap in place, you might need to play around with /sys/class/asuslib/charger_limit_cap and set to so something lower. (e.g. with adb shell)
Hope that helps, I didn't find this anywhere on the internet, but searched through the available control files on my phone until I found this one working.

Hi Mario,
I own a Zenfone 8 (ASUS_I006D) and installed LineageOS 19.1 with the build from 27.05.2022.
It is rooted with Magisk and I tried to setup the battery charging limit using the app "Battery Charge Limit".
Unfortunately, it is not working with your guide.
I think, the problem is that on my phone the file you mentioned is missing:
/sys/class/asuslib/charger_limit_en
I checked the directory with Total Commander and there is only one file:
set_virtualthermal
Do you have any idea, what I'm missing here?
Is the carger_limit_en file supposed to be delivered with LOS?
Thanks

This was an unwanted double post.

Nbg1983 said:
Do you have any idea, what I'm missing here?
Is the carger_limit_en file supposed to be delivered with LOS?
Click to expand...
Click to collapse
I tested this while still using LOS18.1. I'm still skeptical about LOS19, still a lot of people report instabilities or crashes.
Might have something to do with the newer LOS version, but also with the firmware. LOS19 has newer firmware for the chipset. This means that config files could have been reworked, moved to a different place. You could look around a bit in sys/class if this file was moved to somewhere.
Could also be a bug in LOS19 that it doesn't parse all the configs correctly.

It looks like that the LOS 19.1 kernel does not provide the necessary files.
I installed the Kernel vom Kirisakura and then the following file exists
/sys/class/asuslib/charger_limit_en
Also, it looks like BCL is working now with your suggested settings.
Unfortunately, the kernel from Kirisakura is not fully compatible with LOS 19.1.
At least, fingerprint reader is not working, anymore. I hope, he'll release a LOS 19.1 compatible custom kernel.

That's indeed interesting, thanks for sharing the info.
The custom kernel replaces boot.img, vendor_boot.img and dtbo.img which they extracted from the stock ROM + optimizations. I doubt that the config files comes from the optimizations, so I guess there is a bug in LOS boot.img, vendor_boot.img or dtbo.img, and it is repaired by patching the stock images here.
Or question: Do you maybe use LineageOS with MicroG? Just asking because in this case, it would explain the issue since MicroG has a bug in the build pipeline so that some firmware images are missing.

I didn't use MicroG.
Its also interesting, that LOS 18.1 seems to have the necessary files for BCL.
I guess, that the files should be included in vendor_boot.img.
Unfortunately, replacing the custom vendor_boot.img with the original one leads to a boot loop.
So I either have to wait and hope for a LOS 19.1 update with included charger files, or I have to downgrade to 18.1?

Perhaps there was an update on this? Where should one submit a ticket for LineageOS? As an issue?

Android 12 GSI Post Install Fixes

I have been messing around with GSI roms on this device for a little over a month, and I've created some Magisk modules and an Xposed module to begin to fix the issues with the Cli display.
Disclaimers (READ THESE!!):
There are still a number of other issues with GSIs on this device, so I wouldn't recommend doing this if you use your razr as your main phone.
If you brick your device, it is your own responsibility. I am not responsible for any damage that my modules or advice might cause to your device. Do not blame me for bricking your device.
This is not written to be easy for beginners. If this is your first time modifying a device's firmware, I would advise against starting with this phone. But I would highly recommend you to start on a different device that has less restrictions and is much cheaper.
If I do not mention how to do something, you should look up a guide first before asking me. The guides that other people write are likely going to be much better and easier to understand than one I can write.
Please note that these modifications may not work on your device if the hardware is slightly different, even if it has the same model number as mine. These modifications are mainly a proof of concept, but I am open to modifying them to work on more devices.
If you are curious about how any of these modifications work, see the readme on the modules' github repositories.
By following the steps in this post, you accept that you may end up with either an expensive paperweight, or a mostly functional device with a GSI rom.
These modifications have been tested on my XT2071-3
First thing to do is to make sure you have a way of recovering your phone if it soft bricks. I downloaded the stock rom from lolinet. Make sure you have a rom that is the same version as your current rom. Motorola leaves anti-rollback enabled even if you have an unlocked bootloader.
If mess up, you can just restore it using fastboot (look up a guide)
If you really messed up, you can always try to use the "Rescue and Smart Assistant Tool", but that may be a last resort due to privacy concerns.
If you really really messed up, you may have to use a blank flash. I haven't ever had to use a blank flash, so I can't vouch for whether or not it will work. (don't do it if you don't have to)
The build number of the OS I used when installing the GSI is: RPSS31.Q1-40-34-15-10-15
Spoiler: Installing
It may also be worthwhile to flash copy-partitions-20210323_1922.zip from a custom recovery to prevent accidentally hard bricking your device. (this is recommended by the Lineage OS wiki for most devices with an a/b partition layout, so I figured I should probably use it just to be safe).
You can use thenameisnigel's unofficial TWRP image, or the unofficial lineage recovery that I attached to this post (I would not recommend flashing either one. Use "fastboot boot recovery.img" instead.) I attached the lineage recovery because it's easier to use without touch support, but either should work just fine.
You may also choose to root your phone with magisk before installing the GSI. It will be necessary for the post-install fixes, and may be harder to install after the fact.
I will not go into too much detail of how to install GSI roms, but here is a rough recreation of the fastboot commands I used:
Code:
fastboot reboot fastboot
fastboot --disable-verification flash vbmeta vbmeta.img
fastboot erase system
fastboot delete-logical-partition product_a
fastboot flash system gsi.img
fastboot -w
fastboot reboot
You should look up a tutorial if you need help. I'm not an expert on any of this.
I've tested:
This release of Phh Treble (the one with gapps doesn't work)
This release of Andy Yan's Lineage OS 19
This release of ponces' Pixel Experience GSI
All of them using the vndklite version, and I have not been able to get Android 11 to work.
Spoiler: Fixing the cli display
Once you boot into the GSI, you will notice that the Cli display will show a keyguard presentation that will freeze and stay on the screen after you unlock the device. You may also notice that touching the Cli display will interact with the main display, and not the Cli display like it should.
To fix this, you can install this magisk module: Razr5G Synaptics Touchscreen Device Associations
Before installing, you may want to mute your ringer, since it will break audio (more on that later)
This magisk module adds a configuration file that will map the touch screens to their respective displays.
Now the touch screen maps correctly, but there's still nothing to interact with.
To fix this, you can install another magisk module: Razr5G Foldable Device Fixes
These are two separate magisk modules because I will be releasing more modules that will utilize the cli display in different ways.
This magisk module will configure Android to treat the phone like a foldable device similar to the Samsung Z Fold. This is not the stock behavior of the device, which is why I will be making different modules that activate the display in a way closer to stock.
Now the cli display will actually show the UI if you turn off the display, close the device, and then wake the device. The UI will even transition from the cli display to the main display when you open the device. But if you close the device while the screen is on, the system will freeze. This has to do with Android's display manager referencing a display that the lid sensor just requested to turn off.
To avoid this conflict, I have an Xposed module this time: Cli Lid Functions
I recommend using LSPosed. You will need to enable this module for "System Framework"
This Xposed module will disable the lid sensor's ability to turn off the display. This is not ideal, but it's better than having to reboot your phone.
Spoiler: Fixing audio
For whatever reason, installing magisk modules that modify /vendor/etc on a GSI on phone will replace the audio policies with empty ones. This is not ideal, as it forces audio out of the speakers at full volume. The original audio policies still exist in the magisk mirror under vendor/etc (but not system/vendor/etc). You can overwrite the blank ones and change a setting to restore functioning audio.
1. Overwrite the blank audio policy:
You can do this with a root file explorer, or through the shell
Method A - Root File Explorer:
go to the magisk tmpfs (type "magisk --path" in a shell running as superuser. Example: `/dev/ABcD12`)
then go to .magisk/mirror/vendor/etc (you may need to show hidden files)
copy a2dp_audio_policy_configuration.xml and audio_policy_configuration.xml
paste them in /vendor/etc on the system root (make sure to overwrite the empty files)
Method B - Shell:
Run these commands in `adb shell` or your favorite terminal emulator
Code:
su
cp $(magisk --path)/.magisk/mirror/vendor/etc/a2dp_audio_policy_configuration.xml /vendor/etc
cp $(magisk --path)/.magisk/mirror/vendor/etc/audio_policy_configuration.xml /vendor/etc
After overwriting the files, do not reboot (otherwise they will get overwitten again).
2. Enable "Use alternative audio policy"
Go to `Settings > Phh Treble Settings > Qualcomm features` and enable "Use alternative audio policy"
3. Reboot
Now you can reboot, and you should have working audio again.
Spoiler: Working/Broken
What's working:
UI on the second display (opening apps, checking notifications, etc.)
Only one display on at a time
Display cutout
Camera (plus, only the outer camera works when the display is folded)
Volume buttons flipping when the lid is closed
Fingerprint
Wifi, Bluetooth, and Bluetooth audio (after disabling the hardware offload)
SMS (kind of... and only with an ims.apk)
Data
Battery life is better than stock
A lot more that I'm missing...
What's broken:
System UI is not optimized for the second display
Brightness on the secondary display
More that I'm missing...
I am still new to GSIs, so I haven't tested a whole lot, or attempted to fix much other than this.
Downloads:
Razr5G Synaptics Touchscreen Device Associations
Razr5G Foldable Device Fixes
Cli Lid Functions
Unofficial Lineage Recovery
While I could build my own GSI rom to deal with all of these issues, I chose not to since it would take more time. There is also another advantage of these modifications, which is that they can be applied to a wide variety of GSIs without having to modify each one manually.
Also, Motorola won't let a $1000+ phone boot with a modified vendor partition, for whatever reason.
This was my first time ever making a magisk module, my first time ever making an Xposed module, my first time ever working with the Android system on this low of a level, and my first time installing a GSI rom.
I may update this post with more progress in the future.

reserved