I'm in a Lenovo with LineageOS, and everytime I flash a nightly (update), the root is gone, I have to flash Magisk again.
Is there any way to keep Magisk installed after an update?
Thanks
Every time you update, the Magisk modified boot image is overwritten by the ROM's stock boot image. Since the Magisk modifications are done to the boot image, this means Magisk is removed.
Solution:
Make sure to use a ROM with working addon.d or simply flash Magisk manually after every update.
I updated my magisk manager to the latest version 22000 and i lost root after I did direct install, I tried flashing the patched boot image with fastboot and I also did a clean flash of my phone and replaced my stock image with the patched boot image but magisk manager is still asking me to install magisk, I also tried with the latest canary build but same thing, I'm frustrated already.
My phone is Itel A11 running Android 6.0
For some odd reason Magisk breaks auto-rotation and sets selinux to permissive on boot after updating to 25.2 (from 25.1).
This is not the first time Magisk messes up Selinux rules. I usuall solved this by making a fresh OS install already with patched boot and by installing the managing app afterwards.
However, this time autorotation stopped working for some reason. And when i try to uninstall Magisk using its app -- OS no longer boots, as if it fails to restore initial boot image.
This selinux problem began since v25.
I use latest official build of Lineage OS 18.1. I have TWRP installed, which i use to install LineageOS.
What am i doing wrong? Has anyone experienced such issues?
I posted the same problem here (did not notice/checked SELinux back then and sound is probably also not working), figured out that all sensors do not work, checked with "Sensor Test" app. I was already considering a separate thread, thus I'll continue here, because this issue definitely deserves a separate thread. Documentation is so scattered and sometimes so confusionly described, that it was hard to make sense of it all...
(Disclaimer: Although I have necessary experience with installing custom ROMs etc., everything stated below is at my own understanding ).
My device: Samsung Galaxy Tab S5e LTE
My goal was: TWRP, LineageOS and Magisk. How hard can it be?
Problems are that (most of the) Samsung devices do not have a "ramdisk" partition where Magisk is normally installed, also the increasingly complexity of encryption en integrity checks makes this more annoying.
First, let me retrace my steps, as far as I can.
When reading the TWRP page, we get a clue where to start: "You are therefore strongly advised to first root your device with Magisk and then pre-root a TWRP image before flashing it to recovery", this is because "Both TWRP and Magisk-rooted Android boot using the recovery kernel, with the device's hardware keys used to choose between TWRP and Android at boot time".
(Magisk "hijacks" part of the recovery partition, since the absence of a ramdisk partition.)
Spoiler: later on you learn this is not completely the case any more, but I would still recommend to hold on to this method, because the TWRP page also states that: "The usual path of installing TWRP prior to rooting is problematic on this device, because the Magisk installer does not support installation to recovery from TWRP. Furthermore, prior rooting of the device with Magisk carries the significant advantage of disabling various device protection mechanisms that you will otherwise need to take care of manually.", and it continues with more scary warnings...
1. Thus followed the Samsung section of the Magisk documentation to have the bootloader unlocked and Magisk installed, but stock firmware is still installed, no problem whatsoever.
Then decipher the already mentioned instruction: "...pre-root a TWRP image before flashing it to recovery". This apparently means that Magisk has to patch the TWRP image, just like as was done with the Samsung firmware.
2. Downloaded the *.tar file of TWRP, extracted the image, patched with Magisk and repacked to the *.tar file with 7-Zip in order to be able to flash it with Odin (see step 4).
*3. I do not recall when I installed the "VBMeta file", although this is instructed in the Lineage OS installation instructions, when following the TWRP instructions it says "...you can now jump to its own section", thus skipping it?? (I did it somewhere in the process...)
Unknown: whether it is still required to patch and flash VBmeta (to disable some verification process)...
4. Flash TWRP recovery, see YouTube video below. This video mentions the use of "multidisabler-samsung", which disables "FBE, proca, Vaultkeeper and auto-reflash of stock recovery on Samsung Pie devices". Current latest version was 3.1, downloaded from this XDA post, I think.
Just as in the YouTube video, I also was stuck at the Samsung logo. After booting into the stock firmware you can check if Magisk still works.
Not sure: "multidisabler-samsung" needed?
5. Install LineageOS (and GApps). The most straightforward step, just install LineageOS, read the instructions. Then install GApps (e.g., BiTGApps).
6. After booting (power and volume + button) and setting up LineageOS, a Magisk icon should be visible in the app drawer, click it and the Magisk app is installed, when opened, Magisk is setting up a few more things and reboots the tablet.
*******************************************************************************************
This is the point were you finally think you made it, but no, here the issues arise.
Issues thus being SELinux permissive status (Xandros Darkstorm), no sound and non-working sensors, thus "auto rotating" feature is not working.
At this point I started to regret my purchase...
In the search of a solution to the problem I stumbled upon the following familiar and solved Magisk issue #4911 (LineageOS 18.1 no sound and no sensors after booting with Magisk), which refers to issue #4394 (Magisk > 21.4 is difficult to install on LineageOS (18.1) with TWRP (Direct Install not enabled unless you use old zip)).
In short: this post mentioned patching the boot image instead of the recovery image.
*******************************************************************************************
I. I extracted "boot.img" from the LineageOS zip file, patched it via Magisk (ramdisk is added to the boot image) and replaced the "boot.img" in the zip file with 7-Zip.
II. Booted into TWRP, flashed an original TWRP image, so recovery is replaced. (Rebooted I guess.)
III. Then wiped previously LineageOS installation and, flashed the LineageOS zip file with patched boot image and GApps and rebooted to system.
IV. After setting up, install Magisk, let is do its thing.
V. I installed "Root Checker Basic" in order to check I gained root checker. It was a PASS! And checked with "Sensor Test" if all sensors worked, they did! And sound also worked .
Yay!
Clearly, all of this can be optimized. Some questions remain, what steps are really necessary and I am also still wondering how to apply a LineageOS update... Anyhow at least it is working.
What resolved
Xandros Darkstorm said:
For some odd reason Magisk breaks auto-rotation and sets selinux to permissive on boot after updating to 25.2 (from 25.1).
This is not the first time Magisk messes up Selinux rules. I usuall solved this by making a fresh OS install already with patched boot and by installing the managing app afterwards.
However, this time autorotation stopped working for some reason. And when i try to uninstall Magisk using its app -- OS no longer boots, as if it fails to restore initial boot image.
This selinux problem began since v25.
I use latest official build of Lineage OS 18.1. I have TWRP installed, which i use to install LineageOS.
What am i doing wrong? Has anyone experienced such issues?
Click to expand...
Click to collapse
What fixed this for me is after re-flashing stock in Odin to get everything working again, just rename the magisk apk to install.zip and flash that in twrp, and open the magisk app once booted, no other steps needed for install, no image patching or anything.
Might be worth seeing if this is the same issue or if there's a more fundamental problem with 25.2
Hi,
I stumbled upon this thread while searching for a way to install Magisk on a S5e.
Following the guide here: https://wiki.lineageos.org/devices/gts4lvwifi/install I already unlocked the bootloader, flashed vbmeta.tar with Odin, flashed lineage-19.1-20221114-recovery-gts4lvwifi.img with Odin and flashed lineage-19.1-20221114-nightly-gts4lvwifi-signed.zip with TWRP-recovery.
Lineage is working fine, but I would also like to use Magisk.
I understood, that the order I follwed is not the recommended order for having both Magisk and Lineage. At least, that is, what you described at the beginning of your post.
But as with your last part you mentioned, that there where issues with sensors, ...
And the solution was to
I. Replace recovery with a patched boot.img of Lineage zip and wipe a prev. Lineage installation
I guess, I might be able to stiull do that though I already have Lineage on the S5e (currently with Lineage/TWRP recovery), right?
I can patch the boot.img from within lineage-19.1-20221114-nightly-gts4lvwifi-signed.zip with Magisk app, right?
Or would I have to patch lineage-19.1-20221114-recovery-gts4lvwifi.img
Is there anything to consider, when zipping the image with the patched boot.img again?
Which TWRP image did you choose to be flashed at step II.?
Barium said:
I. I extracted "boot.img" from the LineageOS zip file, patched it via Magisk (ramdisk is added to the boot image) and replaced the "boot.img" in the zip file with 7-Zip.
II. Booted into TWRP, flashed an original TWRP image, so recovery is replaced. (Rebooted I guess.)
III. Then wiped previously LineageOS installation and, flashed the LineageOS zip file with patched boot image and GApps and rebooted to system.
IV. After setting up, install Magisk, let is do its thing.
V. I installed "Root Checker Basic" in order to check I gained root checker. It was a PASS! And checked with "Sensor Test" if all sensors worked, they did! And sound also worked .
Yay!
Clearly, all of this can be optimized. Some questions remain, what steps are really necessary and I am also still wondering how to apply a LineageOS update... Anyhow at least it is working.
Click to expand...
Click to collapse
Thanks
If this is also a solution, can you please let me know, if there is anyhting to consider, when flashing the stock (got it from SAMMOBILE)? Can the lineage-19.1-20221114-recovery-gts4lvwifi.img still be left on the tab?
After re-flashing the stock, I guess you flashed lineage again, right?
Or did you stay with the stock and just flashed magisk (after renaming the apk to zip)?
Thanks
TheTofu said:
What fixed this for me is after re-flashing stock in Odin to get everything working again, just rename the magisk apk to install.zip and flash that in twrp, and open the magisk app once booted, no other steps needed for install, no image patching or anything.
Click to expand...
Click to collapse
I dared patching the TWRP recover for S5e and flashed it via Odin (AP).
S5e boots up in Lineage, Magisk is working fine.
But when I power off the tablet or restart, Lineage Recovery shows up telling me, that my data would be corrupt.
My only options are to try again or to do a factory reset.
Only way out of this is to re-flash the above mentioned recovery image again.
So how do I get the Magisk patched TWRP recovery permanent?
I wiped system? and re-flashed Lineage via TWRP, got "original" TWRP Recovery for S5e Magisk permanent.
I have to admid, I tried several things and got lucky I did not break something.
I had nearly, what I wanted - TWRP, Lineage and Magisk, but there were issues with the sensors (no auto rotate).
Again I helped myself:
1) flashed the original, unpatched TWRP Recovery for S5e
2) flashed unpatched Lineage for S5e
3) flashed MindTheGapps
4) flashed Magisk-v25.2.apk
No bootloop, original TWRP permanent, Magisks working fine, no issues with sensors.
Tried steps 1, 2 and 4 with the Lineage Recovery and it worked too.
It's a bit of an older phone but I cannot get root properly working on my Samsung GT-I9300 using Magisk. I need Magisk to hopefully get some banking apps working again on my LineageOS 17.1 custom ROM. I downloaded Magisk v25.2 (Latest) from github, patched the boot.img from the installed ROM: lineage-17.1-20200717-UNOFFICIAL-i9300.zip, all with no errors.
Instead of using fastboot I renamed the patched magisk_patched-25200_eb1Em.img to boot.img and created a tar file from it so I can flash it with Odin3 v3.14.1.exe (AP checkbox) as I did for the twrp recovery image. After this some signs of root access are visible. Root Checker Pro even shows my device as rooted. Still it says that the su binaries are missing and Magisk keeps showing as not installed. I even tried CF-Auto-Root-m0-m0xx-gti9300.tar through odin and/or flash UPDATE-SuperSU-v2.46.zip through the installed twrp recovery but the results stay the same.
Wat can I do more to get it working?