Database Develop

[FIX] CM led notifications [MERGED]

These changes have been merged into the latest nightly. Expect to see it in the new dinc build on 11/30/2010.
-------------
Hey fellow dinc users. We've been complaining for too long and now we can complain no more (or some more)
I've made a patch that fixes the led notifications so that green and amber blinks now. You can flash this over any version of cm 6.
The led blinks like stock, but the blink rate is not configurable.
-Flash in succession works for different notification colors.
Flash like any zip. Be sure to back up.
Bug: There seems to be an issue with the led light colors not being properly set by CM settings.. Here is a possible solution:
tdiman said:
Next: Bingo:
Set a custom color (somewhere in the pink-red range). Got a red LED immediately.
Now flash color, blink rate work as advertised.
Hopefully that helps narrow down the issue me and CUViper are seeing.
Click to expand...
Click to collapse
Devs: I've started a Gerritt issue for the fix. I'm not sure if I broke things for other phones.. so hopefully there'll be more contribution from other devs to get this into cm6.1..... update- they didn't like my generic liblights fix, so I've made a device specific one for our inc. It works right now, but I will clean up the file when I get a chance.
http://review.cyanogenmod.com/527
NEW: http://review.cyanogenmod.com/#change,681

Do you think this will work with RUBY?

shoman24v said:
Do you think this will work with RUBY?
Click to expand...
Click to collapse
I think it should. But please let us know if it doesn't!

Let me do a backup and I'll try it out.

nice.. much appreciated! what's left in terms of issues? just the cam force close or are there others? once the cam's fixed.. i'd like to use cm as my daily

The camera really only fcs for 720p recording with autofocus. I might look into it over Thanksgiving.
The led issue was just really bugging me and I was getting impatient lol..

No, go. When I get a text it doesn't blink, or even stay on like it did.

shoman24v said:
No, go. When I get a text it doesn't blink, or even stay on like it did.
Click to expand...
Click to collapse
Sorry man, there must be other changes in Ruby that I don't know about. Have you tried changing the colors of your notifications? The driver only responds if it's green or red.

seanzer said:
Sorry man, there must be other changes in Ruby that I don't know about. Have you tried changing the colors of your notifications? The driver only responds if it's green or red.
Click to expand...
Click to collapse
I don't believe Ruby allows you to change the color of your LED. We only have two anyway

shoman24v said:
I don't believe Ruby allows you to change the color of your LED. We only have two anyway
Click to expand...
Click to collapse
You should try an led tester or handcent. An app that lets you change test the color of the led. I could recode the patch to default to green for all other colors, I believe that would make it work for MIUI. Pm me if you're willing to try it..

I think many users may want it blink for Ruby. Though, it does work just fine as it is being only solid. Reason I sorta perfer that is I'm not being tricked into thinking I have a notification. When it blinks I have to always take a second look at it
I tried LED Tester, only colors we have are green and red.

For the apps that have built in LED configuration, like handcent and kik. THey wouldn't even have the orange LED blinking right, which leads me to have it set to no blind in CMsettings and the app settings.
Will this fix work with those aswell?

mikeymop said:
For the apps that have built in LED configuration, like handcent and kik. THey wouldn't even have the orange LED blinking right, which leads me to have it set to no blind in CMsettings and the app settings.
Will this fix work with those aswell?
Click to expand...
Click to collapse
I'm not sure what you mean, but I can use handcent's settings to set the led color. Only green and red work though. For the apps that don't have a way to set the color, I can control it using cyanogen's settings under the led notifications menu.

I added some review comments in Gerrit for you. When I tried it myself, I wasn't able to get it working until I uncommented your BLINK_FILE writes.

This b0rks the green LED when charging above 90% Now both orange and green are lit.
Also rather then plain green flashing I get nothing :/

CUViper said:
I added some review comments in Gerrit for you. When I tried it myself, I wasn't able to get it working until I uncommented your BLINK_FILE writes.
Click to expand...
Click to collapse
When remove the comments, don't the blinks go sporadically?
I intended for the leds to be able to have both red and green, but it looks rediculous so I'm going to fix it.

seanzer said:
When remove the comments, don't the blinks go sporadically?
Click to expand...
Click to collapse
I'm not sure what you mean by sporadic. It's a quick blink about every two seconds, longer off than on. But with your comments in place, I don't get anything blinking lights at all. The solid charge light works, but blinking notification doesn't.

CUViper said:
I'm not sure what you mean by sporadic. It's a quick blink about every two seconds, longer off than on. But with your comments in place, I don't get anything blinking lights at all. The solid charge light works, but blinking notification doesn't.
Click to expand...
Click to collapse
Interesting, try setting different blink rates, it definitely works!
I'm posting a new version fixing the issue with both lights showing up.

Ok, this is weird. I built your second patch from Gerrit, pushed it out, rebooted, and then suddenly I was getting the opposite of before, now a long blink on with a short off. So I went into Advanced and chose "Reset all colors and apps", and now I can't get anything to blink at all. I'm about to give up and let you and others figure it out...
Can you tell what all the settings are for you? I have only the default "Miscellaneous" category, and I've tried "Always pulse" on and off. The other Advanced settings don't look like they should matter, but I have the rest all off. Then I go into the applications list and choose Gmail, set it to green or red, choose any blink rate, and then "Flash test" does nothing.

You should get a long blink with short off..
I just repeated what you did..
Reset all notifications,
Goto led settings for gmail,
Test flash does nothing,
pick green..even though it was already selected...
Test flash and it worked..
Not exactly sure why it doesn't work for you. lets see what the others say.

[Q] Notification LED colours

What sort of notification LED does the Galaxy Note have? I've used three different Android phones since the original G1 and it feels like they're turning into pretty useless two or three colour things now. The G1 had a multi-colour LED, something like six or seven colour choices, as did my Motorola Milestone but my current phone, the HTC Desire HD, has a pathetic tri-colour LED. I was seriously considering the new One X but that has a dual-colour LED!
Anyway.. getting sidetracked. Can a Note user please tell me what, if any, notification LED the phone has and what colours it can display if it does have one? I know this won't be a big deal to a lot of people but I relied pretty heavily on the multiple colours in the past.

it has none.

None.
But, you can install a custom kernel that supports notification light and software to enable indicator light, such as when you have a new email. Then your soft buttons will be lit up.
I think there's also variations of quality on those soft touch lights. I had two Note, one had clear soft light on the soft button, the other had dirty looking light on the soft buttons. Both works fine, but just something to know.

hp79 said:
None.
But, you can install a custom kernel that supports notification light and software to enable indicator light, such as when you have a new email. Then your soft buttons will be lit up.
I think there's also variations of quality on those soft touch lights. I had two Note, one had clear soft light on the soft button, the other had dirty looking light on the soft buttons. Both works fine, but just something to know.
Click to expand...
Click to collapse
as what jeremy.chan and hp79 have said that the SGN has no notification indicator. but if we are taking about custom kernel to have the touch key light as the indicator, it will be white in color.

Dyonas said:
What sort of notification LED does the Galaxy Note have? I've used three different Android phones since the original G1 and it feels like they're turning into pretty useless two or three colour things now. The G1 had a multi-colour LED, something like six or seven colour choices, as did my Motorola Milestone but my current phone, the HTC Desire HD, has a pathetic tri-colour LED. I was seriously considering the new One X but that has a dual-colour LED!
Anyway.. getting sidetracked. Can a Note user please tell me what, if any, notification LED the phone has and what colours it can display if it does have one? I know this won't be a big deal to a lot of people but I relied pretty heavily on the multiple colours in the past.
Click to expand...
Click to collapse
The only notification LED you can have is the soft touch keys backlight. It will be white in color and you can change the blinking rate to your custom setting.
You require root and a custom kernel like abyss which supports this and attain the said functionality by using this app - https://play.google.com/store/apps/...wsMSwxLDEsIm5lbGRhci5ibG4uY29udHJvbC5mcmVlIl0.
Hit thanks if it helped

If your on stock rom, install Noled app from market.

Thanks for the replies everyone, I appreciate it It's strange to see such a useful feature missing or reduced from what it started out as but I'm sure there are reasons behind it.

Dyonas said:
It's strange to see such a useful feature missing or reduced from what it started out as but I'm sure there are reasons behind it.
Click to expand...
Click to collapse
Bad Samsung user interface? Samsung arrogance? Silly patents? Doubt there's a good reason.
But you aint gonna change it, so you'll just have to live with it!

my black notification led works just fine............

Mystic38 said:
my black notification led works just fine............
Click to expand...
Click to collapse
i never noticed it until i read your post. it's actually amazing!

It's possible make a notification like the iPhone 4 ?, whit the flash led, if you have a notification blink two times or something similar.
PD: sorry for my english

Led Changer

Hi, is there anyway to totally customize the led notification light on the r1hd, apart fro mthe standerd red and green

thabuff said:
Hi, is there anyway to totally customize the led notification light on the r1hd, apart fro mthe standerd red and green
Click to expand...
Click to collapse
I think gravitybox allows you to do this, you'll need Xposed framework though.

I have looked into this extensively. There is another thread about it already. Unfortunately, the LED is this phone has only red and green colors - that's it. Now, by turning on both the red and green at the same time, you should be able to get a third color - orange. BUT, the red LED is so much brighter than the green LED that the "orange" looks almost the same as the red, so it's really not usable. I emailed back and forth with the developer of the wonderful lightflow app to help figure out if it was a hardware or a software issue. Unfortunately for us, it's a hardware issue. They saved a few cents by using a red and green color LED instead of a much higher quality red, green, blue LED.
The bottom line is that the LED can only be bright red or green. You can use blink rates in combinations with the colors to indicate different things though. If you look at my post in the other thread, you can see how to turn the red and green on and off again with some simple commands.

yaconsult said:
I have looked into this extensively. There is another thread about it already. Unfortunately, the LED is this phone has only red and green colors - that's it. Now, by turning on both the red and green at the same time, you should be able to get a third color - orange. BUT, the red LED is so much brighter than the green LED that the "orange" looks almost the same as the red, so it's really not usable. I emailed back and forth with the developer of the wonderful lightflow app to help figure out if it was a hardware or a software issue. Unfortunately for us, it's a hardware issue. They saved a few cents by using a red and green color LED instead of a much higher quality red, green, blue LED.
The bottom line is that the LED can only be bright red or green. You can use blink rates in combinations with the colors to indicate different things though. If you look at my post in the other thread, you can see how to turn the red and green on and off again with some simple commands.
Click to expand...
Click to collapse
Well thx for the research m8. It's unfortunate tho. But nevertheless thanks very much for the info

I was VERY disappointed to find this out! My previous phone was a Moto G xt1045 and it had a white notification light only. On the models after that, they removed it altogether in favor of "ambient display" - yech! Doesn't do you a damn bit of good when you are across the room and look over at the phone. A blinking light, you can see. A notification that pops up from time to time, you are unlikely to.
I was so looking forward to having a full color LED like the Nexus 5 I had years ago had. But... $60!

Sorry for my english this Led its only "Led charger" or Led notificatiom also?

Chukie022 said:
Sorry for my english this Led its only "Led charger" or Led notificatiom also?
Click to expand...
Click to collapse
No, it's not just for indicating charging. You can use it to indicate anything you like using an application like LightFlow.
But since it can only display the colors red and green, and both together still look like red because red is so much brighter, you really only have two colors to work with.
You can use things like different blink rates and sounds to indicate different notifications as well.

Led Indicator color issue

I received Note 9(VZW) directly from Samsung 3 days ago. I traded in Note 8 and received $500 credit. It is my first purchase from Samsung.
Everything works fine except the LED Indicator. I don't see any problem with Red, Green and Blue colors. I noticed the color of KakaoTalk notification LED is not solid yellow as it should. It looks like light green(half yellow and half green). If I let it blink for a while, it sometimes changes to Yellow and goes back to light green. I installed "Light Manager" and tested all available colors. I see a problem with Yellow, Orange and White. Yellow looks like light Green, Orange looks like Yellow and While looks like light Cyan. If I them blink for a wile, the correct color of Yellow and Orange sometimes light up. However, White remains in light Cyan.
I think my Note 9 is defective. Has anyone exchanged a defective phone from Samsung? What process do I need to go through? Do they send you a new phone 1st like VZW does?
Thanks.

Couldn't even get light manager to work on my device. It said that screen must be off to test the led colors. If screen is off how the hell do I press the on screen test color button [emoji23]
Sent from my SM-N960U1 using Tapatalk

Limeybastard said:
Couldn't even get light manager to work on my device. It said that screen must be off to test the led colors. If screen is off how the hell do I press the on screen test color button [emoji23]
Click to expand...
Click to collapse
That's because you have to turn screen off once you press test mode or W.e it's called, wait a few seconds and notification light will start to flash.

I use LED Blinker Pro and it works perfectly ?
/CK
---------- Post added at 08:55 ---------- Previous post was at 08:54 ----------
limeybastard said:
couldn't even get light manager to work on my device. It said that screen must be off to test the led colors. If screen is off how the hell do i press the on screen test color button [emoji23]
sent from my sm-n960u1 using tapatalk
Click to expand...
Click to collapse
omg ?
/ck

Jake.S said:
That's because you have to turn screen off once you press test mode or W.e it's called, wait a few seconds and notification light will start to flash.
Click to expand...
Click to collapse
Yep , I wasn't patient enough when I turned screen off [emoji28].
Sent from my SM-N960U1 using Tapatalk
---------- Post added at 06:23 AM ---------- Previous post was at 06:20 AM ----------
kwatch said:
I received Note 9(VZW) directly from Samsung 3 days ago. I traded in Note 8 and received $500 credit. It is my first purchase from Samsung.
Everything works fine except the LED Indicator. I don't see any problem with Red, Green and Blue colors. I noticed the color of KakaoTalk notification LED is not solid yellow as it should. It looks like light green(half yellow and half green). If I let it blink for a while, it sometimes changes to Yellow and goes back to light green. I installed "Light Manager" and tested all available colors. I see a problem with Yellow, Orange and White. Yellow looks like light Green, Orange looks like Yellow and While looks like light Cyan. If I them blink for a wile, the correct color of Yellow and Orange sometimes light up. However, White remains in light Cyan.
I think my Note 9 is defective. Has anyone exchanged a defective phone from Samsung? What process do I need to go through? Do they send you a new phone 1st like VZW does?
Thanks.
Click to expand...
Click to collapse
Yep orange and yellow look about the same on mine too. Meaning when I pick orange it's yellow and orange and when I pick yellow it's orange and yellow also. You best exchange yours, not acceptable for $1000+ device [emoji23] [emoji1787]
PS. I remember all my previous notes were similar. Good luck.
Sent from my SM-N960U1 using Tapatalk

I am having this same issue too when I use light flow. I need to know if it's a defect or if it's something the app is doing. Doesn't seem as though that many ppl are having the issue or even notice? The phone is fine otherwise. Can anyone else verify if this is happening? Anyone with two devices?

I have the identical problem as the original poster, with exactly the same colour issues.
The bizarre thing is, this has only just started to occur. The colours were pretty well defined before, other than the white which was always a little cyan looking.
Last night I was expecting a yellow LED from a notification and I got green.
I then tried all colour options in Light Manager and it seemed I only got red/green/blue despite what I selected. Same with defining custom colours in Whatsapp.
I experimented and set the LED to BRIGHT in Light Manager. Was previously on Normal. This improved things massively. All of this was done in evening time indoors with not much light.
Today I re-set the LED to NORMAL in light manager, and the colours were fine. Also the Whatsapp colours were now ok too. This confused me, but I read on Light Manager forum that this phone has an ambient LED sensor so I am wondering if that is what is affecting the colours. I will try again tonight in the dark and see if they have reverted back to R/G/B again.
So my solution at the moment is to set the LED to BRIGHT in the Light Manager settings.
Not ideal really as on my S7 previously the LED was faultless.

I had an note 2, note 8 and now note 9 and they all have the same issue with some colour blending with that LED.
It must had some multiple fixed colour LEDs around the hole and the green and yellow must be "far" from each other so that when it need to mix them to make the desired colour, they badly blend.

Question Customise notification Led

Hi all,
Wondering if anyone knows if the notification LED can be customised? I've tried light flow but it doesn't work correctly (perhaps because of the lack of colours supported by zenfone LED?).

Sadly, the notification LED is only red green and yellow

Adaoh said:
Sadly, the notification LED is only red green and yellow
Click to expand...
Click to collapse
That is a little unfortunate although if it could be customized it still would be handy (for example green on vs slow flash vs fast flash all for different apps).. Seems strange that the green light flow settings don't work even though the LED has green.