Related
Use everything here on your own risk and hit THANKS BUTTON if you like my work!
General Information:
As you propably know, till now there is no CRT-off MOD out for the S3. This is because only changing the value of config_animateScreenLights from true to false in framework-res.apk is not working anymore!
Together with Tungstwenty and rovo89 we faced out, that the problem are some missing commands in the /system/framework/services.jar
After comparing files from S2 and S3 Tungstwenty could help me to find the right position to edit files and with a litte bit of testing we found the right commands to enable the CRT-off-effect!
Click to expand...
Click to collapse
Tungstwenty said:
Let me clarify what is required in order to have the CRT effects working:
A patched library that properly (i.e. no flicker, etc.) provides the effects --> see attached flashable zip's or use Tweakbox
Code changes on the ROM in order to properly trigger the effect(s), which the library will then respond to those triggers --> look at the how-to or use Tweakbox
Item no. 1 is the one that I worked on and for which a fully working library was now provided.
The 2nd part can be done in 2 different ways - either patching the S3's ROM to properly enable the CRT-On and/or CRT-Off effects, OR do some hooking on the existing methods in the ROM and without changing that code, override the flags (i.e., the way Tweakbox does it).
It's this 2nd aspect that you guys need to address somehow. I worked with rovo89 on Tweakbox and not only does it bundle with the library, it also does the code changes in memory to make it work (topic no. 2).
But sphinx02 had already provided that, initially, after some discussion on what needed to be patched on the S3 ROM.
So, in order to have it working you have 2 ways:
Either use Tweakbox and make use of its configuration options to enable only CRT-Off, only CRT-On, or whatever you fancy.
Ask for someone (such as sphinx02) that has an S3, to keep up with existing ROMs (it will need to be changed separately for every one), and provide patched apk's on top of the existing ones so that it enables the effect triggers I mentioned. This will also need to take into account whether you prefer both effects on, only CRT-Off, etc.
I hope this is a bit more clear now, if not just let me know.
Click to expand...
Click to collapse
Click to expand...
Click to collapse
HOW-TO make the Code Changes:
This is what have to be done:
First of all decompile classes of services.jar (I won't provide any information to this, there are many tutorials out there how to use the smali tools!)
Than in com/android/server/PowerManagerService.smali we have to make the method nativeStartSurfaceFlingerAnimation(I)V callable from inner classes. To do that, we have to add the following after the last access$XXXX method:
Code:
.method static synthetic access$9000(Lcom/android/server/PowerManagerService;I)V
.registers 2
.parameter "x0"
.parameter "x1"
.prologue
.line 110
invoke-direct {p0, p1}, Lcom/android/server/PowerManagerService;->nativeStartSurfaceFlingerAnimation(I)V
return-void
.end method
Than we have to add some commands to the file com/android/server/PowerManagerService$BrightnessState.smali to trigger the CRT-off-effect. For that add the red part between :cond_38 and iget-object v4, p0, Lcom/a.... like this (its around line 400 in code):
Code:
.line 2679
.restart local v3 #turningOff:Z
:cond_38
[COLOR="Red"] iget-object v4, p0, Lcom/android/server/PowerManagerService$BrightnessState;->this$0:Lcom/android/server/PowerManagerService;
const/16 v3, 0x11 # CRT-On and CRT-Off
#calls: Lcom/android/server/PowerManagerService;->nativeStartSurfaceFlingerAnimation(I)
invoke-static {v4, v3}, Lcom/android/server/PowerManagerService;->access$9000(Lcom/android/server/PowerManagerService;I)V[/COLOR]
iget-object v4, p0, Lcom/android/server/PowerManagerService$BrightnessState;->this$0:Lcom/android/server/PowerManagerService;
#getter for: Lcom/android/server/PowerManagerService;->mScreenBrightness:Lcom/android/server/PowerManagerService$BrightnessState;
invoke-static {v4}, Lcom/android/server/PowerManagerService;->access$6000(Lcom/android/server/PowerManagerService;)Lcom/android/server/PowerManagerService$BrightnessState;
move-result-object v4
If you want to have only CRT-OFF, you can replace
Code:
const/16 v3, 0x11 # CRT-On and CRT-Off
with this:
Code:
const/16 v3, 0x10 # CRT-Off only
Finally recompile the file, put it on your phone and you can see the CRT-Off effect on your S3!
Click to expand...
Click to collapse
Click to expand...
Click to collapse
Avoid flickers, enable CRT-ON in lib-file:
Tungstwenty said:
Hi,
I worked on the porting of the patch to S3 and despite not having one myself, I'm pretty confident that the binary rovo89 and myself included in the latest Tweakbox should work on an S3.
Could any of you guys try it out?
What to do:
Install the newest Xposed framework from here. Open the Installer app, press Install/Update and reboot.
Install the Tweakbox mod from here. Open it and enable the CRT effects in the appropriate section. You can also enable any other tweaks you like, to check if they also work for the S3 (most of them should)
Go back to the Xposed Installer app, activate the Tweakbox mod (2nd tab), then in the libraries section select "libsurfaceflinger.so" and use the I9300 version. Tick the "Replace in test-mode only" option and back in the 1st tab do a soft / test reboot.
If everything goes well and the effects work as expected, you can go back to the installer app and untick "test-mode only" so the lib is overridden on every boot.
Note that except for the app_process system file which is installed by the framework (creating a backup file, and which should have no practical effects until any mods are enabled later), all other replacements such as the surfaceflinger lib do not change anything in /system but are rather performed by loading the files from an alternate path.
I'd appreciate your feed back especially for the CRT effect, but also the other existing Tweakbox options.
Thanks!
Click to expand...
Click to collapse
Or use in addition to the changes in services.jar the attached flashable zip's to overwrite libsurfaceflinger.so with the corrected one by Tungstwenty or me, XXAL for (XXALE8,XXALF2,XXALF6) and XXBL for (XXBLFB,XXBLG1,...)
Click to expand...
Click to collapse
Click to expand...
Click to collapse
Notes:
- This is a development thread so please discuss only things that interest for further development
- First part of the development has been discussed in this Thread of S2-forums
- As on the S2 after the CRT-off-effect sometimes the screen flickers --> fixed by Tungstwenty
- For some reason, it works without setting config_animateScreenLights from true to false in framework-res.apk
- I hope Tungstwenty and rovo89 can help us again to edit the libsurfaceflinger.so to avoid that it flickers after the CRT-off-effect
Click to expand...
Click to collapse
Click to expand...
Click to collapse
Testing the effect:
I have made the changes for ODEXED and DEODEXED XXALF2 ROM, if you want to test it have a look at my thread in the themeing/modding forums:
[MOD][ALF2/ALF6/BLFB][ODEX/DEODEX] 1% BatMod + ExtPowMen + CRT-OFF-ON or CRT-OFF-ONLY
Please post development-unrelated stuff there!!
Click to expand...
Click to collapse
Click to expand...
Click to collapse
Credits:
Credits are going out to Tungstwenty and rovo89 for their excellent work on the S2 and for their help/advice on the S3! Excellent developers!
I hope you guys will help us again to fix the libs and perhaps enabling CRT-on-effect aswell!!!
Thank you for helping us again!
Click to expand...
Click to collapse
Click to expand...
Click to collapse
reserved for future use, just in case..
Nice one!
Sent from my GT-I9300 using xda premium
sphinx02 said:
- I hope Tungstwenty and rovo89 can help us again to edit the libsurfaceflinger.so to avoid that it flickers after the CRT-off-effect
Click to expand...
Click to collapse
The flicker issue and the lack of CRT-On effect are *exactly* the same issues that are present on the S2 lib as well.
It has been fixed there, but changing ARM code without the sources is a very tedious process and that requires a fair amount of testing till it eventually works.
Without having access to an S3 it's very hard to do this or even explain what needs to be done
On top of that, I have other pending stuff I need to work on so you shouldn't expect a fix very soon, sorry.
Tungstwenty said:
The flicker issue and the lack of CRT-On effect are *exactly* the same issues that are present on the S2 lib as well.
It has been fixed there, but changing ARM code without the sources is a very tedious process and that requires a fair amount of testing till it eventually works.
Without having access to an S3 it's very hard to do this or even explain what needs to be done
On top of that, I have other pending stuff I need to work on so you shouldn't expect a fix very soon, sorry.
Click to expand...
Click to collapse
Ok, I see the problematic.. But perhaps you can give me the original and the modified files from the s2 so I can compare the 2 files and perhaps see by myself what is changed! And as I never changed anything in .so files perhaps you can tell me additionally how you have edited them!
I'm willing to try around again and to play with bytecode or so on, but I think I need a little input from you!
You mentioned the tool objdump, so I think I have to become familiar with this tool, am I right?
sphinx02 said:
Ok, I see the problematic.. But perhaps you can give me the original and the modified files from the s2 so I can compare the 2 files and perhaps see by myself what is changed! And as I never changed anything in .so files perhaps you can tell me additionally how you have edited them!
I'm willing to try around again and to play with bytecode or so on, but I think I need a little input from you!
Click to expand...
Click to collapse
Ok then, I'll give you the starting pointers so you can have a look at what lies ahead
The S2 patched file with ON and OFF both working correctly, with no flickers, is in this post.
The S2 original file is attached here.
Do a binary compare to see the changed bytes and their offsets.
To have a look at the code, you need to have the NDK installed.
Run "objdump -x libsurfaceflinger.so" to see the decompiled ARM code.
And have fun trying to understand that
Tungstwenty said:
Ok then, I'll give you the starting pointers so you can have a look at what lies ahead
The S2 patched file with ON and OFF both working correctly, with no flickers, is in this post.
The S2 original file is attached here.
Do a binary compare to see the changed bytes and their offsets.
To have a look at the code, you need to have the NDK installed.
Run "objdump -x libsurfaceflinger.so" to see the decompiled ARM code.
And have fun trying to understand that
Click to expand...
Click to collapse
Ok, thank you for that.. I dont know at this point if I ever will have success with it but I will give it a try as I have the time to! Thank you very much again Tungstwenty for your tips/advice!
While trying around a little bit and thinking about the problem, I had the following idea:
Is it not possible to build an own, additional library file with the crt-off functions? Sources for that are out there! Just copy together and build an .so file. Than in the Java-Code we are including this new native code and simply calling the function from this new / additional lib-file? What do you think about that?
Looks like someone needs to do this again...
http://forum.xda-developers.com/showthread.php?t=1676378
The flicker bug is just a bit annoying
Edits
Lol sorry just seen the post a couple above mine. Hope you guys can fix it. Good luck.
Sent from my GT-I9300 using XDA Premium HD app
sphinx02 said:
While trying around a little bit and thinking about the problem, I had the following idea:
Is it not possible to build an own, additional library file with the crt-off functions? Sources for that are out there! Just copy together and build an .so file. Than in the Java-Code we are including this new native code and simply calling the function from this new / additional lib-file? What do you think about that?
Click to expand...
Click to collapse
I don't think that's a viable option. rovo already tried that with existing sources, I think, and the resulting library did not work on sammy's rom.
As for creating a separate library with only those functions, I also don't think that's possible as everything related with screen rendering (state, buffers, etc.) is on this lib and therefore a separate one would not have any of that info.
Hi,
I worked on the porting of the patch to S3 and despite not having one myself, I'm pretty confident that the binary rovo89 and myself included in the latest Tweakbox should work on an S3.
Could any of you guys try it out?
What to do:
Install the newest Xposed framework from here. Open the Installer app, press Install/Update and reboot.
Install the Tweakbox mod from here. Open it and enable the CRT effects in the appropriate section. You can also enable any other tweaks you like, to check if they also work for the S3 (most of them should)
Go back to the Xposed Installer app, activate the Tweakbox mod (2nd tab), then in the libraries section select "libsurfaceflinger.so" and use the I9300 version. Tick the "Replace in test-mode only" option and back in the 1st tab do a soft / test reboot.
If everything goes well and the effects work as expected, you can go back to the installer app and untick "test-mode only" so the lib is overridden on every boot.
Note that except for the app_process system file which is installed by the framework (creating a backup file, and which should have no practical effects until any mods are enabled later), all other replacements such as the surfaceflinger lib do not change anything in /system but are rather performed by loading the files from an alternate path.
I'd appreciate your feed back especially for the CRT effect, but also the other existing Tweakbox options.
Thanks!
Now I try, thank you..
And CRT on is possible?
failax said:
Now I try, thank you..
And CRT on is possible?
Click to expand...
Click to collapse
Yes. If everything is working as I expect, the new things vs your current situation are:
- No more flickering issues when CRT-Off
- Now also includes CRT-On
- Can detect device orientation and do a "vertical" CRT effect instead of horizontal
All these are optional and can be turned on/off in the Tweakbox preferences.
I tried.
CRT OFF has the same problem, CRT On is not visible, but I had to place also a jar file?
---------- Post added at 12:01 PM ---------- Previous post was at 11:50 AM ----------
I must add that I'm on checkromevo hd and I've already inserted a mod to see crt off, I don't know if this can help.
Other mods in tweakbox work.
failax said:
CRT OFF has the same problem, CRT On is not visible, but I had to place also a jar file?
Click to expand...
Click to collapse
Mmm, did you follow the steps I mentioned before, i.e. enabling the lib replacement in test mode and doing a soft reboot?
You should end up with a library on /vendor/lib (ramfs) and it should get loaded on startup instead of the one in /system/lib. Can you check with a file browser if the file under /vendor/lib does exist?
Also, could you open a terminal, run "set" and check if LD_LIBRARY_PATH is "/vendor/lib:/system/lib", as in S2?
Tungstwenty said:
Mmm, did you follow the steps I mentioned before, i.e. enabling the lib replacement in test mode and doing a soft reboot?
You should end up with a library on /vendor/lib (ramfs) and it should get loaded on startup instead of the one in /system/lib. Can you check with a file browser if the file under /vendor/lib does exist?
Also, could you open a terminal, run "set" and check if LD_LIBRARY_PATH is "/vendor/lib:/system/lib", as in S2?
Click to expand...
Click to collapse
I've rebooted totally, what do you mean for soft reboot?
Now I try to see those files..
EDIT:
under vendor/lib I see 2 things, I see a folder called DRM and inside libdrmwvplugin.so, and single file called libwvm.so.
Also, could you open a terminal, run "set" and check if LD_LIBRARY_PATH ?
Yes it's there.
failax said:
I've rebooted totally, what do you mean for soft reboot?
Now I try to see those files..
EDIT:
under vendor/lib I see 2 things, I see a folder called DRM and inside libdrmwvplugin.so, and single file called libwvm.so.
Click to expand...
Click to collapse
Can you open the Xposed Installer app and post a screenshot of each of the 3 tabs? "Framework", "Modules" and "Libraries" (in this last one, scroll to the bottom to display the "libsurfaceflinger.so" entry so it's visible in the picture)
Can you send me the modded libsurfaceflinger.so so I can test it directly?
Maybe a downloadlink via pm...
I have sphinx mod for CRT, so If I deselect CRT off on tweakbox, it is shown the same.
sphinx02 said:
Can you send me the modded libsurfaceflinger.so so I can test it directly?
Maybe a downloadlink via pm...
Click to expand...
Click to collapse
Would you mind just taking it from the Tweakbox package, and in the process also checking if the on-the-fly replacement is working for you?
---------- Post added at 12:03 PM ---------- Previous post was at 12:01 PM ----------
failax said:
I have sphinx mod for CRT, so If I deselect CRT off on tweakbox, it is shown the same.
Click to expand...
Click to collapse
Your lib settings are ok, so if you do a soft reboot (pressing the button on the app), it should come back with a libsurfaceflinger.so file in /vendor/lib. It's won't happen, though, if you do a "normal" reboot.
It isn't happening to you? Could it be that the soft reboot tries to load the new lib, fails, and immediately does a hard/normal reboot - did you notice anything that could point to this?
Main thread + features + install instructions + dev support
http://forum.xda-developers.com/showthread.php?t=2201860
PhilZ Touch is a CWM Advanced Edition that adds all the features you could ever miss in CWM
It is a well proven recovery for many phones
It also adds a full touch interface a completely configurable GUI
Please give your feedback, what works, and any bug you could encounter
Read the features, and check if you are missing something
Also, do not forget to read about the powerful aroma file manager integration and double tap shortcut
Download links
Last version can be found here:
celoxhd
http://goo.im/devs/philz_touch/CWM_Advanced_Edition
Original dev supporter:
http://www.androidfilehost.com/?w=files&flid=12461
Click to expand...
Click to collapse
Huge thanks and credits to @titanic_fanatic
He ported the sources and provided all needed stuff to build it
Excellent, many thanks for all the work you put into this for us. We very much appreciate it
On the topic of bugs, I only have two (but I really don't mind at all). The screenshot works except for the resulting image is wavy coloured lines and no vibration regardless of the setting.
We've never had either, so I'm not missing them at all, but wanted to let you know.
Take care Phil
Sent from my SGH-I757M using XDA Premium 4 mobile app
titanic_fanatic said:
Excellent, many thanks for all the work you put into this for us. We very much appreciate it
On the topic of bugs, I only have two (but I really don't mind at all). The screenshot works except for the resulting image is wavy coloured lines and no vibration regardless of the setting.
We've never had either, so I'm not missing them at all, but wanted to let you know.
Take care Phil
Sent from my SGH-I757M using XDA Premium 4 mobile app
Click to expand...
Click to collapse
Added you to credits on the device page in main thread and here in OP :good:
screen shots: forget it, I should disable it once for all on new devices. Sadly, we have no working thing for most new devices. Only some Sammy and the mako did work
vibration: can you provide the path for vibrator?, it should be in kernel drivers I guess. Currently I use:
Code:
/sys/class/timed_output/vibrator/enable
We echo some msec value there and it Bzzzzz for that msec
Phil3759 said:
Added you to credits on the device page in main thread and here in OP :good:
screen shots: forget it, I should disable it once for all on new devices. Sadly, we have no working thing for most new devices. Only some Sammy and the mako did work
vibration: can you provide the path for vibrator?, it should be in kernel drivers I guess. Currently I use:
Code:
/sys/class/timed_output/vibrator/enable
We echo some msec value there and it Bzzzzz for that msec
Click to expand...
Click to collapse
That's the correct path Maybe the driver isn't loading properly... I'll see if I can get a dmesg Log when booting recovery to see if the driver actually loads
Sent from my SGH-I757M using XDA Premium 4 mobile app
Vibrator Fixed
Hey @Phil3759, I did a whole lot of investigating tonight and have figured out and fixed the vibration issue. I discovered that it was trying to load the module from /system/lib/modules/vibrator.ko. This is my roms ko file and is currently for cm10.2. The kerenel I setup for this recovery is our cm11 kernel and uses a different module (compiled against that kernel). It was trying to load the cm10.2 module from my rom into the cm11 kernel which obviously doesn't work, so I split the recovery.img added the correct module at /tmp/system/lib/modules added the necessary lines to init.recovery.qcom.rc and repackaged the kernel and new ramdisk.
I have flashed this and tested it. it works like a charm now Can you replace the version in your repo with this new one?
titanic_fanatic said:
Hey @Phil3759, I did a whole lot of investigating tonight and have figured out and fixed the vibration issue. I discovered that it was trying to load the module from /system/lib/modules/vibrator.ko. This is my roms ko file and is currently for cm10.2. The kerenel I setup for this recovery is our cm11 kernel and uses a different module (compiled against that kernel). It was trying to load the cm10.2 module from my rom into the cm11 kernel which obviously doesn't work, so I split the recovery.img added the correct module at /tmp/system/lib/modules added the necessary lines to init.recovery.qcom.rc and repackaged the kernel and new ramdisk.
I have flashed this and tested it. it works like a charm now Can you replace the version in your repo with this new one?
Click to expand...
Click to collapse
If you update your device tree, it would be even better. That way, my next updates won't be affected again
Phil3759 said:
If you update your device tree, it would be even better. That way, my next updates won't be affected again
Click to expand...
Click to collapse
I just finished updating my device tree with the necessary fixes for the vibrator to work in recovery
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/6f005f4045551e48adfa0ac228641bf8d6a12128
Also, not that I care, but Amarullz was able to get screenshots working in the latest AromaInstaller (Flamboyan I think). If your interested, maybe ask him what he did to get it to work. He could probably point you to the commits
Take Care
titanic_fanatic said:
I just finished updating my device tree with the necessary fixes for the vibrator to work in recovery
https://github.com/titanic-fanatic/...mmit/6f005f4045551e48adfa0ac228641bf8d6a12128
Also, not that I care, but Amarullz was able to get screenshots working in the latest AromaInstaller (Flamboyan I think). If your interested, maybe ask him what he did to get it to work. He could probably point you to the commits
Take Care
Click to expand...
Click to collapse
Looking at it quickly: why that first extra / at end of copy files?
Also, won't be cleaner to use standard path like /lib/modules?
/tmp can be wiped and modified by installers and recovery
Phil3759 said:
Looking at it quickly: why that first extra / at end of copy files?
Also, won't be cleaner to use standard path like /lib/modules?
/tmp can be wiped and modified by installers and recovery
Click to expand...
Click to collapse
The first / is because it's part of a set of chained product copy files directives:
# Ramdisk
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/ramdisk/init.qcom.usb.rc:root/init.qcom.usb.rc \
# BT firmware
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/firmware/bcm4330B1.hcd:system/etc/firmware/bcm4330B1.hcd \
# Needed for vibrator to work in recovery
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/recovery/root/lib/modules/vibrator.ko:recovery/root/lib/modules/vibrator.ko \
device/samsung/celoxhd/recovery/root/init.recovery.qcom.rc:recovery/root/init.recovery.qcom.rc
Click to expand...
Click to collapse
I did this only to adhere to the existing pattern in my device.mk file, the one appended to the first PRODUCT_COPY_FILES was already there from when I forked the project and took that as being a set of chained commands. If this is wrong, I will change it
I definitely see your point on the /tmp dir. I here the commit that fixes that
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/61da6be2d60a03797ddc31c0187cc5c62bb3a97a
titanic_fanatic said:
The first / is because it's part of a set of chained product copy files directives:
I did this only to adhere to the existing pattern in my device.mk file, the one appended to the first PRODUCT_COPY_FILES was already there from when I forked the project and took that as being a set of chained commands. If this is wrong, I will change it
I definitely see your point on the /tmp dir. I here the commit that fixes that
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/61da6be2d60a03797ddc31c0187cc5c62bb3a97a
Click to expand...
Click to collapse
I uploaded 6.01.2 with your fixed vibrator :good:
PRODUCT_COPY_FILES:
Maybe I am wrong, but usually, in make files, only the last element has no trailing /
Code:
# Ramdisk
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/ramdisk/init.qcom.usb.rc:root/init.qcom.usb.rc
xxx-yyy \
zzz-pppp\
last_one
# BT firmware
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/firmware/bcm4330B1.hcd:system/etc/firmware/bcm4330B1.hcd
# Needed for vibrator to work in recovery
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/recovery/root/tmp/system/lib/modules/vibrator.ko:recovery/root/tmp/system/lib/modules/vibrator.ko \
device/samsung/celoxhd/recovery/root/init.recovery.qcom.rc:recovery/root/init.recovery.qcom.rc
Also, just for info, my full gui builds need these, often in cm.mk:
Code:
TARGET_SCREEN_HEIGHT := 1280
TARGET_SCREEN_WIDTH := 720
Phil3759 said:
I uploaded 6.01.2 with your fixed vibrator :good:
PRODUCT_COPY_FILES:
Maybe I am wrong, but usually, in make files, only the last element has no trailing /
Code:
# Ramdisk
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/ramdisk/init.qcom.usb.rc:root/init.qcom.usb.rc
xxx-yyy \
zzz-pppp\
last_one
# BT firmware
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/firmware/bcm4330B1.hcd:system/etc/firmware/bcm4330B1.hcd
# Needed for vibrator to work in recovery
PRODUCT_COPY_FILES += \
device/samsung/celoxhd/recovery/root/tmp/system/lib/modules/vibrator.ko:recovery/root/tmp/system/lib/modules/vibrator.ko \
device/samsung/celoxhd/recovery/root/init.recovery.qcom.rc:recovery/root/init.recovery.qcom.rc
Also, just for info, my full gui builds need these, often in cm.mk:
Code:
TARGET_SCREEN_HEIGHT := 1280
TARGET_SCREEN_WIDTH := 720
Click to expand...
Click to collapse
It seems that the extra \ was introduced in our JB branch and has never been fixed. Various examples in googles repo confirm that you are correct. I have removed the extra \ and added the properties you mentioned above to the cm.mk file. Here is the relevant commit:
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/6ce5f482d63cd70cf64a3d1428ad2428844e23cb
Hey @Phil3759, I just downloaded and flashed the latest version. Thanks kindly for the update
I see that I made a boo boo and forgot to update the path to the vibrator in the init.recovery.qcom.rc file and so the vibrator isn't loading. I've fixed that with the following commit:
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/b87b3267d75a0de1bb94f68850ae6986ac4dde92
One other thing, for some reason the background is tiled 4 times as if my devices dimensions were not set correctly. I do have that set in my cm.mk file. Here was the commit for that:
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/6ce5f482d63cd70cf64a3d1428ad2428844e23cb
Is there somewhere else I'm supposed to specify the device screen dimensions?
Thanks again for the new version and I apologize for missing that path in the init.recovery.qcom.rc.
titanic_fanatic said:
Hey @Phil3759, I just downloaded and flashed the latest version. Thanks kindly for the update
I see that I made a boo boo and forgot to update the path to the vibrator in the init.recovery.qcom.rc file and so the vibrator isn't loading. I've fixed that with the following commit:
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/b87b3267d75a0de1bb94f68850ae6986ac4dde92
One other thing, for some reason the background is tiled 4 times as if my devices dimensions were not set correctly. I do have that set in my cm.mk file. Here was the commit for that:
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/6ce5f482d63cd70cf64a3d1428ad2428844e23cb
Is there somewhere else I'm supposed to specify the device screen dimensions?
Thanks again for the new version and I apologize for missing that path in the init.recovery.qcom.rc.
Click to expand...
Click to collapse
About background image:
I think this is the cause:
https://github.com/CyanogenMod/android_device_samsung_celox-common/blob/cm-11.0/celox-common.mk#L45
called here:
https://github.com/titanic-fanatic/...xhd/blob/philz-recovery-cm-11.0/device.mk#L37
Your cm.mk settings are overridden
Maybe just move device resolution from cm.mk to device.mk after Line 37
About the vibrator: do you need exfat through kernel modules? If yes, let me know. It is much faster than fuse. For that, you'll need to compile the kernel with samsung exfat sources. I can guide you for that
Else, link me to what exactly is needed in your kernel for the vibrator to work. If it is just a change in defconfig, I can add it and compile along exfat
Phil3759 said:
About background image:
I think this is the cause:
https://github.com/CyanogenMod/android_device_samsung_celox-common/blob/cm-11.0/celox-common.mk#L45
called here:
https://github.com/titanic-fanatic/...xhd/blob/philz-recovery-cm-11.0/device.mk#L37
Your cm.mk settings are overridden
Maybe just move device resolution from cm.mk to device.mk after Line 37
About the vibrator: do you need exfat through kernel modules? If yes, let me know. It is much faster than fuse. For that, you'll need to compile the kernel with samsung exfat sources. I can guide you for that
Else, link me to what exactly is needed in your kernel for the vibrator to work. If it is just a change in defconfig, I can add it and compile along exfat
Click to expand...
Click to collapse
I see it, and now as you've recommended I reset the values after calling celox-common.mk. The commit is here:
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/cd44b44b7cbb0ddb3b649ac5c4f8d5d1f51d7998
As for exfat, I will be adding this when I have some time to rebuild this kernel. We can worry about exfat for the next time you do device updates and hopefully I'll have it ready by that time. I have your main thread in my subscriptions, so I'll know when your ready to release a new version and will remind you to sync with my repo at that time
Thanks for catching that issue with screen size
titanic_fanatic said:
I see it, and now as you've recommended I reset the values after calling celox-common.mk. The commit is here:
https://github.com/titanic-fanatic/android_device_samsung_celoxhd/commit/cd44b44b7cbb0ddb3b649ac5c4f8d5d1f51d7998
As for exfat, I will be adding this when I have some time to rebuild this kernel. We can worry about exfat for the next time you do device updates and hopefully I'll have it ready by that time. I have your main thread in my subscriptions, so I'll know when your ready to release a new version and will remind you to sync with my repo at that time
Thanks for catching that issue with screen size
Click to expand...
Click to collapse
np
Let me know if you need info to add exfat
I will update with the current fixes asap
Phil3759 said:
np
Let me know if you need info to add exfat
I will update with the current fixes asap
Click to expand...
Click to collapse
Can I get a link to these fixes please when you have it ready
titanic_fanatic said:
Can I get a link to these fixes please when you have it ready
Click to expand...
Click to collapse
https://github.com/PhilZ-cwm6/GE-Ed...mmit/a8963ca853cfd88466716f8a25434d5c469a2bb9
It is just adding the exfat folder in drivers and edit the makefile with -y to have it built as static. No need to separate modules
Phil3759 said:
https://github.com/PhilZ-cwm6/GE-Ed...mmit/a8963ca853cfd88466716f8a25434d5c469a2bb9
It is just adding the exfat folder in drivers and edit the makefile with -y to have it built as static. No need to separate modules
Click to expand...
Click to collapse
Excellent. I'll add it soon, it should be a pretty quick process.
Quick question though since we are currently having some issues with random reboots in all of my latest builds of cm-11.0. My kernel was updated at some point, and that's when my builds started having random reboots. They are actually not random, but seem rather consistent.
My question is this, do you think this will affect operation in recovery? I believe the reboots are due to kernel panic from a graphics related issue but am not sure if that will only affect the rom and not recovery.
If this might affect recovery, I think I'll build it as a module so I can just add it to my device tree instead of having to update the entire zImage. This will at least give us the old working kernel with the exfat module included.
What do you think?
Sent from my SGH-I757M using XDA Premium 4 mobile app
titanic_fanatic said:
Excellent. I'll add it soon, it should be a pretty quick process.
Quick question though since we are currently having some issues with random reboots in all of my latest builds of cm-11.0. My kernel was updated at some point, and that's when my builds started having random reboots. They are actually not random, but seem rather consistent.
My question is this, do you think this will affect operation in recovery? I believe the reboots are due to kernel panic from a graphics related issue but am not sure if that will only affect the rom and not recovery.
If this might affect recovery, I think I'll build it as a module so I can just add it to my device tree instead of having to update the entire zImage. This will at least give us the old working kernel with the exfat module included.
What do you think?
Sent from my SGH-I757M using XDA Premium 4 mobile app
Click to expand...
Click to collapse
you'll end up with magic number mismatch errors
There are some hacks to force loading on mismatch, but, in my previous experience, they failed on many devices
the drivers must be compiled along the zImage
Now, why don't we drop to celox-common kernel which seems to work fine on skyrocket and other phones?
Phil3759 said:
you'll end up with magic number mismatch errors
There are some hacks to force loading on mismatch, but, in my previous experience, they failed on many devices
the drivers must be compiled along the zImage
Now, why don't we drop to celox-common kernel which seems to work fine on skyrocket and other phones?
Click to expand...
Click to collapse
It is for the most part the same kernel with the few quirks of my device. More notably is my devices display drivers are mipi s6e8aa0_720hd and had to fork the kernel to apply some fixes to that driver as it's not maintained by cm.
Hmmm. I'll be the guinea pig. I will build with the new kernel and I'll test the recovery before you upload. I just think that the issue might be a memory leak in android causing the kernel to panic (overlay issue) and might not have an effect in recovery since its graphics are very basic.
I'll let you know when it's ready
Sent from my SGH-I757M using XDA Premium 4 mobile app
Hello devs
I am relatively new to building ROMs, though I have built a couple of ROMs (like AOSPA) before. I have been closely following the lineage 15 development closely, and seeing the new branch created, I started a build. I had a few minor hiccups early, but after resolving them, I have successfully hit a brick wall. Any and all help would be appreciated. Thanks!
Hi there
Actually, lineage-15.0 branch is not fully usable.
You can check review.lineageos.org at the corresponding branch for info.
About android_alarm.h issue, you can add that library to your downloaded sources.
AndroGeek
try add to boardconfig
WITH_LINEAGE_CHARGER := false
Click to expand...
Click to collapse
Building for now...
tathanhlam66 said:
try add to boardconfig
Click to expand...
Click to collapse
Just tried it.. seems to be building well now! I haven't tried AndroGeek's method, and I will give it a shot if anything goes wrong again.
Also @tathanhlam66, what happens when when I add that line to BoardConfig.mk? (Just out of curiosity)
DaNightmare said:
Just tried it.. seems to be building well now! I haven't tried AndroGeek's method, and I will give it a shot if anything goes wrong again.
Also @tathanhlam66, what happens when when I add that line to BoardConfig.mk? (Just out of curiosity)
Click to expand...
Click to collapse
See here
https://github.com/LineageOS/android_vendor_lineage/blob/lineage-15.0/config/BoardConfigLineage.mk
If you declare With lineage charger = false, the library libhealthd.lineage will not be built
And you will not have that error
Correct me if i'm wrong
Thanks @Gava97 for the short explanation.
I am now getting another error, with the kernel this time. It may or may not be a problem with the source.... (I don't think it is related to the Lineage charger.)
Screenshot attached. Any and all help would be appreciated
DaNightmare said:
Thanks @Gava97 for the short explanation.
I am now getting another error, with the kernel this time. It may or may not be a problem with the source.... (I don't think it is related to the Lineage charger.)
Screenshot attached. Any and all help would be appreciated
Click to expand...
Click to collapse
Have you tried to use make clean or make mrproper before re-build?
...
shivatejapeddi said:
...
Click to expand...
Click to collapse
Helpful af post...
Gava97 said:
Have you tried to use make clean or make mrproper before re-build?
Click to expand...
Click to collapse
That was the first thing I tried, did not work. I even deleted kernel/lge/hammerhead and re-downloaded it. Still doesn't work.
I think the lineage 15 code is very premature and development hasn't even begun for hammerhead. I'm stopping the building for now and will continue when the sources are sufficiently updated. Thanks all for the help!
try this https://github.com/hyperUnicorns/li...mmit/bd542e1741ff48385bc7633dbddb38b6061eb748
Amy07i said:
try this https://github.com/hyperUnicorns/li...mmit/bd542e1741ff48385bc7633dbddb38b6061eb748
Click to expand...
Click to collapse
I agree with you, when there is an error like this "missing <Linux/something.h>" it means that's kernel related, commit looks good.
Hi all:
This is a thread for my alternative LineageOS 14.1 roms for suzuran.
I'm building these roms from time to time for my own needs and I think other people should participate.
Since the "official" development of LineageOS 14.1 has been stopped, I decided to build a new version only if the Android security patch level has been changed or I've changed anything.
Download 2021-07-19
This is a 7z archive with the zip'ed rom and the md5 file in it. Please unpack this archive, copy the included two files somewhere to your device, reboot into TWRP and flash this zip file. Enable zip verification and md5sum checking. Maybe you have to rename the md5 file to *.md5sum; depending on the TWRP version you are using.
Kernel sources
Tree sources
Features:
OS Version: 7.1.2 Nougat
Kernel: Linux 3.10
New: Android security patch level: 5 June 2021
Using sony blob's from stock version 32.4.A.1.54
Important informations:
You should be familiar with general installation of custom roms.
Required for installation: TWRP 3.1.1 (or newer).
OR use my self built TWRP-version 3.5.2!
No need for making a clean install, but sometimes it helps a lot!
This rom is pre-rooted. For those who want to use magisk or any other rooting tool, you can easily remove this by flashing this file.
Use this rom at your own risk! It comes without any warranty! I'm not responsible for any damage! If you don't agree with that, don't try to flash this rom in any way.
Differences between my version and the "official" one:
Kcal Display Driver - Thanks to @GreyLeshy and @Sony user 16
Voltage Control - Thanks to @GreyLeshy and @Sony user 16
OMS-Support - Thanks to @nathanchance
Added F-Droid and UnifiedNLP! If you don't want this, simply de-install it.
I've included some little extensions like changelog and volume adjustment.
I've set maximum speaker volume to a higher value.
I've increased microphone gain.
I've increased all volume steps from 7 to 15.
I've changed the microfone gain to avoid echo in phone calls.
I've enabled data for MMS.
I've enabled MHL.
Not working:
VoLTE, VoWiFi
If you want to use encryption, you have to disable SIM PIN first!
One (last) request: Please don't ask for including any app. I won't do this, because I want to keep this rom as clean as possible.
Changelog
Troubleshooting:
If you're running into an error, please search in this thread if this error is already posted, before you post it again!
If not, I need a LOG to see what went wrong. Without a LOG I can't help you!
A LOG can be fetched by connecting the device with an USB cable to your PC and then by typing these commands line by line:
Code:
adb root
adb shell logcat -b all -d > logcat
Send my this LOG file via PM.
If you think this could be a SELinux related issue, please try to set the device to permissive mode first.
If the issue is gone, I need the policy file too (plus LOG). Fetch it by typing this line in a terminal:
Code:
adb pull /sys/fs/selinux/policy
If you stuck in a bootloop you can fetch a LOG with this trick:
Press the power button and the volume up button together until the device shuts down.
HOLD the power button.
Release the volume up button and press the volume down button immediately after releasing the volmue up button.
The device should start into TWRP recovery.
Tap on "Advanced", then on "Terminal" and enter these commands line by line:
Code:
cd sys/fs/pstore
cp * /sdcard
Send me the copied file(s), if any, via PM.
Nice
Berni-0815 said:
Hi @all:
First of all, please excuse my bad english... :angel:
They said I should create my own thread for my alternative LineageOS 14.1 roms for suzuran. Here it is.
I'm building these roms from time to time for my own needs and I think other people should participate.
Download
Kernel sources
Tree sources
OS Version: 7.1.2 Nougat
Kernel: Linux 3.10
Required for installation: TWRP 3.1.1
Important informations:
You should be familiar with general installation of alternative roms.
I've included some little extensions like changelog and volume adjustment.
There is no need to make a clean install, but sometimes it helps a lot!
Use it at your own risk!
Click to expand...
Click to collapse
Hi ! It would be great if u put out the advantage of yours vs with the official LOS
Berni i said before and i m saying again please make this topic a lineage based rom..
İnclude minimal app for google play store.
And maybe can add substratum inside.. or can be a default diffefent theme ..
I believe you can..
Thx bro.
ROBNX85 said:
Hi ! It would be great if u put out the advantage of yours vs with the official LOS
Click to expand...
Click to collapse
As I wrote: "I've included some little extensions like changelog and volume adjustment."
emosis said:
İnclude minimal app for google play store.
Click to expand...
Click to collapse
As I said a few days before: I don't want to include gapps! If somebody wants to use gapps, feel free to flash them separately. You can download them here. You need arm64 and 7.1 for suzuran.
And maybe can add substratum inside..
Click to expand...
Click to collapse
Substratum support is not longer available, because the devs have stopped their development for Nougat since august.
Berni-0815 said:
As I wrote: "I've included some little extensions like changelog and volume adjustment."
Click to expand...
Click to collapse
Add a basic ad-blocker too ?
Berni-0815 said:
As I said a few days before: I don't want to include gapps! If somebody wants to use gapps, feel free to flash them separately. You can download them here. You need arm64 and 7.1 for suzuran.
...
Click to expand...
Click to collapse
I agree gapps should not be included. It is easy enough to just flash it right after flashing the rom
I am thinking about official vs rom, I think the two roms are probably nearly identical. Probably the most important factor will be the frequency of updates.
PeppeBove said:
Add a basic ad-blocker too
Click to expand...
Click to collapse
You can use AdAway which is an open source host list based ad blocker. See https://adaway.org
PeppeBove said:
Add a basic ad-blocker too
Click to expand...
Click to collapse
I don't see a reason to bake something into the ROM when there are many apps that can do it.
I think something like Xposed-type tweaks being put into settings would be more appropriate. Alleviating the need for xposed. But I don't think it makes sense to load random apps into the ROM.
New version; please have a look at the first post
Berni-0815 said:
New version; please have a look at the first post
Click to expand...
Click to collapse
Awesome work, thank you so much! Flashing it now.
Just 1 question - do you know if encryption works on your builds?
I've never tried it. I've not so good experience with encryption on a stock rom; so I've decided not to use this feature at all!
Hi Bernhard.
Thanks for your hard work!
i have a question for you.... As i understand it you take all the changes/updates from the offifcial lienage and implement them into your own build. And add the changes as described in post 1.
Am i right about this?
I think that battery life is bad on the official compaired to the version you do.
Do you add battery improvements in your build?
Thanks in advance.
Torben 5247
torben5247 said:
Thanks for your hard work!
Click to expand...
Click to collapse
Oh, it is not so hard to do this, but, thank you! Sometimes I have to search a few hours or try (and revert) something, but in the end I've gotten everything to work as I like it to work.
As i understand it you take all the changes/updates from the offifcial lienage and implement them into your own build.
Click to expand...
Click to collapse
I'm using the LineageOS repositories from github as they are, that's right. I don't use my own repo's; nzzane is doing this AFAIK (Klick). A few weeks ago I'm using other repo's, because LineageOS had bad (will say: not working) sources for our devices.
And add the changes as described in post 1.
Am i right about this?
Click to expand...
Click to collapse
Yes! :good: One or two of my changes should be implemented into the "official" builds, but until now I don't understand how to use "commitments". Maybe in a few days... :angel:
I think that battery life is bad on the official compaired to the version you do.
Do you add battery improvements in your build?
Click to expand...
Click to collapse
No. Nothing like this.
On my own device battery life is about three days...
Hi,
PeppeBove said:
Add a basic ad-blocker too
Click to expand...
Click to collapse
emosis said:
İnclude minimal app for google play store.
And maybe can add substratum inside..
Click to expand...
Click to collapse
Like other persons, I don't want to have a lot of applications include in the rom. I want to choose the ones I use. This is one reason that made me come to alternative rom.
Another reason is that Lineage use less google s"hit" than stock rom.
So if you have the vision of more app and google stuff include, you better stay on stock. Alternative Roms offers me more freedom; but that's just my opinion...
This is prerooted? There are some of us out there that need to install certain apps before rooting.
Cerhio said:
This is prerooted?
Click to expand...
Click to collapse
Yes.
Berni-0815 said:
One or two of my changes should be implemented into the "official" builds, but until now I don't understand how to use "commitments".
Click to expand...
Click to collapse
I've just committed three of my changes. We'll see if they will be merged...
Berni-0815 said:
I've just committed three of my changes. We'll see if they will be merged...
Click to expand...
Click to collapse
The brightness settings? I hope so
What else?
Berni-0815 said:
I've just committed three of my changes. We'll see if they will be merged...
Click to expand...
Click to collapse
That's so great to hear, let's hope they get accepted.
Huge thank you for keeping this device alive Berni!
Does its existence for devices like the Z3C make it more or less likely for us to see on suzuran? Would love to see a LineageOS 17 ROM for this device. Makes me wish I was a dev. Thanks to all those who continue to grind hours into porting and developing ROMs for the platform.
beflythis said:
Would love to see a LineageOS 17 ROM for this device.
Click to expand...
Click to collapse
Oh! I have successfully built a LineageOS 17.0 rom for z5c! :good:
But.... As my 16.0 try this rom is not booting...
Don't know why
Berni-0815 said:
Oh! I have successfully built a LineageOS 17.0 rom for z5c! :good:
But.... As my 16.0 try this rom is not booting...
Don't know why
Click to expand...
Click to collapse
Are you making any kernel changes? If not, that's probably why. You can't use the LineageOS 15.1 kernel on the PIE. Correct me if I'm wrong but Pie requires linux kernel 4.4x and greater while, Android 10 requires 4.9 and greater.
Apart from fixing compile-errors, no.
But I don't think that the kernel version is important. This project uses kernel 3.x too, if I'm not wrong...
Sure, there have to be changes, but I can't do so...
I've tried another kernel (this one) and I changed/added some files to avoid compile errors. But the result is the same:
The splash screen apears, then a blank screen....
The splash screen apears, then a blank screen....
The splash screen apears, then a blank screen....
The splash screen apears, then a blank screen....
...and so on until end of battery...
Have you tried looking at any sort of logs, kernel logs? (I'm not sure if there would be one in the first place) It would be better to try by increments (PIE first with https://github.com/joel16/android_kernel_sony_msm8994). I might give it a try this weekend just for the sake of it.
Joel16 said:
Have you tried looking at any sort of logs, kernel logs? (I'm not sure if there would be one in the first place)
Click to expand...
Click to collapse
Where should these logs be?
I have no access to the device at this early stage...
An when I reflash a working rom /system will be overwritten.
It would be better to try by increments (PIE first with https://github.com/joel16/android_kernel_sony_msm8994). I might give it a try this weekend just for the sake of it.
Click to expand...
Click to collapse
I've tried to build pie with this kernel. Nearly the same result.
Berni-0815 said:
Where should these logs be?
I have no access to the device at this early stage...
An when I reflash a working rom /system will be overwritten.
I've tried to build pie with this kernel. Nearly the same result.
Click to expand...
Click to collapse
Weird, I ran into some issues building pie yesterday, but didn't have any time to fix it. I'll try again tonight and see how it goes. If I still have issues, I'll have to wait till the weekend.
Joel16 said:
Weird, I ran into some issues building pie yesterday
Click to expand...
Click to collapse
I'm sorry; I should have tell you about that... :angel:
I changed a lot of things to compile it successfully. Here are my changes (I hope this list is complete):
.bashrc:
Code:
export CPU_SSE42=false
to avoid crashes in hiddenapi and profman
device/sony/kitakami-common/SonyOtgSwitch/Android.mk:
Code:
LOCAL_SDK_VERSION := current
kernel/sony/msm8994/include/uapi/linux/rmnet_data.h; insert lines 226 to 236 (line 226 changed [a comma at the end of line]):
Code:
RMNET_NETLINK_DEL_VND_TC_FLOW,
/*
* RMNET_NETLINK_NEW_VND_WITH_NAME - Creates a new virtual network
* device node with the specified
* device name
* Args: int32_t node number
* char[] vnd_name - Use as name
* Returns: status code
*/
RMNET_NETLINK_NEW_VND_WITH_NAME
bionic/libc/include/bits/fortify/fcntl.h; insert lines 33 to 36:
Code:
#ifndef __O_TMPFILE
#define __O_TMPFILE 020000000
#endif
#define O_TMPFILE (__O_TMPFILE | O_DIRECTORY)
hardware/qcom/audio-caf/msm8994/hal/audio_hw.c; line 2457:
Code:
ALOGE("%s: error [B]%ld[/B] - %s", __func__, ret, pcm_get_error(out->pcm));
hardware/qcom/audio-caf/msm8994/hal/audio_extn/audio_extn.c; lines 523 and 524:
Code:
void audio_extn_set_parameters(struct audio_device *adev [B]__unused[/B],
struct str_parms *parms [B]__unused[/B])
and line 67:
Code:
static struct audio_extn_module aextnmod [B]__unused[/B] = {
hardware/qcom/display-caf/msm8994/libqdutils/idle_invalidator.cpp; line 127:
Code:
ALOGD_IF(II_DEBUG, "IdleInvalidator::%s Idle Timeout fired len [B]%ld[/B]",
hardware/qcom/display-caf/msm8994/libhdmi/hdmi.cpp: line 196:
Code:
ALOGD("%s: Scan Info string: %s length = [B]%ld[/B]",
and line 320:
Code:
ALOGD_IF(DEBUG, "%s: EDID string: %s length = [B]%ld[/B]",
device/sony/kitakami-common/SonyOtgSwitch/Android.mk: line 5:
Code:
LOCAL_PRIVATE_PLATFORM_APIS := true
Changes in bold
Berni-0815 said:
I'm sorry; I should have tell you about that... :angel:
I changed a lot of things to compile it successfully. Here are my changes (I hope this list is complete):
.bashrc:
Code:
export CPU_SSE42=false
to avoid crashes in hiddenapi and profman
device/sony/kitakami-common/SonyOtgSwitch/Android.mk:
Code:
LOCAL_SDK_VERSION := current
kernel/sony/msm8994/include/uapi/linux/rmnet_data.h; insert lines 226 to 236 (line 226 changed [a comma at the end of line]):
Code:
RMNET_NETLINK_DEL_VND_TC_FLOW,
/*
* RMNET_NETLINK_NEW_VND_WITH_NAME - Creates a new virtual network
* device node with the specified
* device name
* Args: int32_t node number
* char[] vnd_name - Use as name
* Returns: status code
*/
RMNET_NETLINK_NEW_VND_WITH_NAME
bionic/libc/include/bits/fortify/fcntl.h; insert lines 33 to 36:
Code:
#ifndef __O_TMPFILE
#define __O_TMPFILE 020000000
#endif
#define O_TMPFILE (__O_TMPFILE | O_DIRECTORY)
hardware/qcom/audio-caf/msm8994/hal/audio_hw.c; line 2457:
Code:
ALOGE("%s: error [B]%ld[/B] - %s", __func__, ret, pcm_get_error(out->pcm));
hardware/qcom/audio-caf/msm8994/hal/audio_extn/audio_extn.c; lines 523 and 524:
Code:
void audio_extn_set_parameters(struct audio_device *adev [B]__unused[/B],
struct str_parms *parms [B]__unused[/B])
and line 67:
Code:
static struct audio_extn_module aextnmod [B]__unused[/B] = {
hardware/qcom/display-caf/msm8994/libqdutils/idle_invalidator.cpp; line 127:
Code:
ALOGD_IF(II_DEBUG, "IdleInvalidator::%s Idle Timeout fired len [B]%ld[/B]",
hardware/qcom/display-caf/msm8994/libhdmi/hdmi.cpp: line 196:
Code:
ALOGD("%s: Scan Info string: %s length = [B]%ld[/B]",
and line 320:
Code:
ALOGD_IF(DEBUG, "%s: EDID string: %s length = [B]%ld[/B]",
device/sony/kitakami-common/SonyOtgSwitch/Android.mk: line 5:
Code:
LOCAL_PRIVATE_PLATFORM_APIS := true
Changes in bold
Click to expand...
Click to collapse
Yup I made those changes except for
Code:
export CPU_SSE42=false
I did not get any issues building but the device does bootloop. I'm gonna see if we can try and pull any sort of logs to see what's causing the issue.
Joel16 said:
Yup I made those changes except for
Code:
export CPU_SSE42=false
I did not get any issues building
Click to expand...
Click to collapse
That seems to be a problem with my cpu. The mentioned line is a cpu instruction. While trying to build this rom on my pc I ran into errors.
but the device does bootloop. I'm gonna see if we can try and pull any sort of logs to see what's causing the issue.
Click to expand...
Click to collapse
Maybe it's possible to backup the system onto a sd-card with an actual twrp and analyse these files?
Berni-0815 said:
That seems to be a problem with my cpu. The mentioned line is a cpu instruction. While trying to build this rom on my pc I ran into errors.
Maybe it's possible to backup the system onto a sd-card with an actual twrp and analyse these files?
Click to expand...
Click to collapse
I'm not entirely sure how it works, but I have heard people talking about pulling logs form bootloops. I mean there has to be a way to debug a bootloop, I highly doubt people just blindly fix them. Perhaps we can access last kernel message or logcat, someway. I'm going to try this weekend and see what I can come up with.
You can do It!!!
Joel16 said:
I'm not entirely sure how it works, but I have heard people talking about pulling logs form bootloops. I mean there has to be a way to debug a bootloop, I highly doubt people just blindly fix them. Perhaps we can access last kernel message or logcat, someway. I'm going to try this weekend and see what I can come up with.
Click to expand...
Click to collapse
Berni-0815 said:
That seems to be a problem with my cpu. The mentioned line is a cpu instruction. While trying to build this rom on my pc I ran into errors.
Maybe it's possible to backup the system onto a sd-card with an actual twrp and analyse these files?
Click to expand...
Click to collapse
What is about adbd, see here:
https://forum.xda-developers.com/showpost.php?p=67386761&postcount=13
The z5c is based on Qualcomm Snapdragon 810 MSM8994, like:
SONY XPERIA Z5 PREMIUM | MOTOROLA DROID TURBO | MICROSOFT LUMIA 950 XL | NUBIA Z9 MAX
Is there any source of a pie build availible where we can get some hints how get a pie build to run?
Here are some kernel sources from the Nubia Z9 Max (nx510j):
https://github.com/nubia-development/android_kernel_nubia_msm8994
I_did_it_just_tmrrow said:
What is about adbd, see here:
https://forum.xda-developers.com/showpost.php?p=67386761&postcount=13
Click to expand...
Click to collapse
I'll have a look at this. :good:
Joel16 said:
Have you tried looking at any sort of logs, kernel logs? (I'm not sure if there would be one in the first place) It would be better to try by increments (PIE first with https://github.com/joel16/android_kernel_sony_msm8994). I might give it a try this weekend just for the sake of it.
Click to expand...
Click to collapse
For my self I try slowly become deeper into that topic: building a rom.
So I did a little bit of research in github and gitlab and I found some interesting repos from this user:
https://github.com/Cyborg2017?tab=repositories
I ask him if he could help us a little bit and the first result is this.
@Joel16 & @Berni-0815 Perhaps this is useful:
https://github.com/Cyborg2017/android_kernel_sony_msm8994/tree/sony_msm8994_p-upstream
I hope it help us to come closer to an LineageOS 17 for suzuran.
I_did_it_just_tmrrow said:
I ask him if he could help us a little bit and the first result is this.
Click to expand...
Click to collapse
Error 404
A little time later: I think, you're talking about this kernel?
---------- Post added at 16:22 ---------- Previous post was at 16:03 ----------
I_did_it_just_tmrrow said:
What is about adbd, see here:
https://forum.xda-developers.com/showpost.php?p=67386761&postcount=13
Click to expand...
Click to collapse
Tried the mentioned tip in the 2nd post of this that thread without any success. I'm so sorry.
How can I include adbd into my build? I'll give it a try...
Berni-0815 said:
Error 404
A little time later: I think, you're talking about this kernel?
---------- Post added at 16:22 ---------- Previous post was at 16:03 ----------
Tried the mentioned tip in the 2nd post of this that thread without any success. I'm so sorry.
How can I include adbd into my build? I'll give it a try...
Click to expand...
Click to collapse
Yep, just try his source. He told that it could be useful to test this kernel with building twrp first.
To the logging problem. I understand that right that you have nothing in:
Code:
/proc/last_kmsg
Nor in:
Code:
/sys/fs/pstore/console-ramoops
and you check this with the twrp terminal?
You should take a look at this:
https://android.stackexchange.com/questions/213336/how-can-i-enable-last-kmsg
I_did_it_just_tmrrow said:
Yep, just try his source.
Click to expand...
Click to collapse
I'm actually building a rom with that kernel. I'll see later if it's working.
To the logging problem. I understand that right that you have nothing in:
Code:
/proc/last_kmsg
Nor in:
Code:
/sys/fs/pstore/console-ramoops
and you check this with the twrp terminal?
Click to expand...
Click to collapse
Right
You should take a look at this:
https://android.stackexchange.com/questions/213336/how-can-i-enable-last-kmsg
Click to expand...
Click to collapse
Ah! Nice. I'll try it later. Thank you very much! :good:
Berni-0815 said:
I'm actually building a rom with that kernel. I'll see later if it's working.
Right
Ah! Nice. I'll try it later. Thank you very much! :good:
Click to expand...
Click to collapse
Let me know how it goes, I'm more than certain kernel is what's preventing us from getting Pie/Q to boot up.