Database Develop

Backporting MDSS doze mode for full ambient display support

Hi!
Our hammerhead currently lacks full support for ambient display in Android L. One+1 has the kernel changes we need already merged(https://github.com/CyanogenMod/andr...mmit/735f665d2f5dd350b92cffae26517ed494760b5f). I checked this patch before - it's not a match to our source, it needs some more merges in video drivers. I was just wondering if anyone on XDA tried to get this working and wanted to share progress and experiences with doze mode on 3.4 msm kernel?
Mike

mikegapinski said:
Hi!
Our hammerhead currently lacks full support for ambient display in Android L. One+1 has the kernel changes we need already merged(https://github.com/CyanogenMod/andr...mmit/735f665d2f5dd350b92cffae26517ed494760b5f). I checked this patch before - it's not a match to our source, it needs some more merges in video drivers. I was just wondering if anyone on XDA tried to get this working and wanted to share progress and experiences with doze mode on 3.4 msm kernel?
Mike
Click to expand...
Click to collapse
but does our panel really supports that mode?, i remember people thinkering with the digitizer to get the double tap to wake like on the g2 (Without bat drain) and they got nowhere

The panel itself works fine, we are missing one feature only - enabling ambient display afer device is picked up, it needs to be ported to our kernel and sensors hal I guess.

We have a IPS LCD display, using Ambient display will suck a lot of battery juice :/

DJBhardwaj said:
We have a IPS LCD display, using Ambient display will suck a lot of battery juice :/
Click to expand...
Click to collapse
IPS doesn't mean its gonna suck battery. Nokia did it on IPS before.
http://allaboutwindowsphone.com/features/item/18191_Nokia_works_a_LCD_miracle-Glan.php
The topic to be discussed here anyway isn't the screen type or its flaws. It is to get sensors to be able to wake the device with ambient display enabled.

akash3656 said:
IPS doesn't mean its gonna suck battery. Nokia did it on IPS before.
http://allaboutwindowsphone.com/features/item/18191_Nokia_works_a_LCD_miracle-Glan.php
The topic to be discussed here anyway isn't the screen type or its flaws. It is to get sensors to be able to wake the device with ambient display enabled.
Click to expand...
Click to collapse
Everyone's got their choice. I had my opinion laid.

how about applying the patch to cm kernel instead of stock, since it uses updated video drivers and such? is a no-go still?

opssemnik said:
how about applying the patch to cm kernel instead of stock, since it uses updated video drivers and such? is a no-go still?
Click to expand...
Click to collapse
It's included in CM12-CAF build, however we still don't have support for waking the screen after the device is picked up.

mikegapinski said:
It's included in CM12-CAF build, however we still don't have support for waking the screen after the device is picked up.
Click to expand...
Click to collapse
If I recall we had the option on some custom roms (4.4.4) to wake the screen when the device was picked up. I think it used the proximity sensor to detect when the device was picked up.
edit- I apologize, I just realized that this was for developers only.

@mikegapinski Any progress on this or is it abandoned? I'm really looking forward to using full ambient display on hammerhead if it's even possible.
Thanks!

You'd need over 750 patches in the graphics subsystem of the kernel before you can start applying relevant doze patches. Plus updated gpu kernel drivers etc etc
We'll have this on an additional nightly CM12 build eventually and it works pretty good. The only drawbacks at the moment are the situation where sometimes the pick-up sensor is triggered and enables the short wake-up effect; this is because we use a sensor blob from bacon. Then, in order to have a reliable pick-up, that always works, I abused the tilt sensor with some fixed parameters, which is wakeup capable. This however leads to a tad too long timespan from actual pick-up to showing the message on the display.
Whatever, take it or leave it.

myfluxi said:
You'd need over 750 patches in the graphics subsystem of the kernel before you can start applying relevant doze patches. Plus updated gpu kernel drivers etc etc
We'll have this on an additional nightly CM12 build eventually and it works pretty good. The only drawbacks at the moment are the situation where sometimes the pick-up sensor is triggered and enables the short wake-up effect; this is because we use a sensor blob from bacon. Then, in order to have a reliable pick-up, that always works, I abused the tilt sensor with some fixed parameters, which is wakeup capable. This however leads to a tad too long timespan from actual pick-up to showing the message on the display.
Whatever, take it or leave it.
Click to expand...
Click to collapse
Is this available fully implemented in any build?
Sent from my Nexus 5 using Tapatalk

akash3656 said:
IPS doesn't mean its gonna suck battery. Nokia did it on IPS before.
http://allaboutwindowsphone.com/features/item/18191_Nokia_works_a_LCD_miracle-Glan.php
The topic to be discussed here anyway isn't the screen type or its flaws. It is to get sensors to be able to wake the device with ambient display enabled.
Click to expand...
Click to collapse
Sorry for reviving this thread, but it IS about the display type. Not the AMOLED vs. LCD part, but if the display module actually incorporates Display Memory - which is a key in low-power Ambient Display options.
What Nokia/MS did is basically using DM with a simple script that moves the content around. It is low power, and as the phone does not need to be awake, power drainage is lowered even further.
Updates are ran by a background service that collects relevant notifications (the 6 lock screen notifications, the big lock screen info + current date/time), and on the exact minute, updates the DM. It results in a less than 1000ms wakelock, and does not keep the device awake.
I highly doubt that many Android phones would come with Display Memory enabled displays - it is simply not worth it financially, and would be mainly useless. So we cannot really reach the whole Nokia-level low power usage, though we can try.

MemoryController said:
Is this available fully implemented in any build?
Click to expand...
Click to collapse
CM 12.x hammerheadcaf

[FIX] [HELIUM] [HYDROGEN] Video Recording Fix

Here is a fix for the video recording not working. This fix works on my Stock Global ROM for the Helium. It may work on CM13 based roms but there may be bugs. This works on the 64/128gb Chinese Helium and the 32gb Chinese Hydrogen.
Helium:
https://drive.google.com/file/d/0B5I_q70mNuR4Vk1xOXQyZ3pfUkE/view?usp=sharing
Hydrogen:
https://drive.google.com/file/d/0B5I_q70mNuR4ZmlKOGx6Qjlid1k/view?usp=sharing

Thanks for trying. Just reporting... On CM13 third edition hydrogen fix doesn't work.The very first time it recorded video with no sound, then on second attempt it recorded just the first frame and no sound. Reboot doesn't help.

nijel8 said:
Thanks for trying. Just reporting... On CM13 third edition hydrogen fix doesn't work.The very first time it recorded video with no sound, then on second attempt it recorded just the first frame and no sound. Reboot doesn't help.
Click to expand...
Click to collapse
Try it on Resurrection Remix and let me know if it works on there. I don't have a Hydrogen so I can't test. There are also so many more options in Resurrection Remix that I don't even want to use plain CM13.

I try it in 2. Edition of CM13. Video work, but i have no Sound.

Tried it right now. RR V2 : Video works but playback seems to be 4x faster than normal. And no Sound.
I really hope you find the problem. It's simple the best phone I eher had.

I hope too, you can fix this. Big Thanks for your help and work.

Worked once twice in Remix. Now it only captures stills with sounds.

RR Mi Max Pro 128GB
Great job, working a treat - thank you.

I have researched/experimented with the video recording bug and I am pretty sure this is the problem.
That is exactly what happens on CM13 based ROMs on Mi Max. I have replicated it by rebooting with usb connected and recording works... dies after usb disconnect and device wakes from deep sleep. I even did dirty remux of brocken recording on my PC and it proved all video frames were there but with incorrect duration.
So looks like we have to wait and hope Xiaomi to fix the device firmware/kernel? part that causes the deep sleep problem on CM(very unlikely) or release source code.
As you probably know the list of all vendor files pulled from miui to build CM is based on the official CM device tree for Note 3 Pro(kenzo) which has very similar hardware... They even pull many of those files for kenzo from Mi Max miui base( android_device_xiaomi_kenzo/proprietary-files.txt). I compared the camera firmwares for both and it is exactly the same bit-by-bit. And yet kenzo CM13 don't have that problem. So it must be some other firmware part or kernel issue.
Also wondering why as far as I know miui doesn't have that problem using same firmware/kernel!? Must be something in the camera app or framework or something...

nijel8 said:
I have researched/experimented with the video recording bug and I am pretty sure this is the problem.
That is exactly what happens on CM13 based ROMs on Mi Max. I have replicated it by rebooting with usb connected and recording works... dies after usb disconnect and device wakes from deep sleep. I even did dirty remux of brocken recording on my PC and it proved all video frames were there but with incorrect duration.
So looks like we have to wait and hope Xiaomi to fix the device firmware/kernel? part that causes the deep sleep problem on CM(very unlikely) or release source code.
As you probably know the list of all vendor files pulled from miui to build CM is based on the official CM device tree for Note 3 Pro(kenzo) which has very similar hardware... They even pull many of those files for kenzo from Mi Max miui base( android_device_xiaomi_kenzo/proprietary-files.txt). I compared the camera firmwares for both and it is exactly the same bit-by-bit. And yet kenzo CM13 don't have that problem. So it must be some other firmware part or kernel issue.
Also wondering why as far as I know miui doesn't have that problem using same firmware/kernel!? Must be something in the camera app or framework or something...
If I have time I will try to build xposed module to intercept the video and fix the first frame duration as dirty/temporary fix(as explained in the link).
EDIT: Ok... As prove of concept build xposed module for testing. It fixes recorded videos but needs some tuning... The first few audio samples are cut off in the repair process and audio gets out of sync. Have to figure out how to fix that...
Just install the attached apk, enable the module in xposed installer and reboot. That's it. Just record as usual. Works with CM and RR(not tested) build-in Camera apps only(for now...).
Click to expand...
Click to collapse
Seems to work on CM13 (3rd version) on my Hydrogen but only if the recorded videos are saved in internal storage (the camera apps non responsive if saving to sdcard). Thanks for putting this fix out, really appreciated.

cmk7128 said:
Seems to work on CM13 (3rd version) on my Hydrogen but only if the recorded videos are saved in internal storage (the camera apps non responsive if saving to sdcard). Thanks for putting this fix out, really appreciated.
Click to expand...
Click to collapse
I should've not called it a fix, it's just a dirty hack... I still can't find a way to sync audio/video properly. That sdcard problem is probably related to much lower write speeds.

nijel8 said:
I should've not called it a fix, it's just a dirty hack... I still can't find a way to sync audio/video properly. That sdcard problem is probably related to much lower write speeds.
Click to expand...
Click to collapse
Thanks for the explanation. Hopefully there will be a permanent fix to the video recording problem in due course. For now, your hack will come in handy.

Let's get back on-topic here thanks guys...

You may want to look at CPUAwake code. with CPUAwake enabled there is no problem with camera after deep sleep and overnight battery drain is still the same (0-1%). It will be great to make "dirty hack" independent from any app (xposed , cpuawake) as a piece of code (somewhere in boot.img inits?). Thank you. as for "no sound" in my patches/builds(some stock miui audio-related files files) I have no problem with it but in some cameras "mono" should be choosen as an audio source. or it could be only "mono" - never tried them separate.

zelipukin said:
You may want to look at CPUAwake code. with CPUAwake enabled there is no problem with camera after deep sleep and overnight battery drain is still the same (0-1%). It will be great to make "dirty hack" independent from any app (xposed , cpuawake) as a piece of code (somewhere in boot.img inits?). Thank you. as for "no sound" in my patches/builds(some stock miui audio-related files files) I have no problem with it but in some cameras "mono" should be choosen as an audio source. or it could be only "mono" - never tried them separate.
Click to expand...
Click to collapse
Yep, my initial test confirms CPUAwake keeps video recording working after device wake up... Thank you for your discovery:good:
I tried a similar idea initiating wakelock before recording but it didn't work...
Is CPUAwake open source? Can't find any code...

I think if we open the hood (UI) there is a single line that tells to the system something like: "system, dont do this !"
somewhere in smalis. cant find it. even worse - dont understand smalis

zelipukin said:
I think if we open the hood (UI) there is a single line that tells to the system something like: "system, dont do this !"
somewhere in smalis. cant find it. even worse - dont understand smalis
Click to expand...
Click to collapse
I actually examined CPUAwake code and it uses android native wake lock acquire() call so nothing special there. And it doesn't release the wake lock till disabled. Don't like that... Trying to find better solution... We'll see...

Let me know if this fixes video recording on CM based ROMs...
Add these two lines to /system/build.prop:
Code:
media.camera.ts.monotonic=0
#[STRIKE]persist.camera.HAL3.enabled=true[/STRIKE]
... and do full reboot(not just soft). USB disconnected... Test video recording, if it works leave device with screen off for 5 minutes, test recording again. It should work(fixed)...
EDIT: I should've mentioned it will only work if video recording was working for you after fresh reboot but brakes when device wakes up from deep sleep... This means all early CM based ROMs are out... they didn't have any video recording working at all or no sound...
EDIT 2: Second line is not needed. Only first line keeps video recording working after deep sleep...

ajsmsg78 said:
Here is a fix for the video recording not working. This fix works on my Stock Global ROM for the Helium. It may work on CM13 based roms but there may be bugs. This works on the 64/128gb Chinese Helium and the 32gb Chinese Hydrogen.
Helium:
https://drive.google.com/file/d/0B5I_q70mNuR4Vk1xOXQyZ3pfUkE/view?usp=sharing
Hydrogen:
https://drive.google.com/file/d/0B5I_q70mNuR4ZmlKOGx6Qjlid1k/view?usp=sharing
Click to expand...
Click to collapse
Deleted
Found the fix in the rr mods folder
Thanks!

Skalexs said:
Deleted
Found the fix in the rr mods folder
Thanks!
Click to expand...
Click to collapse
Could you please help me with a link to that mode?

lineage os 16

Installed Los 16 on the s5 last night. So far it works flawlessly. Looks like this little phone has another year of life left in it!!!!!!

mojorisin7178 said:
Installed Los 16 on the s5 last night. So far it works flawlessly. Looks like this little phone has another year of life left in it!!!!!!
Click to expand...
Click to collapse
Hi, can I ask what version of TWRP did you use? Thank you.

I'm just using the LOS 16 and works excellent.

mojorisin7178 said:
Installed Los 16 on the s5 last night.........
Click to expand...
Click to collapse
zrockcool said:
Hi, can I ask...........
Click to expand...
Click to collapse
twilightorange said:
I'm just using the LOS 16..........
Click to expand...
Click to collapse
Just an FYI...
The following thread has been used regarding support, guidance and feedback for the Official LineageOS 16.0 klte by Haggertk (the Official Lineage Team Maintainer).
https://forum.xda-developers.com/showthread.php?t=3850840
Good Luck!
~~~~~~~~~~~~~~~
UNLESS asked to do so, PLEASE don't PM me regarding support. Sent using The ClaRetoX Forum App on my Enigma Machine {aenigma = Latin for "Riddle"}.

zrockcool said:
Hi, can I ask what version of TWRP did you use? Thank you.
Click to expand...
Click to collapse
Hi,
It's all in the sgs5 klte subfourm. I am on the latest version.

twilightorange said:
I'm just using the LOS 16 and works excellent.
Click to expand...
Click to collapse
Excellent is about right. It's so much better than Oreo LOS for GS5, which had a lot of bluetooth issues. Performance is amazing for an old 32bit CPU.
edit: I also have LOS16 running on Nexus 7 2013 and it surprised how well it runs for such an old device.

What about the battery life compared to LOS 15.1?

Display "stays black" issue on SM-900F
Hi.
Upgraded my wife's S5 to LOS 16 (from LOS 15.1?) lately and she's still happily using it (thx to all supporters).
I recently got another used SM-900F and though it's battery is a bit drawn out it seemed to have working smoothly while still on Samsung stock ROM.
However since I flashed it to LOS 16 it has some strange behaviour with it's backlight / display.
After some time of inactivity the display goes off, but I can't the display lit again. When pressing the home or power button the LEDs of the "soft" buttons flash, but the display stays black.
But the device is working as I can press the power button and bring "up" the power menu, but as I can't see anything I have to press the "shutdown" option blindly, and yes, the device powers off then.
If I the take off the battery for a while everything seems to be ok again.
But if the device is in that "black" mode even powering it up in "download mode" the display stays dark. So I assume this can't be an issue of LOS!?

Re: Display "stays black" issue on SM-900F
odoll said:
So I assume this can't be an issue of LOS!?
Click to expand...
Click to collapse
It isn't. To be sure I reflashed the latest German Vodafone Samsung Stock 6.0.1 ROM back to the S5. Though everything worked smoothly in the beginning the display started *****ing after a while again. (it's sometimes lightly flashing green for a glimpse of a second)
As I got the impression it maybe related to a thermal problem I left it on a heating's radiator for a while, and yes, display got lit every time I tried. Let it get "cold" again and it starts *****ing ...

odoll said:
I can't the display lit again
Click to expand...
Click to collapse
this is a common failure of (this generation of) samsung's OLEDs
if you use low brightness or are in cold weather a lot, the display will start flickering until brightness is raised
the screen will also fail to turn on sometimes, just turn it off then on again, repeat as needed, sometimes you need to warm up the phone
(edit: i've seen the galaxy logo show up then fade to black on a fresh boot, i've also seen someone on stock have the problem, so it's definitely not software)
recently i read about mouse button failing to click or clicking multiple times, one remedy was cleaning off possible corrosion with isopropyl, so i wonder if this OLED issue is similar (it might be if cold temperature increases the problem, electricity doesnt flow as well, etc)

Hi,
excuse me
sometimes I play midi USB keyboards.
Anyone has tested USB OTG?
Does work well ?
Thks

LineageOS 17.1, Flickering on dark theme

Hi all,
I hope that I'm posting in the right place. I am running Lineage OS 17.1 on a Pixel 4XL and I am experiencing a flickering wherein the background color changes from the darker version to a lighter version and back again. This is especially noticeable with the dark theme and apparently it is a known issue (
https://www.reddit.com/r/Android/comments/hnkmln/_/fxc1l7p
, https://www.androidpolice.com/2020/...option-to-show-refresh-rate-looks-like-fraps/, https://www.androidpolice.com/2020/...option-to-show-refresh-rate-looks-like-fraps/). My problem is that I cannot find any of the 90Hz or "Smooth Refresh" options anymore. But, I know that they were there before I installed LineasOS 17.1. Any help is greatly appreciated.

kbdeamon said:
Hi all,
I hope that I'm posting in the right place. I am running Lineage OS 17.1 on a Pixel 4XL and I am experiencing a flickering wherein the background color changes from the darker version to a lighter version and back again. This is especially noticeable with the dark theme and apparently it is a known issue (
https://www.reddit.com/r/Android/comments/hnkmln/_/fxc1l7p
, https://www.androidpolice.com/2020/...option-to-show-refresh-rate-looks-like-fraps/, https://www.androidpolice.com/2020/...option-to-show-refresh-rate-looks-like-fraps/). My problem is that I cannot find any of the 90Hz or "Smooth Refresh" options anymore. But, I know that they were there before I installed LineasOS 17.1. Any help is greatly appreciated.
Click to expand...
Click to collapse
Do you have developer options enabled? If not, click settings/About Phone, click the very bottom 'build number' 5 times. This will enable dev options.
Also you should post questions in the Q/A but not the dev forums. You will get better help in the Q/A.
Another useful resource is the forum for the specific ROM if you do not get results in Q/A. Where you posted the question is more for development of ROMs, kernels, and such so it's not the best place for the type of question. The mods may move it but they may not.

GROOVYJOSHCLARK said:
Do you have developer options enabled? If not, click settings/About Phone, click the very bottom 'build number' 5 times. This will enable dev options.
Also you should post questions in the Q/A but not the dev forums. You will get better help in the Q/A.
Another useful resource is the forum for the specific ROM if you do not get results in Q/A. Where you posted the question is more for development of ROMs, kernels, and such so it's not the best place for the type of question. The mods may move it but they may not.
Click to expand...
Click to collapse
Hi,
thanks for the help.
I do have Developer Mode enabled. I could not find any refresh rate or smooth display settings. But according to this (www.pcmag.com/news/pixel-4-turns-off-90hz-refre...) it seems like the refresh rate may have something to do with brightness and it seems to be backwards in that turning brightness up above 75 enables 90Hz while turning brightness down below 75 disables 90Hz and sets it to 60. I see the flicker with a brightness below 50. Turning brightness up to 100 seems to make the flicker go away but it is really really bright.

kbdeamon said:
Hi,
thanks for the help.
I do have Developer Mode enabled. I could not find any refresh rate or smooth display settings. But according to this (www.pcmag.com/news/pixel-4-turns-off-90hz-refre...) it seems like the refresh rate may have something to do with brightness and it seems to be backwards in that turning brightness up above 75 enables 90Hz while turning brightness down below 75 disables 90Hz and sets it to 60. I see the flicker with a brightness below 50. Turning brightness up to 100 seems to make the flicker go away but it is really really bright.
Click to expand...
Click to collapse
I'm not directly on LOS at this moment (I'm using PD11), but I have used it a few times and didn't have this issue (or I don't remember having the issue while using it).
A few questions, first did you find and test the refresh rate in dev options, if so, did it help? Second (more of a personal question than anything else) but you noted LOS 17.1, that's Android 10. Why use the older 10 and but not LOS 11 (18.1) now that it's official? I believe LOS 10 is phased out for Android 11 (18.1) so I'd use the latest official LOS (18.1 Android 11). Third, have you enabled force 90 Hz in dev options and tested that outcome? I know some users mentioned they needed to do this to fix random display issues but I am not directly familiar with them (so it's not tested by me personally).

I ran Lineage based on Android 11, never tried the Android 10 version of it, but with Sultan kernel, I didn't have the issue. Currently running PD on Android 11 with Sultan, no issues here as well.
What's the reason you're staying on Android 10? Also, in the display settings, any chance it's called something else instead of smooth display?
Also, it could just be the rom itself. It seems another user had the same issue. https://forum.xda-developers.com/t/low-brightness-flicker-lineageos-stock-too.4197665/

just figured i'd put this here... i posted this back on December 3rd 2020:
Low Brightness Flicker (LineageOS & Stock too?)
Hi, sorry if this was posted before, but with XDA moving to XenForo, search seems messed up, i did several searches and nothing comes up for "flicker" in this whole Pixel 4 XL Forum... Has anyone else dealt with the low brightness screen...
forum.xda-developers.com
Darker app was the only fix i've found that actually worked, i have three pixel 4 XLs now, newest one is running Android 11 / LineageOS 18.1 ... it affects all of them, it's hardware related as you stated above with the refresh rate... that would be a good fix, if you could lock the refresh rate, but i was never able to accomplish that
i have need of miracast in my car now, and Pixel phones still blocking that sucks... might have to find a new model of phone

Question custom rom to (or) permanent fix for the 90hz bug for poco m3 pro

is there one or what? ever since I bought this phone it has not been fixed. I already know the temporary fixes and it's just annoying to keep turning **** off every time it lags.

Update your phone to miui 14. The problem is not fixed completely, but it is better

Wait, what is the issue?

I installed crdroid rom and 90hz mode is fine!
don't know about miui14.

xenon113 said:
I installed crdroid rom and 90hz mode is fine!
don't know about miui14.
Click to expand...
Click to collapse
how fine is it? do you still get the 90hz bug or not at all? I installed Pixel so this problem would be fixed but unfortunately, it's not fixed in it.

As we discussed Here, unfortunately there's no fix, since it maybe a hardware issue, and appears to related with the energy management at processor level or mobile (5g/4g) modem of this processor.

xenon113 said:
I installed crdroid rom and 90hz mode is fine!
don't know about miui14.
Click to expand...
Click to collapse
is a little bt better but not fixed. look at gpu render grafic on developer option. is not good as 60 hz. but is not bad like miui