[Discussion] Open Source, image post-processing algorithm. - OnePlus 3 Guides, News, & Discussion

Keeping the sensor parameters aside, can we expect an open-source take on the post-processing for smartphone cameras? This code can be modified as needed and can be incorporated into custom roms. Thus eliminating the reliance on the OEMs for the updates.
Sent from my ONEPLUS A3003 using Tapatalk

I'm no camera expert, but, doesn't post processing depend on a individual camera module? I think all custom rom developers can contribute together on a particular camera module for the phone (like, for oneplus 3, all custom rom developers for oneplus3 can contribute together on the camera module, which then, they can integrate into their individual roms, as you are suggesting!). But, I've noticed that custom rom developers are less interested in camera of the phones (argument being, if you need professional quality photographs, buy a DSLR, which doesn't make sense to me.) I hope it changes.

Yes you are right. Devs should understand that, we don't expect DSLR level photos but atleast we can expect the quality to be on par with the stock factory rom. That way, migrating to a custom rom wouldn't be that much of a pain.
Sent from my ONEPLUS A3003 using Tapatalk

We have seen OP's over aggressive approach to noise reduction leading to very soft images resulting in a loss of details. If devs could tune down the noise reduction a bit, might give better results.
Sent from my ONEPLUS A3003 using Tapatalk

Hello,
I created a thread where I uploaded some pictures (4 sets). I took them side-by-side using both Official/Stock OxygenOS Camera as well as the Ported OxygenOS Camera. And the original photos were also uploaded.
I am interested in knowing how far (or near/identical) the quality really is (this is not a technical/scientific experiment, but more on just visual inspection of the photos). I am inviting people to participate and let me know what they think by voting in the thread.
Here is the thread: https://forum.xda-developers.com/oneplus-3/how-to/poll-tell-difference-ported-oos-camera-t3574805
I will reveal the answers when the poll closes.

topet2k12001 said:
Hello,
I created a thread where I uploaded some pictures (4 sets). I took them side-by-side using both Official/Stock OxygenOS Camera as well as the Ported OxygenOS Camera. And the original photos were also uploaded.
I am interested in knowing how far (or near/identical) the quality really is (this is not a technical/scientific experiment, but more on just visual inspection of the photos). I am inviting people to participate and let me know what they think by voting in the thread.
Here is the thread: https://forum.xda-developers.com/oneplus-3/how-to/poll-tell-difference-ported-oos-camera-t3574805
I will reveal the answers when the poll closes.
Click to expand...
Click to collapse
Hello, Well, I'am aware of your poll but the problem is I couldn't find any pictures in Gdrive.
Sent from my ONEPLUS A3003 using Tapatalk

navneetsoni11 said:
Hello, Well, I'am aware of your poll but the problem is I couldn't find any pictures in Gdrive.
Sent from my ONEPLUS A3003 using Tapatalk
Click to expand...
Click to collapse
Hi,
Thanks for letting me know. Someone else responded in that thread around 2pm so it looks like the pictures are available for viewing without problems.
When you click the link (from the polling thread), you will see four folders - one folder = 1 Set for comparison. You will need to open the folders to see the pictures.
Here's the link once again: https://drive.google.com/drive/folders/0BxHcXHUSGaDDUXRoVk1WcGhxWWM
Hope you can try it out and try to see the difference. Looking forward to it!

Thanks man, now I can see the pics.
Sent from my ONEPLUS A3003 using Tapatalk

navneetsoni11 said:
Thanks man, now I can see the pics.
Sent from my ONEPLUS A3003 using Tapatalk
Click to expand...
Click to collapse
Great to hear. If you have the time, please try to vote and comment in the thread: https://forum.xda-developers.com/oneplus-3/how-to/poll-tell-difference-ported-oos-camera-t3574805
...so that I can add your vote.

navneetsoni11 said:
Yes you are right. Devs should understand that, we don't expect DSLR level photos but atleast we can expect the quality to be on par with the stock factory rom. That way, migrating to a custom rom wouldn't be that much of a pain.
Sent from my ONEPLUS A3003 using Tapatalk
Click to expand...
Click to collapse
That makes no sense what's so ever. This is the difference between closed sourced and open sourced drivers and such. You can't expect the same quality from devs that do this for free without the use of documentation from the camera maker, to companies that can spend millions in developing camera software.
This is something you have to weigh. Understand the trade off. There is a price to pay for being on open source software and sometimes it is more then people are willing to pay. Which is OK.

topet2k12001 said:
Great to hear. If you have the time, please try to vote and comment in the thread: https://forum.xda-developers.com/oneplus-3/how-to/poll-tell-difference-ported-oos-camera-t3574805
...so that I can add your vote.
Click to expand...
Click to collapse
I did cast my vote, however it was challenging to find which was shot with stock or port. Therefore you should add a "Can't tell" option (just a suggestion).
Sent from my ONEPLUS A3003 using Tapatalk

navneetsoni11 said:
I did cast my vote, however it was challenging to find which was shot with stock or port. Therefore you should add a "Can't tell" option (just a suggestion).
Sent from my ONEPLUS A3003 using Tapatalk
Click to expand...
Click to collapse
Thanks for casting your vote, @navneetsoni11.
I realized too late that XDA's polling system allows for only a single vote, and the only way to edit it would be to make a request to a Forum Moderator. Also the poll is about to end on the 17th. I'll assess if it will still be feasible to have it added.

Related

Improved performance with "Performance Booster"

I have LG Optimus 4X HD since 2012. It was good until I upgraded to JB 4.1.2 (official). Severe battery drain, game lags, heating etc forced me to install custom ROMs. First tried CM, better than stock but not as good as I wanted; then tried MIUI V5, much better than both stock & CM. Never tried custom kernels though. I even tried other Chinese ROMs (based on stock) to see if better. Battery, UI etc were more than satisfactory with MIUI but lags in games and sometimes hanging while opening apps were still frustrating. Then one day I saw "Performance Booster" somewhere & gave a try with free version first. It drastically changed the performance then I installed donate version which improved overall experience. As mentioned in the app it didn't improve benchmarks but improved phones performance for sure. In other words, it saved my money from buying a new phone. Now I don't need new one as I have 'Huawei Mediapad X1' for reading, games & watching videos, which I bought here in China for less than 300$ (it's 400 Euros outside China).
So what is it? I don't try to be rude, but at least you can share where we can find it or something. I know Google it's a good friend but I don't know what exactly. BTW thanks for share your experience
Sent from my LG-P880 using XDA Premium 4 mobile app
josue270193 said:
So what is it? I don't try to be rude, but at least you can share where we can find it or something. I know Google it's a good friend but I don't know what exactly. BTW thanks for share your experience
Sent from my LG-P880 using XDA Premium 4 mobile app
Click to expand...
Click to collapse
I think it's not allowed to post links to apps here in this forum so didn't post. You can search in play store, it's there, give a try & see yourself.
{fd}ware said:
I don't think that it's forbidden to post links, as long as you don't earn money by doing so (for example adfly links). But I'm not absolutely sure.
I've also searched the app on the Play Store, couldn't find any app called "Performance Booster" though.
Gesendet von meinem GT-I9505 mit Tapatalk
Click to expand...
Click to collapse
Im guessing hes talking about this: https://play.google.com/store/apps/details?id=com.gejos.android.performancebooster Which i would highly recommend not using.
This is from the description:
Performance Booster will change the kernel process for managing all layers such Android Runtime in Core Libraries and Dalvik VM layers, User Libraries layer, Application Framework layer, and Applications layer.
Click to expand...
Click to collapse
This is gibberish, makes no sense. And thats the best description they give of what it does. All of this *developers* apps look fake and possibly/ quite likely are malicious in nature. All their apps are 86K in size
I have tested by curiosity, and my conclusion is "I haven't seen any clear effect"
So... immediately uninstalled
Sent from my LG-P880 using xda app-developers app
JoinTheRealms said:
This is gibberish, makes no sense. And thats the best description they give of what it does. All of this *developers* apps look fake and possibly/ quite likely are malicious in nature. All their apps are 86K in size
Click to expand...
Click to collapse
Got curious and decompiled the apk. Most of the stuff is license checking. Otherwise it sets a few process management properties and that's all.
Adam77Root said:
Got curious and decompiled the apk. Most of the stuff is license checking. Otherwise it sets a few process management properties and that's all.
Click to expand...
Click to collapse
So generally speaking, pretty useless eh?
MidnightDevil said:
So generally speaking, pretty useless eh?
Click to expand...
Click to collapse
Mostly yeah, which is why this thread is finally being moved into general section (where all shares are supposed to go into) as well as closed.

120FPS Slow Motion Video

This may be an inappropriate place to start this thread but I assumed it to apply to development nonetheless so I understand if it must be relocated.
That being said, about the ONE feature the Nexus 6 lacks that made me envy the latest LG, Samsung, or Apple phone is the ability to record in slow motion at a minimum of 120 FPS at 720p. I've looked into this briefly and it appears that the sensor hardware of the Nexus 6 could easily achieve 120 FPS recording if there were software to allow it. I've also read (but NOT verified) that Android 5.0 includes new camera API's specifically for slow motion recording but it isn't enabled in stock Lollipop on the Nexus 6.
I'm new completely to developing for Android and I'm a novice developer in general at that, however, I really want to enable this awesome feature on our otherwise awesome and superior phones both for myself and for the community that's done so much for me over the years.
Before I venture on understanding and hopefully finding a solution to this, is there any more immediate progress or advice anyone else has made on this particular issue or any explanation of the alleged slow motion camera API's in 5.0?
I'm sure it's coming down the road....
A lot of good things ahead my friend, patience is the key
This alone has me interested in learning how to modify apk's. Lots left to learn, can't seem to do anything with any files i've extracted from the Google Camera APK. They're
all tied up in containers I am unable to make use of without my linux machine.
Check this out. https://github.com/PkmX/lcamera. It is FOSS so you can even help out.
Sent from my Nexus 6 using Tapatalk
Good things come to those who wait... And buy nexus.
Sent from my Nexus 6 using XDA Free mobile app
Relocation
Hello,
The reason I've moved this thread over to the Q&A section is because as of right now it doesn't contain any real developer-related information. (no offense intended) Please have a look at this thread to see what kind of threads should belong in the developer section.
Good luck developing!
B1nny
Forum moderator
I've used framelapse to create timelapse videos. but i am still seeking a good slow motion video solution for the Nexus6
similar thread already here >
http://forum.xda-developers.com/nexus-6/help/slow-motion-video-t2913021
B1nny said:
Hello,
The reason I've moved this thread over to the Q&A section is because as of right now it doesn't contain any real developer-related information. (no offense intended) Please have a look at this thread to see what kind of threads should belong in the developer section.
Good luck developing!
B1nny
Forum moderator
Click to expand...
Click to collapse
No offense taken at all. I expected such. Maybe one day I'll make it to the big leagues! Lol.
Robert_W said:
similar thread already here >
http://forum.xda-developers.com/nexus-6/help/slow-motion-video-t2913021
Click to expand...
Click to collapse
Thanks for that reference.
daftlush said:
Check this out. https://github.com/PkmX/lcamera. It is FOSS so you can even help out.
Sent from my Nexus 6 using Tapatalk
Click to expand...
Click to collapse
I've been following that recently as well. There seems to be a whole lot already there as a ground work for slow motion recording. It's almost like Motorola intended to originally include it, like with the fingerprint sensor libraries that were removed after they decided not to include biometric hardware... Except, I'm confident now that the sensor in our Nexus 6 can handle 120FPS if instructed to.

In display fingerprint scanner 6T vs Mate 20 Pro

I made this video
I prefer the mate 20 pro implementation.
What do you guys think?
I have listed few genuine concerns.
MOD EDIT: LINK REMOVED
Sent from my LYA-L29 using Tapatalk
ayaskant12 said:
I made this video
I prefer the mate 20 pro implementation.
What do you guys think?
I have listed few genuine concerns.
MOD EDIT: LINK REMOVED
Click to expand...
Click to collapse
I prefer 1+ 6T but thanks for the video?
spjetrovic said:
I prefer 1+ 6T but thanks for the video[emoji12]
Click to expand...
Click to collapse
I am not saying its bad but a reliable face unlock would have been better with this 1st gen tech.
basically i like both but on comparison i like mate 20 Pro slightly better
Sent from my LYA-L29 using Tapatalk
Bias aside, the Mate 20 Pro's implementation is much better. Also seems and looks faster tbh
rootmaster96 said:
Bias aside, the Mate 20 Pro's implementation is much better. Also seems and looks faster tbh
Click to expand...
Click to collapse
thank you
Sent from my LYA-L29 using Tapatalk
rootmaster96 said:
Bias aside, the Mate 20 Pro's implementation is much better. Also seems and looks faster tbh
Click to expand...
Click to collapse
I agree as far as implementation may be better . but 6T was the first to have it! keeping that in mind as far as the speed that you mentioned it's the way he recorded the video if you watched it
spjetrovic said:
I agree as far as implementation may be better . but 6T was the first to have it! keeping that in mind as far as the speed that you mentioned it's the way he recorded the video if you watched it
Click to expand...
Click to collapse
Actually Hauwei had it first. Unless you are talking about oppo.
huawei mate rs porsche and vivo nex were first to use the in display scanner.
speed feels faster in 6t because no pressure is needed but mate 20 needs pressure to be applied
Sent from my LYA-L29 using Tapatalk
spjetrovic said:
6T was the first to have it!
Click to expand...
Click to collapse
6T was the first to have it in the US only. Definitely not the first when you consider intl. market
when i isaid first in video i didnt mean literally the first to use.
I wanted to mean first gen tech.
Why be the frontrunners in implementing a first gen tech in a low cost VFM device and sacrificing useful functionality
Sent from my LYA-L29 using Tapatalk
I don't use it just don't work for me what is a shame
jaythenut said:
I don't use it just don't work for me what is a shame
Click to expand...
Click to collapse
you mean the FP scanner on 6T?
Even i didnt like the implementation either.
OnePlus has become greedy.
For US markets thats fine since 500$ smartphone is rare may be.
But with asian context the company is bringing nothing new.
Slow death for sure.
I was a fanboy and now ......
https://youtu.be/P-nrt7PUFVQ
Sent from my LYA-L29 using Tapatalk
ayaskant12 said:
you mean the FP scanner on 6T?
Even i didnt like the implementation either.
OnePlus has become greedy.
For US markets thats fine since 500$ smartphone is rare may be.
But with asian context the company is bringing nothing new.
Slow death for sure.
I was a fanboy and now ......
https://youtu.be/P-nrt7PUFVQ
Sent from my LYA-L29 using Tapatalk
Click to expand...
Click to collapse
Yes mate fp ,works once out of 10 times if at all lol
jaythenut said:
Yes mate fp ,works once out of 10 times if at all lol
Click to expand...
Click to collapse
for me it was ok, not that bad. but I found OnePlus 6 to be much better value after using 6T.
Sent from my LYA-L29 using Tapatalk
ayaskant12 said:
I made this video
I prefer the mate 20 pro implementation.
What do you guys think?
I have listed few genuine concerns.
MOD EDIT: LINK REMOVED
Sent from my LYA-L29 using Tapatalk
Click to expand...
Click to collapse
I have deleted your YouTube link. Here's why: Posting to direct users to your YouTube videos or YouTube channel is not allowed. Per the forum rules:
Self-promotion is forbidden, this includes blogs, social media and video channels etc. Random links will be removed.
Click to expand...
Click to collapse
You may include a video to supplement meaningful written content in a post, but posting to say "Hey, I made a video" is not allowed.
the Doctor said:
I have deleted your YouTube link. Here's why: Posting to direct users to your YouTube videos or YouTube channel is not allowed. Per the forum rules:
You may include a video to supplement meaningful written content in a post, but posting to say "Hey, I made a video" is not allowed.
Click to expand...
Click to collapse
Thanks
Sent from my LYA-L29 using Tapatalk
ayaskant12 said:
Thanks
Sent from my LYA-L29 using Tapatalk
Click to expand...
Click to collapse
I checked further and both fingerprint and face unlock work simultaneously even when screen is off. once u start pressing on scanner!!
But atleast huawei doesn't cheat in that respect and informs on lockscreen that it was unlocked by face unlock!!
Sent from my LYA-L29 using Tapatalk

Magisk Manager Redesign

Okay, here we go...
Hey!
After about a month of endless cycle of try & scrap designs I think I'm ready present my redesign of the Magisk Manager. At this point I have covered every main screen that you (user) will come in contact with, now it's time to start implementing (or rather rewriting) code from the old app to the new one.
Don't get me wrong, I'm far away from from done; but! I have a sneak-peek of what's to (hopefully) come - considering John will ultimately accept my pull request, lol.
Rationale:
I'm an android (app) developer by occupation and I use Magisk almost every day. I love my work and everything I do, so I decided to help John with a redesign - so the app is less generic and additions (as far as features go) are easier to implement with less of a boilerplate. I have no idea if anybody would even care about the redesign so I would love to hear your thoughts!
At work I'm kinda more appreciated as a developer than a designer so I was never actually allowed to design any production app.
Structure:
The apk is work of about 10 days and roughly 40 commits.
It's mainly written in Kotlin (yey!) with a help from databinding, which makes everything much cleaner.
On top of that I use a "framework" which is actually more of a anti-boilerplate collection of libraries (jetpack wrapper) for all Android stuff - such as activites, fragments, viewmodels and interaction between them. (Can't post links since >that's whatchu get for mainly using reddit< I guess.) Nevertheless bye bye recyclerview and viewpager adapters, bye bye littering code with animations and other UI stuff.
Warning:
Few of my friends reported that the app is marked as malicious by Google Play Protect, maybe because it contains johns original package name + "debug". I know what it looks like, new user, no posts, malicious app warning. Meh. It's not, build it from source, inspect it on GitHub if you don't trust me.
Also it contains Manifest permission for connecting to the internet - this is not implemented yet and does not connect to anything. Everything you see is offline mock data or your own installed apps. Again, inspect source if you don't trust me.
It might crash on APIs<21 due to some unresolved xml setters and usage of vector resources. I'll fix that once everything else is done, don't mind that.
Some visual bugs might occur, refrain from reporting it please.
This is just a preview. DESIGN PROTOTYPE
Screenshots:
https://imgur.com/a/BRd40cg
Download:
NO DOWNLOAD. Already working on a official manager. Stay tuned.
Source:
https://github.com/diareuse/magisk
So what now?
Well, tell me how you like it!
What really bothers you in the new redesign that could be changed for the better?
What do you really like?
And yeah! almost forgot. I was wondering if redoing preferences would be better or worse. Do you prefer standard (support library-based) or entirely custom (with the super fancy dialog ripped from Android Q that you can preview while selecting Dark Mode in settings)?
I really like the redesign of the app. You should definitely get in touch with the Magisk dev to take it up a notch and implement it in the official app.
Sent from my ONEPLUS A3003 using Tapatalk
CrashOverride1995 said:
I really like the redesign of the app. You should definitely get in touch with the Magisk dev to take it up a notch and implement it in the official app.
Sent from my ONEPLUS A3003 using Tapatalk
Click to expand...
Click to collapse
Thanks I appreciate that!
I was trying to but he seems to successfully ignore all of my PMs here or on Reddit. I can only imagine how much spam is he getting so I don't blame him
diareuse said:
Thanks I appreciate that!
I was trying to but he seems to successfully ignore all of my PMs here or on Reddit. I can only imagine how much spam is he getting so I don't blame him
Click to expand...
Click to collapse
Try to use Twitter, he seems active there.
Sent from my ONEPLUS A3003 using Tapatalk
Nice work:good:
How does this work when it comes to hiding MM?
hshah said:
How does this work when it comes to hiding MM?
Click to expand...
Click to collapse
The whole app does not work yet see OP. This is just a design prototype.
Hiding will be probably somewhat tricky, I have no idea how will the new code features reflect in john's hiding mechanism.
Check PM mate, sent the code for your download to be a word link :good:
Honestly I feel in love with the design. I think John should adopt the design. You and John together can make some more modifications and bring this design (or improved) into official versions. Nice work bro, highly appreciate it.
Looks really nice, very in keeping with the new oneui. The newest official is really dated looking with too much advertising. Looks like a dang NASCAR lol I themed 6.0.0 for myself and just used that apk since pure black or pure white
Hi i just install the app on my rooted pixel 1gen running android Q i like the design but i dont know why i cant see the modules and should i uninstall the original magisk app ?
diareuse said:
The whole app does not work yet see OP. This is just a design prototype.
Hiding will be probably somewhat tricky, I have no idea how will the new code features reflect in john's hiding mechanism.
Click to expand...
Click to collapse
I know @topjohnwu doesn't really enjoy the app development part of Magisk, so having someone improve on it is likely gonna be appreciated. But, you absolutely have to make sure that you do not break features like hiding the Manager... That is a key feature that has taken a lot of work to implement and has to work.
Kurtlestat said:
Looks really nice, very in keeping with the new oneui. The newest official is really dated looking with too much advertising. Looks like a dang NASCAR lol I themed 6.0.0 for myself and just used that apk since pure black or pure white
Click to expand...
Click to collapse
Wait, what? Advertising? There's no advertising in the Magisk Manager...
Didgeridoohan said:
Wait, what? Advertising? There's no advertising in the Magisk Manager...
Click to expand...
Click to collapse
Sorry I just meant the links etc on the home page.
I use adaway and haven't seen an advert in years ?? this is my effort on v6.0.0 (pic) no previous experience in android at all, so not too bad ?
ParadoxTheDevil said:
Honestly I feel in love with the design. I think John should adopt the design. You and John together can make some more modifications and bring this design (or improved) into official versions. Nice work bro, highly appreciate it.
Click to expand...
Click to collapse
I think "should adopt" sounds like you'd force him to do so. That's not what I'm trying to do though I can only propose and it's completely up to him whether he accepts it or nah.
Didgeridoohan said:
I know @topjohnwu doesn't really enjoy the app development part of Magisk, so having someone improve on it is likely gonna be appreciated. But, you absolutely have to make sure that you do not break features like hiding the Manager... That is a key feature that has taken a lot of work to implement and has to work.
Click to expand...
Click to collapse
As far as I can tell, the hiding mechanism relies only on renaming package name within the system so the app should be just fine. Reflection that is used within my version will probably not be touched.
But I'd be sad to scrap the whole work if the hiding does not work - nevertheless if it pulls through with the community (and it seems like it) I'll make my absolute best to make the transition as seamless as possible. That's why I created separate module which can be built alongside the current version for (hopefully short) transition period.
My intention is of course not to break sh*t, but to improve on design and functionality of current app. Would be really d*ck move to do otherwise, I think.
I just did this in art app, changed the green header/footer colours to black and white and put radio buttons instead of checkbox. The colour scheme looks a little more like the oneui. You could maybe get a hex colour picker and get the proper colours and do it more professionally. Keep up the awesome work by the way.
Omg this is fancy as f**k
If this would also allow us to use AROMA like on flashfire am i totally in! Great Redesign!
Oh damn, this is beautiful redesign! I love it very much.
Kurtlestat said:
Looks really nice, very in keeping with the new oneui. The newest official is really dated looking with too much advertising. Looks like a dang NASCAR lol I themed 6.0.0 for myself and just used that apk since pure black or pure white
Click to expand...
Click to collapse
Advertising? Everything there is needed for functions.
madbat99 said:
Advertising? Everything there is needed for functions.
Click to expand...
Click to collapse
I would guess he's probably taking about the social media links at the bottom of the main screen. Which are not actually advertising anything but linking places to access support and updates.

Question Can the Pixel 7 shoot full unbinned 50mp in any manner? maybe with mod

Was curious of anyone knew if the Pixel 7 can shoot unbinned full resolution in any way?
I have read that the main sensor in this is the same as the Pixel 7 Pro, which is the Samsung GN1, and that technically the hardware is capable of unbinned shooting, kind of like the Sony IMX586 or similar is capable.
Usually when there is a way to shoot unbinned with these kind of sensors it is done by way of first properly rooted device, then custom mod and installed via Magisk + the right GCAM port + maybe a custom XML file.
Just wondering of anyone figured out a way to do it the Pixel 7 main or even Pixel 7
Thanks.
Interesting if it is possible; waiting for senior members replies!
This would be awesome
wrkadung said:
Interesting if it is possible; waiting for senior members replies!
Click to expand...
Click to collapse
thesm4rt1 said:
This would be awesome
Click to expand...
Click to collapse
If serious, we should consider starting a bounty thread...

Categories

Resources