Related
This module doubles the number of steps in volume adjustment for both media and in-call volume.
WARNING: Apparently doesn't work on all devices, for example OnePlus 3 according to this.
what about a collection thread for build prop tweaks to use in Magisk?
Thanks for the module. It's got a funny bump going louder until the middle of the scale, then getting suddenly significantly quieter again and going louder until the end, for media playback.
Bettik said:
Thanks for the module. It's got a funny bump going louder until the middle of the scale, then getting suddenly significantly quieter again and going louder until the end, for media playback.
Click to expand...
Click to collapse
Could be hardware/driver-dependant. I've used a (non-systemized) prop modification before on a tablet and it was pretty smooth.
time comes, good modules too :good:
Just a reminder for those who encounter problems. ro.config.vc_call_vol_steps=14
ro.config.media_vol_steps=30 won't work for all devices, such as OnePlus 3, at least on its official OxygenOS.
Once you change your media volume steps from default 15 to the 30, using the script above which is included in the module, on your OnePlus 3. The steps are increased, while it's just a loop. The volume drop back to the lowest again at the 16th step and totally silent at some steps bigger than 20.
BTW, the xposed module VolumeSteps+ won't work on OnePlus 3 either.
accidentally quoted OP instead of editing it.
changes couldn't be reseted after removing the system.prop or the module. Any thing to do?
chjun90 said:
changes couldn't be reseted after removing the system.prop or the module. Any thing to do?
Click to expand...
Click to collapse
Remove module, reboot. When asking for help, provide logs.
stangri said:
Remove module, reboot. When asking for help, provide logs.
Click to expand...
Click to collapse
i do that many times. i have removed the module days ago, but the chages still on my phone. i found the bug in all the modules with system.prop not only yours. thinking it's bugs of magisk v11.1.
chjun90 said:
i do that many times. i have removed the module days ago, but the chages still on my phone. i found the bug in all the modules with system.prop not only yours. thinking it's bugs of magisk v11.1.
Click to expand...
Click to collapse
Would be great if you had created an issue against Magisk on github then. Probably uninstalling magisk (from recovery) and re-installing it would start you with a clean slate.
Alternatively, there're unofficial builds of the next-gen magisk available, maybe they would fix the issue.
stangri said:
Would be great if you had created an issue against Magisk on github then. Probably uninstalling magisk (from recovery) and re-installing it would start you with a clean slate.
Alternatively, there're unofficial builds of the next-gen magisk available, maybe they would fix the issue.
Click to expand...
Click to collapse
i had
Is it compatible with the latest 11.6 magisk? Anyone tested?
Angelos N. said:
Is it compatible with the latest 11.6 magisk? Anyone tested?
Click to expand...
Click to collapse
11.0.0 version is and I have.
Angelos N. said:
Is it compatible with the latest 11.6 magisk? Anyone tested?
Click to expand...
Click to collapse
Causes systemui FC.
This is because of system.prop. I had this same issue when changing.
To 11.6.
ahrion said:
Causes systemui FC.
Click to expand...
Click to collapse
As evident from the screenshots below it works fine.
Care to post link to the github issue where 11.6 has broken system.prop support?
stangri said:
As evident from the screenshots below it works fine.
Care to post link to the github issue where 11.6 has broken system.prop support?
Click to expand...
Click to collapse
I had the same issue with my mods, removing system.prop fixed this issues. 11.6 broke resetprop for certain people. I don't see any issues on the GitHub for magisk, but I know this is an issue because me on my own mods and others have reported this same issue. I've tested it and that's what I have found.
It doesn't happen to all phones but I think it's a magisk issue with resetprop, something that was not an issue in 11.5.
ahrion said:
I had the same issue with my mods, removing system.prop fixed this issues. 11.6 broke resetprop for certain people. I don't see any issues on the GitHub for magisk, but I know this is an issue because me on my own mods and others have reported this same issue. I've tested it and that's what I have found.
It doesn't happen to all phones but I think it's a magisk issue with resetprop, something that was not an issue in 11.5.
Click to expand...
Click to collapse
I think you're making way to large assumptions here. From my experience, there's no issue with resetprop. This module and many others I've tried and use on v11.6, that utilises system.prop and resetprop work just fine.
Yes, when I tested your module my device wouldn't boot unless I removed the system.prop from the audmodlib. But I don't think that had anything to do with the system.prop itself, but rather what you'd put in it...
Didgeridoohan said:
I think you're making way to large assumptions here. From my experience, there's no issue with resetprop. This module and many others I've tried and use on v11.6, that utilises system.prop and resetprop work just fine.
Yes, when I tested your module my device wouldn't boot unless I removed the system.prop from the audmodlib. But I don't think that had anything to do with the system.prop itself, but rather what you'd put in it...
Click to expand...
Click to collapse
I'm not making assumptions. I'm literally telling you what issues I've experienced with my 9 modules and I'm not the only one It worked before 11.5/11.6 until I removed system.prop, which was the issue. The issue itself was not present before on previous versions. This was happening for me when upgrading to 11.6.
This is a reproduceable issue that was introduced once resetprop changes were introduced in 11.5/11.6 which did not occur before then, with the same exact zips updated to v3 module template. If you check the magisk release notes it CLEARLY states he made changes to resetprop. Which obviously confirms what I'm saying now.
Audmodlib lib has literally nothing in it that would bootloop your device. All it does is copy your system files into its own magisk folder. Nothing else. It makes ZERO edits to those files if you look at the code. The additional mods that edit audmodlib are what make edits to your existing device code.
I was just seeing if we could figure out a solution to this issue and to pinpoint why this is happening.
ahrion said:
I'm not making assumptions. I'm literally telling you what issues I've experienced with my 9 modules and I'm not the only one It worked before 11.5/11.6 until I removed system.prop, which was the issue. The issue itself was not present before on previous versions. This was happening for me when upgrading to 11.6.
This is a reproduceable issue that was introduced once resetprop changes were introduced in 11.5/11.6 which did not occur before then, with the same exact zips updated to v3 module template. If you check the magisk release notes it CLEARLY states he made changes to resetprop. Which obviously confirms what I'm saying now.
Audmodlib lib has literally nothing in it that would bootloop your device. All it does is copy your system files into its own magisk folder. Nothing else. It makes ZERO edits to those files if you look at the code. The additional mods that edit audmodlib are what make edits to your existing device code.
I was just seeing if we could figure out a solution to this issue and to pinpoint why this is happening.
Click to expand...
Click to collapse
I get it that you're trying to promote use of your own audmodlib template over the standard magisk template. Have you personally tried using *this* module *without* any other borked/broken modules? If so, please list the HW/SW (ROM, kernel, magisk and magisk manager versions, list of installed modules) combination which results in a bootloop.
PS. This is not a support thread for other broken modules.
Thats my first productive creation for XDA, so dont be to hard to me
I don't like to have features, which I never use, so I always disable or remove everythink i dont need.
On my custom roms I always diable the multi user mode by adding the following line to the build.prop:
Code:
fw.max_users=1
I was annoyed to edit this file after each ROM update.
So I created this module. It just adds the above mentioned line to the build.prop.
It is really simple, but now I don't need to edit the build.prop.
Maybe for someone this can be useful.
It works with:
- Android 6.x (Tested on OnePlus X and OnePlus 3 with CM13)
- Android 7.x (Tested on LOS 14.1 and OxygenOS 4.5.x)
v1.3: Update to Magisk Template 1400 (14.0).
Looks good but I would change the modid to something other than template. This is in the config.sh file and defines the folder it uses under /magisk. Anyways I used your zip as a template for my own build.prop edits that I will post shortly. I'll throw a little credit your way too.
Sorry, I was on vacation and than really busy...
@shinji257: Thank you for the hint. I changed it and uploaded the mod as v 1.1.
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
dima-82 said:
Sorry, I was on vacation and than really busy...
@shinji257: Thank you for the hint. I changed it and uploaded the mod as v 1.1.
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
Click to expand...
Click to collapse
That module probably still works (haven't updated it since posted) but the Magisk template is not updated.
My module does pretty much the same thing as yours, there is only one more line on the prop that I add.
fw.show_multiuserui=0
This disable all the UI and configurations sections for multiuser. Its not obligatory, but for me it makes sense to disable the interface aswell if you are disabling the function.
You can add that if the multiuser options keep showing even after disabling multiuser.
FHC1998 said:
That module probably still works (haven't updated it since posted) but the Magisk template is not updated.
My module does pretty much the same thing as yours, there is only one more line on the prop that I add.
fw.show_multiuserui=0
This disable all the UI and configurations sections for multiuser. Its not obligatory, but for me it makes sense to disable the interface aswell if you are disabling the function.
You can add that if the multiuser options keep showing even after disabling multiuser.
Click to expand...
Click to collapse
When I looked for the build.prop settings to disable multi user functionality I found the mentioned line as well.
But I cannot see any difference if I add it. At least it has not effect on my phone (OnePlus 3, CM13).
dima-82 said:
When I looked for the build.prop settings to disable multi user functionality I found the mentioned line as well.
But I cannot see any difference if I add it. At least it has not effect on my phone (OnePlus 3, CM13).
Click to expand...
Click to collapse
It depends on the device, I originally tested on a few, and some needed this line.
For instance, I tested your module on my device (ZenFone 2 laser) and it worked perfectly without the line, but on my friend's ZenFone 2 it kept showing the UI even though not allowing creating more users.
@dima-82 Module works great for me. I'm running a OP3T on offical LineageOS. All the multiuser stuff is gone from the settings and notification shade.
Sent from my ONEPLUS A3000 using Tapatalk
mp3deviant721 said:
@dima-82 Module works great for me. I'm running a OP3T on offical LineageOS. All the multiuser stuff is gone from the settings and notification shade.
Sent from my ONEPLUS A3000 using Tapatalk
Click to expand...
Click to collapse
Thanks for the feedback.
The official LineageOS for OP3T is Android 7.x? Nightly builds?
dima-82 said:
Thanks for the feedback.
The official LineageOS for OP3T is Android 7.x? Nightly builds?
Click to expand...
Click to collapse
The build I'm running is 7.1.1. Haven't tried 7.1.2 yet. Yes on the "nightly" build.
Sent from my ONEPLUS A3000 using Tapatalk
@dima-82,
Hello, I used your module to enable multi user mode, all I did is edited the file inside the .zip where the string to disable the multi user mode is located, and replaced it with the two strings to enable it.
Now I was wondering since this works, could I make a thread with the mod?
I would obviously credit You, and link to Your profile and this thread.
Here is the module on my device :silly:
dariomrk said:
@dima-82,
Hello, I used your module to enable multi user mode, all I did is edited the file inside the .zip where the string to disable the multi user mode is located, and replaced it with the two strings to enable it.
Now I was wondering since this works, could I make a thread with the mod?
I would obviously credit You, and link to Your profile and this thread.
Click to expand...
Click to collapse
Of course you can do.
But as mentioned in post #3 there was already a similar module. I think it does exactly what you need.
dima-82 said:
Of course you can do.
But as mentioned in post #3 there was already a similar module. I think it does exactly what you need.
Click to expand...
Click to collapse
Oh, I didn't see that, I will check if it does the exactly same thing (probably yes)...
---------- Post added at 03:06 PM ---------- Previous post was at 03:05 PM ----------
Just checked it out, and yes it does the exactly same thing
Please I need multiuser enable magisk module for Android 6
dima-82 said:
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
Click to expand...
Click to collapse
Here
Got bootloop after the install of this module.
Device: Zuk Z2
ROM: AEX 4.4
Unofficial Magisk 13.2 (170716)
I am running it on official Magisk 13.2 without any issues.
Did you also install other modules?
dima-82 said:
I am running it on official Magisk 13.2 without any issues.
Did you also install other modules?
Click to expand...
Click to collapse
Yes have other 5 modules
You installed / activated only this very one module and got a bootloop?
Before I created this module I edited the build.prop manually. And if you make a mistake there, you will get a bootloop as well.
May be your OS does not support this property.
I tested on my devices only, and it worked always.
Eventually you can try an other module from @FHC1998, which should do the same:
https://forum.xda-developers.com/showpost.php?p=71936097&postcount=3
jhobc said:
Got bootloop after the install of this module.
Device: Zuk Z2
ROM: AEX 4.4
Unofficial Magisk 13.2 (170716)
Click to expand...
Click to collapse
You could eventually try this mod:
https://forum.xda-developers.com/apps/magisk/module-single-user-mod-t3639486#post73160966 by @seebz
Ainur JamesDSP is now available in Magisk Manager. Thanks to the devs for their great work. Enjoy!
Not working on pixel xl with magisk 14.3. Repeatedly showing the app has shut down unexpectedly. And then my system started an automatic factory wipe (good thing I forced shut down before the wipe started)
biribiribiri said:
Not working on pixel xl with magisk 14.3. Repeatedly showing the app has shut down unexpectedly. And then my system started an automatic factory wipe (good thing I forced shut down before the wipe started)
Click to expand...
Click to collapse
Yikes. I wonder if AML doesn't support Pixel yet. I will look into it and add a note to the OP. Thanks for the heads up.
biribiribiri said:
Not working on pixel xl with magisk 14.3. Repeatedly showing the app has shut down unexpectedly. And then my system started an automatic factory wipe (good thing I forced shut down before the wipe started)
Click to expand...
Click to collapse
By the way, were you running any other audio mods at the time?
s8m said:
By the way, were you running any other audio mods at the time?
Click to expand...
Click to collapse
no
I am getting a blank screen when opening jamesDSP upon flashing and rebooting. Then if I got to recovery and wipe cache and dalvik and reboot it just does a constant FC, over and over. I provided a log through ADB. I am running ABC ROM, Android O, Angler. As you can also see I have audmodlib and ainur audio as well. Also, before I wiped cache and dalvik and the JamesDSP screen was just blank it did show in notification. Basically, Not working at all here. Thanks for the work bud. The first link is the constant FC with ADB, and the second link is Matlog with the blank JamesDSP screen when opening.
https://haste.blamealexcruz.com/WoNVF1m7XX.swift
https://haste.blamealexcruz.com/8EdpzPLtrU.pl
yung40oz84 said:
I am getting a blank screen when opening jamesDSP upon flashing and rebooting. Then if I got to recovery and wipe cache and dalvik and reboot it just does a constant FC, over and over. I provided a log through ADB. I am running ABC ROM, Android O, Angler. As you can also see I have audmodlib and ainur audio as well. Also, before I wiped cache and dalvik and the JamesDSP screen was just blank it did show in notification. Basically, Not working at all here. Thanks for the work bud. The first link is the constant FC with ADB, and the second link is Matlog with the blank JamesDSP screen when opening.
https://haste.blamealexcruz.com/WoNVF1m7XX.swift
https://haste.blamealexcruz.com/8EdpzPLtrU.pl
Click to expand...
Click to collapse
Thanks - very helpful! Looking quickly at your logcat this may be related to libjamesDSPImpulseToolbox.so being placed inside /system/lib/ instead of /system/lib64/ (my device is ARM64 but accepts /system/lib/). I'll look into a workaround and update this in next build.
s8m said:
Thanks - very helpful! Looking quickly at your logcat this may be related to libjamesDSPImpulseToolbox.so being placed inside /system/lib/ instead of /system/lib64/ (my device is ARM64 but accepts /system/lib/). I'll look into a workaround and update this in next build.
Click to expand...
Click to collapse
Great! Looking forward to it.
When users provide logs...
I already submitted this to the repo. Why are you posting our module as yours? V1.1 is BETA. There's a reason why it is unreleased.
Please have this thread removed. You're going to cause issues for other users, which is already happening.
ahrion said:
I already submitted this to the repo. Why are you posting our module as yours? V1.1 is BETA. There's a reason why it is unreleased.
Please have this thread removed. You're going to cause issues for other users.
Click to expand...
Click to collapse
I'm confused... this is built off a fork of your AM3D repo but my fork is not your repo. V1.1-beta is the version I created. Like the OP says I created this module, combining your AML/Unity framework and james34602's JamesDSPManager.
If you are working on a JamesDSPManager module that is news to me (hence why I made this module). If you are working on a module that is also v1.1-beta that is quite a coincidence! Are you saying you don't want other devs building off of your AML library and sharing with the community? I thought that was welcome (you are planning a template after all) but I will remove this module if you would rather control development.
s8m said:
I'm confused... this is built off a fork of your AM3D repo but my fork is not your repo. V1.1-beta is the version I created. Like the OP says I created this module, combining your AML/Unity framework and james34602's JamesDSPManager.
If you are working on a JamesDSPManager module that is news to me (hence why I made this module). If you are working on a module that is also v1.1-beta that is quite a coincidence! Are you saying you don't want other devs building off of your AML library and sharing with the community? I thought that was welcome (you are planning a template after all) but I will remove this module if you would rather control development.
Click to expand...
Click to collapse
Ahhhh. I didn't check the GitHub repo. I thought you just built the thread with my GitHub repo (which I submitted through Magisk).
That's so weird lol.
You're good then, but using the latest sources will cause things to be wonky with the current stable version of the other mods. It will cause FC all day.
False alarm. Sorry about that! I'm still gonna make a thread for this however.
ahrion said:
Ahhhh. I didn't check the GitHub repo. I thought you just built the thread with my GitHub repo (which I submitted through Magisk).
That's so weird lol.
You're good then, but using the latest sources will cause things to be wonky with the current stable version of the other mods. It will cause FC all day.
False alarm. Sorry about that! I'm still gonna make a thread for this however.
Click to expand...
Click to collapse
OK no worries! That's a good point that using unreleased sources can cause other unwanted problems. I will take this down if you are creating a separate thread. It's probably better for everyone if you are able to manage the development of AML modules.
s8m said:
OK no worries! That's a good point that using unreleased sources can cause other unwanted problems. I will take this down if you are creating a separate thread. It's probably better for everyone if you are able to manage the development of AML modules.
Click to expand...
Click to collapse
It's up to you man. I submitted the stuff yesterday to the Magisk repo, along with a V4A as well as Unity Xposed.
Since you're looking from outside, in. Was Unity easy to configure for you? The entire point for AML is to link everything to together for Magisk. Then we created Unity to be an all in one installer. Any AML modules are encouraged and welcome. Ainur is running AML currently.
Yeah I must say Unity is really well done. I've only ever done very simple Magisk modules (for personal use) so I may not be the best judge, but there wasn't much learning curve at all with Unity. The way the patching and multi-arch handling is set up is really intuitive and logical. This module was really simple to create compared to your ViPER4Android module but it was nice not to have to think about modifying the install-binary or add custom sed commands. All in all - #impressed !
s8m said:
Yeah I must say Unity is really well done. I've only ever done very simple Magisk modules (for personal use) so I may not be the best judge, but there wasn't much learning curve at all with Unity. The way the patching and multi-arch handling is set up is really intuitive and logical. This module was really simple to create compared to your ViPER4Android module but it was nice not to have to think about modifying the install-binary or add custom sed commands. All in all - #impressed !
Click to expand...
Click to collapse
Awesome. You can thank @Zackptg5
Another addition is SETools-inject for Android, that functions like sepolicy inject that MagiskSU/SuperSU have. Essentially, it allows rootless and other forms of root to also use it via init.d. As of yet, no one has actually used SETools for this.
We've also added init.d patching, for rootless and other root methods. Essentially, ramdisk will be automatically patched for AML system modules to use init.d (even if your rom didn't support it before). So init.d patch for all Android versions, MM/N+, has been added. Currently nearly all (if not all) init.d support is broken.
ahrion said:
I already submitted this to the repo. Why are you posting our module as yours? V1.1 is BETA. There's a reason why it is unreleased.
Please have this thread removed. You're going to cause issues for other users, which is already happening.
Click to expand...
Click to collapse
I hope your mod will be in the repo soon, topjohnwu has been very picky with your soubd mods.
24imelqui said:
I hope your mod will be in the repo soon, topjohnwu has been very picky with your soubd mods.
Click to expand...
Click to collapse
It's not that he has been picky. It's just it takes some time to get approved.
Topjohnwu is a busy man.
BTW, Unity allows system mode installation natively if Magisk is not installed, includes addon..d as well.
Magisk is not required for any Unity zips.
ahrion said:
It's up to you man. I submitted the stuff yesterday to the Magisk repo, along with a V4A as well as Unity Xposed.
Click to expand...
Click to collapse
It may be a dumb question, but does your Ainur JamesDSP module require Ainur or can it run independently without Ainur installed?
As anyone who works on Magisk modules knows there is a new module template out, and for the life of me I can not get it working whatsoever. No matter what the install will always fail in my test builds. If anyone can be kind enough to submit a pull request with the updated template applied to my 2 modules, F-Droid Privileged Extension and Systemless TZData I would be extremely thankful.
EDIT: I might just have been overthinking due to life at the moment.
ryaniskira said:
As anyone who works on Magisk modules knows there is a new module template out, and for the life of me I can not get it working whatsoever. No matter what the install will always fail in my test builds. If anyone can be kind enough to submit a pull request with the updated template applied to my 2 modules, F-Droid Privileged Extension and Systemless TZData I would be extremely thankful.
EDIT: I might just have been overthinking due to life at the moment.
Click to expand...
Click to collapse
I have a funny feeling it is because the updater-binary is now empty and has to be manually replaced with a proper installer script. Read more here.
What happened to @VR25's modules in the repo? Today I looked but his most excellent modules are gone from the repo. Good thing I downloaded them a few days ago, so I'm wondering if there's a reason for the modules' disappearance?
He didn't have time to update them to the new template before the repo purge. I'm sure he'll update and resubmit when time permits...
The modules will be back.
Don't ignore
VR25 said:
The modules will be back.
Click to expand...
Click to collapse
Sir I am working with a recovery project. I added magisk manager in the recovery by the help of your code. I also gave credit to you. I am asking the permission that can I release the project or I did a wrong step.