Related
Hello, guys!
I guess most of you know about this "magic patch" that significantly boosts Linux speed. It's going to be merged in the 2.6.38 branch and it's shipping with Ubuntu Natty too. But this kernel patch can be applied to a previous kernel as well, just rebuilding it with this 224 magical lines of code.
What I wanted to know is if it's possibile to rebuild our kernels with this patch, if it is already, or if it's possibile but won't have significant boosts on Android devices.
You may read more about this on Phoronix. On the 2nd page there are video demos for lazy ones!
This has been discussed here twice &found not to help because we dont use harddisk.
Sent from my GT-I9000 using XDA App
was it "proven" or "theorized" ?
You can look it up here in dev. Search
Sent from my GT-I9000 using XDA App
ragin said:
This has been discussed here twice &found not to help because we dont use harddisk.
Sent from my GT-I9000 using XDA App
Click to expand...
Click to collapse
Thank you, but can you please link the thread with this discussion? I can't seem to find it. Also, this patch regards CPU, not hard disks.
this patch will be officially introduced in the 2.6.38 kernel..
also, this kernel will have about 50% more speed increase, due to the 200 lines patch and another issue resolved after it .. in general the upcoming kernel will be blazingly fast !!
there is a script that tries to do the same as the patch for earlier kernels. which I use on my Ubuntu laptop, and yes major performance increase !!
I tried to apply it to my previous phone (HTC Hero), but didn't work. I also asked Cyanogen on his twitter, but didn't care to give me an answer..
finally I gave up, and decided to wait for the next Android version that will have the 2.6.38 in the future..
MaXo64 said:
this patch will be officially introduced in the 2.6.38 kernel..
also, this kernel will have about 50% more speed increase, due to the 200 lines patch and another issue resolved after it .. in general the upcoming kernel will be blazingly fast !!
there is a script that tries to do the same as the patch for earlier kernels. which I use on my Ubuntu laptop, and yes major performance increase !!
I tried to apply it to my previous phone (HTC Hero), but didn't work. I also asked Cyanogen on his twitter, but didn't care to give me an answer..
finally I gave up, and decided to wait for the next Android version that will have the 2.6.38 in the future..
Click to expand...
Click to collapse
I'm using that script too on Maverick! I don't think there should be a significant increase in responsiveness if you apply it on high-end systems, but our SGS might benefit from it (as my old dual core system).
You say it didn't work on your Hero, but were there any errors in dmesg or you didn't find any significant change in speed?
thunderteaser said:
I'm using that script too on Maverick! I don't think there should be a significant increase in responsiveness if you apply it on high-end systems, but our SGS might benefit from it (as my old dual core system).
You say it didn't work on your Hero, but were there any errors in dmesg or you didn't find any significant change in speed?
Click to expand...
Click to collapse
dmesg should no difference. the script just showed a lot of errors.
I tried the "non-Ubuntu" version as described in Webupd8, but still similar errors.
I guess Android place the kernel differently from Linux desktops.
I might be mistaken, but SO kernel uses its. And haven't really noticed any difference with or without it.
MaXo64 said:
this patch will be officially introduced in the 2.6.38 kernel..
also, this kernel will have about 50% more speed increase, due to the 200 lines patch and another issue resolved after it .. in general the upcoming kernel will be blazingly fast !!
there is a script that tries to do the same as the patch for earlier kernels. which I use on my Ubuntu laptop, and yes major performance increase !!
I tried to apply it to my previous phone (HTC Hero), but didn't work. I also asked Cyanogen on his twitter, but didn't care to give me an answer..
finally I gave up, and decided to wait for the next Android version that will have the 2.6.38 in the future..
Click to expand...
Click to collapse
please don't spread incorrect facts:
* the "automated per tty task groups" (or autogroup) patch - by using cgroups (in CFS - the cpu scheduler) and thus isolating several taks from each other, giving them dedicated slices of cpu power - allows the system to be more responsive under load if there is a kind of cpu hog (task producing much load)
* the speed increase is due to Nick Piggin's VFS changes and Andrea Arcangeli & Mel Gorman's Transparent Hugepages (THP) support (and of course lots of other changes)
dupel said:
I might be mistaken, but SO kernel uses its. And haven't really noticed any difference with or without it.
Click to expand...
Click to collapse
that's correct: - "sched patch : automated per tty task groups (system more smooth and responsive) (v3(since 4_3) and v4(since 4_4))"
so you tried SO kernel with the patch applied and once reverted ?
but - yeah, I got you: I'm myself running a heavy patched 2.6.37 kernel with transparent hugepages, CFS autogroup, etc. enabled - and it certainly can play off its advantage most noticably during heavy system load
zacharias.maladroit said:
that's correct: - "sched patch : automated per tty task groups (system more smooth and responsive) (v3(since 4_3) and v4(since 4_4))"
so you tried SO kernel with the patch applied and once reverted ?
but - yeah, I got you: I'm myself running a heavy patched 2.6.37 kernel with transparent hugepages, CFS autogroup, etc. enabled - and it certainly can play off its advantage most noticably during heavy system load
Click to expand...
Click to collapse
So, please, correct my noobiness, isn't Android using TTY shells? If it's not than I understand why this patch can't be applied, but if it is, rebuilding a kernel with just 200 lines more is no big deal and we all could benefit from it. It's not very common for Android to be under heavy load but hey, it's going to be default in 2.6.38, so why not?
There is a better patch :
blog.internetnews.com/skerner/2010/11/forget-200-lines-red-hat-speed.html
But I don't know if android uses shells.
Protocamlann said:
There is a better patch :
blog.internetnews.com/skerner/2010/11/forget-200-lines-red-hat-speed.html
But I don't know if android uses shells.
Click to expand...
Click to collapse
Yes, that's exactly the script I was talking about a few posts ago. On my system running 2.6.35, I did not rebuild the kernel with the "patch of wonders" but applied this script. But as you may have read, it acts in userspace which is slightly different in Android (as far as I know it's not using the same environment variables and I don't know about any ~/.bashrc equivalents, but again correct me if I'm wrong), that's why a kernel-oriented patch would be more suitable.
* well, actually newer revisions of that patch don't make use of ttys but of the task session
so basically it seems to create separate groups for each task (or program for simplicity's sake)
(source)
I'm also not sure if current Android kernel revisions use CFS at all ("Android versus Linux?")
laststufo has the autogroup patch included in his SO Kernel but I don't know how to measure its effect ... (whether it makes any difference)
* other options to improve interactivity would be to use Lennart Poettering's bash-approach (the script), like MaXo64 already posted: link
since Android uses Bourne Shell (sh) instead of BASH the script might need to be rewritten
* if it's stable enough on the SGS - yet another option would be to use Con Kolivas BFS
thunderteaser said:
Yes, that's exactly the script I was talking about a few posts ago. On my system running 2.6.35, I did not rebuild the kernel with the "patch of wonders" but applied this script. But as you may have read, it acts in userspace which is slightly different in Android (as far as I know it's not using the same environment variables and I don't know about any ~/.bashrc equivalents, but again correct me if I'm wrong), that's why a kernel-oriented patch would be more suitable.
Click to expand...
Click to collapse
well, you could rewrite that script that it is run as a init-script (afaik in /system/init.d/ )
besides that:
there are stripped down (smaller) versions of bash 4.1* that are known to work on CM6 and the HTC Hero
so it should be a possibility to use that script on stock roms, too
if you can install busybox & root it, there also should be the possibility to install bash
zacharias.maladroit said:
* well, actually newer revisions of that patch don't make use of ttys but of the task session
so basically it seems to create separate groups for each task (or program for simplicity's sake)
(source)
I'm also not sure if current Android kernel revisions use CFS at all ("Android versus Linux?")
laststufo has the autogroup patch included in his SO Kernel but I don't know how to measure its effect ... (whether it makes any difference)
* other options to improve interactivity would be to use Lennart Poettering's bash-approach (the script), like MaXo64 already posted: link
since Android uses Bourne Shell (sh) instead of BASH the script might need to be rewritten
* if it's stable enough on the SGS - yet another option would be to use Con Kolivas BFS
Click to expand...
Click to collapse
It seems you're very well informed, so thanks for the infos you're posting!
I'm not a coder, though, so I hope a kernel developer could pick this up and go for BFS. You said laststufo already implemented this patch in his kernel, so that's really good! We should just find a way of testing its effectiveness.
zacharias.maladroit said:
well, you could rewrite that script that it is run as a init-script (afaik in /system/init.d/ )
besides that:
there are stripped down (smaller) versions of bash 4.1* that are known to work on CM6 and the HTC Hero
so it should be a possibility to use that script on stock roms, too
if you can install busybox & root it, there also should be the possibility to install bash
Click to expand...
Click to collapse
Yes, I've also seen bash shipping with some ROMs, so it's definitely possibile, though as I said before, I'm no coder...
thunderteaser said:
It seems you're very well informed, so thanks for the infos you're posting!
I'm not a coder, though, so I hope a kernel developer could pick this up and go for BFS. You said laststufo already implemented this patch in his kernel, so that's really good! We should just find a way of testing its effectiveness.
Click to expand...
Click to collapse
I'm a kernel-dev for linux-kernels so I got to know & learned to cherish them
just stumbled over a thread in the Epic 4G forum
for reference: [Q] [REQ] Galbraith Patch worked into kernals?
zacharias.maladroit said:
I'm a kernel-dev for linux-kernels so I got to know & learned to cherish them
Click to expand...
Click to collapse
You really are? That's great! So why don't you join laststufo to try maximizing the impact of his implemented "patch of wonders"? As I try to keep up with your techical chatting it seems I really can't do more than asking you to help!
zacharias.maladroit said:
just stumbled over a thread in the Epic 4G forum
for reference: [Q] [REQ] Galbraith Patch worked into kernals?
Click to expand...
Click to collapse
Uhm, so it seems BFS isn't stable on our hardware, pretty bad.
COLOR="Red"]This thread will discontinue, Now I'm published my new mod's thread under Magisk, that mod includes Whole new ViPERFX app and many other mods and upcomings so From now everybody please follow this thread below:
[Module] ViPERFX
https://forum.xda-developers.com/apps/magisk/viperfx-t3667145[/COLOR][/SIZE][/B]
Introduction:
ViPER4Android is very popular audio mod around the world of Android and probably the best audio mod ever made. But there is so many complexity ViPER4Android couldn't go further through, so I wish "ViPER-FX" could be a project to let our beloved ViPER4Android step in advance. Original V4A details at ViPER4Android Official forum.
Modifications:
+ Based on ViPER4Android v2.5.0.5
+ New Material UI and Icon
+ App rotation enabled.
+ Default install as system app to prevent task kill.
in MIUI or some rom could be installed as user-app
for IRS compatibility [Experimental]
+ The zip edition includes apk.
Recommendation:
* Magisk Manager, Framework installed.
* Android 5.0+
* To update from ViPER-FX v4.0 (v4.0 only) first remove it.
How to install?
* Flash the zip using Magisk Manager or Custome recovery.
# Track this thread using the URL below.
URL: [url]http://forum.xda-developers.com/showthread.php?t=3535401[/URL]
Thanks To:
Code:
[user=4470081]@topjohnwu[/user] for Magisk Framework.
[user=3901724]@zhuhang[/user] and ViPER520 (Founders of ViPER4Android).
[user=4445176]@guitardedhero[/user] | [user=5704037]@repey6[/user] | [user=5210243]@exodius48[/user] | [user=6118476]@#mrk[/user]
for helping/support/testing.
...and those I forgot to mention.
I spend dedicated time, made pressure on brain and did hard work to make this perfect
If you like my post please hit Thanks and give a rate....
~~ Feel The power of ViPER-FX ~~
Contributors
metaspook
Version Information
Status: Stable
Current Stable Version: 4.1
Stable Release Date: 2017-01-13
The long waited finally come, will try this out.
the title is a bit misleading:
-this is not [Magisk], this is a [Module]
-it's not 100% clear if you packed the Magisk module or if you also offer a modded App (in thread description)
-it also has the same id as @topjohnwu 's module...
id=v4a
name=ViPER-FX
version=Base v2.5.0.5 | MKM v4.0
versionCode=3
author=ViPER’s Audio | Mod by Metaspook
description=ViPER-FX is a system wide audio enhancing software, modified edition of ViPER4Android.
support=https://www.androidfilehost.com/?w=files&flid=143525
donate=http://vipersaudio.com/blog/?page_id=95
Click to expand...
Click to collapse
@metaspook
Can you delete V4A app inside "\system\priv-app\ViPERFX" in next release? Because if V4A app installed inside /system/ there will be no sound improvement by IRS. Tested on my device running MIUI rom, dunno on other rom.
I use sepaker & many times change the IRS, but no sound improvement.
crusader727 said:
the title is a bit misleading:
-this is not [Magisk], this is a [Module]
-it's not 100% clear if you packed the Magisk module or if you also offer a modded App (in thread description)
-it also has the same id as @topjohnwu 's module...
Click to expand...
Click to collapse
Got it... actually I had to make this thread in short time making this of thread n sort it as well as possible is a bit hard something could be missing, but this thread will be more informative, well sorted soon...
Thank you.
exodius48 said:
@metaspook
Can you delete V4A app inside "\system\priv-app\ViPERFX" in next release? Because if V4A app installed inside /system/ there will be no sound improvement by IRS. Tested on my device running MIUI rom, dunno on other rom.
I use sepaker & many times change the IRS, but no sound improvement.
Click to expand...
Click to collapse
Do u'v installed Magisk n flash the zip through it?
B'cz this is a whole new way to dealing with system.
If u did but after that also don't work let me know.
metaspook said:
Do u'v installed Magisk n flash the zip through it?
B'cz this is a whole new way to dealing with system.
If u did but after that also don't work let me know.
Click to expand...
Click to collapse
Yes bro, i already used magisk long time ago.
Recently compared with V4A original (installed as user app /data/app/) & V4A module by topjohnwu, my device can read IRS and has sound improvement.
I don't know this issue is MIUI related or not, but I always get that issue if V4A app installed as system app (/system/app or /system/priv-app).
exodius48 said:
Yes bro, i already used magisk long time ago.
Recently compared with V4A original (installed as user app /data/app/) & V4A module by topjohnwu, my device can read IRS and has sound improvement.
I don't know this issue is MIUI related or not, but I always get that issue if V4A app installed as system app (/system/app or /system/priv-app).
Click to expand...
Click to collapse
OK I'll release next update separately..
I can't tell whether or how this differs from the existing V4A module offered by topjohnwu.
Cool. I'd like to try this out. I just had some questions:
1. What do these commands do:
Code:
/data/magisk/sepolicy-inject --live -s mediaserver -t mediaserver_tmpfs -c file -p read,write,execute
/data/magisk/sepolicy-inject --live -s audioserver -t audioserver_tmpfs -c file -p read,write,execute
2. Why are the following folders blank?
Code:
system/etc
system/lib/soundfx
system/vendor/etc
oreo27 said:
Cool. I'd like to try this out. I just had some questions:
1. What do these commands do:
2. Why are the following folders blank?
Click to expand...
Click to collapse
1. It helps to keep Viper FX alive in SELinux enforcement.
2. Into these directories necessary files will be extracted or pulled from original /system.
Thanks to wanna know. :good:
metaspook said:
1. It helps to keep Viper FX alive in SELinux enforcement.
2. Into these directories necessary files will be extracted or pulled from original /system.
Thanks to wanna know. :good:
Click to expand...
Click to collapse
Oh. I didn't think to check in the update-binary. It feels like this is a complicated script for sure:
Code:
# Push files
unzip -oq $ZIP "system/*" -d $MODPATH
unzip -pq $MODPATH/system/priv-app/ViPERFX/ViPERFX.apk assets/libv4a_fx_jb_$DRVARCH.so > $MODPATH/system/lib/soundfx/libv4a_fx_ics.so
ui_print "[OK] Pushing files."
# Config files modification.
for X in /system/etc/audio_effects.conf /system/etc/htc_audio_effects.conf /system/vendor/etc/audio_effects.conf; do
cp -af $X $MODPATH$X
sed -i '/v4a_fx {/,/}/d' $MODPATH$X
sed -i '/v4a_standard_fx {/,/}/d' $MODPATH$X
sed -i 's/^libraries {/libraries {\n v4a_fx {\n path \/system\/lib\/soundfx\/libv4a_fx_ics.so\n }/g' $MODPATH$X
sed -i 's/^effects {/effects {\n v4a_standard_fx {\n library v4a_fx\n uuid 41d3c987-e6cf-11e3-a88a-11aba5d5c51b\n }/g' $MODPATH$X
done; ui_print "[OK] Config modification."
Does this mean that if I uninstall this mod, Viper is completely uninstalled without any changes present in my entire device? If so, it's a pretty good implementation.
Nice! Works just fine on my Nexus 6. Will this be submitted to the Magisk repo? Would be useful to have it in the manager...
oreo27 said:
Oh. I didn't think to check in the update-binary. It feels like this is a complicated script for sure:
Code:
# Push files
unzip -oq $ZIP "system/*" -d $MODPATH
unzip -pq $MODPATH/system/priv-app/ViPERFX/ViPERFX.apk assets/libv4a_fx_jb_$DRVARCH.so > $MODPATH/system/lib/soundfx/libv4a_fx_ics.so
ui_print "[OK] Pushing files."
# Config files modification.
for X in /system/etc/audio_effects.conf /system/etc/htc_audio_effects.conf /system/vendor/etc/audio_effects.conf; do
cp -af $X $MODPATH$X
sed -i '/v4a_fx {/,/}/d' $MODPATH$X
sed -i '/v4a_standard_fx {/,/}/d' $MODPATH$X
sed -i 's/^libraries {/libraries {\n v4a_fx {\n path \/system\/lib\/soundfx\/libv4a_fx_ics.so\n }/g' $MODPATH$X
sed -i 's/^effects {/effects {\n v4a_standard_fx {\n library v4a_fx\n uuid 41d3c987-e6cf-11e3-a88a-11aba5d5c51b\n }/g' $MODPATH$X
done; ui_print "[OK] Config modification."
Does this mean that if I uninstall this mod, Viper is completely uninstalled without any changes present in my entire device? If so, it's a pretty good implementation.
Click to expand...
Click to collapse
1. The code I wrote looks a bit complicated but its for to reduce the size of the module (you can see I didn't packed the driver separately, codes are extracts those from the apk) and for more task will be done in less lines.
2. Yes.. obviously that's why using Magisk framework is so useful. It wont change anything in /system while installing nor in uninstalling your /system would be intact.
Didgeridoohan said:
Nice! Works just fine on my Nexus 6. Will this be submitted to the Magisk repo? Would be useful to have it in the manager...
Click to expand...
Click to collapse
Thanks... yes I wish also soon.
exodius48 said:
Yes bro, i already used magisk long time ago.
Recently compared with V4A original (installed as user app /data/app/) & V4A module by topjohnwu, my device can read IRS and has sound improvement.
I don't know this issue is MIUI related or not, but I always get that issue if V4A app installed as system app (/system/app or /system/priv-app).
Click to expand...
Click to collapse
Actually I pushing the apk into the system cause if Viper install as user app in data, 3rd party or internal app killer kill it and Viper looses to output the effect even also when remove from recent list. but I have an idea if its just happens with your MIUI rom... can you give me your ROM's 'build.prop" file ???
Is not working for me, IS activated on Magisk Modules Install,
But V4A say "Install/Update now?", Samsung S5 G900m, Is rooted using SuperSU 2.79, Latest Magisk Manager/Installer,
I Installed this V4A why magisk "Refuses" to open Modules download page "No Modules Found", And i have to download manually from internet. (SafetyNet says RED, Root and Magisk is green in Magisk Manager)
V4A is installed as System App, And SELINUX is Permissive,
I Try to change V4A to user APP, But not working;
metaspook said:
Actually I pushing the apk into the system cause if Viper install as user app in data, 3rd party or internal app killer kill it and Viper looses to output the effect even also when remove from recent list. but I have an idea if its just happens with your MIUI rom... can you give me your ROM's 'build.prop" file ???
Click to expand...
Click to collapse
Yes you're right. But on MIUI (especially MIUI 8 on my device) i can control it. We can lock app into taskbar and turn off MIUI optimization for selected app by turn off background restriction. Those will prevent MIUI kill running app.
build.prop file attached. :good:
metaspook said:
1. The code I wrote looks a bit complicated but its for to reduce the size of the module (you can see I didn't packed the driver separately, codes are extracts those from the apk) and for more task will be done in less lines.
2. Yes.. obviously that's why using Magisk framework is so useful. It wont change anything in /system while installing nor in uninstalling your /system would be intact.
Click to expand...
Click to collapse
This is pretty good. I installed this and it's working great. Just a quick question, I don't suppose it can work on phone calls as well? I was looking to get my bluetooth volume increased.
oreo27 said:
This is pretty good. I installed this and it's working great. Just a quick question, I don't suppose it can work on phone calls as well? I was looking to get my bluetooth volume increased.
Click to expand...
Click to collapse
Not sure about it... Test urself, look can work or not
This module doubles the number of steps in volume adjustment for both media and in-call volume.
WARNING: Apparently doesn't work on all devices, for example OnePlus 3 according to this.
what about a collection thread for build prop tweaks to use in Magisk?
Thanks for the module. It's got a funny bump going louder until the middle of the scale, then getting suddenly significantly quieter again and going louder until the end, for media playback.
Bettik said:
Thanks for the module. It's got a funny bump going louder until the middle of the scale, then getting suddenly significantly quieter again and going louder until the end, for media playback.
Click to expand...
Click to collapse
Could be hardware/driver-dependant. I've used a (non-systemized) prop modification before on a tablet and it was pretty smooth.
time comes, good modules too :good:
Just a reminder for those who encounter problems. ro.config.vc_call_vol_steps=14
ro.config.media_vol_steps=30 won't work for all devices, such as OnePlus 3, at least on its official OxygenOS.
Once you change your media volume steps from default 15 to the 30, using the script above which is included in the module, on your OnePlus 3. The steps are increased, while it's just a loop. The volume drop back to the lowest again at the 16th step and totally silent at some steps bigger than 20.
BTW, the xposed module VolumeSteps+ won't work on OnePlus 3 either.
accidentally quoted OP instead of editing it.
changes couldn't be reseted after removing the system.prop or the module. Any thing to do?
chjun90 said:
changes couldn't be reseted after removing the system.prop or the module. Any thing to do?
Click to expand...
Click to collapse
Remove module, reboot. When asking for help, provide logs.
stangri said:
Remove module, reboot. When asking for help, provide logs.
Click to expand...
Click to collapse
i do that many times. i have removed the module days ago, but the chages still on my phone. i found the bug in all the modules with system.prop not only yours. thinking it's bugs of magisk v11.1.
chjun90 said:
i do that many times. i have removed the module days ago, but the chages still on my phone. i found the bug in all the modules with system.prop not only yours. thinking it's bugs of magisk v11.1.
Click to expand...
Click to collapse
Would be great if you had created an issue against Magisk on github then. Probably uninstalling magisk (from recovery) and re-installing it would start you with a clean slate.
Alternatively, there're unofficial builds of the next-gen magisk available, maybe they would fix the issue.
stangri said:
Would be great if you had created an issue against Magisk on github then. Probably uninstalling magisk (from recovery) and re-installing it would start you with a clean slate.
Alternatively, there're unofficial builds of the next-gen magisk available, maybe they would fix the issue.
Click to expand...
Click to collapse
i had
Is it compatible with the latest 11.6 magisk? Anyone tested?
Angelos N. said:
Is it compatible with the latest 11.6 magisk? Anyone tested?
Click to expand...
Click to collapse
11.0.0 version is and I have.
Angelos N. said:
Is it compatible with the latest 11.6 magisk? Anyone tested?
Click to expand...
Click to collapse
Causes systemui FC.
This is because of system.prop. I had this same issue when changing.
To 11.6.
ahrion said:
Causes systemui FC.
Click to expand...
Click to collapse
As evident from the screenshots below it works fine.
Care to post link to the github issue where 11.6 has broken system.prop support?
stangri said:
As evident from the screenshots below it works fine.
Care to post link to the github issue where 11.6 has broken system.prop support?
Click to expand...
Click to collapse
I had the same issue with my mods, removing system.prop fixed this issues. 11.6 broke resetprop for certain people. I don't see any issues on the GitHub for magisk, but I know this is an issue because me on my own mods and others have reported this same issue. I've tested it and that's what I have found.
It doesn't happen to all phones but I think it's a magisk issue with resetprop, something that was not an issue in 11.5.
ahrion said:
I had the same issue with my mods, removing system.prop fixed this issues. 11.6 broke resetprop for certain people. I don't see any issues on the GitHub for magisk, but I know this is an issue because me on my own mods and others have reported this same issue. I've tested it and that's what I have found.
It doesn't happen to all phones but I think it's a magisk issue with resetprop, something that was not an issue in 11.5.
Click to expand...
Click to collapse
I think you're making way to large assumptions here. From my experience, there's no issue with resetprop. This module and many others I've tried and use on v11.6, that utilises system.prop and resetprop work just fine.
Yes, when I tested your module my device wouldn't boot unless I removed the system.prop from the audmodlib. But I don't think that had anything to do with the system.prop itself, but rather what you'd put in it...
Didgeridoohan said:
I think you're making way to large assumptions here. From my experience, there's no issue with resetprop. This module and many others I've tried and use on v11.6, that utilises system.prop and resetprop work just fine.
Yes, when I tested your module my device wouldn't boot unless I removed the system.prop from the audmodlib. But I don't think that had anything to do with the system.prop itself, but rather what you'd put in it...
Click to expand...
Click to collapse
I'm not making assumptions. I'm literally telling you what issues I've experienced with my 9 modules and I'm not the only one It worked before 11.5/11.6 until I removed system.prop, which was the issue. The issue itself was not present before on previous versions. This was happening for me when upgrading to 11.6.
This is a reproduceable issue that was introduced once resetprop changes were introduced in 11.5/11.6 which did not occur before then, with the same exact zips updated to v3 module template. If you check the magisk release notes it CLEARLY states he made changes to resetprop. Which obviously confirms what I'm saying now.
Audmodlib lib has literally nothing in it that would bootloop your device. All it does is copy your system files into its own magisk folder. Nothing else. It makes ZERO edits to those files if you look at the code. The additional mods that edit audmodlib are what make edits to your existing device code.
I was just seeing if we could figure out a solution to this issue and to pinpoint why this is happening.
ahrion said:
I'm not making assumptions. I'm literally telling you what issues I've experienced with my 9 modules and I'm not the only one It worked before 11.5/11.6 until I removed system.prop, which was the issue. The issue itself was not present before on previous versions. This was happening for me when upgrading to 11.6.
This is a reproduceable issue that was introduced once resetprop changes were introduced in 11.5/11.6 which did not occur before then, with the same exact zips updated to v3 module template. If you check the magisk release notes it CLEARLY states he made changes to resetprop. Which obviously confirms what I'm saying now.
Audmodlib lib has literally nothing in it that would bootloop your device. All it does is copy your system files into its own magisk folder. Nothing else. It makes ZERO edits to those files if you look at the code. The additional mods that edit audmodlib are what make edits to your existing device code.
I was just seeing if we could figure out a solution to this issue and to pinpoint why this is happening.
Click to expand...
Click to collapse
I get it that you're trying to promote use of your own audmodlib template over the standard magisk template. Have you personally tried using *this* module *without* any other borked/broken modules? If so, please list the HW/SW (ROM, kernel, magisk and magisk manager versions, list of installed modules) combination which results in a bootloop.
PS. This is not a support thread for other broken modules.
Thats my first productive creation for XDA, so dont be to hard to me
I don't like to have features, which I never use, so I always disable or remove everythink i dont need.
On my custom roms I always diable the multi user mode by adding the following line to the build.prop:
Code:
fw.max_users=1
I was annoyed to edit this file after each ROM update.
So I created this module. It just adds the above mentioned line to the build.prop.
It is really simple, but now I don't need to edit the build.prop.
Maybe for someone this can be useful.
It works with:
- Android 6.x (Tested on OnePlus X and OnePlus 3 with CM13)
- Android 7.x (Tested on LOS 14.1 and OxygenOS 4.5.x)
v1.3: Update to Magisk Template 1400 (14.0).
Looks good but I would change the modid to something other than template. This is in the config.sh file and defines the folder it uses under /magisk. Anyways I used your zip as a template for my own build.prop edits that I will post shortly. I'll throw a little credit your way too.
Sorry, I was on vacation and than really busy...
@shinji257: Thank you for the hint. I changed it and uploaded the mod as v 1.1.
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
dima-82 said:
Sorry, I was on vacation and than really busy...
@shinji257: Thank you for the hint. I changed it and uploaded the mod as v 1.1.
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
Click to expand...
Click to collapse
That module probably still works (haven't updated it since posted) but the Magisk template is not updated.
My module does pretty much the same thing as yours, there is only one more line on the prop that I add.
fw.show_multiuserui=0
This disable all the UI and configurations sections for multiuser. Its not obligatory, but for me it makes sense to disable the interface aswell if you are disabling the function.
You can add that if the multiuser options keep showing even after disabling multiuser.
FHC1998 said:
That module probably still works (haven't updated it since posted) but the Magisk template is not updated.
My module does pretty much the same thing as yours, there is only one more line on the prop that I add.
fw.show_multiuserui=0
This disable all the UI and configurations sections for multiuser. Its not obligatory, but for me it makes sense to disable the interface aswell if you are disabling the function.
You can add that if the multiuser options keep showing even after disabling multiuser.
Click to expand...
Click to collapse
When I looked for the build.prop settings to disable multi user functionality I found the mentioned line as well.
But I cannot see any difference if I add it. At least it has not effect on my phone (OnePlus 3, CM13).
dima-82 said:
When I looked for the build.prop settings to disable multi user functionality I found the mentioned line as well.
But I cannot see any difference if I add it. At least it has not effect on my phone (OnePlus 3, CM13).
Click to expand...
Click to collapse
It depends on the device, I originally tested on a few, and some needed this line.
For instance, I tested your module on my device (ZenFone 2 laser) and it worked perfectly without the line, but on my friend's ZenFone 2 it kept showing the UI even though not allowing creating more users.
@dima-82 Module works great for me. I'm running a OP3T on offical LineageOS. All the multiuser stuff is gone from the settings and notification shade.
Sent from my ONEPLUS A3000 using Tapatalk
mp3deviant721 said:
@dima-82 Module works great for me. I'm running a OP3T on offical LineageOS. All the multiuser stuff is gone from the settings and notification shade.
Sent from my ONEPLUS A3000 using Tapatalk
Click to expand...
Click to collapse
Thanks for the feedback.
The official LineageOS for OP3T is Android 7.x? Nightly builds?
dima-82 said:
Thanks for the feedback.
The official LineageOS for OP3T is Android 7.x? Nightly builds?
Click to expand...
Click to collapse
The build I'm running is 7.1.1. Haven't tried 7.1.2 yet. Yes on the "nightly" build.
Sent from my ONEPLUS A3000 using Tapatalk
@dima-82,
Hello, I used your module to enable multi user mode, all I did is edited the file inside the .zip where the string to disable the multi user mode is located, and replaced it with the two strings to enable it.
Now I was wondering since this works, could I make a thread with the mod?
I would obviously credit You, and link to Your profile and this thread.
Here is the module on my device :silly:
dariomrk said:
@dima-82,
Hello, I used your module to enable multi user mode, all I did is edited the file inside the .zip where the string to disable the multi user mode is located, and replaced it with the two strings to enable it.
Now I was wondering since this works, could I make a thread with the mod?
I would obviously credit You, and link to Your profile and this thread.
Click to expand...
Click to collapse
Of course you can do.
But as mentioned in post #3 there was already a similar module. I think it does exactly what you need.
dima-82 said:
Of course you can do.
But as mentioned in post #3 there was already a similar module. I think it does exactly what you need.
Click to expand...
Click to collapse
Oh, I didn't see that, I will check if it does the exactly same thing (probably yes)...
---------- Post added at 03:06 PM ---------- Previous post was at 03:05 PM ----------
Just checked it out, and yes it does the exactly same thing
Please I need multiuser enable magisk module for Android 6
dima-82 said:
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
Click to expand...
Click to collapse
Here
Got bootloop after the install of this module.
Device: Zuk Z2
ROM: AEX 4.4
Unofficial Magisk 13.2 (170716)
I am running it on official Magisk 13.2 without any issues.
Did you also install other modules?
dima-82 said:
I am running it on official Magisk 13.2 without any issues.
Did you also install other modules?
Click to expand...
Click to collapse
Yes have other 5 modules
You installed / activated only this very one module and got a bootloop?
Before I created this module I edited the build.prop manually. And if you make a mistake there, you will get a bootloop as well.
May be your OS does not support this property.
I tested on my devices only, and it worked always.
Eventually you can try an other module from @FHC1998, which should do the same:
https://forum.xda-developers.com/showpost.php?p=71936097&postcount=3
jhobc said:
Got bootloop after the install of this module.
Device: Zuk Z2
ROM: AEX 4.4
Unofficial Magisk 13.2 (170716)
Click to expand...
Click to collapse
You could eventually try this mod:
https://forum.xda-developers.com/apps/magisk/module-single-user-mod-t3639486#post73160966 by @seebz
AKT Profile for Magisk
AKT Profile by Asiier & Senthil360 for Magisk in order to use service.sh(late_start).
Why?
I can't fully mount the /system partition and so /system/etc/init.d/99AKT is not editable.
The result is that at each boot/reboot I have to go through the whole procedure to apply the setting.
This module should make things easier: instead of rely on init.d, it uses the built-in function of magisk.
Profiles/Project Credits:
// Nameless by @Senthil360 | Fusion by @patalao | Burnout PR3 by @Mostafa Wael \ // Project Zhana & X.A.N.A by @Asiier | GhostPepper, HawkPepper and FairPark by @Asiier \
OP5 SupportMostafa Wael | @Funk Wizard
[AKT] Advanced Kernel Tweaks v1.0 For OP5 & S835 devices
I have just editet the /system/bin/AKT file to make it compatible with Magisk
Original Project:
https://forum.xda-developers.com/oneplus-3/how-to/advanced-interactive-governor-tweaks-t3476589
Change Log
v1.0 - Initial release
v1.1 - Fixed apply profile on boot
v1.2 - OP5 Support + Magisk Template v15
Requeriment
Magisk 15.0
Installation
-Uninstall the original AKT package through terminal
-Download the module from the Download section below(different zip for SD835|OP5 and SD820/1|OP3/T)
-Flash the zip package from Magisk Mangaer and reboot
-Apply the desired profile like you do with the default package from the Terminal emulator:
Code:
su
AKT
Download:
SD820/1 | OP3/T: https://github.com/Razorphyn/AKT_Pr...2/AKT_Profiles_Magisk-1.2.SD820.821-OP3.T.zip
SD835 | OP5: https://github.com/Razorphyn/AKT_Pr...oad/1.2/AKT_Profiles_Magisk-1.2.SD835-OP5.zip
Source:
Repository: https://github.com/Razorphyn/AKT_Profiles_Magisk
cool, do i need to uninstall the original atk?
What's the advantages of this module over AKT app provided in AKT thread?
well i think this will apply auto at boot.
How i verify if profile is activated ?
gatalon said:
cool, do i need to uninstall the original atk?
Click to expand...
Click to collapse
I am not sure that magisk will overwrite the already exixtant bin file, so I would say yes.
Just remember to apply the profile once you have installed the module.
pinoholo said:
What's the advantages of this module over AKT app provided in AKT thread?
Click to expand...
Click to collapse
Theoretically:
-No files are added directly to/system
-Do not need additional mod to enable init.d and potentially break SafetyNet
Practically:
I am not able to mount /system in rw, but only ro, this means that I can't edit the file inside the init.d folder, especially 99AKT which stores the profile info to apply on boot.
Also the removal of the bin file is a pain(only through TWRP)
Basically what happens is that instead of editing
Code:
/system/etc/init.d(su.d)/99AKT
, this module save the profile to apply on boot in
Code:
/magisk/mymodule/post-fs-data.sh
mmm273 said:
well i think this will apply auto at boot.
How i verify if profile is activated ?
Click to expand...
Click to collapse
I have never thought about it, but in principle, from the Terminal you should see the active profile.
To be sure I think you need to check the real value with some app and compare them with the profile file.
Probably an easier way is to use an app that display the value(I think Kernel Auditor does this, you can check the CPU freq and other value) and compare those value with te profile enabled and the profile disabled(once you have rebooted)
Well because when I apply it (Zhana / XANA whatever it doesn't matter), swipe to appdrawer lags. When I restart phone it doesn't lags. So I suppose it's not activated auto?
mmm273 said:
Well because when I apply it (Zhana / XANA whatever it doesn't matter), swipe to appdrawer lags. When I restart phone it doesn't lags. So I suppose it's not activated auto?
Click to expand...
Click to collapse
You know why? Because it doesn't work, but I have fixed it: now the module runs the script at late_start instead of post-fs-data, the stage is NON-BLOCKING, it will run in parallel with other processes (by documentation)[Basically it can take "few" seconds to show the results]
I have just checked and it should works: it edits the files in /sys/ with the value of the selected profile.
I will be grateful if you can test it again.
Tried but don't know feel still same like not fully loaded.
mmm273 said:
Tried but don't know feel still same like not fully loaded.
Click to expand...
Click to collapse
I have done few more tests and it looks like the value shown in Kernel Adiutor corresponds to the one of the selected profile...have you applied the profile as a "fresh installation"(not the "Reapply" option)?
Yeah sure I deleted all AKT files and module. Restart phone. Apply your new module. Restart phone. In terminal selected profile. All seems slower but that's ok, restarted phone and yet it was smooth. When I applied it again, again it became slower.
Something isn't right there.
mmm273 said:
Yeah sure I deleted all AKT files and module. Restart phone. Apply your new module. Restart phone. In terminal selected profile. All seems slower but that's ok, restarted phone and yet it was smooth. When I applied it again, again it became slower.
Something isn't right there.
Click to expand...
Click to collapse
My two-cents is tat since the profile is applied during boot you don't feel any slowing down/adjustment of the performance.
I reality I'm not sure, because as I can see the values displayed by Kernel Adiutor(and by the relative involved files) are the same of the profile and they change respect the default one.
I don't know if Nougat behaves differently respect the previous OS or Magisk "init.d" does not process as the "real" one, I have just adapted the module, maybe someone that has more knowledge respect me can solve this doubt.
I would say that it works, however I think that the important thing is that you notice a battery/performance increase.
I am sorry I cannot help you more...but at least the module now doesn't put any file in /system directly...
Razorphyn said:
AKT Profile for Magisk
AKT Profile by Asiier & Senthil360 for Magisk in order to use service.sh(late_start).
Why?
I can't fully mount the /system partition and so /system/etc/init.d/99AKT is not editable.
The result is that at each boot/reboot I have to go through the whole procedure to apply the setting.
This module should make things easier: instead of rely on init.d, it uses the built-in function of magisk.
Profiles/Project Credits:
// Nameless by @Senthil360 | Fusion by @patalao | Burnout PR3 by @Mostafa Wael \ // Project Zhana & X.A.N.A by @Asiier | GhostPepper, HawkPepper and FairPark by @Asiier \
I have just editet the /system/bin/AKT file to make it compatible with Magisk
Original Project:
https://forum.xda-developers.com/oneplus-3/how-to/advanced-interactive-governor-tweaks-t3476589
Change Log
v1.0 - Initial release
v1.1 - Fixed apply profile on boot
Requeriment
Magisk 14.0
Installation
-Uninstall the original AKT package through terminal
-Download the module from the Download section below
-Flash the zip package from Magisk Mangaer and reboot
-Apply the desired profile like you do with the default package from the Terminal emulator:
Code:
su
AKT
Download:
Module: https://github.com/Razorphyn/AKT_Profiles_Magisk/files/1447769/AKT_Profiles_Magisk-1.1.zip
Source:
Repository: https://github.com/Razorphyn/AKT_Profiles_Magisk
Click to expand...
Click to collapse
can it be for Lenovo zuk z2 plus sd 820 device
will it work on that as well?????
Any chance of you doing this for the OP5 version, I have the 5T and AKT for 5 works well on it... Thanks.
It would be great if someone did this for the SD 835.
yung40oz84 said:
Any chance of you doing this for the OP5 version, I have the 5T and AKT for 5 works well on it... Thanks.
Click to expand...
Click to collapse
tech_head said:
It would be great if someone did this for the SD 835.
Click to expand...
Click to collapse
Sorry for the delay, I have adapted the code for OP5, but I am not able to test it. If you want to try, then let me know.
Razorphyn said:
Sorry for the delay, I have adapted the code for OP5, but I am not able to test it. If you want to try, then let me know.
Click to expand...
Click to collapse
I have the OP5T, it should work for that and I would be willing to test. Thanks bud!!! Just let me know and pass along the module, I will flash
I have an Essential. I'm willing to try it.
I have Magisk installed and I know how to back anything out if it doesn't work correctly.
tech_head said:
I have an Essential. I'm willing to try it.
I have Magisk installed and I know how to back anything out if it doesn't work correctly.
Click to expand...
Click to collapse
He said he adapted code for OP5, lol. U can try on Essential but it's a long shot.
yung40oz84 said:
I have the OP5T, it should work for that and I would be willing to test. Thanks bud!!! Just let me know and pass along the module, I will flash
Click to expand...
Click to collapse
I have misspoken, I have adapted the code and updated the first post, you can find the attached module at the end of it.
yung40oz84 said:
He said he adapted code for OP5, lol. U can try on Essential but it's a long shot.
Click to expand...
Click to collapse
tech_head said:
I have an Essential. I'm willing to try it.
I have Magisk installed and I know how to back anything out if it doesn't work correctly.
Click to expand...
Click to collapse
He is not fully wrong, it should support every SD835, but the result is not guaranteed.
Anyway, the module zip is attached at the edn of the first post, in principle nothing or irreparable should occurs