This module patches OPLongshot's code so that it produces PNG screenshots, as it should, instead of JPEG screenshots (ew!). It patches only the VDEX/ODEX files, which have no signature on them — only the APK is signed, which we do not modify, so OPLongshot still retains system signature privileges. The original APK is included to avoid version mismatches (although I don't think there will be much issue even if it isn't includd).
Note that the OPLongshot was taken from the OnePlus 5T's system image. YMMV for other devices on OxygenOS (or even HydrogenOS?).
The current version uses the version of OPLongshot from OnePlus 5T OxygenOS 5.1.0/5.1.1 (same), with version 1.1.0.180328153957.6a699c8.
Remember to clear Dalvik/ART cache after installing this.
GitHub repository (also details of how the patch is done).
Download zip (temporary until the Magisk repo bot refreshes)
any plan for OP5?
h20ray said:
any plan for OP5?
Click to expand...
Click to collapse
Could you upload the APK and odex/vdex files?
Are you going to port it to OnePlus 3/3T devices?
Does it works with the OP5 ?
angelsel said:
Could you upload the APK and odex/vdex files?
Click to expand...
Click to collapse
I've attached the latest the OPLongshot folder (taken from the latest OB14 for the OP5 and zipped). Looking forward to the modifications for this version as well for the OP5, whenever you get the time. Thank you!
shadowstep said:
I've attached the latest the OPLongshot folder (taken from the latest OB14 for the OP5 and zipped). Looking forward to the modifications for this version as well for the OP5, whenever you get the time. Thank you!
Click to expand...
Click to collapse
Do you plan to compile from OB15?
V5 doesn't work on the last OB 14(5T)
Nemo Aeternam said:
V5 doesn't work on the last OB 14(5T)
Click to expand...
Click to collapse
Same here
We will no longer update this great module
We? Hope for an update! jpg must die..
Sent with much love & Android. OnePlus 5T
Would be great to see an update, no longer works on Pie for OP6.
This was meant for the OnePlus 5T stable builds only (as the title states); I don't use the beta builds, nor do I own a OnePlus 6. That the modified vdex even worked on the beta builds and non-5T builds was not intentional.
Someone else can follow the method I have detailed to create modules for the OnePlus 6 and the 5T open betas.
The current version works on OxygenOS 5.1.5 for OnePlus 5T (the APK did not change from 5.1.4 to 5.1.5).
angelsel said:
This was meant for the OnePlus 5T stable builds only (as the title states); I don't use the beta builds, nor do I own a OnePlus 6. That the modified vdex even worked on the beta builds and non-5T builds was not intentional.
Someone else can follow the method I have detailed to create modules for the OnePlus 6 and the 5T open betas.
The current version works on OxygenOS 5.1.5 for OnePlus 5T (the APK did not change from 5.1.4 to 5.1.5).
Click to expand...
Click to collapse
About vdex2dex, did you use it with the entire AOSP tree or do you have a standalone version with dependencies?
If you do have a standalone version (which I couldn't find) can you provide it?
tanish2k09 said:
About vdex2dex, did you use it with the entire AOSP tree or do you have a standalone version with dependencies?
If you do have a standalone version (which I couldn't find) can you provide it?
Click to expand...
Click to collapse
I used it with the entire AOSP tree. Sorry.
Can i just use it in Oneplus 3??
Sent from my OnePlus3 using XDA Labs
Is there any timeframe on when Pie support for this module will be implemented? It worked fine for me in the previous beta version, and now I can only take screenshots with the module disabled since I updated my OP5T today.
zland said:
Is there any timeframe on when Pie support for this module will be implemented? It worked fine for me in the previous beta version, and now I can only take screenshots with the module disabled since I updated my OP5T today.
Click to expand...
Click to collapse
Yes, we need this mod. Sadly I can't do it myself.. but maybe I can help you out with the needed files, OP?
OP Longshot seem to still be at ver. 1.1.0...
but there is a new folder inside the path of OP Longshot called "lib". Inside that folder is a folder called arm64, and inside arm64 are two files calling "libencryptjni.so" and "op_encrypt.so" maybe these are the reasons the old magisk module won't work? i don't know for sure, but i know that these folders and files aren't present in the magisk module.
I would buy you a beer OP, for updating this mod. :good:
moeq123 said:
Yes, we need this mod. Sadly I can't do it myself.. but maybe I can help you out with the needed files, OP?
OP Longshot seem to still be at ver. 1.1.0...
but there is a new folder inside the path of OP Longshot called "lib". Inside that folder is a folder called arm64, and inside arm64 are two files calling "libencryptjni.so" and "op_encrypt.so" maybe these are the reasons the old magisk module won't work? i don't know for sure, but i know that these folders and files aren't present in the magisk module.
I would buy you a beer OP, for updating this mod. :good:
Click to expand...
Click to collapse
I followed the instructions as mentioned in the GitHub readme, and I ended up successfully getting a modified version.
Sadly though, it doesn't seem to work on android P
I have updated the module, based on OOS OB20 (OP5T) but should also work for OB22 (OP5). Cheers.
Related
Thats my first productive creation for XDA, so dont be to hard to me
I don't like to have features, which I never use, so I always disable or remove everythink i dont need.
On my custom roms I always diable the multi user mode by adding the following line to the build.prop:
Code:
fw.max_users=1
I was annoyed to edit this file after each ROM update.
So I created this module. It just adds the above mentioned line to the build.prop.
It is really simple, but now I don't need to edit the build.prop.
Maybe for someone this can be useful.
It works with:
- Android 6.x (Tested on OnePlus X and OnePlus 3 with CM13)
- Android 7.x (Tested on LOS 14.1 and OxygenOS 4.5.x)
v1.3: Update to Magisk Template 1400 (14.0).
Looks good but I would change the modid to something other than template. This is in the config.sh file and defines the folder it uses under /magisk. Anyways I used your zip as a template for my own build.prop edits that I will post shortly. I'll throw a little credit your way too.
Sorry, I was on vacation and than really busy...
@shinji257: Thank you for the hint. I changed it and uploaded the mod as v 1.1.
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
dima-82 said:
Sorry, I was on vacation and than really busy...
@shinji257: Thank you for the hint. I changed it and uploaded the mod as v 1.1.
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
Click to expand...
Click to collapse
That module probably still works (haven't updated it since posted) but the Magisk template is not updated.
My module does pretty much the same thing as yours, there is only one more line on the prop that I add.
fw.show_multiuserui=0
This disable all the UI and configurations sections for multiuser. Its not obligatory, but for me it makes sense to disable the interface aswell if you are disabling the function.
You can add that if the multiuser options keep showing even after disabling multiuser.
FHC1998 said:
That module probably still works (haven't updated it since posted) but the Magisk template is not updated.
My module does pretty much the same thing as yours, there is only one more line on the prop that I add.
fw.show_multiuserui=0
This disable all the UI and configurations sections for multiuser. Its not obligatory, but for me it makes sense to disable the interface aswell if you are disabling the function.
You can add that if the multiuser options keep showing even after disabling multiuser.
Click to expand...
Click to collapse
When I looked for the build.prop settings to disable multi user functionality I found the mentioned line as well.
But I cannot see any difference if I add it. At least it has not effect on my phone (OnePlus 3, CM13).
dima-82 said:
When I looked for the build.prop settings to disable multi user functionality I found the mentioned line as well.
But I cannot see any difference if I add it. At least it has not effect on my phone (OnePlus 3, CM13).
Click to expand...
Click to collapse
It depends on the device, I originally tested on a few, and some needed this line.
For instance, I tested your module on my device (ZenFone 2 laser) and it worked perfectly without the line, but on my friend's ZenFone 2 it kept showing the UI even though not allowing creating more users.
@dima-82 Module works great for me. I'm running a OP3T on offical LineageOS. All the multiuser stuff is gone from the settings and notification shade.
Sent from my ONEPLUS A3000 using Tapatalk
mp3deviant721 said:
@dima-82 Module works great for me. I'm running a OP3T on offical LineageOS. All the multiuser stuff is gone from the settings and notification shade.
Sent from my ONEPLUS A3000 using Tapatalk
Click to expand...
Click to collapse
Thanks for the feedback.
The official LineageOS for OP3T is Android 7.x? Nightly builds?
dima-82 said:
Thanks for the feedback.
The official LineageOS for OP3T is Android 7.x? Nightly builds?
Click to expand...
Click to collapse
The build I'm running is 7.1.1. Haven't tried 7.1.2 yet. Yes on the "nightly" build.
Sent from my ONEPLUS A3000 using Tapatalk
@dima-82,
Hello, I used your module to enable multi user mode, all I did is edited the file inside the .zip where the string to disable the multi user mode is located, and replaced it with the two strings to enable it.
Now I was wondering since this works, could I make a thread with the mod?
I would obviously credit You, and link to Your profile and this thread.
Here is the module on my device :silly:
dariomrk said:
@dima-82,
Hello, I used your module to enable multi user mode, all I did is edited the file inside the .zip where the string to disable the multi user mode is located, and replaced it with the two strings to enable it.
Now I was wondering since this works, could I make a thread with the mod?
I would obviously credit You, and link to Your profile and this thread.
Click to expand...
Click to collapse
Of course you can do.
But as mentioned in post #3 there was already a similar module. I think it does exactly what you need.
dima-82 said:
Of course you can do.
But as mentioned in post #3 there was already a similar module. I think it does exactly what you need.
Click to expand...
Click to collapse
Oh, I didn't see that, I will check if it does the exactly same thing (probably yes)...
---------- Post added at 03:06 PM ---------- Previous post was at 03:05 PM ----------
Just checked it out, and yes it does the exactly same thing
Please I need multiuser enable magisk module for Android 6
dima-82 said:
And actually I found already a similar magisk module created by user @FHC1998:
https://forum.xda-developers.com/apps/magisk/magisk-multiuser-enable-disable-t3552643
Click to expand...
Click to collapse
Here
Got bootloop after the install of this module.
Device: Zuk Z2
ROM: AEX 4.4
Unofficial Magisk 13.2 (170716)
I am running it on official Magisk 13.2 without any issues.
Did you also install other modules?
dima-82 said:
I am running it on official Magisk 13.2 without any issues.
Did you also install other modules?
Click to expand...
Click to collapse
Yes have other 5 modules
You installed / activated only this very one module and got a bootloop?
Before I created this module I edited the build.prop manually. And if you make a mistake there, you will get a bootloop as well.
May be your OS does not support this property.
I tested on my devices only, and it worked always.
Eventually you can try an other module from @FHC1998, which should do the same:
https://forum.xda-developers.com/showpost.php?p=71936097&postcount=3
jhobc said:
Got bootloop after the install of this module.
Device: Zuk Z2
ROM: AEX 4.4
Unofficial Magisk 13.2 (170716)
Click to expand...
Click to collapse
You could eventually try this mod:
https://forum.xda-developers.com/apps/magisk/module-single-user-mod-t3639486#post73160966 by @seebz
Hi,
I just got my Google WiFi 3-kit and it seems that the channel they work on (149) wasn't supported in my country (NL) so I made a simple Magisk module to change the region to [EU]
This 'fix' is simpy a change to "wifi-service.jar" which can be located in /system/framework/
Source: https://github.com/thomasvt1/extendwifi
DOWNLOAD
Updates v7
Update OOS to 4.5.10
Add support for Magisk v14.0
Special thanks to:
- https://forum.xda-developers.com/pixel/themes/mod-wifi-country-code-fix-root-required-t3558044
Would there be any benefit to flashing this if I'm in the US, or do they all have the NL flag?
The wifi region is selected based on the SIM in your phone. Most people won't need this, care, or notice.
Second, this is probably illegal since it changes your phone to use frequencies that are not allowed in the users home country. Is anyone going to get caught or in trouble for this? Unlikely. But it also won't be useful unless you've purchased hardware that broadcasts on frequencies not allowed in your country. IE, Google WiFi hasn't been released in Europe yet and doesn't officially follow EU frequency range. Which is why it's useful for @Thomasvt but not for anyone else.
@PokemonTotalWar: Long answer? No.
@PokemonTotalWar: For US users, probably not, except if you use channel 12/13 from the 2.4GHz spectrum. > https://en.wikipedia.org/wiki/List_of_WLAN_channels
@Raharazod Actually Google WiFi is released in the EU. (France, Germany and the UK) http://www.androidpolice.com/2017/06/26/google-wifi-may-coming-france-monday/ as for my country. All Apple products, and my laptop happily use the 5GHz network without any modification except my OnePlus 5.
Thomasvt said:
@Raharazod Actually Google WiFi is released in the EU. (France, Germany and the UK) http://www.androidpolice.com/2017/06/26/google-wifi-may-coming-france-monday/ as for my country. All Apple products, and my laptop happily use the 5GHz network without any modification except my OnePlus 5.
Click to expand...
Click to collapse
OH! I thought it was still pending release over here. Wasn't really keeping a close eye.
Well it shouldn't.
There ARE 5Ghz bands that are allowed in the EU, just not all of them. I was assuming that your module enabled ones that weren't otherwise allowed.
I've got my phone bootloop
Thomasvt said:
Hi,
I just got my Google WiFi 3-kit and it seems that the channel they work on (149) wasn't supported in my country (NL) so I made a simple Magisk module to change the region to [EU]
This 'fix' is simpy a change to "wifi-service.jar" which can be located in /system/framework/
Source: https://github.com/thomasvt1/extendwifi
DOWNLOAD
Updates v7
Update OOS to 4.5.10
Add support for Magisk v14.0
Special thanks to:
- https://forum.xda-developers.com/pixel/themes/mod-wifi-country-code-fix-root-required-t3558044
Click to expand...
Click to collapse
After installing module I've got my phone bootloop. May you define place for the original wifi-service.jar file during module installation.
Thanks, Kinger
Kinger1970 said:
After installing module I've got my phone bootloop. May you define place for the original wifi-service.jar file during module installation.
Thanks, Kinger
Click to expand...
Click to collapse
Just use 'magisk mount' and remove it from /magisk.
What O2OS are you running?
Thank you for quick response
Thomasvt said:
Just use 'magisk mount' and remove it from /magisk.
What O2OS are you running?
Click to expand...
Click to collapse
Thank you, restored system easily. Problem I'm not running O2OS system on phone I've crashed, installed on different phone by mistake.
Thank you, cheers!
I got another Problem on oreo closed beta 2.
After update from 4.5.14 my 5ghz wont connect with settings in router auto channel..
This means channels 36 above until 52 wont work.
If i sett a special channel like 52 above my 5ghz wifi connects to my op5..
Did OnePlus messed something up?
Located in Germany op5 A5000
Hi Dimontiman,
Have you tried with the official OxygenOS Open Beta 1? Since leaked closed beta 1 and 2 were not made for public and lots of bugs.
Did it give any errors when adding the module in Magisk?
If still doesn't work on official open beta 1, then perhaps an update to this module would be required perhaps.
keepasa said:
Hi Dimontiman,
Have you tried with the official OxygenOS Open Beta 1 (8.0)?
Click to expand...
Click to collapse
Yes both open beta 1 and xlosed beta 2
Same Wifi Problems
I do have a Oxygen (leaked build 1) version on my github: https://github.com/thomasvt1/extendwifi/tree/4.5.2 (just download as zip).
I haven't been able to get smali working yet with the open beta 1. I'm not sure if the closed beta one works on the open beta.
Edit: My version from git still does work with the open beta 1. Just tested.
Edit2: New updated version for Open Beta 1: https://github.com/thomasvt1/extendwifi/tree/O2_Open1 [just downoad zip and use in magisk]
Thomasvt said:
I do have a Oxygen (leaked build 1) version on my github: https://github.com/thomasvt1/extendwifi/tree/4.5.2 (just download as zip).
I haven't been able to get smali working yet with the open beta 1. I'm not sure if the closed beta one works on the open beta.
Edit: My version from git still does work with the open beta 1. Just tested.
Edit2: New updated version for Open Beta 1: https://github.com/thomasvt1/extendwifi/tree/O2_Open1 [just downoad zip and use in magisk]
Click to expand...
Click to collapse
Hey
Appreciate your work, what does your module change exactly?
Additional to OP
Dimontiman said:
Hey
Appreciate your work, what does your module change exactly?
Additional to OP
Click to expand...
Click to collapse
It changes just one file; https://github.com/thomasvt1/extendwifi/tree/O2_Open1/system/framework
And then just the setCountryCode method as per this guide;
https://forum.xda-developers.com/pixel/themes/mod-wifi-country-code-fix-root-required-t3558044
open beta is supported?
enskje said:
open beta is supported?
Click to expand...
Click to collapse
https://github.com/thomasvt1/extendwifi/archive/O2_Open1.zip
This is for Open Beta 1
Small update for Openbeta 1 - the region didn't apply every boot so I fixed that;
https://github.com/thomasvt1/extendwifi/archive/O2_Open1.zip
Thomasvt said:
Small update for Openbeta 1 - the region didn't apply every boot so I fixed that;
https://github.com/thomasvt1/extendwifi/archive/O2_Open1.zip
Click to expand...
Click to collapse
Hey can you update this version to magisk repo as i cant use the zip on magisk
Dimontiman said:
Hey can you update this version to magisk repo as i cant use the zip on magisk
Click to expand...
Click to collapse
Sorry the magisk repo version will only be the stable version of OxygenOS.
Maybe try a file explorer to select the zip, I know ES File Explorer works when using the 'file way' and not the 'normal android way'.
I hope this helps!
Thomasvt said:
Sorry the magisk repo version will only be the stable version of OxygenOS.
Maybe try a file explorer to select the zip, I know ES File Explorer works when using the 'file way' and not the 'normal android way'.
I hope this helps!
Click to expand...
Click to collapse
If i flash the zip from twrp, can stock be afterwards restored? I mean to uninstall
According to Project Treble lead Iliyan Malchev,
Malchev says that Treble standardizes Android hardware support to such a degree that generic Android builds compiled from AOSP can boot and run on every Treble device. In fact, these “raw AOSP” builds are what will be used for some of the CTS testing Google requires all Android OEMs to pass in order to license the Google apps—it’s not just that things should work, they are required to work.
Click to expand...
Click to collapse
Now that there's an Oreo beta for the Essential Phone that supports Treble, perhaps this can be used to further development on the device.
/u/foremi on Reddit confirmed that simply flashing a Pixel 2 system and boot image to the device is not enough, as it fails to boot, so the question is what constitutes a generic AOSP build?
I don't have Linux installed right now or I'd build it myself, but I suspect that building it with the simple target device of "generic" might be what Malchev is referring to.
If any devs would like to test this theory or give their input as to how they think this actually works I think it'd be incredibly useful for not just Essential phone development, but Android development as a whole.
EDIT: @phhusson confirms that the target device should be aosp_arm64_ab
FWIW "generic AOSP build" is really what it says it is.
I have access to the "Google certification generic AOSP build" (that's weirdly not public, I don't know why), so I gave it a try. (Edit: So if the ROM was Treble-certified, it would work)
I get the Android bootanimation, but that's all (I have to say that's still a big step forward compared to other Android versions
Looking at the logs, I see a loop of crash because of: /vendor/bin/hw/[email protected]
Which I guess is the HAL for the accessories, but that doesn't seem to be the reason for the crash
The reason of the crash, seem to be this:
11-15 12:59:04.491 5331 5331 F MediaProfiles: frameworks/av/media/libmedia/MediaProfiles.cpp:329 CHECK(quality != -1) failed.
in CAF, frameworks/av/media/libmedia/MediaProfiles.cpp we see vendor-specific (i.e. not in AOSP) quality attributes, like "vga"
And it is defined by Essential's framework (in vendor/etc/media_profiles_V1_0.xml)
Considering there are media_profiles xml files, I'd guess that _V1_0 is supposed to only contain AOSP-capable qualities
Edit2: The fingerprint of "certification generic AOSP", is Android/aosp_arm64_ab/generic_arm64_ab:8.0.0/OTR1.171023.001/4412360:userdebug/test-keys
So my guess to build this is that lunch aosp_arm64_ab && make should work
Edit3: the generated fingerprint is too long to build, needs to do make BUILD_NUMBER=4412360
Edit4: To make the situation more clear:
- NO, current ROM is NOT Treble capable
- BUT, almost everything is available for that. Every HAL is using "hwbinder" which is the basis, and most work needed for Treble
Also, I've seen some reddit comment mentioning boot.img.
Current version of Treble only concerns system.img, and NOT boot.img!
Future version are supposed to have generic boot.img as well, but that's not to be expected before at the very least Android P.
phhusson said:
Edit2: The fingerprint of "certification generic AOSP", is Android/aosp_arm64_ab/generic_arm64_ab:8.0.0/OTR1.171023.001/4412360:userdebug/test-keys
So my guess to build this is that lunch aosp_arm64_ab && make should work
Click to expand...
Click to collapse
I was gonna link to the aosp_arm64 make file but it said it was specifically for the emulator so I wasn't sure, that's good to know though.
phhusson said:
Also, I've seen some reddit comment mentioning boot.img.
Current version of Treble only concerns system.img, and NOT boot.img!
Future version are supposed to have generic boot.img as well, but that's not to be expected before at the very least Android P.
Click to expand...
Click to collapse
Thanks for this, I suspected such but couldn't find a clear answer from Google on the matter so I suggested trying the boot.img as well just in case.
Now, someone has to test this on a different Treble device such as the Pixel or Pixel 2. I'm thinking MAYBE because the Oreo build for essential is just a beta its treble implementation isn't finished and hasn't passed Google's CTS requirements to boot the generic aosp image. Perhaps this will change in the final build.
For what it's worth I only have a LG V20 right now which currently doesn't support Treble, so I'm pretty useless as far as testing anything goes, but if this is figured out it'll greatly influence what device I go with when I eventually upgrade.
Now, someone has to test this on a different Treble device such as the Pixel or Pixel 2.
Click to expand...
Click to collapse
Yup. I feel like Treble deserves its own "device" section in XDA
I'm afraid I'm working on something that other people already did on other devices...
I'm thinking MAYBE because the Oreo build for essential is just a beta its treble implementation isn't finished and hasn't passed Google's CTS requirements to boot the generic aosp image. Perhaps this will change in the final build.
Click to expand...
Click to collapse
That's my guess as well.
Interesting stuff. Excited to hear updates on this. PM me if you make a breakthrough and want a feature
MishaalRahman said:
Interesting stuff. Excited to hear updates on this. PM me if you make a breakthrough and want a feature
Click to expand...
Click to collapse
There's not much I can do on my end sadly, without a Treble capable device, but if anyone is interested in trying this on another device with a mainline Treble-enabled Oreo build I'd install Linux and post the build up so just let me know
PhantomGamers said:
There's not much I can do on my end sadly, without a Treble capable device, but if anyone is interested in trying this on another device with a mainline Treble-enabled Oreo build I'd install Linux and post the build up so just let me know
Click to expand...
Click to collapse
Google Pixel/Pixel 2 will do, yes?
MishaalRahman said:
Google Pixel/Pixel 2 will do, yes?
Click to expand...
Click to collapse
Yeah they should be fine
PhantomGamers said:
Yeah they should be fine
Click to expand...
Click to collapse
Alright, I'll find you some testers
MishaalRahman said:
Alright, I'll find you some testers
Click to expand...
Click to collapse
Here's the system image if you find anyone, it's a straight fresh build of aosp branch 8.0.0r34
If it doesn't work it's possible that I messed the build up, but it should be fine.
Can someone running the Oreo beta post their results running this app?
If the beta isn't CTS compliant, we should know.
PhantomGamers said:
Can someone running the Oreo beta post their results running this app?
If the beta isn't CTS compliant, we should know.
Click to expand...
Click to collapse
Hero you go
TheDethEgineer said:
Hero you go
Click to expand...
Click to collapse
Thanks a lot!
This is interesting... according to Malchev, CTS testing REQUIRES a device to boot a generic AOSP image, and yet the Oreo build is CTS certified and doesn't boot the AOSP image...
PhantomGamers said:
Thanks a lot!
This is interesting... according to Malchev, CTS testing REQUIRES a device to boot a generic AOSP image, and yet the Oreo build is CTS certified and doesn't boot the AOSP image...
Click to expand...
Click to collapse
That's true only for new devices, not for devices upgrading for nougat to oreo.
I wasn't aware there was an AMA yesterday... Too bad we could have asked.
Tester with OG Pixel XL says it gives invalid zip file format error when trying to flash in TWRP
MishaalRahman said:
Tester with OG Pixel XL says it gives invalid zip file format error when trying to flash in TWRP
Click to expand...
Click to collapse
How about flashing the system image directly from a Pixel 2 XL?
MishaalRahman said:
Tester with OG Pixel XL says it gives invalid zip file format error when trying to flash in TWRP
Click to expand...
Click to collapse
It's not a TWRP flashable zip, you have to extract the system.img from the zip and flash it with fastboot in the bootloader.
Also as @PresidentMcCain said, seeing the results of flashing a pixel 2 xl system image would be interesting too.
Oh and make sure the tester's OG pixel is already running Oreo before trying. Just adding that in case they didn't upgrade yet.
PhantomGamers said:
It's not a TWRP flashable zip, you have to extract the system.img from the zip and flash it with fastboot in the bootloader.
Also as @PresidentMcCain said, seeing the results of flashing a pixel 2 xl system image would be interesting too.
Oh and make sure the tester's OG pixel is already running Oreo before trying. Just adding that in case they didn't upgrade yet.
Click to expand...
Click to collapse
Ah, I see.
Do you happen to know the exact command? I'm not that familiar with A/B partition devices and how that changes fastboot commands.
MishaalRahman said:
Ah, I see.
Do you happen to know the exact command? I'm not that familiar with A/B partition devices and how that changes fastboot commands.
Click to expand...
Click to collapse
I believe it should work as normal
fastboot flash system system.img
EDIT: Apparently with the A/B partitions you'd do fastboot flash system_b system_other.img to flash the b partition, but the aosp build didn't include a system_other.img so I'm assuming perhaps it's not necessary
So far I still can't find anyone willing to flash this on their Pixel haha. People are really hesitant to flash stuff on the Pixel it seems. Times are not like they used to be =\
Disclaimer :
Code:
I am not responsible for any damage to your device!
Use this mod at your own risk!
What's this?
This mod increases the audio bitrate on video recording from a disgraceful 96kbps to a respectable 320kbps. Thus, giving a richer, more pleasing audio quality.
Still confused? Click here for a better explanation
Requirements :
- A rooted phone with magisk installed
- An opened mind (important!)
Contributors :
@Jt380p
@Slim K
* NOTES * (READ) :
- Not all ROMs are compatible with this mod, you might end up in a bootloop. YOU HAVE BEEN WARNED!
Download :
https://drive.google.com/file/d/1wr-p7puOL8nYb1wj1AyVbh9XmMp5kRKI/view?usp=sharing (Flash with magisk manager)
Source :
https://forum.xda-developers.com/Mi-9/themes/magisk-audio-bitrate-increase-t3927810
Audio files provided by @Slim K
Thanks to :
@Slim K
@topjohnwu for Magisk
Created : 7/11/2020
Last updated : 7/11/2020
reserved
Just tried it on stock MIUI with stock camera and Gcam. Works like a charm. Ty :good:
Slim K said:
Just tried it on stock MIUI with stock camera and Gcam. Works like a charm. Ty :good:
Click to expand...
Click to collapse
For me it works on Stock, but not on Urnyx05 GCam. Thanks Dev.
Lineage android 11 will benefit from it, or that is already implemented in them?
So which ROMs are not compatible?
Aki-to said:
So which ROMs are not compatible?
Click to expand...
Click to collapse
This mod uses magisk module template to replace a file in vendor folder. A tip for beginners using such a mod is to inspect it to know what it does. For example in the root of the module zip you will find the folder system, which has the needed folders/files path for replacement. If you open install.sh in text viewer, you would read the line :
Bash:
set_perm $MODPATH/system/vendor/etc/media_profiles_vendor.xml 0 0 0644
That should tell you which file it is and their permissions. Now open the same path on your ROM and look for that file, if it exists, then it should work. Although not every camera app (e.g gcam) uses that file.
Slim K said:
This mod uses magisk module template to replace a file in vendor folder. A tip for beginners using such a mod is to inspect it to know what it does. For example in the root of the module zip you will find the folder system, which has the needed folders/files path for replacement. If you open install.sh in text viewer, you would read the line :
Bash:
set_perm $MODPATH/system/vendor/etc/media_profiles_vendor.xml 0 0 0644
That should tell you which file it is and their permissions. Now open the same path on your ROM and look for that file, if it exists, then it should work. Although not every camera app (e.g gcam) uses that file.
Click to expand...
Click to collapse
Thanks, this was very helpful.
Indeed, it seems like a very easy set of scripts, did not expect that. However, the only thing I could not find is where the default functions are actually called, though I assume these are generic functions that are always called by Magisk, no matter which module is being installed.
This mod is also so extremely tiny, you could pretty much make these changes manually. Just take care of permissions and replace the file, that's it. It's even less complicated than working with /etc/fstab, it seems.
Perhaps I should release a couple of mods myself, if mod devs are getting such a Magisk Module template thing, anyway, which pretty much does all the work, already.
Aki-to said:
Thanks, this was very helpful.
Indeed, it seems like a very easy set of scripts, did not expect that. However, the only thing I could not find is where the default functions are actually called, though I assume these are generic functions that are always called by Magisk, no matter which module is being installed.
Click to expand...
Click to collapse
You assume correctly. The path to the functions can be usually found in /data/adb/magisk/util_functions.sh on your device.
Perhaps I should release a couple of mods myself, if mod devs are getting such a Magisk Module template thing, anyway, which pretty much does all the work, already.
Click to expand...
Click to collapse
Why write code twice when it already exists and works for everyone.
Hello, could someone please confirm if it works on firmware xiaomi eu 12.0.4. stable, thank you very much.
nike1973 said:
Hello, could someone please confirm if it works on firmware xiaomi eu 12.0.4. stable, thank you very much.
Click to expand...
Click to collapse
Yes it works
Thank you. Works on MIUI EU 12.0.6.
Eu 12.0.6, super stabilization (on stock camera) crashes when module is active.
I flashed it to the phone. The stock camera app still records audio at 127kbps. Does not save with 320kbps!.I use Indonesian stable miui 12/android 10. please Help!
Anyone tried on Xiaomi.eu rom?
Running 12.0.8.
Hi!
gkhnkaanyrtc said:
I flashed it to the phone. The stock camera app still records audio at 127kbps. Does not save with 320kbps!.I use Indonesian stable miui 12/android 10. please Help!
View attachment 5272691View attachment 5272693
Click to expand...
Click to collapse
Hi! I have the same problem ... Did you fix it? I use Miui 12.0.1 with Android 11
320kbps should be the default, I wonder why the f**k Xiaomi gives us 96kbps.
Does it work in Pixel Experience rom on Surya?
EDIT: It's too annoying to maintain and edit 6 separate threads. The installer works across all devices, so please visit this post for the latest version: https://forum.xda-developers.com/t/...or-patch-levels-2021-01-05-and-later.4226343/
Thanks!
NOTE: Download link in the OP will install mod for the current patch level down to January 2021. It will detect your current patch level and install the correct file. For earlier system builds from 2020 and prior, please use the official discontinued module on the Magisk Manager repo. I did not clone the entire Active Edge Mod repository; my unofficial repository only hosts January 2021 and later builds.
Changes:
I know, I know... I said I was done with releasing my Unofficial Active Edge Mod installer, yet here's another month's update. I might keep doing it for those that update immediately and want it a bit sooner, so long as it's fortunate enough to happen on a day when I'm able to do it relatively quickly. Since I'm building these anyway and sending them over to the dev, for now, to upload to the official Magisk repo, for now I don't mind also updating it here a bit sooner. Anyway, more on this below and some of the headache involved moving forward...
04-05-2021: Soooo... the script I wrote to churn these out as quickly as possible as Google releases the updates, relied on system image dumps on GitRip... unfortunately the domain was seized by the FBI (lol) and so it looks like the old dumper is no longer updating his Android dumps repo on GitRip. Fortunately, mikalovtch pointed me over to a new source that hosts such system dumps, and I was able to get these done relatively quickly afterwards. OP is updated with the 04-05-2021 installer now!
03-02-2021: Meant to post an update a week or two ago. Noticed the magisk module on the official Magisk repo now says [RE-CONTINUED], so there really isn't much need for me to continue updating this anymore! As a final gift, I ran my batch builder script and built the modded apk's for all variants for the 2021-03-05 patch level, and download link for the module installer is in the OP.
02-02-2021: February 2021 mod is now uploaded. Updated installer is in the link in the OP.
02-01-2021: Modified and uploaded modded SystemUIGoogle.apk files for 3 / 3 XL / 3a / 3a XL to GitHub repository. Updated Magisk installer slightly to accommodate this, and removed a few unnecessary lines. Won't make any difference if you already installed the first release.
i5lee8bit said:
ONLY WORKS FOR PIXEL 4 XL "CORAL" AND PIXEL 4 "FLAME"!!!!
(WON'T EVEN INSTALL ON OTHER DEVICES, SO DON'T BOTHER)
tl;DR - A continuation of the "[Discontinued]Active Edge Mod for Pixel devices" Magisk module on the Magisk Module Repository, discontinued and last released for 2020-12-05 patch level. This is simply the same exact mod applied to the 2021-01-05 patch level. PLEASE DO NOT BOTHER THE ORIGINAL DEV FOR ANY SUPPORT - THIS IS AN UNOFFICIAL MOD.
Click to expand...
Click to collapse
awesome work mate, love this mod. i saw ur post on pixel 4xl forum first and downloaded and flashed that. everything seems 2b working fine! but then i noticed this thread posted seperately on our phone's forum. is there any difference between them?? just wanna make sure that i flashed the rite file. thx again for all mate
vdevl said:
awesome work mate, love this mod. i saw ur post on pixel 4xl forum first and downloaded and flashed that. everything seems 2b working fine! but then i noticed this thread posted seperately on our phone's forum. is there any difference between them?? just wanna make sure that i flashed the rite file. thx again for all mate
Click to expand...
Click to collapse
Yep, you flashed the right file. Both posts link to the same zip file. The module installer, like the original module, gathers your device information and then downloads the correct file for your device and installs it. Even has an MD5 hash checksum check to make sure it's all good before installing. It was actually a really fun little project to work on, and interesting to see how Jan designed it to be semi-automated, with several fail-safe checks. For example, there's a post fs data script to also disable the module automatically if the user upgrades the system patch level and hasn't yet upgraded the module, likely to ensure the systemuigoogle mod isn't incompatible with the new update and potentially cause issues. Really well designed by the original dev!
How do I actually map it? I have installed on my pixel 4xl but it only opens an unusable google assistant UI.