Database Develop

Advanteges of Magisk?

I want to root my device.
But I'm unable to decide that I should root via supersu or Magisk.
I've read that magisk provide systemless root, but what the advanteges of systemless root/magisk?
Can someone help me that what's the use/advantage of Magisk?
is it much stable then supersu?
I don't want to risk my device as I'm app developer

akash.galaxy07 said:
I want to root my device.
But I'm unable to decide that I should root via supersu or Magisk.
I've read that magisk provide systemless root, but what the advanteges of systemless root/magisk?
Can someone help me that what's the use/advantage of Magisk?
is it much stable then supersu?
I don't want to risk my device as I'm app developer
Click to expand...
Click to collapse
If you are an app developer, use Magisk. Magisk allows you to pass google's safety tests (Safetynet) - which you should know about if you develop apps! but basically, google will not think your device is compromised is you use Magisk, but WILL think your device is compromised if you use SuperSU - even if SuperSU is installed in Systemless mode. Don't forget to enable magisk hide in the Magisk Manager app to make sure this works though.
Some app developers will check safetynet upon launching their app to see if the device is compromised, and if it is, either restrict features, or deny access entirely. A good example of this is Banking apps, though they usually use their own root detection - but that can be hidden with Magisk Hide. - No bank wants their app being used on a compromised device, where a virus with root access could collect information. The more you know

manor7777 said:
If you are an app developer, use Magisk. Magisk allows you to pass google's safety tests (Safetynet) - which you should know about if you develop apps! but basically, google will not think your device is compromised is you use Magisk, but WILL think your device is compromised if you use SuperSU - even if SuperSU is installed in Systemless mode. Don't forget to enable magisk hide in the Magisk Manager app to make sure this works though.
Some app developers will check safetynet upon launching their app to see if the device is compromised, and if it is, either restrict features, or deny access entirely. A good example of this is Banking apps, though they usually use their own root detection - but that can be hidden with Magisk Hide. - No bank wants their app being used on a compromised device, where a virus with root access could collect information. The more you know
Click to expand...
Click to collapse
Thanks bro, and, is it stable too? I mean, are there any risks involved?

akash.galaxy07 said:
Thanks bro, and, is it stable too? I mean, are there any risks involved?
Click to expand...
Click to collapse
There are risks with any kind of root on your phone, as an app developer, you should know that.
You could get a virus that takes advantage of root to encrypt all of your files.
Again, you should know this if you are an app developer, there is a difference between creating a single app, and developing applications as a whole!
Magisk is very stable though, more so on OxygenOS but it will be pretty stable with LineageOS too! I have had no problems whatsoever! I have been using android pay and all my root apps without my phone ever crashing! And if you are careful, you won't get a virus (root will not cause a virus, user stupidity gets virus') - enjoy

I'd like to add the main advantage to why I use Magisk.
All my system modifications (build.prop changes, debloating, changed/removed ui audio, etc) are still there after a system update. Even if I have to do a clean install with a wipe, all it takes is flashing a couple of extra zips and everything is right back were I want it.

Didgeridoohan said:
I'd like to add the main advantage to why I use Magisk.
All my system modifications (build.prop changes, debloating, changed/removed ui audio, etc) are still there after a system update. Even if I have to do a clean install with a wipe, all it takes is flashing a couple of extra zips and everything is right back were I want it.
Click to expand...
Click to collapse
Can you please link me to Magisk installation thread for Oneplus 3t. I can't find any on XDA. I found one thread that belongs to Magisk dev but it is very confusing with installing all the systemless SuperSU and such.

vipivj said:
Can you please link me to Magisk installation thread for Oneplus 3t. I can't find any on XDA. I found one thread that belongs to Magisk dev but it is very confusing with installing all the systemless SuperSU and such.
Click to expand...
Click to collapse
There's no specific 3T thread that I know of... It's all there in the Magisk forums. It's not as complicated as it might seem.
If you're unrooted, just flash the Magisk zip in TWRP. Done!
If you have systemless SuperSU installed and want to keep it, just flash the Magisk zip in TWRP. Done!
If you have systemless SuperSU installed and want to switch to MagiskSU, you'll need to first remove SuperSU. Use the full unroot option in the SuperSU app and say yes when asked if you want to restore the boot image backup. After that, flash the Magisk zip in TWRP. Done!
If you have any other root installed, just flash the Magisk zip in TWRP and the installation script will do it's best to remove it and install MagiskSU instead. Done!
Edit: There might be variations on the above, depending on if you're using stock ROM or not. Take a look at the link in my signature if you run into problems. I've tried to collect as much info, tips and tricks as possible in one place.

Didgeridoohan said:
There's no specific 3T thread that I know of... It's all there in the Magisk forums. It's not as complicated as it might seem.
If you're unrooted, just flash the Magisk zip in TWRP. Done!
If you have systemless SuperSU installed and want to keep it, just flash the Magisk zip in TWRP. Done!
If you have systemless SuperSU installed and want to switch to MagiskSU, you'll need to first remove SuperSU. Use the full unroot option in the SuperSU app and say yes when asked if you want to restore the boot image backup. After that, flash the Magisk zip in TWRP. Done!
If you have any other root installed, just flash the Magisk zip in TWRP and the installation script will do it's best to remove it and install MagiskSU instead. Done!
Edit: There might be variations on the above, depending on if you're using stock ROM or not. Take a look at the link in my signature if you run into problems. I've tried to collect as much info, tips and tricks as possible in one place.
Click to expand...
Click to collapse
Thanks, it is clear now. Is it possible to 100% pass safety net with Magisk? I read somewhere that it's a hit and miss.
Apart from the Magisk modules what's the benefit of rooting with Magisk instead of superSU? I saw many people still support superSU than Magisk, does it mean that Magisk has some flows or bugs?

vipivj said:
Thanks, it is clear now. Is it possible to 100% pass safety net with Magisk? I read somewhere that it's a hit and miss.
Apart from the Magisk modules what's the benefit of rooting with Magisk instead of superSU? I saw many people still support superSU than Magisk, does it mean that Magisk has some flows or bugs?
Click to expand...
Click to collapse
I've had no issues passing SafetyNet on my OP3T. It depends on what ROM you're using and if you have any other modifications that Magisk Hide can't hide. Apart from Magisk Hide and systemless modifications Magisk is also open source, if you value that kind of stuff...
There might be apps out there that use specific SuperSU stuff and won't work fully with MagiskSU. I haven't had any issues though (apart from a couple of workarounds, like for Tasker - again, see my signature) and many app developers are starting to make their apps work with MagiskSU as well. Most work out of the box though.

MagiskHide
You can use apps like Android Pay or Snapchat on a rooted device

Didgeridoohan said:
I've had no issues passing SafetyNet on my OP3T. It depends on what ROM you're using and if you have any other modifications that Magisk Hide can't hide. Apart from Magisk Hide and systemless modifications Magisk is also open source, if you value that kind of stuff...
There might be apps out there that use specific SuperSU stuff and won't work fully with MagiskSU. I haven't had any issues though (apart from a couple of workarounds, like for Tasker - again, see my signature) and many app developers are starting to make their apps work with MagiskSU as well. Most work out of the box though.
Click to expand...
Click to collapse
Another noob question, what is the difference between normal and systeless SuperSU?
Considering current known problems Magisk have , isn't it a good idea to use Magisk superSU combo and SuperSU hide?

vipivj said:
Another noob question, what is the difference between normal and systeless SuperSU?
Considering current known problems Magisk have , isn't it a good idea to use Magisk superSU combo and SuperSU hide?
Click to expand...
Click to collapse
Systemless root doesn't alter /system... If you want a more in-depth explanation I'm sure your friend Google can explain it to you.
For OP3T on OxygenOS (I'm currently on 4.1.3) I've not experienced any issues with Magisk. I don't know what those "currently known problems" are that you're worried about...

Didgeridoohan said:
Systemless root doesn't alter /system... If you want a more in-depth explanation I'm sure your friend Google can explain it to you.
For OP3T on OxygenOS (I'm currently on 4.1.3) I've not experienced any issues with Magisk. I don't know what those "currently known problems" are that you're worried about...
Click to expand...
Click to collapse
I meant those issues happens with Tasker etc. Thank you for the answers, you've been very helpful.
I started googling and reading in XDA as well but you know the doubts that comes along ?

vipivj said:
I meant those issues happens with Tasker etc. Thank you for the answers, you've been very helpful.
I started googling and reading in XDA as well but you know the doubts that comes along
Click to expand...
Click to collapse
Ah... Ok. Those kind of issues are easy to work around and the next version of Tasker will have official MagiskSU support.

Use Magisk Manager
I also used Magisk Manager in my old device at it worked fine and as magisk allow you to root Android without effecting on system files I could also install root unsupported apps as well. So i think Magisk is the best solution for you.
link deleted by Moderator due to untrustworthy site will be a help full site to gather more info about magisk from one place.

Topjohnwu has strictly stated that any website which spreads Magisk is not official and cannot be trusted. The only official place is the XDA Thread. If you see any Member promoting an external site related to Magisk, please report the post.

Apps refuse to start because phone being rooted but it isn't!

At least 2 of my Apps refuse to start. One is my banking app and they do not offer any other way of interaction.
The problem is that the phone in fact is not rooted! It's just "OEM unlocked" to be prepared for root (which I need for E.g. titanium backup, but only maybe once a month).
Please give me a way out of this vicious circle!
I cannot remove the OEM unlock because it requires full wipe every time. Or is there a way?
Or what can I possibly tell the App Provider to improved their Code so that Oneplus phone state is being recognized (more) correctly?
Any help would be greatly appreciated.

Use Magisk I guess? Use it to hide root from that app.

Reeb_Lam said:
Use Magisk I guess? Use it to hide root from that app.
Click to expand...
Click to collapse
In fact I already flashed an official image and still (with no zip installed via TWRP) I'm getting refusals from these apps.
So for sure some apps decide from something else then simply an installed "root" manager or the installed "su" binaries.
What else could they decide from? "OEM unlock" was my first guess (and it would also be the worst, because as far as I know it can't be "hidden" temporarily, or can it?), but maybe there are other settings. Does anybody know more?

ako673de said:
In fact I already flashed an official image and still (with no zip installed via TWRP) I'm getting refusals from these apps.
So for sure some apps decide from something else then simply an installed "root" manager or the installed "su" binaries.
What else could they decide from? "OEM unlock" was my first guess (and it would also be the worst, because as far as I know it can't be "hidden" temporarily, or can it?), but maybe there are other settings. Does anybody know more?
Click to expand...
Click to collapse
You need to do some reading about Safetynet. If you're OEM unlocked you fail Verified Boot checks. Most custom Kernels include a bypass for this. Magisk alone should also work. I think you missed one important step:
Open Play Store Settings. Scroll down. It says 'Uncertified' at the bottom, right? Now install and set up Magisk. Go to system App Settings and clear Data and Cache for Play Store. Return to the Play Store Settings and scroll down. Now it should say 'Certified'. It might not be immediate, but it will happen. Now your Banking Apps work.
If you don't want, or have no luck with Magisk, simply flash a Custom Kernel that bypasses Verified Boot, and works with OOS.
Simple.

Thank you. That was for sure a major part of the overall issue. Unfortunately it didn't yet fix it. I'm now certified in play store and magisk succeeds with both safety net checks (which however it also did before). And root is disabled in magisk. dm-verity does not show the warning during Boot and the Check itself should be disabled (I followed the recommendation in another Thread to Patch the Boot Image).
Anything else you can imagine?

ako673de said:
Thank you. That was for sure a major part of the overall issue. Unfortunately it didn't yet fix it. I'm now certified in play store and magisk succeeds with both safety net checks (which however it also did before). And root is disabled in magisk. dm-verity does not show the warning during Boot and the Check itself should be disabled (I followed the recommendation in another Thread to Patch the Boot Image).
Anything else you can imagine?
Click to expand...
Click to collapse
Link to other Thread?
I don't know Magisk but are you hiding Root from your Banking App? Have you cleared Data and Cache for the Banking App since getting Certified?

First my phone did not Boot any more after installing superSU. Fixed that by patching Boot.img (to disable dm-verity) according to this thread: https://forum.xda-developers.com/oneplus-3t/how-to/disable-dm-verity-force-encryption-op3t-t3688748
Now data and cache of all (now) 3 affected Apps has been cleared and Magisk is configured to be hidden for them, but still no change.
However, in Magisk there is the "extended" option "AVB 2.0/keep dm-verity", which is unticked. I'm not sure, should I try to set it?
Any other idea?

ako673de said:
Any other idea?
Click to expand...
Click to collapse
Nope. If Play Store says Certified you should be good to go. I can only imagine it's a Magisk issue. Post screenshots of your config and let the Magisk experts pick through them. Maybe there's something not set up correctly.

ako673de said:
First my phone did not Boot any more after installing superSU. Fixed that by patching Boot.img (to disable dm-verity) according to this thread: https://forum.xda-developers.com/oneplus-3t/how-to/disable-dm-verity-force-encryption-op3t-t3688748
Now data and cache of all (now) 3 affected Apps has been cleared and Magisk is configured to be hidden for them, but still no change.
However, in Magisk there is the "extended" option "AVB 2.0/keep dm-verity", which is unticked. I'm not sure, should I try to set it?
Any other idea?
Click to expand...
Click to collapse
Hide Magisk Manager. I had to do that to get my banking app to work.
Edit: you may need to reboot after hiding Magisk Manager and clear you banking app's data before it works.
Sent from my OnePlus3T using XDA Labs

Thank you, indeed that WORKED! Well, at least for 2 out of 3 Apps. I think I can tell which one: "HVB banking". Maybe could somebody cross-check this one on his/her phone?

After firmware update to OOS 5.0.5 I now have the problem that my PlayStore can no longer be convinced in any way to show that it's certified. But interestingly my banking Apps work (currently really no root app installed). I even waited for one day because earlier in this thread somebody mentioned that it might take awhile. Is there anything special I need to care about under the new OS version?

ako673de said:
After firmware update to OOS 5.0.5 I now have the problem that my PlayStore can no longer be convinced in any way to show that it's certified. But interestingly my banking Apps work (currently really no root app installed). I even waited for one day because earlier in this thread somebody mentioned that it might take awhile. Is there anything special I need to care about under the new OS version?
Click to expand...
Click to collapse
Did you reflash custom kernel after update?

I'm not using any. What I did right after the update is to disable dm-verity (with a patched boot.img), like I did last time. But magisk is not yet re-installed because I wanted to see at least once the HypoVereinsbank App working, which it in fact does (different to last time when the phone was not rooted as well, and the store not certified!).

ako673de said:
But magisk is not yet re-installed
Click to expand...
Click to collapse
That's why... You can't pass the ctsProfile check if your bootloader is unlocked, and if you can't pass the ctsProfile check the Play Store won't be certified. You need Magisk for that...

Now I'm getting confused. The initial mail of this thread explains the situation as it was when I opened this thread:
--> Original ROM, no root, and banking apps didn't work <--
The advice to clear data of the PlayStore immediately brought the PlayStore back to "certified".
This is clearly in contrast to what you're saying now.
I can imagine only one reason: Maybe the older PlayStore had a bug and therefore was able to "certify" even with unlocked bootloader?
Sidenote: My main intention to do the firmware upgrade was that the "safety net checks" in Magisk suddenly stopped working one day (with the error message "invalid response", most probably you know what I'm talking about, I've read some comments from you on this issue). Therefore it's maybe really not too unlikely that Google has changed something very basic. Could you please confirm?
Edit: Now magisk is back, version 16.7, and in fact PlayStore is back to "certified" AND now even the HypoVereinsbank App works. Just one thing remains: magisk safety net check still says "invalid response" (after it downloaded some "FOSS" code, which it didn't do last time, when it was still working).

ako673de said:
Edit: Now magisk is back, version 16.7, and in fact PlayStore is back to "certified" AND now even the HypoVereinsbank App works. Just one thing remains: magisk safety net check still says "invalid response" (after it downloaded some "FOSS" code, which it didn't do last time, when it was still working).
Click to expand...
Click to collapse
https://www.didgeridoohan.com/magisk/MagiskHide#hn_The_response_is_invalid

Sorry, now comes a probably often asked question: do I need the safetynet check option in magisk for something real? Or do the alternative apps fulfill all possible needs? What are these needs? Isn't that exactly what the PlayStore does to determine "certified"?

After quite some months of absolutely no "root" problems with any of my apps, since today o2banking again doesn't work.
I tried to update Magisk, but after update of the Magisk manager app to v7.1.1(203) it reports that Magisk is not installed at all, and any update of Magisk itself resulted in just the same. So I reverted back to v6.1.0(165) and everything seems to be okay, except that o2banking doesn't work. SafetyNet is clean, Magisk is hidden for o2banking and Magisk manager is repacked.
Does anybody know what the problem might be? Especially with that new version of the manager app, but also with Magisk v19.0 which cannot be installed from v6.1.0 (max. is v18.1). Any ideas welcome! I'm now on OOS 5.0.8 by the way.
SOLVED it myself: As mentioned somewhere in the update FAQ of Magisk there was a bug in manager v6.1.0 that causes the updated v7.1.1 to co-exist with the old version if the old version has been re-packed. If anybody encounters the same problem, the solution is at the bottom of this page: https://www.didgeridoohan.com/magisk/ManagerIssues.
o2banking will then still not work. Update to v19.0 is mandatory. But that is no problem then any more...

probably your banking app identified oxygen os as custom rom and have root. 1 out of 3 banking app in my phone doesn't work with lineageos even though i already hide magisk, but when running oxygen os with magisk hide, and also hide magisk manager (turn it on in magisk manager setting) all 3 banking app work just fine. maybe try sending a message to bank app developer to add oxygen os as exception.

Did you notice my edit? It was a problem with magisk manager update and magisk main version. Now everything is back up and running.

AdAway with temp root

I have an unlocked bootloader with TA-Backup like described in this thread.
But to get my banking app working I only want ro use the stock kernal.
I use the newest firmware: G8441_47.2.A.10.28_1310-4373_R3C
Is it possible to install AdAway if I boot with a different kernal with root and activate the host files?
After a reboot the stock kernal will be used with working adaway.
Does this work?

DripleX said:
I have an unlocked bootloader with TA-Backup like described in this thread.
But to get my banking app working I only want ro use the stock kernal.
I use the newest firmware: G8441_47.2.A.10.28_1310-4373_R3C
Is it possible to install AdAway if I boot with a different kernal with root and activate the host files?
After a reboot the stock kernal will be used with working adaway.
Does this work?
Click to expand...
Click to collapse
Better option for you on that situation is to use a dns proxy for ad filtering
something like this app
https://f-droid.org/en/packages/org.jak_linux.dns66/

Yes I use a app like this, but the problem is, that sometimes it takes up to 1 - 2 min till it is connected to the DNS Server.

Have you tried if the banking app works with magiskhide and "hide magisk package name" from magisk settings?

vofferz said:
Have you tried if the banking app works with magiskhide and "hide magisk package name" from magisk settings?
Click to expand...
Click to collapse
Yes, I tried this, but as I read in some other threads, this will only work with newest Magisk.
But then I have to recompile the kernal for myself.

@DripleX, If you like to check if magisk is causing your (banking) apps to detect root, you may try this:
j4nn said:
Dear @albenex, although I would also assume it should be possible to resolve this with use of magiskhide and other settings, I've uploaded not-pre-rooted kernels for the latest fw version into my experimental folder here.
So you can clean up all traces of magisk (factory reset may be needed to be sure) and use a boot-*-47.2.A.10.45-hideunlock.img kernel to test it. Also be sure to run unmodified stock fw.
Click to expand...
Click to collapse
These kernels are not pre-rooted with magisk but include the patch to hide bootloader unlock.
That should provide you setup very close to still locked phone (if you have your TA-locked restored).
If the app is working with the *-hideunlock.img kernel, magisk would need to be made hidden to get it working with a rooted kernel.
If it did not work even with the not-prerooted kernel, it would mean BL unlock is detected some other way (most likely using your Android Attest key - assuming you have it "provisioned") as it seems to be the case with google pay.
A donation was received on Tue Apr 30 15:03:03 UTC 2019 - I assume it has been from you @DripleX.
If so, thank you.

Thank you @j4nn for your reply!
I will check this after my vacation.
And yes, I made the donation

Magisk Hide can't wok on latesd CIB mobile bank app

Hi!
The latest CIB mobile bank app (updated at: 2019-09-21) detect phone as rooted.
I tried with Magisk 19.3 and 19.4 beta too.
System is Android v7.1.2 and LineageOS 14.1-20171021-UNOFICIAL-KonstaKANG-Y560.
I've reinstalled the bank app (with reboot system), but nothing changed.
I've tried this steps too, it's brake Magisk installation. After that I must reinstall Magisk.
Please repair/update this on next version!

ANOka said:
Hi!
The latest CIB mobile bank app (updated at: 2019-09-21) detect phone as rooted.
I tried with Magisk 19.3 and 19.4 beta too.
System is Android v7.1.2 and LineageOS 14.1-20171021-UNOFICIAL-KonstaKANG-Y560.
I've reinstalled the bank app (with reboot system), but nothing changed.
I've tried this steps too, it's brake Magisk installation. After that I must reinstall Magisk.
Please repair/update this on next version!
Click to expand...
Click to collapse
Sadly the most safe way to use banking apps is on a stock device without root
([emoji3590]09-09-18[emoji3590])

Works fine on latest Canary after hiding Magisk Manager (settings -> Hide Magisk Manager).

Like above, I tested the app and it doesn't detect root on my device (OP3T, custom Pie ROM, Magisk Canary build 19402 with hidden Manager 237). Magisk can hide from the app, so something about your setup is the issue.

Didgeridoohan said:
...Magisk Canary build 19402 with hidden Manager 237...
Click to expand...
Click to collapse
Where can I download?

ANOka said:
Where can I download?
Click to expand...
Click to collapse
If you've already tried v19.4 beta, there's practically no difference (especially regarding MagiskHide).

Didgeridoohan said:
If you've already tried v19.4 beta, there's practically no difference (especially regarding MagiskHide).
Click to expand...
Click to collapse
I've tried, not working. (See the first open post!)

ANOka said:
I've tried, not working. (See the first open post!)
Click to expand...
Click to collapse
I know, so my statement was made to let you know that you might not need the Canary build at this very moment (since there's currently practically no difference between the builds).
Anyway, take a look here for help on getting the app running:
https://didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps

Banking App not working

My net banking application not working on any rom. After installation it stopped in initial setup. I have tried almost all android 10 roms.

You have to use magisk hide with your app so that it doesnt know that your phone is rooted.

deniz2694 said:
You have to use magisk hide with your app so that it doesnt know that your phone is rooted.
Click to expand...
Click to collapse
also worth noting that some banking apps really dont like a rom that has a custom vendor.

I have the same problem with lloyds banking app (UK). It will only work on miui based rom or official lineage os rom. In all other roms it will always detect root no matter what I do try to do hide it.

abmoh13 said:
I have the same problem with lloyds banking app (UK). It will only work on miui based rom or official lineage os rom. In all other roms it will always detect root no matter what I do try to do hide it.
Click to expand...
Click to collapse
You have to change name of magisk manager in settings/ hide magisk. Then restart, check saftynet, hide banking app and Google services, install two magisk modules - saftypatch and sqlite.