Database Develop

[Feature request] Add a "Bookmark this Module" (or similar) to the Xposed Installer

[Feature request] Add a "Bookmark this Module" (or similar) to the Xposed Installer
Hey,
I just installed Xposed on my Nexus and browsed though the available modules, but as I am relatively new to the whole topic of rooting / Xposed etc. I am currently unsure which module to install so I thought it would be great to have some kind of function to put a module to a bookmark / watchlist / wishlist section similar to the Play Store instead of installing it right away. That button could be placed next to the download button e.g.
Many thanks for thinking about it And thanks for providing such awesome work with the framework.

Morning,
what do you think? Would it be possible to add some kind of "watchlist" to Xposed?
With a hopefully ever growing list of modules it could be quite handy.
Thanks for considering it.

My way of bookmarking: I download and install a module but don't enable it in Xposed. So I could try it later

I could imagine that feature some kind in the future. It could be integrated into the "Settings" tab of the module. Not high prio for me though...

rovo89 said:
I could imagine that feature some kind in the future. It could be integrated into the "Settings" tab of the module. Not high prio for me though...
Click to expand...
Click to collapse
Can you also please add a 5th state "dont remind for updates" to this settings tab?

defim said:
Can you also please add a 5th state "dont remind for updates" to this settings tab?
Click to expand...
Click to collapse
Yeah. But do you think this makes sense as an option for the Stable/Beta/Experimental choice? It would mean that the module would be treated as if there weren't any versions at all. I think it would be better to make this a separate setting, so you would still see all the versions, but it wouldn't trigger the "updates available" texts on the welcome screen. This would be even better if it (optionally) remembered the latest version at the time you selected it, and would disable itself when there's a newer version available. So that would be a "skip this version" setting.

@rovo89: "Skip this version" is even!
It fits my user case: Version 1.5 and 1.6 of an app doesnt work correctly, but 1.4 does. So it would be great to be informed of a 1.7, but do't show all the time "updated available"

I pretty much do the same as defim but run into problems on my tablet that doesn't have as much space to install to and it reserves 500 meg and blocks installs but if I want I could fill that space with download, music or whatever. Only way to install at that point is to delete stuff/uninstall to get above 500 mb free to install something and not really feasible on that device just to remember a module I want to try later or keep an eye on so I'd love a wish list type feature.
Sent from my XT1080 using XDA Premium 4 mobile app

Hello,
The bookmark feature of xposed, could be an xposed module in itself, hooking the Xposed app and expanding its features Just a thought.
Kind Regards
TwinAdk

TwinAdk said:
The bookmark feature of xposed, could be an xposed module in itself, hooking the Xposed app and expanding its features Just a thought.
Click to expand...
Click to collapse
That would be very ugly...
Xposed is open-source for a reason. I don't see Xposed as the solution for everything. If you have the chance to change the software at it's origin, do that. It's less work and much more sustainable.

[REQUEST] PBMC for Magisk

If you all remember an xposed module "Physical Button Music Control - PBMC" developed by @Xspeed. I am basically looking for that module to be part of Magisk.
Is there anyone that could port it? It's a humble request from the great developers of this community.
ABOUT THE MODULE:
It basically allows u to have various control options for music, system shortcuts, keyboard presses, application launch etc by using volume buttons of ur phone as well as other buttons regardless of whether the screen is on or not. (You can set the actions to only occur if screen is on or off).
My main concern is that the function should would with screen off.

TahirZX said:
If you all remember an xposed module "Physical Button Music Control - PBMC" developed by @Xspeed. I am basically looking for that module to be part of Magisk.
Is there anyone that could port it? It's a humble request from the great developers of this community.
ABOUT THE MODULE:
It basically allows u to have various control options for music, system shortcuts, keyboard presses, application launch etc by using volume buttons of ur phone as well as other buttons regardless of whether the screen is on or not. (You can set the actions to only occur if screen is on or off).
My main concern is that the function should would with screen off.
Click to expand...
Click to collapse
Hello,
i am looking also from 1 or 2 months on that but it's REALLY difficult because Magisk is really different from XPosed, so i search a framework that i could "import" on Nougat.
The difficuty is in fact that i search an android Framework library that is must up to date (or its me that will must make it up to date), find a way to implement it with Magisk and debug all the stuff..
For me, it's purelly impossible to implement theses features on Android stock without any dedicated framework.
XPosed is an hooking method to implement an art framework, by this fact you can use this framework implementation to declare several extra functions on Android.
Magisk is an system-less implementation system that allow u to use "mororring" Linux fonctions to avoid system partition modifications.

I'm familiar with the difference between magisk and xposed but can't all these functions work say in like a custom kernel? Like how the holding power button turns on flash?

TahirZX said:
I'm familiar with the difference between magisk and xposed but can't all these functions work say in like a custom kernel? Like how the holding power button turns on flash?
Click to expand...
Click to collapse
No, because has my answer on the original thread was confirmed by the dev, more than most of the commands used in the code of PBMC aren't recognized by default in android and so require an external framework like XPosed.
It's the same fact for others apps too certains options in Greenify (as an exemple).
Customs kernels could define differents hardware-software values from stock bases, but they don't add really completly massive codes in android frameworks.

Alright then well have u found any Alternative or would we just have to wait for stable xposed on nougat?

Back in the day before the creation of Xposed people used framework patchers to add volume button track skip feature for example. But this was usable only to ROM developers on custom ROMs.
While it MAY be possible to create a patcher to use with Magisk, it's purely theoretical and would have a lot of flaws in practice (one example would be multiple developers trying to patch one file and users ending up bricking their devices in worst case scenario). Other issue would be time: Java development took me a whole year to make PBMC, and making a patcher would take twice as much time. Not really a good idea, I guess Xposed for Nougat will come earlier than that

Xspeed said:
Back in the day before the creation of Xposed people used framework patchers to add volume button track skip feature for example. But this was usable only to ROM developers on custom ROMs.
While it MAY be possible to create a patcher to use with Magisk, it's purely theoretical and would have a lot of flaws in practice (one example would be multiple developers trying to patch one file and users ending up bricking their devices in worst case scenario). Other issue would be time: Java development took me a whole year to make PBMC, and making a patcher would take twice as much time. Not really a good idea, I guess Xposed for Nougat will come earlier than that
Click to expand...
Click to collapse
Then we shall all wait patiently for u to port it to nougat when xposed on nougat is stable. ?

TahirZX said:
Then we shall all wait patiently for u to port it to nougat when xposed on nougat is stable.
Click to expand...
Click to collapse
As far as I remember I made it compatible and I've seen people saying it works on that unstable version of Xposed for Nougat.

Actually it does work on Nougat, the problem is that Xposed for Magisk breaks the SafetyNet.

I'm looking for something like this as well...
Not looking for anything fancy. I just want to be able to long press volume up or down to skip music tracks while screen is off. Im on stock OOS rooted and TWRP on OnePlus 6.

[Q] Why aren't there any cool modules for Magisk? (compared to modules for Xposed)

Extremely sorry if I am spamming the forum with this thread, but thought of starting this discussion to see if the geeks can help with sharing the knowledge.
I don't think I have to emphasize on why Magisk over Xposed (The Magisk Forum has a lot of articles on why.), but I am surprised to realize that Magisk is still the so called "new guy" even after these many years of launch..
All I get for a sample search "best modules Magisk" is a bunch of tweaking modules which say they can alter your ART mechanism or save your battery, I mean, who cares for the performance in 2019!!! we have got beastly phones and just want magik to happen on them. Magisk is still the same serious experimental mod that lets you root and hide it from banking/work apps but not yet cool.
For example, every time I installed Xposed on a new phone, I would go look for the famous "Gravity Box" just to enable the status bar brightness control gesture.
And the "X-insta" that lets me download media from Instagram . (Of course this module seems to be dead for a few months).
And a bunch of adblockers.
And a hell lot mods that I don't remember from the top of my head, but it was really magic.. And it is slowing down (I feel so..)
Well, someone might say that we can install Xposed itself as a module, but that just crashes the "SafetyNet" which is very annoying, it makes the phone useless without being able to open GooglePay and other banking apps.
I know I might be wrong but I am posting just to see if people use any equivalent "cool" modules in Magisk that are not easily seen in the Magisk Modules repo or if someone has found a way to pass the "SafetyNet" with Xposed+Magisk to make Android awesome again!!:good:

sagar2208 said:
Extremely sorry if I am spamming the forum with this thread, but thought of starting this discussion to see if the geeks can help with sharing the knowledge.
I don't think I have to emphasize on why Magisk over Xposed (The Magisk Forum has a lot of articles on why.), but I am surprised to realize that Magisk is still the so called "new guy" even after these many years of launch..
All I get for a sample search "best modules Magisk" is a bunch of tweaking modules which say they can alter your ART mechanism or save your battery, I mean, who cares for the performance in 2019!!! we have got beastly phones and just want magik to happen on them. Magisk is still the same serious experimental mod that lets you root and hide it from banking/work apps but not yet cool.
For example, every time I installed Xposed on a new phone, I would go look for the famous "Gravity Box" just to enable the status bar brightness control gesture.
And the "X-insta" that lets me download media from Instagram . (Of course this module seems to be dead for a few months).
And a bunch of adblockers.
And a hell lot mods that I don't remember from the top of my head, but it was really magic.. And it is slowing down (I feel so..)
Well, someone might say that we can install Xposed itself as a module, but that just crashes the "SafetyNet" which is very annoying, it makes the phone useless without being able to open GooglePay and other banking apps.
I know I might be wrong but I am posting just to see if people use any equivalent "cool" modules in Magisk that are not easily seen in the Magisk Modules repo or if someone has found a way to pass the "SafetyNet" with Xposed+Magisk to make Android awesome again!!:good:
Click to expand...
Click to collapse
Magisk doesn't work the same way as Xposed,one mounts and modifies files and the other hooks and modifies app code at runtime,and yes there is a way to use Xposed and pass safetynet if you are either on Oreo or Pie,it's called Edxposed
Edxposed is an open source Xposed alternative released early this year that uses a different method to hook into the system which allows it to pass safetynet and it allows you to blacklist apps in which you don't to load Xposed into,and if you are in pie there is already a beta of gravitybox that fully supports Pie (it's not yet in the Xposed repo because it's not fully stable yet)

Here are some pictures showing edxposed passing safetynet and me using the event lock module on Android pie,incase you are interested here are the links to edxposed https://forum.xda-developers.com/xposed/android-9-0-xposed-solutions-t3889513 it works on both Oreo and Pie (ignore the last step and just use edxposed installer) it's the last link and the first post,if you have any doubts feel free to ask there

DanGLES3 said:
Here are some pictures showing edxposed passing safetynet and me using the event lock module on Android pie,incase you are interested here are the links to edxposed https://forum.xda-developers.com/xposed/android-9-0-xposed-solutions-t3889513 it works on both Oreo and Pie (ignore the last step and just use edxposed installer) it's the last link and the first post,if you have any doubts feel free to ask there
Click to expand...
Click to collapse
A Hope!!
Thank you very much for the info, will try and post an update..

Even after these many years of launch people seems to not understand Magisk purpose, features and way of work. Same for Xposed.
Does Magisk has "modules" ? Yes! Does Xposed has "modules" ? Yes! But that's it. The name. The only thing in common between Magisk and Xposed is _the name, the word, "module" _ for their respective plug-ins, addons. Nothing more. Period.
Magisk attachs to Android, works completely different from the way Xposed does. What they do and what they can do are different. They are not even closer to be an alternative of one to another.
Having that said, do not expect that modules of one can deliver similar features of a module of another. If this somehow someday for an specific pair of modules happen be sure they are accomplishing that but doing in complete different ways behind the scenes.
About Xposed not breaking SafetyNet, we have now for Android O+ the alternatives EdXposed (open source) and Tai Chi (closed source). They do not break it because the way they're implemented is different from original Xposed by Rovo. They are different approachs, new code with new ways of work, but that delivers same entrance points, same nomenclature, as original Xposed itself. Thus being (generally speaking) compatible with modules originally built to original Xposed.
Both EdXposed and Tai Chi are experimental yet, although working fine at least on Android P. If they show themselves as solid solutions then probably we will see new Xposed like modules appearing out there. I do hope so.

wilsonhlacerda said:
Even after these many years of launch people seems to not understand Magisk purpose, features and way of work. Same for Xposed.
Does Magisk has "modules" ? Yes! Does Xposed has "modules" ? Yes! But that's it. The name. The only thing in common between Magisk and Xposed is _the name, the word, "module" _ for their respective plug-ins, addons. Nothing more. Period.
Magisk attachs to Android, works completely different from the way Xposed does. What they do and what they can do are different. They are not even closer to be an alternative of one to another.
Having that said, do not expect that modules of one can deliver similar features of a module of another. If this somehow someday for an specific pair of modules happen be sure they are accomplishing that but doing in complete different ways behind the scenes.
About Xposed not breaking SafetyNet, we have now for Android O+ the alternatives EdXposed (open source) and Tai Chi (closed source). They do not break it because the way they're implemented is different from original Xposed by Rovo. They are different approachs, new code with new ways of work, but that delivers same entrance points, same nomenclature, as original Xposed itself. Thus being (generally speaking) compatible with modules originally built to original Xposed.
Both EdXposed and Tai Chi are experimental yet, although working fine at least on Android P. If they show themselves as solid solutions then probably we will see new Xposed like modules appearing out there. I do hope so.
Click to expand...
Click to collapse
Couldn't have said it better (my previous texts were written at 3am so pardon for any mistake I did XD)

com.adobe.ims.accountaccess (Adobe Account Access) seems to detect Magisk, even while hidden.

H! So I am actually unsure where to post this..
Here's hoping you can figure something out and not be mad at me if this is the wrong place to post this.
Initially, i was going to post this as a Bug report on Github. However, I figured this was not correct.
Technically speaking this also isn't really an issue with magisk itself, more that adobe might have found a way to circumvent magisk anti detection methods.
In short: The App "Adobe Account Access" (com.adobe.ims.accountaccess on the play store: https://play.google.com/store/apps/details?id=com.adobe.ims.accountaccess) seems to have found a way to detect magisk and/or root, even though root detection is hidden in magisk.
The App just displays a prompt, saying "Device not supported. Sorry, your phone is not supported for Adobe Account Access.", even though the device used should be supported.
I checked with adobe community support on whether my Phone is supported or not and according to them, it should indeed be supported: https://community.adobe.com/t5/acco...-access-app-device-not-supported/m-p/11696613
I suspect they have found a way to get around all magisk anti detection methods and i would be grateful if someone would be kind enough to check if there is a workaround or if magisk's detection prevention needs an update.
Unfortunately, i don't have much more to say other than that..
There aren't any magisk log entries that would indicate something went wrong (only entries mentioning the app are"i" loglevel, one coming from hide_list_add and one coming from proc_monitor).
I could not find anything out of the ordinary in the logcat, although i suppose i could be more thorough with my search.
My technical/general info would be:
Magisk Version used: 22.0 (22000) (18)
SafetyNet integrity: Both basicIntegrity AND ctsProfile = pass; evalType = BASIC
ROM used: OxygenOS 10.0.11.GM21BA
Android version: 10
Device name: OnePlus 7 Pro
"Adobe Account Access" App version: 1.6
+++ Please feel free to ask for any additional info in case I missed it +++
Thanks in advance for any productive suggestion!

When does it display this "device not supported" message? I tested just now and could log in and set everything up without even adding the app to the Hide list, and with the Magisk app unhidden.

Didgeridoohan said:
When does it display this "device not supported" message? I tested just now and could log in and set everything up without even adding the app to the Hide list.
Click to expand...
Click to collapse
Oh? That is peculiar.. Damn, that implies an issue somewhere else i reckon ://
It displays it immediately after launching the app. The very first screen..
What phone and which OS (/ROM) are you using? Might just be that my phone is genuinely not supported and the folks over at the adobe community forum lied when saying my phone should be compatible..
Also, which android version are you on if you don't mind me asking?

You don't have any modules installed? No edxposed or lsposed, or magisk modules?
Have you tried root detection apps like Root Beer Fresh to see if indeed the app is unable to detect root? If you try any such app, remember to add it to the Magisk Hide list beforehand, otherwise the app will clearly detect root.

It's a OnePlus 3T with Android 9 ArrowOS. As stated above, it could very well be a module, like EdXposed. Or a root app, or a file or folder on your device, or something completely different.
It's not detecting Magisk at least, that's for sure...
General root hiding tips:
https://www.didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps

@Barrel Titor
Samsung Galaxy S7 Custom 9.0 Pie, Magisk 22 root with random name, application without hiding works fine.

Hi all!
First of all: Apologies! I meant to respond sooner to this, but work has kept me occupied and the one time I actually was available, XDA Forums went down into maintenance mode..
Secondly: Sorry for maybe jumping the gun here a bit!
It does look like I should have tested this issue a bit more! I am definitely going to keep on trying to fix this on my own using the resources and methods you have suggested!
I have tested com.adobe.ims.accountaccess on my sisters unrooted OnePlus Nord.. It works fine there, which is really confusing. None of the other apps I am using show this sort of issue :c Not even my banking app!
@mario0318 Thanks for your suggestion! I know it is good practice to remove/disable all your modules. However, none of the modules I have currently installed are particularly large and they certainly do not modify much compared to what is possible. I am going to attach a list to this response, however I am also going to try disabling them one by one and see if I can find the culprit! Unfortunately, I will not be able to disable the "Google Dialer Framework" module, since it causes the device to bootloop if the google dialer app is still present.
Here is a list of all the modules I have installed and enabled at the moment:
Spoiler
App Systemizer (Terminal Emulator)
Busybox for Android NDK
Google Dialer Framework
Looki75 Product Sans font
Systemless Hosts
ViPER4ANDROID FX
Honourable mentions (these modules are completely DISABLED):
Spoiler
Riru
Riru - EdXposed
However, please note again that SafetyNet seems to be INTACT, with "basicIntegrity" and "ctsProfile" still passing and "evalType" being "BASIC".
In any case. Thanks to everyone for their contribution! I really appreciate any suggestion!
Edit: @mario0318 right after I posted this message, I went ahead and gave "RootbeerFresh" a shot. It does not detect root when it is hidden from it. This makes my leading theory to be that the app truly does not support OnePlus 7 Pro devices. Wouldn't know why it doesn't support this model in particular though. Until I either unroot or find someone with the same device, willing to install Adobe Account Access, i can't say for sure though.

Barrel Titor said:
Hi all!
First of all: Apologies! I meant to respond sooner to this, but work has kept me occupied and the one time I actually was available, XDA Forums went down into maintenance mode..
Secondly: Sorry for maybe jumping the gun here a bit!
It does look like I should have tested this issue a bit more! I am definitely going to keep on trying to fix this on my own using the resources and methods you have suggested!
I have tested com.adobe.ims.accountaccess on my sisters unrooted OnePlus Nord.. It works fine there, which is really confusing. None of the other apps I am using show this sort of issue :c Not even my banking app!
@mario0318 Thanks for your suggestion! I know it is good practice to remove/disable all your modules. However, none of the modules I have currently installed are particularly large and they certainly do not modify much compared to what is possible. I am going to attach a list to this response, however I am also going to try disabling them one by one and see if I can find the culprit! Unfortunately, I will not be able to disable the "Google Dialer Framework" module, since it causes the device to bootloop if the google dialer app is still present.
Here is a list of all the modules I have installed and enabled at the moment:
Spoiler
App Systemizer (Terminal Emulator)
Busybox for Android NDK
Google Dialer Framework
Looki75 Product Sans font
Systemless Hosts
ViPER4ANDROID FX
Honourable mentions (these modules are completely DISABLED):
Spoiler
Riru
Riru - EdXposed
However, please note again that SafetyNet seems to be INTACT, with "basicIntegrity" and "ctsProfile" still passing and "evalType" being "BASIC".
In any case. Thanks to everyone for their contribution! I really appreciate any suggestion!
Edit: @mario0318 right after I posted this message, I went ahead and gave "RootbeerFresh" a shot. It does not detect root when it is hidden from it. This makes my leading theory to be that the app truly does not support OnePlus 7 Pro devices. Wouldn't know why it doesn't support this model in particular though. Until I either unroot or find someone with the same device, willing to install Adobe Account Access, i can't say for sure though.
Click to expand...
Click to collapse
So upon Google searching "oneplus 7 pro adobe account access" it appears to be a common problem.

mario0318 said:
So upon Google searching "oneplus 7 pro adobe account access" it appears to be a common problem.
Click to expand...
Click to collapse
I cannot find any results using this search term on google other than my own post on the adobe community forums.. This one: https://community.adobe.com/t5/acco...access-app-device-not-supported/td-p/11695914

@mario0318 do you happen to know a way to somehow "pretend" to the app that i am in fact using a different phone? Something that would allow me to make the app believe it is running on a different device?

Barrel Titor said:
@mario0318 do you happen to know a way to somehow "pretend" to the app that i am in fact using a different phone? Something that would allow me to make the app believe it is running on a different device?
Click to expand...
Click to collapse
Well, the well known magisk module MHPC or Magisk Hide Props Config comes to mind. You can change device fingerprints and maybe also give the Device Simulation feature a go, or custom edit any range of configurable props.
You could do so without the module editing the build.props yourself. Or if you stick with edxposed and deal with not having magisk manager's hide enabled, perhaps any of the device spoofers on the xposed repo could fool the app. Or Sudohide if you set Adobe app to hide from any and all apps that are root relevant. May also consider removing directories in your internal and removable storage for things like TWRP or PBRP, Titanium Backup, xposes, etc, you know, things that a simple media scan looking for any sign of root apps might pick up.
But for now, I'd give MHPC a try and change device fingerprint and maybe enable device simulation if simple fingerprint change doesn't work.

I'm having the same issue on a rooted OnePlus 8T

Same for me on op7 pro. Hiding with somiko but Adobe still not working. Nor could I bypass square, it notes root when it pairs Bluetooth

Xposed in 2021

Hi,
I had used long time back when it was being developed by Rovo89. I have not used Xposed After that.
I am currently using a Pixel 2XL with Magisk. I believe LSXposed is the best to dive into Xposed for Android 11 right now.
What are the best Xposed Mods available that I can use ? I saw that all the mods I see are quite old.
I remember using Xposed for Adblocking (MinMinguard) & Gravity Box. Have moved to host based ad blocking with Magisk. Does Minminguard still work better than that ?
Also, are there any compatibility issues with Android 11?

coolsid8 said:
Hi,
I had used long time back when it was being developed by Rovo89. I have not used Xposed After that.
I am currently using a Pixel 2XL with Magisk. I believe LSXposed is the best to dive into Xposed for Android 11 right now.
What are the best Xposed Mods available that I can use ? I saw that all the mods I see are quite old.
I remember using Xposed for Adblocking (MinMinguard) & Gravity Box. Have moved to host based ad blocking with Magisk. Does Minminguard still work better than that ?
Also, are there any compatibility issues with Android 11?
Click to expand...
Click to collapse
LSPosed is indeed the better option for A11 in my opinion. It's lighter and faster, but it requires to know which packages are to hook. Some modules that are still maintained list them in the descriptions. But if there is no description, you have to guess or ask the developer directly.
My favourite modules are Xposed Edge (Pro), SudoHide (1.28.5), Twitter AdEater, GravityBox, for MIUI -CustoMIUIzer. As for AdBlocking, I've tried MinMinGuard on Android 11, but the latest version isn't work properly, you would have to use 2.0.9 version. But honestly, it's very old now and I would rather recommend AdAway or AdGuard (requires VPN). Personally I use the latter one, I purchased lifetime subscription and I think its very effective tool.

Hey, thanks for the reply. Looks like almost all things that I need are getting fulfilled by Magisk right now.